Anton Baklanov
d63703f1cd
Fixed #18714 -- Added 'fuzzy' compilemessages option
2014-11-18 22:44:16 +01:00
Tillmann Karras
d188101319
Fixed #23799 -- Made makemigrations respect --no-optimize.
...
Thanks to yamila-moreno for the idea of a skip message.
2014-11-18 07:37:06 +01:00
Claude Paroz
684b2077b3
Improved readability of negative condition in makemessages
...
Thanks Berker Peksag for the suggestion.
2014-11-17 13:42:14 +01:00
Claude Paroz
6a05f0dfe3
Simplified handle_extensions management utility
...
makemessages now doesn't need any special ignoring logic, after
commit bb4a92d784
.
2014-11-17 09:24:56 +01:00
Ilja Maas
bb4a92d784
Fixed #23840 -- Fixed makemessages find_files method
...
Changed the handling of extensions to be used for gettext. Now
obeying the --extension argument. find_files now only find the
given or default extensions and puts only these in the
TranslatableFiles. As a result there are no more confusing messages
for filetypes (extension) not handled by makemessages.
2014-11-17 09:21:24 +01:00
Berker Peksag
d2d6c0c097
Fixed #21363 -- Added datetime.timedelta support to TimestampSigner.unsign().
2014-11-15 19:36:33 +01:00
Claude Paroz
35dac5070b
Added a new GeoJSON serialization format for GeoDjango
...
Thanks Reinout van Rees for the review.
2014-11-15 18:07:18 +01:00
Michael Manfre
a305695f28
Merge pull request #3481 from manfre/ticket-16358
...
Fixed #16358 - Made memcache backend delete old value on a failure to set.
2014-11-13 22:10:22 -05:00
Tim Graham
c24a2e6cbd
Fixed #23765 -- Removed BooleanField default check which often yielded false positives.
2014-11-13 20:12:29 +01:00
Michael Manfre
bc8abe36ba
Fixed #16358 - Made memcache backend delete old value on a failure to set.
...
Default Memcached configuration allows for a maximum object of 1MB and
will fail to set the key if it is too large. The key will be deleted from
memcached if it fails to be set. This is needed to avoid an issue with
cache_db session backend using the old value stored in memcached, instead
of the newer value stored in the database.
2014-11-13 00:46:03 -05:00
Aymeric Augustin
f742c653e0
Removed return from __init__.
...
__init__ isn't allowed to return anything other than None and it isn't
common practice to include a return statement.
2014-11-12 21:26:31 +01:00
Aymeric Augustin
3bc7a14ea5
Normalized opening a file and decoding its content.
...
`io.open` is required on Python 2.7. Just `open` would work on Python 3.
2014-11-11 22:54:27 +01:00
Aymeric Augustin
95b8323ac2
Removed import forgotten in previous commit.
2014-11-11 22:54:26 +01:00
Claude Paroz
5ec367ccdd
Fixed #23788 -- Used new JavaScript support in recent gettext
...
JavaScript string extraction support has been added in gettext
0.18.3.
Thanks Aymeric Augustin for the review.
2014-11-11 22:52:30 +01:00
Aymeric Augustin
b8ba73cd0c
Raised SuspiciousFileOperation in safe_join.
...
Added a test for the condition safe_join is designed to prevent.
Previously, a generic ValueError was raised. It was impossible to tell
an intentional exception raised to implement safe_join's contract from
an unintentional exception caused by incorrect inputs or unexpected
conditions. That resulted in bizarre exception catching patterns, which
this patch removes.
Since safe_join is a private API and since the change is unlikely to
create security issues for users who use it anyway -- at worst, an
uncaught SuspiciousFileOperation exception will bubble up -- it isn't
documented.
2014-11-11 19:05:14 +01:00
averybigant
b7a5b6ab86
Fixed #23750 -- Allowed core.checks.register to be used as a function
2014-11-11 16:29:32 +01:00
Veres Lajos
a71a2ea756
Fixed typos using https://github.com/vlajos/misspell_fixer
2014-11-03 20:59:30 -05:00
Konrad Świat
934a16dc93
Fixed #23468 -- Added checks for duplicate fixtures directories in loaddata.
...
If settings.FIXTURE_DIRS contains duplicates or a default fixture
directory (app_name/fixtures), ImproperlyConfigured is raised.
Thanks to Berker Peksag and Tim Graham for review.
2014-10-31 18:21:54 -04:00
Matthew Somerville
cc25bfebd5
Clarified BaseCommand --traceback behavior.
2014-10-30 14:15:31 -04:00
Jon Dufresne
eb4f6de980
Fixed #8149 -- Made File.__iter__() support universal newlines.
...
The following are recognized as ending a line: the Unix end-of-line
convention '\n', the Windows convention '\r\n', and the old
Macintosh convention '\r'.
http://www.python.org/dev/peps/pep-0278
Thanks tchaumeny for review.
2014-10-30 11:52:59 -04:00
Claude Paroz
528c9af543
Fixed #23717 -- Fixed makemessages crash when STATIC_ROOT=None
2014-10-27 13:56:25 +01:00
Tony Zhu
dd1ea70779
Fixed #23699 -- Prevented flush from loading initial data for apps with migrations.
2014-10-27 06:56:44 -04:00
Loic Bistuer
eb82fb0a9d
Refactored color_style() and no_style() to improve testability. Refs #23663 .
...
This includes the following improvements:
- The type of the style object is now called 'Style' rather than 'dummy'.
- The new make_style() function allows generating a Style object directly
from a config string. Before the only way to get a style object was
through the environ and it also required that the terminal supported
colors which isn't necessarily the case when testing.
- The output of no_style() is now cached with @lru_cache.
- The output of no_style() now has the same set of attributes as the
other Style objects. Previously it allowed anything to pass through
with __getattr__.
2014-10-22 11:27:00 +07:00
Loic Bistuer
bdb4118b1a
Fixed #23686 -- Tweak color output of the system check framework.
...
Thanks Tim Graham for the review.
2014-10-22 11:27:00 +07:00
Loic Bistuer
533532302a
Fixed #23663 -- Initialize output streams for BaseCommand in __init__().
...
This helps with testability of management commands.
Thanks to trac username daveoncode for the report and to
Tim Graham and Claude Paroz for the reviews.
2014-10-22 09:25:50 +07:00
Claude Paroz
8b4cc9df9c
Fixed #23583 -- More selectively ignored static/media roots
...
Fixed a regression introduced by 28efafa24c
.
Thanks Michal Čihař for the report and initial patch, and
Collin Anderson and Tim Graham for the reviews.
2014-10-21 20:18:21 +02:00
Loic Bistuer
c34e13e17c
Fixed #23107 -- Made runserver output respect --no-color.
...
This commit reverts 67d7da5fb9
.
The previous fix changed the environment globally, which meant
that any call to `call_command(no_color=True)` prevented further
`call_command` with color.
This fix still relies on the environment because it's currently the only
way to reach WSGIRequestHandler, but it's now limited to the `runserver`
command. This seems an acceptable compromise considering `runserver` runs
indefinitely.
Thanks Tim Graham for the review.
2014-10-22 01:03:15 +07:00
Claude Paroz
4fe6824ffd
Fixed #23679 -- Fixed null introspection for char/text fields
...
Thanks Paul Dejean for the report.
2014-10-20 22:37:19 +02:00
Claude Paroz
b8f2c972d0
Removed redundant skip_checks option for call_command
2014-10-20 17:26:00 +02:00
Claude Paroz
6d11bb102d
Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times"
...
This reverts commit 8d6e1afe0b
.
call_command now always set skip_checks to True (tested in
user_commands).
2014-10-20 17:26:00 +02:00
Claude Paroz
685edab9da
Fixed #23685 -- Made call_command skip checks by default
...
Thanks Loic Bistuer for the report/review and Tim Graham for the
review.
2014-10-20 17:26:00 +02:00
Loic Bistuer
c974b7bbe0
Renamed skip_validation into skip_checks as the former is now deprecated.
2014-10-19 18:00:54 +07:00
Loic Bistuer
ec8a2e3b07
Prevented syncdb from calling system checks multiple times. Refs #23650 .
2014-10-19 18:00:53 +07:00
Claude Paroz
8d6e1afe0b
Fixed #23650 -- Prevented migrate from calling checks 3 times
...
Thanks Ilya Baryshev for the report and Tim Graham for the review.
2014-10-17 20:20:56 +02:00
Tim Graham
7ae03204ac
Fixed #23469 -- Removed test runner compatibility check which often yielded false positives.
2014-10-17 10:31:49 -04:00
Rigel Di Scala
a5c77417a6
Fixed #23615 -- Validate that a Model instance's "check" attribute is a method.
...
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.
This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
2014-10-16 23:49:21 +07:00
Collin Anderson
a6a8268d19
Fixed #23660 -- Moved sort_dependencies to core.
2014-10-16 03:04:13 +07:00
Anubhav Joshi
10b17a22be
Fixed #19508 -- Implemented uri_to_iri as per RFC.
...
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
2014-10-16 02:31:17 +07:00
Claude Paroz
59d487e7fc
Fixed #23638 -- Prevented crash while parsing invalid cookie content
...
Thanks Philip Gatt for the report and Tim Graham for the review.
2014-10-13 17:37:58 +02:00
Florian Apolloner
8d789449c7
Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC.
2014-10-12 22:01:24 +02:00
Thomas Chaumeny
6448dd8335
Fixed #23642 -- Made LocMemCache.incr() thread-safe as documented
2014-10-12 23:47:48 +07:00
Jaap Roes
1b5918f160
Fixed #23625 -- Removed CacheClass shim
2014-10-10 08:43:26 -04:00
Brandon Taylor
16ed35fafc
Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows.
2014-10-09 14:58:20 -04:00
Jon Dufresne
c1ef234e31
Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes
2014-10-07 13:06:39 -04:00
Markus Holtermann
2f16ff5a6c
Fixed #23601 -- Ensured view exists in URLconf before importing it in admindocs.
2014-10-06 09:31:39 -04:00
Thomas Chaumeny
b2aad7b836
Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282.
...
Thanks Collin Anderson for the review.
2014-09-29 00:01:38 +07:00
Claude Paroz
e1fbb68e4e
Updated comment about Python issue
2014-09-27 22:48:30 +02:00
Marco Buttu
e077c29155
Fixed #23551 -- Fixed bash autocompletion crash on Python 3.
2014-09-25 07:44:22 -04:00
Claude Paroz
ed297061a6
Fixed #18782 -- Prevented sql_flush to flush views
...
Thanks rodolfo_3 for the report and the initial patch, and
Josh Smeaton, Shai Berger and Tim Graham for the reviews.
2014-09-23 20:13:31 +02:00
José Padilla
5472d18e31
Fixed #23461 -- Added EMAIL_TIMEOUT setting
2014-09-13 09:33:21 -04:00
Tim Graham
52ef6a4726
Fixed #17101 -- Integrated django-secure and added check --deploy option
...
Thanks Carl Meyer for django-secure and for reviewing.
Thanks also to Zach Borboa, Erik Romijn, Collin Anderson, and
Jorge Carleitao for reviews.
2014-09-12 15:05:23 -04:00
Andi Albrecht
00535e8e6b
Fixed #20743 -- Added support for keyfile/certfile in SMTP connections.
...
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
2014-09-10 11:14:20 -04:00
Flavio Curella
c53f2451a8
Fixed #23398 -- Added helpful error message when runserver is accessed via HTTPS
2014-09-09 12:29:30 -04:00
Tim Graham
0e4d79c4f0
Fixed #22882 -- Fixed a UnicodeDecodeError in flush.
...
Thanks djbaldey for the report.
2014-09-06 10:07:34 -04:00
Tim Graham
1101467ce0
Limited lines to 119 characters in django/
...
refs #23395 .
2014-09-05 09:22:16 -04:00
Raffaele Salmaso
1435cfbe8d
Fixed #23302 -- Added --name/-n option to makemigrations command
2014-09-02 21:09:18 -04:00
Bas Peschier
eacf244506
Converted sql_queries into a lazily evaluated list.
...
Fixed #23364 . Thanks Markush2010 for the report.
2014-08-30 13:27:56 +02:00
Joshua "jag" Ginsberg
eb2af16c59
Fixed #21483 -- Added WSGI environ to kwargs sent to request_started signal.
2014-08-29 10:12:03 -04:00
Tim Graham
cf33777306
Clarified a comment in django.core.files.temp.
2014-08-29 07:27:15 -04:00
Simon Charette
1e404180c1
Fixed #23379 -- Corrected a referencing issue in sql_create.
...
Thanks to Trac alias flakfizer for the report.
2014-08-28 15:17:50 -04:00
areski
0396cd8f19
Fixed #23327 -- Added 'zero' syntax to migrate help message
2014-08-22 13:40:14 -04:00
Tim Graham
0d8d30b7dd
Fixed #23157 -- Removed O(n) algorithm when uploading duplicate file names.
...
This is a security fix. Disclosure following shortly.
2014-08-20 14:39:40 -04:00
Florian Apolloner
28e765810d
Prevented reverse() from generating URLs pointing to other hosts.
...
This is a security fix. Disclosure following shortly.
2014-08-20 14:39:40 -04:00
Gabriel Muñumel
3e241313a4
Fixed #23136 -- Added a message when sqlclear does nothing
2014-08-18 13:20:29 -04:00
Baptiste Mispelon
5853c87a45
Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate.
2014-08-18 18:55:12 +02:00
Ramiro Morales
152afadef1
Merge pull request #3075 from ramiro/makemessages-ignore-windows
...
Fixed #23298 -- Made makemessages actually ignore specified dirs on Wind...
2014-08-18 13:33:02 -03:00
Raffaele Salmaso
e0a98e2374
Fixed #23309 -- Fixed call_command to parse args correctly
2014-08-18 17:54:24 +02:00
Ramiro Morales
b4dce7c37a
Fixed #23298 -- Made makemessages actually ignore specified dirs on Windows.
...
This was detected by two failures in the i18n.test_extraction of our
test suite.
Refs #20422 , refs #22336
2014-08-15 16:19:04 -03:00
Ramiro Morales
0bfb538661
Fixed #23291 -- Don't add Unicode varname/value to environment.
...
Windows doesn't like that and it causes 114 failures in the
admin_scripts tests with Python 2.x.
2014-08-14 12:22:21 -03:00
Claude Paroz
055d95fce0
Fixed #23265 -- Used system-specific encoding in runserver
...
Thanks SpaceFox for the report.
2014-08-14 12:08:06 +02:00
Tim Graham
7f4be9cbc2
Fixed flake8 warning.
2014-08-13 12:33:18 -04:00
Claude Paroz
2cc8ffe258
Fixed #22985 -- Made call_command accept option name parameter
...
Thanks giulettamasina for the report and Tim Graham for the review.
2014-08-12 21:53:29 +02:00
Claude Paroz
dc462a8ed5
Removed unused migrate option
2014-08-09 17:13:00 +02:00
Justin Hamade
8fe406864c
Fixed #22336 -- Added path matching for makemessages ignore option
...
This fixes a regression introduced by 9012a9e200
.
2014-08-08 22:54:30 +02:00
Florian Apolloner
2d542bf60c
Ensured that Paginator.page_range works the same on Python 2 and 3.
...
This somewhat fixes #23088 , refs 23140.
2014-08-03 21:10:00 +02:00
Florian Apolloner
40fb6a5601
Revert "Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`."
...
This reverts commit 6508db2ff9
.
Refs #23088 .
2014-08-03 21:08:24 +02:00
Christoph Heer
d47409831f
Fixed #23067 -- Updated docs to use django-admin
2014-07-30 14:14:03 -04:00
areski
67d7da5fb9
Fixed #23107 -- Made runserver output respect --no-color.
2014-07-30 12:58:53 -04:00
Andrew Godwin
096a5de5d2
Fixed #23092 : Squashing handles external dependencies
2014-07-29 10:22:00 -07:00
Andrew Godwin
8ebd6d35d7
Fixed #23090 : Document and enforce not double-squashing migrations
2014-07-29 10:02:59 -07:00
Florian Apolloner
2ab0ed7b28
Only warn about initial data if fixtures have been found.
2014-07-27 13:23:16 +02:00
Anubhav Joshi
5cdb8f8c1e
Fixed #16617 -- Added 'value' to BaseValidator params.
...
Also allowed overriding the default messages in subclasses of BaseValidator.
Thanks sperrygrove for initial patch.
2014-07-26 10:03:00 -04:00
Andrew Godwin
f44dbf74a4
Mark initial_data as deprecated separately from syncdb. Refs #23077 .
2014-07-25 09:09:15 -07:00
Moayad Mardini
6508db2ff9
Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`.
2014-07-25 11:04:58 +03:00
Damien Nozay
70c54a3694
Fixed #23028 : Added unique_togther support to inspectdb.
2014-07-18 16:10:59 +00:00
Claude Paroz
28efafa24c
Ignored STATIC_ROOT and MEDIA_ROOT in makemessages
...
Also alleviate issues with weird file names typically found in
MEDIA_ROOT directories (#23010 ).
Thanks Tim Graham for the review.
2014-07-16 09:38:57 +02:00
Huu Nguyen
f7a78f9bba
Fixed #22791 -- Invoke interactive questioner only for conflicts in specified apps.
...
Thanks bendavis78 for the report and Tim Graham for the review.
2014-07-14 11:00:49 -04:00
Tim Graham
b48c2c5925
Removed extra newline.
2014-07-12 10:16:53 -04:00
Andrew Godwin
ebb13bbd88
Fixed #22983 : Alert when squashing RunPython operations with referred functions.
2014-07-11 19:00:39 -07:00
Claude Paroz
e167e96cfe
Fixed #22223 -- Prevented over-escaping URLs in reverse()
...
And follow more closely the class of characters defined in the
RFC 3986.
Thanks Erik van Zijst for the report and the initial patch, and
Tim Graham for the review.
2014-07-09 09:54:34 +02:00
Claude Paroz
b144bfb5ce
Fixed #21079 -- Further normalized table names in inspectdb
...
Thanks Michael Manfre for the report and Tim Graham for the review.
2014-07-06 21:19:27 +02:00
Daniel Hahler
67f9f385aa
Fixed various minor doc typos / references.
2014-07-05 20:26:26 -04:00
Tim Graham
1f8bb95cc2
Corrected domain max length for EmailValidator; refs #20631 .
...
Thanks MarkusH for the report.
2014-07-04 20:50:28 -04:00
Tim Graham
7fd55c3481
Fixed #20631 -- Increased the default EmailField max_length to 254.
...
Thanks pmartin for the report.
2014-07-04 14:15:00 -04:00
Loic Bistuer
1966054feb
Fixed #22915 -- Document backward incompatible changes in the ValidationError constructor.
...
This patch also fixes update_error_dict to better handle the use case described
in this ticket, previously the type of the provided container could be lost in
some conditions.
Thanks Russell Keith-Magee for the report and Tim Graham for review.
2014-07-04 17:05:31 +07:00
Ian Foote
4c39c270af
Add missing spaces to implicitly joined strings
2014-06-29 22:56:21 +01:00
Anubhav Joshi
dbbcfca476
Fixed #21668 -- Return detailed error page when SuspiciousOperation is raised and DEBUG=True
...
Thanks GDorn and gox21 for report.
Thanks Tim Graham for idea and review.
2014-06-24 08:55:36 -04:00
Andrew Godwin
0fba4c0ed7
Fixed #22487 : Don't flush out data from before normal TestCases
2014-06-23 20:25:09 -07:00
Anubhav Joshi
7f76251fb7
Refactored common code in handlers/base.py and urlresolvers.py
2014-06-23 15:27:25 -04:00
Claude Paroz
9618d68b34
Fixed #8033 -- Explained app registry error during translation setup
...
Thanks Tim Graham and Aymeric Augustin for the review.
2014-06-23 09:31:45 +02:00
Andrew Godwin
ecc06d44ed
Clean up syncdb parts of migrate output if no synced apps
2014-06-22 13:03:25 -07:00
Huu Nguyen
fbb684d95e
Fixed #22862 -- Added --noinput option to makemigrations.
...
Thanks artortenburger for the report.
2014-06-20 08:55:02 -04:00
Claude Paroz
b67e9ed8c9
Swapped placeholders in [sql]migrate command error
2014-06-20 13:53:17 +02:00
Andrew Godwin
9f4852f649
Fixed #22863 : Improve clarity of makemigrations for non-db params
2014-06-19 23:41:32 -07:00
Maxime Turcotte
9996158db4
Fixed #22835 -- Deprecated NoArgsCommand.
2014-06-19 08:54:59 -04:00
Vincent-Vega
4529af9ecf
Fixed #22845 -- Correctly handled memcached default timeout value.
2014-06-16 16:34:00 -04:00
Andrew Godwin
2b79be2bee
Fixed #22848 : Ignore no-migrations errors during makemigrations only
2014-06-16 09:58:35 -07:00
Claude Paroz
c24e979ece
Fixed #7762 -- Hidden full script name in command error output
2014-06-14 20:01:02 +02:00
Claude Paroz
5949c2118d
Restored command error behavior when called from command line
...
Refs #19973 .
2014-06-14 18:53:33 +02:00
Alex Gaynor
2ca5fc55b0
Fixed several flake8 errors
2014-06-14 10:20:42 -04:00
Claude Paroz
f17b24e407
Converted remaining management commands to argparse
2014-06-14 13:43:44 +02:00
Claude Paroz
4b4524291a
Converted test management command to argparse
...
Keeping backwards compatibility with test_runner.option_list is
tricky and would imply transforming an optparse.Option to an
argparse.Action. I choose to introduce a backwards incompatible
change because it only affects testing, not runtime behavior.
2014-06-14 13:43:39 +02:00
Claude Paroz
8568638603
Fixed #19973 -- Replaced optparse by argparse in management commands
...
Thanks Tim Graham for the review.
2014-06-14 11:17:48 +02:00
mlavin
4696cd9671
Fixed #22477 -- Removed contrib middleware from the global settings defaults.
...
Also added a compatibility check for changed middleware defaults.
Forwardport of d94de802d3
from stable/1.7.x
2014-06-13 12:45:56 -04:00
Loic Bistuer
6e8d614acd
Made the vendored NamedTemporaryFile work as a context manager. Refs #22680 .
...
This fixes a regression on Windows introduced by b7de5f5
.
Thanks Tim Graham for the report and review.
2014-06-12 08:07:34 +07:00
Florian Apolloner
e2efc8965e
Fixed #22680 -- I/O operation on closed file.
...
This patch is two-fold; first it ensure that Django does close everything in
request.FILES at the end of the request and secondly the storage system should
no longer close any files during save, it's up to the caller to handle that --
or let Django close the files at the end of the request.
2014-06-11 08:57:30 +02:00
Tim Graham
93d05536fd
Fixed #22770 -- Removed create_superuser from post_migrate signals.
...
Moved logic to syncdb command for backwards compatibility.
2014-06-10 14:37:37 -04:00
Andrew Godwin
8c12d51ea2
Fixed #22487 : Optional rollback emulation for migrated apps
2014-06-08 19:30:15 -07:00
Andrew Godwin
3f91238adf
Fixed #22777 : Add dependency on through for autodetected M2M adds
2014-06-08 17:12:59 -07:00
Víðir Valberg Guðmundsson
f70f669941
Fixed #22749 : Making SQL management commands migration aware.
2014-06-07 17:18:30 -07:00
Aymeric Augustin
47a9347b98
Fixed #6992 -- Improved error when middleware omits HttpResponse.
...
Thanks guettli for the report.
2014-06-07 19:48:45 +02:00
Unai Zalakain
11284a63d4
Fixed #18314 -- Corrected request.build_absolute_uri() handling of paths starting with //
...
``HttpRequest.build_absolute_uri()`` now correctly handles paths starting with ``//``.
``WSGIRequest`` now doesn't remove all the leading slashes either,
because ``http://test/server `` and http://test//server `` aren't the same thing
(RFC2396).
Thanks to SmileyChris for the initial patch.
2014-06-07 08:59:02 -04:00
Moayad Mardini
4f72e5f03a
Fixed #21773 -- made daemon threads default in the development server.
...
Thanks clime for the report.
2014-06-05 12:26:24 -04:00
Claude Paroz
fb9d8f0652
Fixed #22717 -- Auto-corrected missing ending slash in FileSystemStorage
...
Thanks David Fischer for the report and Moayad Mardini for the
review.
2014-06-04 08:53:17 +02:00
Tim Graham
4445d36d47
Fixed #22384 -- Deprecated reversing URLs by dotted path.
2014-06-03 07:30:14 -04:00
Florian Apolloner
83e7555ffe
Revert "Making SQL management commands migration aware."
...
This reverts commit cb9c9a7b58
.
2014-06-01 12:00:09 +02:00
Andrew Godwin
67d9f70e4c
Fix test failure caused by 3149cdce32
2014-05-29 15:34:35 -07:00
Víðir Valberg Guðmundsson
cb9c9a7b58
Making SQL management commands migration aware.
2014-05-29 23:03:10 +02:00
Alex Gaynor
1dcc603eff
Fixed several typos in Django
2014-05-28 17:39:14 -07:00
Simon Charette
d0f7c7f59a
Argument to `reversed` must be a sequence on Py3.
2014-05-27 18:28:13 -04:00
Simon Charette
fed2877cf1
Fix a regression introduced by f011b90363
.
...
`django.get_version` was actually used by the module.
2014-05-27 18:23:44 -04:00
Claude Paroz
f011b90363
Removed an old compatibility shim added in 1.0
2014-05-27 22:28:49 +02:00
Claude Paroz
fe53bc524b
Fixed #21630 -- Simplified management command discovery
...
Thanks Aymeric Augustin for the report end the review.
2014-05-27 22:18:51 +02:00
Aymeric Augustin
4865326f22
Fixed #22699 -- Configure default settings in some management commands.
...
This makes it possible to run django.setup() in management commands that
don't need a settings module. In addition it simplifies error handling.
Thanks Claude for the review.
2014-05-27 21:43:52 +02:00
Moayad Mardini
2e613ea5c5
Fixed #22675 -- makemigrations --dry-run to output migrations to stdout.
...
`makemigrations --dry-run` will output the complete migrations file
that would be written if it's used along with `--verbosity 3`.
2014-05-27 00:40:55 +03:00
Florian Apolloner
9d1bf8f841
Removed executeable bit from a few files.
2014-05-25 23:16:40 +02:00
Loic Bistuer
b7de5f5d3f
Fixed a few ResourceWarning in the test suite. Refs #22680 .
2014-05-26 03:23:17 +07:00
Moayad Mardini
63fc91b3ca
Fixed #22676 -- makemigrations --dry-run should not ask for defaults
...
Made the fix in InteractiveMigrationQuestioner class code, rather than
MigrationAutodetector, because --dry-run shouldn't affect whether
MigrationAutodetector will detect non-nullable fields, but the
questioner should skip the question and returns a None for default
(since that won't be used anyway) if --dry-run is used.
2014-05-24 09:56:18 -04:00
Claude Paroz
dbb48d2bb9
Applied unicode_literals to makemessages command
...
This also fixes #22686 as some sort of side-effect.
2014-05-24 11:51:57 +02:00
Thomas Grainger
46082339d2
the SECRET_KEY is not a hash
2014-05-22 11:19:54 +01:00
Ramiro Morales
fce6a29428
Merge pull request #2498 from ramiro/move-serverhandler
...
Moved ServerHandler helper class to tests.
2014-05-21 18:59:01 -03:00
Claude Paroz
7999ed9b69
Updated Django makemessages process
...
makemessages should now automatically distribute translatable
strings in the proper locale files, for Django too
(see 50a8ab7cd1
).
2014-05-19 09:30:26 +02:00
Tim Graham
c7a4ae94a0
Removed some unnecessary exception naming; thanks claudep.
2014-05-18 17:42:03 -04:00
Esau Rodriguez
ec9043ab2f
Fixed #21799 - Modified loaddata --ignorenonexistent to ignore models.
2014-05-18 15:52:07 -04:00
Erik Romijn
424fe76349
Fixed #22579 -- Corrected validation for email to reject trailing slash
...
Thanks to Claude Paroz for the report and patch and Tomasz
Paczkowski for the review.
2014-05-16 15:13:11 +02:00
Claude Paroz
f5d4b45df1
Fixed #21634 -- Prevented hiding ImproperlyConfigured when command not found
...
Thanks nikolay.v.golub@gmail.com for the report.
2014-05-16 12:08:31 +02:00
Claude Paroz
e520a73eee
Harmonized some PEP 0263 coding preambles
2014-05-15 19:58:41 +02:00
Aymeric Augustin
3800f63721
Dropped fix_IE_for_vary/attach.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:19:48 +02:00
Ramiro Morales
a9b7f31bfc
Completed long overdue sqlinitialdata deprecation.
2014-05-11 23:15:59 -03:00
Rainer Koirikivi
a75324c654
Fixed #14226 -- Dependency calculation for complex M2M relations.
...
`sort_dependencies` incorrectly interpreted 'complex' M2M relations
(with explicit through models) as dependencies for a model. This caused
circular complex M2M relations to be unserializable by dumpdata.
Thanks to aneil for the report and outofculture for initial tests.
2014-05-11 19:50:01 -03:00
Malcolm Box
66880e4cd1
Fixed #22606 -- Locmemcache has_key() failed for infinite cache expiry
...
Refactored cache expiry logic for Locmemcache to make consistent across
all places where accessed, and correctly handle None as expiry time.
2014-05-09 18:35:07 +02:00
David Szotten
7fe60ae64a
Fixed #22588 -- Fix RegexValidator __eq__
...
Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.
2014-05-08 19:51:15 -07:00
Claude Paroz
fc32e9c0d9
Removed unused imports in makemigrations
2014-05-08 19:39:43 +02:00
Andrew Godwin
f9d7e18dc5
Fixed #22576 : Ensure makemigrations doesn't touch the database.
2014-05-06 22:41:59 -07:00
Andrew Godwin
6944418277
Fixed #22337 : FileSystemStorage marked as deconstructible and tested.
2014-05-06 22:23:23 -07:00
Loic Bistuer
d1799233f4
Fixed clash caused by the newly introduced -e shorthand for makemessages --exclude.
...
This fixes a regression caused by 0707b82
. Refs #22328 .
2014-05-02 23:07:17 +07:00
Andrew Godwin
e049c88603
Cleanup failing test w/contenttypes and remove useless graph load
2014-04-30 15:11:52 -07:00
Andrew Godwin
8f6dff372b
Fixed #22485 : Include all unmigrated apps in project state by default.
2014-04-30 12:25:12 -07:00
Tim Graham
d9c272b22f
Removed unused import.
2014-04-30 07:23:39 -04:00
Bruno Ribeiro da Silva
83413c53d2
Fixed #22511 -- Added args to migrations management commands.
2014-04-30 07:15:03 -04:00
Ramiro Morales
2df7238512
Removed bogus, ineffective 'U' flag from codecs.open() call.
2014-04-29 07:46:54 -03:00
Aymeric Augustin
8b5b199e20
Fixed #3214 -- Stopped parsing SQL with regex.
...
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.
Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.
sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.
Many people contributed to both tickets, thank you all, and especially
Claude for the review.
Refs #22401 .
2014-04-26 17:46:23 +02:00
Ana Krivokapic
0707b824fe
Fixed #22328 -- Added --exclude option to compilemessages and makemessages.
2014-04-26 17:07:44 +07:00
Kevin Christopher Henry
91afc00513
Fixed #21157 -- Fixed problems with ResolverMatch
...
- Fixed bug in get_callable() that caused resolve() to put a string
in ResolverMatch.func.
- Made ResolverMatch.url_name match the actual url name (or None).
- Updated tests that used the string value in ResolverMatch.func, and
added regression tests for this bug.
- Corrected test urls whose dummy view paths caused failures (behavior
that was previously masked by this bug).
2014-04-23 20:12:34 -04:00
Claude Paroz
3a435a057c
Set compile messages options as class variable
...
Refs #18714 . Same logic as options for makemessages commands.
2014-04-23 15:15:03 +02:00
Malcolm Box
af5f688392
Fixed #22495 -- Locmem cache.add() failed with infinite timeouts
...
cache.add() incorrectly succeeded when there was an existing key
with an infinite (None) timeout.
2014-04-23 14:49:46 +02:00
Preston Timmons
3c06b2f2a3
Fixed #22486 -- Restored the ability to reverse views created using functools.partial.
...
Regression in 8b93b31487
.
Thanks rcoup for the report.
2014-04-23 07:27:52 -04:00
Tim Graham
8b93b31487
Fixed a remote code execution vulnerabilty in URL reversing.
...
Thanks Benjamin Bach for the report and initial patch.
This is a security fix; disclosure to follow shortly.
2014-04-21 18:11:26 -04:00
Florian Apolloner
405b13fe83
Fixed migrate when called inside a transaction.
...
This is useful for tests manually calling migrate inside a testcase,
for normal usage this should make no difference, since there is no
surrounding transaction after all. If there is one we still try to
leave the transaction in a useable state (for postgres at least).
If this commit turns out to be causing issues, settings savepoint=False
is probably the right fix :)
2014-04-21 15:37:12 +02:00
Aymeric Augustin
428c0bbe1b
Appeased flake8 2.1.0.
2014-04-21 12:27:34 +02:00
Claude Paroz
275811a93c
Adapted fixture read mode to file type
...
Binary mode added in ed532a6a1e
is not supported by ZipFile.
Refs #22399 .
2014-04-18 18:54:46 +02:00
Claude Paroz
ed532a6a1e
Fixed #22399 -- Forced fixture reading in binary mode
...
This might help on systems where default encoding is not UTF-8 (and
on Python 3).
Thanks bacilla for the report.
2014-04-18 17:55:35 +02:00
Moayad Mardini
214d1e1b0f
Fixed #22454 - Changed compatibility warning hint
...
The warning hint of `_check_test_runner` of 1.6 compatibility had a link
to a general release note. The link should be edited to refer the
relevant "Backwards incompatible changes in 1.6" section that documents
the cause and the possible solutions and workarounds of the warning.
2014-04-17 20:41:25 -04:00
Tim Graham
47927eb786
Revert "Fixed #22401 -- Deprecated regular expression parsing of initial SQL in favor of installing sqlparse."
...
This reverts commit 071c933775
.
This introduced a regression on MySQL and custom SQL is deprecated.
2014-04-16 21:03:22 -04:00
Tim Graham
395d75ea6b
Fixed #22194 -- Added --list-tags option to check command.
...
Thanks Elvard for the patch.
2014-04-10 09:43:55 -04:00
Tim Graham
b513fa5fc6
Fixed #22195 -- Used constants to define built-in tags for check framework.
...
Thanks Elvard for the patch.
2014-04-10 08:45:48 -04:00
julien 'pouete' Godin
071c933775
Fixed #22401 -- Deprecated regular expression parsing of initial SQL in favor of installing sqlparse.
2014-04-09 19:25:07 -04:00
Daniel Neuhäuser
4aa80149e7
Fixed #22327 -- Turned BaseEmailBackend into a context manager
...
Changed the BaseEmailBackend to allow usage as context manager to open
and close connections.
2014-03-31 14:08:51 -04:00
Ramiro Morales
9a982d5ccc
Moved ServerHandler helper class to tests.
...
It has been only used in the builtin_servers tests since Django 1.4.
2014-03-30 20:55:40 -03:00
Alex Gaynor
778ce245dd
Corrected many style guide violations that the newest version of flake8 catches
2014-03-30 12:11:05 -07:00
Zbigniew Siciarz
3cdb0baa45
Fixed #22335 -- Fixed popen_wrapper error on non-English Windows systems.
2014-03-26 00:42:19 +01:00
Tim Graham
9b7ba8af1b
Fixed #22322 -- Fixed incorrect explanation of what managed=False does.
...
refs #14305 .
Thanks Adrian Klaver for the report.
2014-03-25 14:01:37 -04:00
Tim Graham
e3c4205b79
flake8 and doc fixes for refs #22257 .
2014-03-25 09:44:59 -04:00
Anubhav Joshi
f34e8fc890
Fixed #22257 -- Added file output option to dumpdata command.
2014-03-25 13:47:03 +05:30
Baptiste Mispelon
96fc3908ad
Fixed a failing test introduced in 918a16bc4c
.
...
Refs #22307 .
2014-03-22 18:05:56 +01:00
Patrick Michaud
acee46fc95
Fixed #22256 -- Replaced bad fallback for missing PATH
...
Thanks Baptiste Mispelon for the review.
2014-03-22 16:52:05 +01:00
Aymeric Augustin
6877a9d415
Avoided transactional truncates on amateur databases.
...
Fixed a test failure that appeared after 753a22a6
, although the bug
existed before that commit.
Refs #22308 .
2014-03-22 14:39:27 +01:00
Aymeric Augustin
0757e0f30d
Avoided transactional DDL on castrated databases.
...
Fixed a test failure that appeared after 753a22a6
, although the bug
existed before that commit.
Refs #22308 .
2014-03-22 11:05:14 +01:00
Hans Lawrenz
918a16bc4c
Fixed #22307 -- Fixed SpooledTemporaryFile bug in File class.
...
Added condition to prevent checking the existence of a file name of a
file like object when the name attribute is None. This is necessary
because a SpooledTemporaryFile won't exist on the file system or have a
name until it has reached its max_size. Also added tests.
2014-03-21 22:34:47 +01:00
Aymeric Augustin
753a22a635
Fixed transaction handling in two management commands.
...
Previously, when createcachetable and flush operated on non-default
databases, they weren't atomic.
2014-03-21 21:29:51 +01:00
Aymeric Augustin
0f9560855e
Removed legacy transaction management per the deprecation timeline.
2014-03-21 21:06:50 +01:00
Tim Graham
4965a77407
Removed PIL compatability layer per deprecation timeline.
...
refs #19934 .
2014-03-21 10:54:53 -04:00
Dejan Noveski
4d0c5f6142
Fixed #22255 -- Added support for specifying re flags in RegexValidator
2014-03-21 11:12:36 +01:00
smallcode
61fdb8d487
Fixed regression in file locking on some platforms.
...
Some platforms with os.name == 'posix' do not have the
fcntl module, e.g. AppEngine.
refs #19373 .
2014-03-18 10:35:22 -04:00
Daniel Hahler
fc167c9b5e
Mentioned that ``dumpdata --natural`` is deprecated.
2014-03-18 07:25:37 -04:00
Andrew Godwin
28779abb75
Fix bad conflict detection during makemigrations
2014-03-08 13:53:20 -08:00
Claude Paroz
210d0489c5
Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings
...
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
2014-03-08 09:57:40 +01:00
Claude Paroz
06efeae598
Added --previous flag to msgmerge command used by makemessages
...
Also took the opportunity to slightly refactor gettext options
so as to ease customization by subclassing the command.
Thanks Michal Čihař for the report and initial patch.
2014-03-06 10:20:01 +01:00
Athena
5d568bcfa6
Fixed #7571 -- Fixed parameter matching in include()'d urlpattern
...
Fixed URL resolving in the case where an outer regex includes an inner
regex and both regexes use positional parameters instead of named
groups, causing the outer regex's parameters to override the inner
regex's.
Modified the regex url resolver so that it will concatenates and then
normalizes, instead of normalizing and then concatenating.
2014-03-05 00:35:03 +01:00
zedr
6fe22b30e0
Fixed #22085 -- Added a feature for setting non-expiring keys as the default.
...
This feature allows the default `TIMEOUT` Cache argument to be set to `None`,
so that cache instances can set a non-expiring key as the default,
instead of using the default value of 5 minutes.
Previously, this was possible only by passing `None` as an argument to
the set() method of objects of type `BaseCache` (and subtypes).
2014-03-04 21:16:35 +01:00
Rodolfo Carvalho
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
Russell Keith-Magee
6b63742ce5
Corrected expected test output to allow for cleanups in signal and compatibility checks.
2014-03-03 19:29:50 +08:00
Russell Keith-Magee
c41335fa27
Added backwards compatibliity checks to reference documentation.
2014-03-03 19:20:48 +08:00
Russell Keith-Magee
21d8175242
Fixed #22193 -- Made hint a truly optional arugment on check messages.
...
Thanks to Thomas Güttler for the suggestion.
2014-03-03 19:16:19 +08:00
Russell Keith-Magee
82ac389486
Edited model and field checks for grammar and consistency.
2014-03-03 18:18:39 +08:00
Erik Romijn
98f13762d7
Fixed #22123 -- EmailValidator now also accepts IPv6 literals in addresses
2014-02-22 17:45:33 +01:00
Baptiste Mispelon
173aa51997
Fixed #21435 -- Improved error message when urlconf is empty.
...
The new error message now hints that the most likely issue
is a circular import.
Thanks to trac user elena for the report and to
bpeschier for the original patch.
2014-02-22 15:36:49 +01:00
Baptiste Mispelon
3841feee86
Fixed #22107 -- Fixed django.core.files.File object iteration.
...
Due to a mixup between text and bytes, iteration over
a File instance was broken under Python 3.
Thanks to trac user pdewacht for the report and patch.
2014-02-20 19:13:25 +01:00
Dmitro
d3e33fff12
Made content_type_extra optional for TemporaryUploadedFile and MemoryUploadedFile.
...
This provides better backwards compatibility for those constructing these
objects manually.
Refs #13721 .
2014-02-18 07:49:42 -05:00
Claude Paroz
621c5cf4a5
Fixed #21732 -- Made compilemessages complain about non-writable location
...
Instead of crashing with a CommandError, now a non-writable location
of mo files will only make compilemessages complain and continue.
Thanks Ramiro Morales for the review.
2014-02-18 13:38:06 +01:00
Baptiste Mispelon
2a9ee49f3c
Removed BaseCommand.stdin introduced in 116d39842d
.
...
This option is not actually very useful in the general case
because it doesn't override sys.stdin.
It's still marginally useful for testing some features of
the createsuperuser command so it was moved there.
This commit also makes the detection of a TTY in createsuperuser
a bit more robust, after a suggestion of appolo13.
2014-02-18 11:36:06 +01:00
Baptiste Mispelon
116d39842d
Added the possibility to pass a stdin object to a management command.
...
This makes testing certain features easier.
Thanks to AeroNotix for the original patch.
2014-02-17 04:58:31 +01:00
MattBlack85
a8ba76c2d3
Fixed #19980 : Signer broken for binary keys (with non-ASCII chars).
...
With this pull request, request #878 should considered closed.
Thanks to nvie for the patch.
2014-02-16 16:50:50 +01:00
Alex Gaynor
cd7f37b647
Corrected a pair of flake8 violations
2014-02-15 10:42:12 -08:00
Grzegorz Nosek
0b6f9f7c6f
Improved fix for #18373 -- backward compatibility
...
Commit 79558c78
cleaned up the (undocumented) interface of Resolver404
exception, which breaks compatibility with code messing with .args[0]
directly. Revert the cleanup part and simply leave the fix itself.
2014-02-15 17:51:18 +01:00
Tim Graham
65b421c661
Fixed some flake8 errors from recent commits.
2014-02-15 11:21:15 -05:00
Aaron France
1150053b99
Fixed #21912 -- Improved error message if a view returns None.
...
Thanks brycenesbitt for the report.
2014-02-15 11:18:16 -05:00
Grzegorz Nosek
79558c787e
Fixed #18373 - improved handling of Resolver404s from views
...
When django.core.urlresolvers.resolve was called from a view, failed
and the exception was propagated and rendered by technical_404_response,
the URL mentioned on the page was the current URL instead of the URL
passed to resolve().
Fixed by using the path attribute from the Resolver404 exception instead
of request.path_info. Also cleaned up the exceptions to use standard
named parameters instead of stuffing a dict in args[0]
2014-02-15 15:56:04 +01:00
Rodolfo Carvalho
4d4e0ea461
Fixed two typos.
2014-02-15 15:16:16 +01:00
Tim Graham
8251438cb8
Moved relative URL handling added in refs #21177 to a better place.
...
Thanks apollo13: "reverse() shouldn't know about absolute/relative paths."
2014-02-15 07:54:35 -05:00
Antoine Catton
e3d0790bd0
Fixed #21177 -- Made resolve_url support relative URLs.
...
This fixes redirecting to relative URLs with django.shortcuts.redirect.
2014-02-14 17:58:03 -05:00
Andrew Godwin
f0f1ba75b0
Fixed #21856 : Don't crash runserver when DATABASES = {}
2014-02-12 19:09:43 +00:00
Andrew Godwin
7e941ba67c
Reverting unapplied migrations check away from being a system-level check.
...
This reverts commit 0ac13ecceb
.
2014-02-12 18:55:20 +00:00
Andrew Godwin
b333de0f5d
Add --empty option to makemigrations
2014-02-12 17:16:40 +00:00
Eli Bendersky
73f51e4113
Fixed #22025 -- Listing app followed by app.Model in dumpdata command
...
When invoked as follows:
$ python manage.py dumpdata blogapp blogapp.Tag
Django would throw a TypeError. This commit fixes the problem and provides
a test.
2014-02-12 15:34:26 +01:00
Si Feng
b102c27ff4
Fixed #20784 -- Added inverse_match parameter to RegexValidator.
2014-02-10 05:38:43 -05:00
Claude Paroz
e2f28572b7
Merge pull request #2245 from funkybob/parse_header
...
Replaced _parse_content_type with cgi.parse_header
2014-02-09 20:39:07 +01:00
Andrew Godwin
d5df7a0515
Fixed #21969 : Fix behaviour of initial_data with migrated apps
2014-02-09 12:22:59 +00:00
Andrew Godwin
2085f53f56
Fixed #21968 : Bad detection of old-style apps to add initial migration
2014-02-09 11:42:10 +00:00
Andrew Godwin
38b4adc696
Merge pull request #2244 from mlavin/21856-migration-checks
...
Fixed #21856 : Allow Empty DATABASES Setting
2014-02-09 10:46:57 +00:00
Curtis
f43e895b15
Replace _parse_content_type with cgi.parse_header
2014-02-09 10:01:16 +11:00
Kevin Christopher Henry
6fe26bd3ee
Fixed #19373 -- Ported Windows file locking from PyWin32 to ctypes
...
There wasn't any file locking under Windows unless PyWin32 was
installed. This removes that (undocumented) dependency by using ctypes
instead.
Thanks to Anatoly Techtonik for writing the ctypes port upon which this
is based.
2014-02-08 15:52:06 -05:00
Berker Peksag
5d263dee30
Fixed #21674 -- Deprecated the import_by_path() function in favor of import_string().
...
Thanks Aymeric Augustin for the suggestion and review.
2014-02-08 11:12:19 -05:00
mlavin
0ac13ecceb
Remove check_migrations from the runserver command and use the new checks framework to check for unapplied migrations. Don't check for migrations if the DATABASES setting is empty.
2014-02-08 09:01:59 -05:00
Michael Manfre
3ffeb93186
Ensure cursors are closed when no longer needed.
...
This commit touchs various parts of the code base and test framework. Any
found usage of opening a cursor for the sake of initializing a connection
has been replaced with 'ensure_connection()'.
2014-02-02 12:47:21 -05:00
Tim Graham
2b6914049a
Fixed #21849 -- Included the count of silenced system checks in output.
2014-01-28 08:31:02 -05:00
Wojciech Banaś
8f2f48ecc9
Fixed #21866 -- Replaced "COMMIT" in managmement command SQL with backend hook.
2014-01-26 12:42:41 -05:00
Aymeric Augustin
f901b4d6c8
Took advantage of the new get_model API. Refs #21702 .
2014-01-26 13:08:05 +01:00
Aymeric Augustin
ee4b806a85
Fixed #21873 -- Removed duplicate import.
...
Thanks Sephi for the report.
2014-01-25 23:22:03 +01:00
Aymeric Augustin
2ff93e027c
Fixed #21829 -- Added default AppConfigs.
...
Thanks Russell for the report, Marc for the initial patch, Carl for the
final review, and everyone who contributed to the design discussion.
2014-01-25 10:41:56 +01:00
José Moreira
8649833cf8
fixed typo on docstring
2014-01-20 16:33:11 +00:00
Russell Keith-Magee
d818e0c9b2
Fixed #16905 -- Added extensible checks (nee validation) framework
...
This is the result of Christopher Medrela's 2013 Summer of Code project.
Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.
Also: Fixes #8579 , fixes #3055 , fixes #19844 .
2014-01-20 10:45:21 +08:00
Andrew Godwin
a68f325791
Fixed #21638 : Validators are now comparable, stops infinite user mig'ns
2014-01-19 18:56:16 +00:00
JustinTArthur
298a2b577f
Adjusted inspectdb management command to yield PEP 8-compliant output barring Django Coding Style exceptions.
2014-01-17 18:03:16 -05:00
Marc Tamlyn
ac8d0a4815
Remove unneded open(.., 'U') when on python 3.
...
Universal newlines is enabled by default on py3, and the usage of 'U' is
deprecated in py3.4.
2014-01-13 17:11:21 +00:00
Marc Tamlyn
9d2c5b0420
Undelete the `return True` removed in 4e0a2fe
.
...
This is quite important otherwise we don't close our connections to the
SMTP server.
2014-01-12 23:38:28 +00:00
Aymeric Augustin
0a7588dd3f
Fixed #21770 -- Updated autocomplete for app-loading.
...
Thanks dfunckt for the report.
2014-01-12 22:29:27 +01:00
Aymeric Augustin
d562527a16
Fixed #21477 -- Renamed db to using in pre/post_migrate signals.
2014-01-12 22:24:33 +01:00
Aymeric Augustin
2dcde523ab
Avoided catching ImproperlyConfigured on django.setup().
...
Fixed #21737 . Thanks Florian for the report.
Also removed redundant imports in that file.
2014-01-06 23:01:29 +01:00
Claude Paroz
aaf5b3e7aa
Moved django.setup() to ManagementUtility
...
In get_commands, setup() might already have been called, for example
when the management command is called through call_command. Moving
setup() to ManagementUtility so as it is only called when the command
is run from command line.
2014-01-02 20:47:40 +01:00
Aymeric Augustin
30a42a4fc3
Adjusted previous commit for Python 3.
2014-01-01 19:12:46 +01:00
Aymeric Augustin
0ce945a671
Fixed #21018 -- Reversed precedence order for management commands.
2014-01-01 18:11:15 +01:00
Aymeric Augustin
f17d00278e
Wiped get_commands() cache when INSTALLED_APPS changes.
...
Refs #21018 , #21688 .
2014-01-01 18:11:09 +01:00
Aymeric Augustin
a95f74e707
Oops.
2013-12-31 13:16:51 +01:00
Aymeric Augustin
6b172a6d6d
Called django.setup() explicitly in management commands.
...
This avoids duplicating code.
2013-12-31 13:11:05 +01:00
Aymeric Augustin
bfcc686d22
Removed the only_with_models_module argument of get_model[s].
...
Now that the refactorings are complete, it isn't particularly useful any
more, nor very well named. Let's keep the API as simple as possible.
Fixed #21689 .
2013-12-30 23:59:34 +01:00
Florian Apolloner
df075c7489
Merge pull request #2126 from apollo13/email_bytes
...
Many thanks to @bitdancer and @aaugustin for answering my stupid questions about (mail)encodings and pointing me in the right direction.
2013-12-30 14:58:49 -08:00
Florian Apolloner
bfe9052831
Decode mails using the message encoding.
2013-12-30 23:54:12 +01:00
Florian Apolloner
c988745cca
Changed console and filebackend to use msg.as_bytes to output the data as it would get send via smtp.
2013-12-30 23:46:05 +01:00
Aymeric Augustin
1c242a297b
Merged Apps.populate_apps() and populate_models().
...
After the recent series of refactorings, there's no reason to keep
two distinct methods.
Refs #21681 .
2013-12-30 23:18:22 +01:00
Aymeric Augustin
80d74097b4
Stopped populating the app registry as a side effect.
...
Since it triggers imports, it shouldn't be done lightly.
This commit adds a public API for doing it explicitly, django.setup(),
and does it automatically when using manage.py and wsgi.py.
2013-12-30 22:11:17 +01:00
Aymeric Augustin
0d2c8ff2be
Populated the app registry earlier at startup.
...
Refs #1796 , #21676 .
2013-12-30 22:11:16 +01:00
Aymeric Augustin
5892a83b18
Stopped calling get_models() for a side effect.
2013-12-29 21:48:58 +01:00
Aymeric Augustin
e5bcd1d455
Changed get_validation_errors to use an app config.
2013-12-29 21:48:58 +01:00
Aymeric Augustin
856aaaf2b1
Changed get_migratable_models to use an app config.
2013-12-29 21:25:28 +01:00
Aymeric Augustin
1d4bcb86ea
Changed sql_* to use an app config instead of a models module.
2013-12-29 21:25:28 +01:00
Aymeric Augustin
368d90e261
Removed unused import.
2013-12-29 20:45:34 +01:00
Aymeric Augustin
7b88a96553
Added AppConfig.get_models().
2013-12-29 20:31:59 +01:00
Aymeric Augustin
00110904ac
Refactored the migration signals to use app configs.
...
De-aliased pre/post_syncdb to pre/post_migrate to increase
backwards-compatibility.
2013-12-29 17:53:42 +01:00
Claude Paroz
6d66ba5948
Fixed #21242 -- Allowed more IANA schemes in URLValidator
...
Thanks Sascha Peilicke for the report and initial patch, and
Tim Graham for the review.
2013-12-28 21:25:32 +01:00
Aymeric Augustin
ba7206cd81
Changed get_model to raise an exception on errors.
...
Returning None on errors required unpythonic error checking and was
inconsistent with get_app_config.
get_model was a private API until the previous commit, but given that it
was certainly used in third party software, the change is explained in
the release notes.
Applied the same change to get_registered_model, which is a new private
API introduced during the recent refactoring.
2013-12-28 20:53:00 +01:00
Florian Apolloner
5dfd824d38
Introduced as_bytes for SafeMIMEText (and other SafeMIME-classes).
...
This is to provide a consistent interface (namely bytes) for the smtp
backend which after all sends bytes over the wire; encoding with as_string
yields different results since mails as unicode are not really specified.
as_string stays for backwardscompatibilty mostly and some debug outputs.
But keep in mind that the output doesn't match as_bytes!
2013-12-28 18:35:17 +01:00
Florian Apolloner
280c1a65cc
Worked around a bug in python 3.3.3. Refs #21093
2013-12-28 15:25:16 +01:00
Florian Apolloner
f28ea02308
Fixed #21093 -- Ensured that mails are not base64 encoded on python 3.3.3+.
...
Thanks to Arfrever for the report and Aymeric for the review.
2013-12-28 12:42:33 +01:00
Aymeric Augustin
c81fae6b95
Used app_label instead of appname.
...
The last component of the dotted path to the application module is
consistently referenced as the application "label". For instance it's
AppConfig.label. appname could be confused with AppConfig.name, which is
the full dotted path.
2013-12-28 09:53:02 +01:00
Aymeric Augustin
a7add2f296
Migrated built-in AppCommands to use handle_app_config.
2013-12-28 09:43:06 +01:00
Aymeric Augustin
bb8ec71f61
Updated the AppCommand API to support apps without a models module.
2013-12-28 09:42:59 +01:00
Aymeric Augustin
efddae252c
Refactored dumpdata with app configs instead of models modules.
2013-12-27 21:25:35 +01:00
Aymeric Augustin
ce1bc2c94b
Made the AppConfig API marginally more consistent.
...
Eliminated the app_ prefix that was more confusing than useful.
2013-12-26 19:25:09 +01:00
Aymeric Augustin
08bb238eae
Merge pull request #2105 from funkybob/cleanup_get_post
...
Used @cached_property for request.GET and COOKIES
2013-12-25 12:34:06 -08:00
Aymeric Augustin
1716b7ce5a
Renamed AppCache to Apps.
...
Also renamed app_cache to apps and "app cache" to "app registry".
Deprecated AppCache.app_cache_ready() in favor of Apps.ready().
2013-12-24 12:25:17 +01:00
Curtis
d7a4b156d9
Use cached_property for request.GET and request.COOKIES
2013-12-24 21:57:57 +11:00
Aymeric Augustin
2fef9e5375
Moved apps back in the toplevel django namespace.
...
Reverted 4a56a93cc4
.
2013-12-22 11:39:55 +01:00
Aymeric Augustin
99bd39ef6e
Added the ability to supply custom app configs.
2013-12-22 11:39:18 +01:00
Aymeric Augustin
16aae35ca8
Improved set_available_apps() in several ways.
...
- Tested consistency the current app_configs instead of INSTALLED_APPS.
- Considered applications added with _with_app as available.
- Added docstrings.
2013-12-22 11:39:18 +01:00
Aymeric Augustin
9cdf1f6d54
Stop testing for inclusion in INSTALLED_APPS.
...
Removed some exception masking in the comments app that was harmful and
couldn't be preserved easily.
2013-12-22 11:39:18 +01:00
Aymeric Augustin
70c9654d45
Renamed registered_model to has_model.
...
This avoids possible confusion with register_model.
Thanks Marc Tamlyn for the suggestion.
2013-12-22 11:39:18 +01:00
Aymeric Augustin
65cd74be8e
Stopped iterating on INSTALLED_APPS.
...
Used the app cache's get_app_configs() method instead.
2013-12-22 11:39:18 +01:00
Aymeric Augustin
d4733b6df0
Not all Python modules have a __path__.
2013-12-22 11:39:18 +01:00
Aymeric Augustin
4582993302
Populated models only when necessary in get_app_config[s].
...
Took this opportunity to change get_app[s] to only consider applications
containing a model module as that seems slightly more backwards compatible.
Since callers that care about models pass only_with_models_module=True,
this has very few consequences. Only AppCommand needed a change.
2013-12-22 11:39:18 +01:00
Aymeric Augustin
f25fa9d859
Deprecated load_app().
...
Adjusted several tests that used it to add apps to the app cache and
then attempted to remove them by manipulating attributes directly.
Also renamed invalid_models to invalid_models_tests to avoid clashing
application labels between the outer and the inner invalid_models
applications.
2013-12-22 11:39:17 +01:00
Aymeric Augustin
439b364e1e
Added an _-prefix to pending lookups because it's transient.
2013-12-22 11:39:17 +01:00
Aymeric Augustin
86804ab063
Terminated AppCache._populate() with extreme prejudice.
...
It was called _populate() before I renamed it to populate(). Since it
has been superseded by populate_models() there's no reason to keep it.
Removed the can_postpone argument of load_app() as it was only used by
populate(). It's a private API and there's no replacement. Simplified
load_app() accordingly. Then new version behaves exactly like the old
one even though it's much shorter.
2013-12-22 11:39:17 +01:00
Aymeric Augustin
2b56d69102
Implemented two-stage app-cache population.
...
First stage imports app modules. It doesn't catch import errors. This
matches the previous behavior and keeps the code simple.
Second stage import models modules. It catches import errors and retries
them after walking through the entire list once. This matches the
previous behavior and seems useful.
populate_models() is intended to be equivalent to populate(). It isn't
wired yet. That is coming in the next commit.
2013-12-22 11:39:17 +01:00
Aymeric Augustin
9b3389b726
Removed the app_config.installed flag.
...
Since applications that aren't installed no longer have an application
configuration, it is now always True in practice.
Provided an abstraction to temporarily add or remove applications as
several tests messed with app_config.installed to achieve this effect.
For now this API is _-prefixed because it looks dangerous.
2013-12-22 11:39:17 +01:00
Aymeric Augustin
972babc3b4
Removed the only_installed argument of get_app_config[s].
...
It wasn't used anywhere and couldn't be implemented any more since
non-installed apps no longer have a configuration.
2013-12-22 11:39:17 +01:00
Aymeric Augustin
742ed9878e
Refactored registration of models.
...
Got rid of AppConfig._stub. As a side effect, app_cache.app_configs now
only contains entries for applications that are in INSTALLED_APPS, which
is a good thing and will allow dramatic simplifications (which I will
perform in the next commit). That required adjusting all methods that
iterate on app_configs without checking the "installed" flag, hence the
large changes in get_model[s].
Introduced AppCache.all_models to store models:
- while the app cache is being populated and a suitable app config
object to register models isn't available yet;
- for applications that aren't in INSTALLED_APPS since they don't have
an app config any longer.
Replaced get_model(seed_cache=False) by registered_model() which can be
kept simple and safe to call at any time, and removed the seed_cache
argument to get_model[s]. There's no replacement for that private API.
Allowed non-master app caches to go through populate() as it is now
safe to do so. They were introduced in 1.7 so backwards compatibility
isn't a concern as long as the migrations framework keeps working.
2013-12-22 11:39:17 +01:00
Aymeric Augustin
73c9e65b75
Added a context manager to hold the import lock.
2013-12-22 11:39:17 +01:00
Aymeric Augustin
9bfdad5472
Style cleanup forgotten in second previous commit.
2013-12-17 22:24:25 +01:00
Aymeric Augustin
0242c56fd8
Deborgified the app cache.
...
Improved Andrew's hack to create temporary app caches to handle
migrations. Now the main app cache has a "master" flag set to True
(which is a non-default keyword argument, thus unlikely to be used by
mistake). Other app cache instances have "master" set to False.
The only sanctioned way to access the app cache is by importing
django.core.apps.app_cache.
If you were instanciating an app cache and relying on the Borg pattern,
you'll have to refactor your code.
2013-12-17 21:53:18 +01:00
Aymeric Augustin
4a56a93cc4
Moved the new app cache inside core.
2013-12-17 10:17:46 +01:00
Aymeric Augustin
5ba743e262
Made it possible to create apps without a models module.
...
This commit reverts f44c4a5d0f
and 39bbd165
.
django.test.simple will be updated in a separate commit as it requires
invasive changes.
2013-12-17 10:17:45 +01:00
Aymeric Augustin
69039becde
Deprecated get_app().
2013-12-17 10:17:45 +01:00
Aymeric Augustin
2732edc5f2
Deprecated get_apps().
2013-12-17 10:17:45 +01:00
Aymeric Augustin
d44de9b933
Removed the _-prefix for populate().
...
Several parts of Django call get_apps() with a comment along this lines
of "this has the side effect of calling _populate()". I fail to see how
this is better than just calling populate()!
2013-12-17 10:17:45 +01:00
Aymeric Augustin
259cd3cd41
Deprecated get_app_package, get_app_path and get_app_paths.
2013-12-17 10:17:45 +01:00
Aymeric Augustin
2c9e84af4a
Removed unused attribute app_errors of the app cache.
...
get_app_errors() always returned an empty dictionary; this behavior is
preserved in django.db.models.loading until that module is deprecated.
2013-12-17 10:17:44 +01:00
Aymeric Augustin
8662654d6d
Removed module-level functions for the app cache.
...
Since the original ones in django.db.models.loading were kept only for
backwards compatibility, there's no need to recreate them. However, many
internals of Django still relied on them.
They were also imported in django.db.models. They never appear in the
documentation, except a quick mention of get_models and get_app in the
1.2 release notes to document an edge case in GIS. I don't think that
makes them a public API.
This commit doesn't change the overall amount of global state but
clarifies that it's tied to the app_cache object instead of hiding it
behind half a dozen functions.
2013-12-17 10:17:44 +01:00
Aymeric Augustin
860c2c8bc5
Moved django.db.models.loading to django.apps.cache.
...
This commit doesn't contain any code changes; it's purely a refactoring.
2013-12-17 10:17:43 +01:00
Loic Bistuer
6685713869
Fixed E127 pep8 warnings.
2013-12-14 11:59:15 -05:00
Loic Bistuer
a2814846ca
Fixed E124 pep8 warnings.
2013-12-10 15:12:48 -05:00
Loic Bistuer
2e3c7d8820
Trigger AttributeError in ValidationError.message_dict when error_dict is missing.
...
The goal of this change is twofold; firstly, matching the behavior of Django 1.6
and secondly, an AttributeError is more informative than an obscure ValueError
about mismatching sequence lengths.
Refs #20867 .
2013-12-07 23:01:28 +07:00
Loic Bistuer
a8f4553aae
Fixed #21555 -- Made ValidationError pickable.
...
Thanks trac username zanuxzan for the report and original patch.
2013-12-07 18:58:37 +07:00
Claude Paroz
41ebc4838d
Fixed #21551 -- Reenabled loading fixtures from subdirectory
...
This was a regression in Django 1.6 that was only partially
restored in 839940f27f
.
Thanks Jonas Haag for the report.
2013-12-07 10:47:34 +01:00
Andrew Godwin
4ca39684ee
Fix poor variable name (flake8 warning)
2013-12-05 14:11:46 +00:00
Andrew Godwin
3b8e46cbc7
Migration VCS conflict detection and --merge for makemigrations
2013-12-04 16:01:49 +00:00
Andrew Godwin
ab587fa51a
Add --dry-run option to makemigrations
2013-12-04 13:55:20 +00:00
Andrew Godwin
1d20e6df95
Migrate prompts if you need makemigrations, runserver prompts for migrate
2013-12-04 13:34:01 +00:00
Ramiro Morales
12615dab78
Fixed #13476 -- Added support for color in console output under Windows.
...
Detect and use the services of the ANSICON third-party tool if it's
available.
2013-12-02 23:18:04 -03:00
Claude Paroz
2080bce695
Fixed #21358 -- Allowed runserver on non-English locales
...
Thanks svartalf for the report.
2013-11-30 19:17:36 +01:00
Claude Paroz
6310d658b7
Closed file after reading pot file
...
Faulty line was introduced in 50a8ab7cd1
.
2013-11-30 11:31:17 +01:00
Claude Paroz
50a8ab7cd1
Enabled makemessages to support several translation directories
...
Thanks Rémy Hubscher, Ramiro Morales, Unai Zalakain and
Tim Graham for the reviews.
Also fixes #16084 .
2013-11-30 11:00:23 +01:00
Loic Bistuer
f563c339ca
Fixed #20867 -- Added the Form.add_error() method.
...
Refs #20199 #16986 .
Thanks @akaariai, @bmispelon, @mjtamlyn, @timgraham for the reviews.
2013-11-30 01:00:53 +07:00
Vajrasky Kok
7e2d61a972
Fixed #21380 -- Added a way to set different permission for static directories.
...
Previously when collecting static files, the directories would receive permissions
from the global umask. Now the default permission comes from FILE_UPLOAD_DIRECTORY_PERMISSIONS
and there's an option to specify the permissions by subclassing any of the
static files storage classes and setting the directory_permissions_mode parameter.
2013-11-29 08:01:30 -05:00
Alex Gaynor
83ab04c6d6
flake8 fixes
2013-11-24 21:07:21 -06:00
Simon Charette
eb38257e51
Fixed #21391 -- Allow model signals to lazily reference their senders.
2013-11-24 17:51:22 -05:00
Florian Apolloner
d47f794f8f
Properly closed cache connections at the end of the request.
...
This only affects the new cache api and not the deprecated get_cache.
Refs #21012
2013-11-24 16:23:28 +01:00
Florian Apolloner
cf7ddc5765
Follow up to e112654fc8
...
Actually comitted the code now :þ
2013-11-23 18:55:28 +01:00
Alex Gaynor
0ec712dd11
A handful of flake8 fixes
2013-11-23 08:26:11 -08:00
Ramiro Morales
62b393c5ae
Fixed #21488 -- Multiple locales treatment in i18n commands.
...
Removed multiple locales separated by commas variation (that wasn't
working as documented) in favor of simply allowing use of the
``--locale``/``-l`` options more than once for ``makemessages`` and
``compilemessages``.
Thanks Romain Beylerian for the report and Claude, Simon for their help.
8750296918
from stable/1.6.x.
2013-11-23 11:53:47 -03:00
Curtis Maloney
ffc37e2343
Fixed #21012 -- New API to access cache backends.
...
Thanks Curtis Malony and Florian Apolloner.
Squashed commit of the following:
commit 3380495e93
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sat Nov 23 14:18:07 2013 +0100
Looked up the template_fragments cache at runtime.
commit 905a74f52b
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sat Nov 23 14:19:48 2013 +0100
Removed all uses of create_cache.
Refactored the cache tests significantly.
Made it safe to override the CACHES setting.
commit 35e289fe92
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sat Nov 23 12:23:57 2013 +0100
Removed create_cache function.
commit 8e274f747a
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sat Nov 23 12:04:52 2013 +0100
Updated docs to describe a simplified cache backend API.
commit ee7eb0f73e
Author: Curtis Maloney <curtis@tinbrain.net>
Date: Sat Oct 19 09:49:24 2013 +1100
Fixed #21012 -- Thread-local caches, like databases.
2013-11-23 15:06:59 +01:00
xuxiang
4cfe6ba6a3
Use `classmethod` as a decorator.
2013-11-19 23:08:21 -05:00
Claude Paroz
97ac22ebfc
Fixed #21457 -- Allowed fixture file name to contain dots
...
Thanks Keryn Knight for the report.
2013-11-18 20:32:13 +01:00
Claude Paroz
115fd140ab
Configure settings sooner in makemessages
...
As get_text_list is using translations, setup settings before
calling it.
2013-11-15 15:30:22 +01:00
Claude Paroz
dffcc5e979
Fixed #20990 -- Ensured unicode paths in compilemessages
...
Thanks Gregoire Astruc for the report and furins for the review.
2013-11-11 11:51:38 +01:00
Bouke Haarsma
9b7455e918
Fixed #21351 -- Replaced memoize with Python's lru_cache.
...
Replaced the custom, untested memoize with a similar decorator from Python's
3.2 stdlib. Although some minor performance degradation (see ticket), it is
expected that in the long run lru_cache will outperform memoize once it is
implemented in C.
Thanks to EvilDMP for the report and Baptiste Mispelon for the idea of
replacing memoize with lru_cache.
2013-11-11 08:53:09 +01:00
Claude Paroz
e7383f16b4
Fixed #14800 -- Suppressed WSGIRequestHandler message filtering
...
Filtering out static file requests in runserver has been judged
arbitrary and can hide some debugging-related activity.
Thanks Roy Smith for the report and Aymeric Augustin for the
review.
2013-11-09 16:23:14 +01:00
Claude Paroz
e6dd70b4db
Fixed #21383 -- Added request details in SuspiciousOperation messages
2013-11-09 12:11:58 +01:00
Tim Graham
536c447820
Fixed a couple flake8 warnings.
2013-11-07 20:10:25 -05:00
Jaap Roes
7be638390e
Fixed #20536 -- rewrite of the file based cache backend
...
* Safer for use in multiprocess environments
* Better random culling
* Cache files use less disk space
* Safer delete behavior
Also fixed #15806 , fixed #15825 .
2013-11-07 16:12:15 +02:00
Andrew Godwin
c7bf4c27a0
Allow squashing of squashed migrations
2013-11-06 15:27:08 +00:00
Alex Gaynor
c347f78cc1
Fixed all E226 violations
2013-11-03 10:08:55 -08:00
Milton Mazzarri
cbc7cbbc5b
Fixed flake8 E251 violations
2013-11-03 03:22:11 -06:00
coagulant
3bc0d46a84
Fixed all E261 warnings
2013-11-02 18:20:39 -04:00
Alex Gaynor
7548aa8ffd
More attacking E302 violators
2013-11-02 13:12:09 -07:00
Alex Gaynor
65c4ac3b24
Merge pull request #1849 from brabadu/master
...
Fixed flake8 E241
2013-11-02 12:57:58 -07:00
Alex Gaynor
4ad9f4d4ea
Replaced a hardcoded "2" with the right named constant
2013-11-02 12:55:36 -07:00
Boryslav Larin
e737c009b8
Fixed flake8 E241
2013-11-02 21:45:40 +02:00
Tim Graham
36ded01527
Fixed #21302 -- Fixed unused imports and import *.
2013-11-02 15:24:56 -04:00
Anssi Kääriäinen
9f76ea1eaa
Fixed #21375 -- related_name='+' clashed with other '+' names
2013-11-02 21:18:35 +02:00
Andrew Godwin
e9cb333bc3
Auto-apply initial migrations if their tables exist already.
2013-10-30 15:17:49 +00:00
Alex Gaynor
b35ff0d920
Fixed all the E203 violations
2013-10-26 18:27:42 -07:00
Alex Gaynor
f2d8027c9a
Fixed up some more flake8 violations (this particular violation still has many occurrences in the tests/ dir so it can't be removed from setup.cfg yet)
2013-10-26 10:50:40 -07:00
Claude Paroz
3afde36d03
Undelete the login() call inadvertantly removed in 4e0a2fe59c
...
Refs #21271 .
2013-10-25 11:23:19 +02:00
SusanTan
4e0a2fe59c
Fixed #21271 -- Added timeout parameter to SMTP EmailBackend.
...
Thanks Tobias McNulty and Tim Graham for discussions and code review.
Thanks Andre Cruz the suggestion and initial patch.
2013-10-24 20:38:00 -04:00
Vajrasky Kok
9eecb91695
Fixed #21219 -- Added a way to set different permission for static files.
...
Previously, when collecting static files, the files would receive permission
from FILE_UPLOAD_PERMISSIONS. Now, there's an option to give different
permission from uploaded files permission by subclassing any of the static
files storage classes and setting the file_permissions_mode parameter.
Thanks dblack at atlassian.com for the suggestion.
2013-10-24 17:40:01 -04:00
Alex Gaynor
9bf5610890
Start attacking E231 violations
2013-10-24 10:30:03 -07:00
Tim Graham
4cfbde71a3
Fixed #12027 -- Fixed EmailValidator to reject a trailing dot.
...
Thanks Klas H for the report and claudep for the patch.
2013-10-23 12:22:14 -04:00
Alasdair Nicol
c3aa2948c6
Fixed #21298 -- Fixed E301 pep8 warnings
2013-10-23 13:45:03 +01:00
Tim Graham
ae48d77ef8
Fixed E225 pep8 warnings.
2013-10-23 06:09:29 -04:00
Tim Graham
1597503a01
Fixed E221 pep8 warnings.
2013-10-22 09:51:39 -04:00
Ramiro Morales
b5f52647fe
Decode from UTF-8 explicitly when reading a text file in makemessages.
...
This shows itself with Python 3 under Windows where UTF-8 usually isn't
the default file I/O encoding and caused one failure and three errors
in our test suite under that platform setup.
2013-10-22 06:09:21 -03:00
Claude Paroz
a098bee1b9
Fixed #19724 -- Output note when showing only core management commands
...
When listing available management commands, only core commands are
listed if settings have any error. This commit adds a note in this
case so errors are not totally silently skipped.
Thanks Peter Davis for the report.
2013-10-21 21:26:48 +02:00
Loic Bistuer
e565e1332d
Fixed #21275 -- Fixed a serializer error when generating migrations for contrib.auth.
...
The migration serializer now looks for a deconstruct method on any object.
2013-10-21 14:54:52 -04:00
Alasdair Nicol
b289fcf1bf
Fixed #21288 -- Fixed E126 pep8 warnings
2013-10-21 08:31:30 -04:00
Alasdair Nicol
a800036981
Fixed #21287 -- Fixed E123 pep8 warnings
2013-10-18 10:07:39 +01:00
Alasdair Nicol
bab9123daa
Fixed #21268 -- Fixed E303 pep8 warnings
2013-10-18 01:46:24 +01:00
Alasdair Nicol
65d1d65d52
Fixed #21267 -- Fixed E502 pep8 warnings
2013-10-18 01:28:32 +01:00
Alasdair Nicol
dfb4cb9970
Fixed #21285 -- Fixed E121,E122 pep8 warnings
2013-10-17 20:20:11 -04:00
Claude Paroz
3514bcb251
Fixed #21284 -- Prevented KeyError swallowing in fetch_command
...
Thanks wildfire for the report.
2013-10-17 18:57:44 +02:00
Bouke Haarsma
2fb5a51fa3
Fixed #18659 -- Deprecated request.REQUEST and MergeDict
...
Thanks Aymeric Augustin for the suggestion.
2013-10-17 09:42:28 -04:00
Javed Khan
a921f06345
Fixed #21280 -- Don't generate empty migration files
2013-10-17 08:21:17 -04:00
Alasdair Nicol
eb214452c3
Fixed #21270 -- Fixed E701 pep8 warnings
2013-10-17 12:12:40 +01:00
Claude Paroz
650b6fd90e
Add get_migratable_models util method to ConnectionRouter
2013-10-16 18:02:49 +02:00
Claude Paroz
2992f42861
Fixed #19657 -- Made sql commands honor allow_migrate
...
Thanks Manel Clos for the report and the initial patch, and
Marc Tamlyn and Tim Graham for the review.
2013-10-16 18:02:32 +02:00
Andrew Godwin
763ac8b642
First pass on squashmigrations command; files are right, execution not.
2013-10-16 12:00:07 +01:00
Unai Zalakain
c7634cd7fe
Fixed #7603 -- Added a 'scheme' property to the HttpRequest object
...
`HttpRequest.scheme` is `https` if `settings.SECURE_PROXY_SSL_HEADER` is
appropriately set and falls back to `HttpRequest._get_scheme()` (a hook
for subclasses to implement) otherwise.
`WSGIRequest._get_scheme()` makes use of the `wsgi.url_scheme` WSGI
environ variable to determine the request scheme.
`HttpRequest.is_secure()` simply checks if `HttpRequest.scheme` is
`https`.
This provides a way to check the current scheme in templates, for example.
It also allows us to deal with other schemes.
Thanks nslater for the suggestion.
2013-10-15 09:04:12 -04:00
Larry O'Neill
83b9bfea44
Fixed #21266 -- Fixed E201,E202 pep8 warnings.
2013-10-14 18:12:00 -04:00
Claude Paroz
42a67ec1cd
Fixed #21269 -- Don't crash when CommandError contains non-ascii
...
Thanks kontakt@eikefoken.de for the report.
2013-10-14 21:21:07 +02:00
Claude Paroz
1e8eadc94e
Fixed #15888 -- Made tablename argument of createcachetable optional
...
Thanks Aymeric Augustin for the report and the documentation and
Tim Graham for the review.
2013-10-14 13:24:40 +02:00
Tai Lee
e527c0b6d8
Fixed #13252 -- Added ability to serialize with natural primary keys.
...
Added ``--natural-foreign`` and ``--natural-primary`` options and
deprecated the ``--natural`` option to the ``dumpdata`` management
command.
Added ``use_natural_foreign_keys`` and ``use_natural_primary_keys``
arguments and deprecated the ``use_natural_keys`` argument to
``django.core.serializers.Serializer.serialize()``.
Thanks SmileyChris for the suggestion.
2013-10-11 12:52:57 -04:00
Tim Graham
945e033a69
Fixed #8918 -- Made FileField.upload_to optional.
...
Thanks leahculver for the suggestion and dc and vajrasky for work
on the patch.
2013-10-11 08:07:25 -04:00
Tim Graham
b67ab75e82
Fixed assorted flake8 errors.
2013-10-11 07:25:14 -04:00
Tim Graham
1dae4ac177
Whitespace cleanup.
...
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
2013-10-10 16:49:20 -04:00
Tim Graham
cec11a3336
Used "is" for comparisons with None.
2013-10-10 09:35:56 -04:00
Russell Keith-Magee
8ff4303946
Refs #21197 -- Clarified upgrade check message.
...
Thanks to Carl and Shai for the discussion.
2013-10-08 10:00:39 +08:00
Baptiste Mispelon
20472aa827
Fixed #21189 : Cleaned up usage of bare except clauses.
...
Thanks to berkerpeksag for the report and to claudep
for the review.
2013-10-05 11:50:03 +02:00
Ramiro Morales
4b715fc05a
Fixed #21209 -- .po file path comments on Windows.
...
Literals from source files with Django template language syntax don't
have a '.py' suffix anymore.
Also, the '.\' prefix is preserved to respect GNU gettext behavior on
that platform.
Refs #16903 .
2013-10-01 20:37:43 -03:00
Michael Manfre
bf757a2f4d
Fixed #21147 -- Avoided time.time precision issue with cache backends.
...
The precision of time.time() is OS specific and it is possible for the
resolution to be low enough to allow reading a cache key previously set
with a timeout of 0.
2013-10-01 13:42:59 -04:00
Michael Manfre
d5606b5763
Fixed #21146 - DatabaseCache converts expires to python value
...
DatabaseCache uses raw cursors to bypass the ORM. This prevents it from
being used by database backends that require special handling of datetime
values.
There is no easy way to test this, so no tests added.
2013-09-26 13:11:43 +03:00
Helen ST
41167645b1
Fixed #14028 - Added validation for clashing db_columns.
...
Thanks akaariai for the suggestion.
2013-09-23 11:51:58 -04:00
Florian Apolloner
2ca00faa91
Fixed "Address already in use" from liveserver.
...
Our WSGIServer rewrapped the socket errors from server_bind into
WSGIServerExceptions, which is used later on to provide nicer
error messages in runserver and used by the liveserver to see if
the port is already in use. But wrapping server_bind isn't enough since
it only binds to the socket, socket.listen (which is called from
server_activate) could also raise "Address already in use".
Instead of overriding server_activate too I chose to just catch socket
errors, which seems to make more sense anyways and should be more robust
against changes in wsgiref.
2013-09-22 22:02:59 +02:00
Kevin Christopher Henry
59a34c43a8
Fixed #18744 -- Updated docstring to highlight limitations of NamedTemporaryFile
...
- Noted that this does not allow for reading and writing the same open
file in different processes under Windows.
- Noted that the keyword arguments to NamedTemporaryFile no longer
match the Python version.
2013-09-19 10:12:03 -04:00
Curtis Maloney
4e9f800742
Fixed #21125 -- Removed support for cache URI syntax
2013-09-19 10:01:39 -04:00
Markus Holtermann
a772ea8117
Fixed #21115 -- Fixed NameError in migrate --list command
2013-09-17 12:53:59 -04:00
Michael Manfre
c89d80e2cc
Fixed #21097 - Added DatabaseFeature.can_introspect_autofield
2013-09-14 09:48:59 +03:00
Michael Manfre
e61cc87129
Fixed #21090 -- Allowed backends to provide dotted field path to inspectdb.
2013-09-11 13:35:26 -04:00
Gregor MacGregor
b2b763448f
Fixed #20841 -- Added messages to NotImplementedErrors
...
Thanks joseph at vertstudios.com for the suggestion.
2013-09-10 11:09:59 -04:00
John Hensley
30fc49a7ca
Fixed #21057 -- Prevented FileSystemStorage from leaving temporary files.
2013-09-10 08:33:53 -04:00
homm
7008ed61c5
Fixed #21033 -- Fixed uploaded filenames not always being truncated to 255 characters
2013-09-10 01:55:16 +02:00
Aymeric Augustin
8aaca651cf
Fixed #20557 -- Properly decoded non-ASCII cookies on Python 3.
...
Thanks mitsuhiko for the report.
Non-ASCII values are supported. Non-ASCII keys still aren't, because the
current parser mangles them. That's another bug.
2013-09-07 10:25:43 -05:00
Aymeric Augustin
ae7f9afaf6
Minor cleanup in the WSGI handler.
2013-09-07 10:25:16 -05:00
Aymeric Augustin
4e88d106dc
Refactored the unmangling of the WSGI environ.
2013-09-07 10:03:50 -05:00
Aymeric Augustin
636860fbfb
Moved two WSGI-specific functions to the WSGI handler.
...
They were defined in base when the mod_python handler used them. See bfcecbff
.
2013-09-07 10:03:49 -05:00
Alex Gaynor
2530735d2d
Fixed a number of flake8 errors -- particularly around unused imports and local variables
2013-09-06 21:56:40 -07:00
Russell Keith-Magee
926bc421d9
Merge pull request #1566 from adamsc64/ticket_11857
...
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
2013-09-06 17:38:37 -07:00
Tim Graham
498014ccd5
Fixed Python 3 syntax error introduced in [ c72392da
]
2013-09-06 20:07:57 -04:00
Russell Keith-Magee
4f5faa1916
Merge pull request #1582 from rca/12756-missing-yaml-module-serializer-error-message
...
Fixed #12756 : Improved error message when yaml module is missing.
2013-09-06 16:05:02 -07:00
Roberto Aguilar
01a5359477
Cleanup commit after peer review.
2013-09-06 22:45:31 +00:00
Andrew Godwin
0b7cf56e28
Add -l alias for migrate --list
2013-09-06 17:00:38 -05:00
Roberto Aguilar
076cf131ec
Moved get_serializer() call in dumpdata command.
...
Moved the get_serializer() call within the condition that checks public
serializers. This will allow exceptions other than
SerializerDoesNotExist to be raised in order to provide the caller with
useful information, e.g when pyyaml is not installed.
2013-09-06 20:33:23 +00:00
Roberto Aguilar
c72392dab4
Added yaml directly into BUILTIN_SERIALIZERS.
...
The serializer definitely exists, but the dependent yaml module may not
be installed. The register_serializer() function will catch exceptions
and will stub in a fake serializer object that will raise the exception
when the serializer is used.
2013-09-06 20:33:23 +00:00
Andrew Godwin
efd1e6096e
Adding 'sqlmigrate' command and quote_parameter to support it.
2013-09-06 15:28:12 -05:00
Dan Johnson
df462cf760
Fixed #21043 -- Made resolve() handle reverse_lazy objects.
...
Thanks Keryn Knight for the report.
2013-09-06 15:46:43 -04:00
Christopher Adams
b2f5ac1656
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
...
- TemporaryFile now minimally mocks the API of the Python standard
library class tempfile.NamedTemporaryFile to avoid AttributeError
exceptions.
- The symbol django.core.files.NamedTemporaryFile is actually assigned
as a different class on different operating systems.
- The bug only occurred if Django is running on Windows, hence why it
was hard to diagnose.
2013-09-06 14:32:46 -04:00
Andrew Godwin
9f6e6009a4
Add --list option to migrate command
2013-09-06 11:06:19 -05:00
Markus Holtermann
bd8e1a354c
Fixed #20977 -- Fixed writing migrations to disk on Python 3
2013-09-06 09:51:58 -04:00
Aymeric Augustin
6a6428a36f
Took advantage of django.utils.six.moves.urllib.*.
2013-09-05 14:39:23 -05:00
Tim Graham
5649c0af9d
Fixed "indentation is not a multiple of four" pep8 issues.
2013-09-03 14:22:21 -04:00
Carl Meyer
8f7f8bf688
Fixed #21026 -- Corrected help for manage.py test command.
2013-09-03 09:50:34 -06:00
Aymeric Augustin
365c3e8b73
Replaced "not PY3" by "PY2", new in six 1.4.0.
2013-09-02 12:11:02 +02:00
Claude Paroz
3e34005b1b
Fixed #13182 -- Prevented trailing spaces in indented json output
...
Thanks Stéphane Raimbault for the report and the initial patch.
2013-08-31 15:18:01 +02:00
Simon Charette
11cd7388f7
Fixed #20989 -- Removed useless explicit list comprehensions.
2013-08-30 10:57:51 -04:00
Tim Graham
c7d0ff0cad
Fixed #20989 -- Removed explicit list comprehension inside dict() and tuple()
...
Thanks jeroen.pulles at redslider.net for the suggestion and
helper script.
2013-08-29 12:11:03 -04:00
Christopher Medrela
32a962bdbf
Fixed #20814 -- Improved model field accessor clash error messages
...
Thanks shai for the suggestion.
2013-08-24 18:00:23 -04:00
Andrew Godwin
beefac8aae
Only create the migration directory once per app
2013-08-21 22:32:05 +01:00
Ramiro Morales
8e571e5f8f
Fixed #12422 -- Don't override global email charset behavior for utf-8.
...
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
2013-08-21 22:32:04 +01:00
Ramiro Morales
01223840f3
Fixed #18967 -- Don't base64-encode message/rfc822 attachments.
...
Thanks Michael Farrell for the report and his work on the fix.
2013-08-21 22:32:04 +01:00
Florian Apolloner
839940f27f
Fixed #20933 -- Allowed loaddata to load fixtures from relative paths.
2013-08-21 22:32:04 +01:00
Andrew Godwin
2e7f45a372
Change autodetector changes API to be just one method
2013-08-21 22:25:15 +01:00
Andrew Godwin
b6a957f0ba
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
docs/ref/django-admin.txt
2013-08-19 18:30:48 +01:00
Alasdair Nicol
22c6497f99
Fixed #20895 -- Made check management command warn if a BooleanField does not have a default value
...
Thanks to Collin Anderson for the suggestion and Tim Graham for
reviewing the patch.
2013-08-15 19:47:26 -04:00
Andrew Godwin
841b7af812
Use DEFAULT_DB_ALIAS
2013-08-12 16:40:41 +01:00
Mel Collins
6bdb3b1135
Fixed #13518 -- Added FILE_UPLOAD_DIRECTORY_PERMISSIONS setting
...
This setting does for new directories what FILE_UPLOAD_PERMISSIONS
does for new files.
Thanks jacob@ for the suggestion.
2013-08-12 07:15:59 -04:00
Andrew Godwin
d5a7a3d6a8
Add clarifying comment
2013-08-10 21:04:59 +01:00
Andrew Godwin
3f1f91f155
Print all bad apps passed to makemigrations, not just the first one.
2013-08-10 20:02:55 +01:00
Andrew Godwin
b3cec920a2
Remove other color_style override
2013-08-09 17:39:07 +01:00
Andrew Godwin
9f73629420
utils.importlib is deprecated
2013-08-09 17:36:16 +01:00
Andrew Godwin
679627660f
Remove useless override of self.style
2013-08-09 17:34:35 +01:00
Andrew Godwin
de64c4d6e9
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
django/core/management/commands/flush.py
django/core/management/commands/syncdb.py
django/db/models/loading.py
docs/internals/deprecation.txt
docs/ref/django-admin.txt
docs/releases/1.7.txt
2013-08-09 14:17:30 +01:00
Alex Gaynor
3e0eb2d788
Fixed a number of lint warnings, particularly around unused variables.
2013-08-04 09:17:10 -07:00
Curtis Maloney
07876cf02b
Deprecated SortedDict (replaced with collections.OrderedDict)
...
Thanks Loic Bistuer for the review.
2013-08-04 07:09:39 -04:00
MinRK
75cf5fc7f0
Added support for IPython.start_ipython in shell
...
IPython 1.0 introduces an actual stable public API function
for starting a normal (non-embedded) IPython session.
This is an official public API, which is promised to survive implementation changes.
2013-07-30 10:22:41 -07:00
Jose L. Patino
7b57e575c9
Fixed #19877 -- Added `--no-color` option to `BaseCommand` to avoid using output styles.
2013-07-30 09:26:18 -04:00
Andrew Godwin
12e9804d16
Rename allow_syncdb to allow_migrate
2013-07-30 12:08:59 +01:00
Andrew Godwin
68e0a169c4
Rename pre_ and post_syncdb to *_migrate, with aliases from old names
2013-07-30 11:52:52 +01:00
Claude Paroz
5c1143910e
Removed most of absolute_import imports
...
Should be unneeded with Python 2.7 and up.
Added some unicode_literals along the way.
2013-07-29 20:28:13 +02:00
Claude Paroz
fdd7a355bf
Deprecated django.utils.importlib
...
This was a shim for pre-Python 2.7 support.
2013-07-29 17:10:22 +02:00
Justin Michalicek
ac09558760
Fixed #20817 -- Added html_message parameter to django.core.mail.send_mail()
2013-07-29 09:53:47 -04:00
Przemek Lewandowski
382c53d7d8
Fixed #18213 -- Allowed empty fixtures (emit a warning rather than raising an exception).
2013-07-29 08:03:51 -04:00
Julien Phalip
47c755327b
Fixed a number of minor misspellings.
2013-07-27 18:46:03 -07:00
Andrew Godwin
d5ca169334
Fix "OK" alignment in migrate output
2013-07-26 16:52:17 +01:00
Andrew Godwin
52643a69e3
Add --fake option to migrate
2013-07-26 16:47:00 +01:00
Andrew Godwin
c1ed21fa9e
Use new transaction API in syncdb section of migrate
2013-07-26 16:39:44 +01:00
Andrew Godwin
6b39010d57
Remove nasty error message checking hack
2013-07-26 16:33:32 +01:00
Andrew Godwin
00276e0414
Add tests for the migrate command and fix a bug they exposed
2013-07-25 13:52:35 +01:00
Tim Graham
bd0dcc6c89
Fixed #20766 -- Deprecated FastCGI support.
2013-07-24 13:41:45 -04:00
Tim Graham
31c13a99bb
Fixed #14300 -- Fixed initial SQL location if models is a package.
...
Thanks al_the_x for the report and fheinz for the draft patch.
2013-07-24 06:56:33 -04:00
Andrew Godwin
162f7b938f
Make migrate command recognise prefixes and 'zero'.
2013-07-22 19:43:58 +01:00
Andrew Godwin
03ec3219a0
Merge branch 'master' into schema-alteration
...
Conflicts:
django/db/backends/mysql/introspection.py
django/db/backends/oracle/creation.py
django/db/backends/postgresql_psycopg2/creation.py
django/db/models/base.py
django/db/models/loading.py
2013-07-22 19:04:25 +01:00
Claude Paroz
11b7b9ad00
Fixed an email validation regression
...
Thanks Vincent Wagelaar for the report.
2013-07-21 21:11:32 +02:00
Tim Graham
2456ffa42c
Fixed #20746 -- Removed Python 2.6 specific code/docs
2013-07-14 13:02:55 -04:00
Claude Paroz
59ebe39812
Fixed #17471 -- Added smtplib.SMTP_SSL connection option for SMTP backend
...
Thanks dj.facebook at gmail.com for the report and initial patch
and Areski Belaid and senko for improvements.
2013-07-11 22:00:08 +02:00
Benjamin Kagia
b0953dc913
Fixed #13721 -- Added UploadedFile.content_type_extra.
...
Thanks Waldemar Kornewald and mvschaik for work on the patch.
2013-07-11 09:11:59 -04:00
Tim Graham
3c736207a3
Fixed #20722 -- Fixed MemcachedCache backend get_many on Python 3.
2013-07-09 11:55:45 -04:00
Alex Gaynor
5ac7f777cd
Merge pull request #991 from stockr-labs/feature/email-backends-generators
...
Fixed #20194 -- Adds generators support for email backends that do not support it.
2013-07-07 16:43:24 -07:00
Alex Gaynor
db2727f952
A few cleanups to capture the minimum amount of code in try/except blocks.
2013-07-08 09:26:52 +10:00
ersran9
76ee39ce14
Fixed 20613 - moved pickle loads/dumps outside with self._lock.reader()/writer() blocks
...
Additionaly added pickled=None initially and check for none before
returning in get
2013-07-06 02:09:52 +05:30
Tomáš Ehrlich
c5bc98d7e1
Fixed #20687 -- Added documentation for django.core.signing API.
...
Thanks Baptiste Mispelon for the suggestion.
2013-07-03 10:36:21 -04:00
Andrew Godwin
b1e0ec06f0
Merge branch 'master' into schema-alteration
2013-07-02 10:49:53 +01:00
Claude Paroz
7fbab3ebaf
Do not allow FileSystemStorage.delete to receive an empty name
...
Refs #20660 .
2013-06-29 18:09:31 +02:00
Ramiro Morales
f73d04dda9
Removed 'cleanup' management command as per deprecation TL.
2013-06-28 21:48:16 -03:00
Andrew Godwin
7a47ba6f6a
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
django/db/backends/__init__.py
django/db/models/fields/related.py
tests/field_deconstruction/tests.py
2013-06-28 17:32:57 +01:00
Andrew Godwin
b21e96d00d
Merge pull request #1311 from loic/ticket20619_take2
...
Fixed missing initializations in WSGIRequest. Refs #20619
2013-06-27 07:44:09 -07:00
Loic Bistuer
48ce167d89
Fixed missing initializations in WSGIRequest. Refs #20619
2013-06-26 14:36:25 +07:00
Russell Keith-Magee
0346563939
Fixed #20653 -- Renamed checksetup management command.
...
This is to allow future compatibility with work that is ongoing in the 2013 GSoC.
2013-06-25 09:37:54 +08:00
Ramiro Morales
1559f84d8b
Fixed #20311 -- Make sure makemessages doesn't create duplicate Plural-Forms .po file headers.
...
Thanks naktinis for the report and initial patch.
2013-06-22 18:45:41 -03:00
Andrew Godwin
0e8ee50e86
Rename makemigration to makemigrations
2013-06-20 15:27:33 +01:00
Baptiste Mispelon
fdbcbb9ebd
Fixed #20632 -- Fixed {{ docs_version }} in project template
2013-06-20 15:39:58 +02:00
Russell Keith-Magee
18e79f1425
Fixed #20486 -- Ensure that file_move_safe raises an error if the destination already exists.
...
Thanks to kux for the report, and Russ Webber for the patch.
2013-06-20 18:55:27 +08:00
Andrew Godwin
41214eaf18
Autodetect fields, have migrate actually work
2013-06-19 16:41:04 +01:00
Andrew Godwin
f25a385a5e
Makemigration command now works
2013-06-19 16:23:52 +01:00
Aymeric Augustin
ffcf24c9ce
Removed several unused imports.
2013-06-19 17:18:40 +02:00
Andrew Godwin
ab5cbae9b7
First stab at some migration creation commands
2013-06-19 15:36:22 +01:00
Andrew Godwin
9daf81b94e
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
django/db/models/loading.py
2013-06-19 12:05:23 +01:00
Loic Bistuer
ee77d4b253
Fixed #20199 -- Allow ModelForm fields to override error_messages from model fields
2013-06-18 08:01:17 -04:00
Loic Bistuer
f34cfec0fa
Refactored ValidationError to allow persisting error params and error codes as the exception bubbles up
2013-06-18 08:01:17 -04:00
Florian Apolloner
ffa8a9ab24
Fixed python 3.2 compat.
2013-06-14 15:44:45 +02:00
Wilfred Hughes
8365ed08b8
Fixed #17076 -- When reversing a URL fails, inform the user which patterns were tried.
2013-06-14 10:26:30 +01:00
Daniel Lindsley
91f317c76d
Added a ``checksetup`` management command for verifying Django compatibility.
2013-06-13 18:39:02 -07:00
Aymeric Augustin
55cbd65985
Fixed #20579 -- Improved TransactionTestCase.available_apps.
...
Also moved its documentation to the 'advanced' section. It doesn't
belong to the 'overview'. Same for TransactionTestCase.reset_sequences.
When available_apps is set, after a TransactionTestCase, the database
is now totally empty. post_syncdb is fired at the beginning of the next
TransactionTestCase.
Refs #20483 .
2013-06-12 20:01:41 +02:00
Aymeric Augustin
13b7f299de
Added a stealth option to flush to allow cascades.
...
This allows using flush on a subset of the tables without having to
manually cascade to all tables with foreign keys to the tables being
truncated, when they're known to be empty.
On databases where truncate is implemented with DELETE FROM, this
doesn't make a difference. The cascade is allowed, not mandatory.
2013-06-10 11:21:54 +02:00
Tim Graham
96c71d423d
Added runserver validation to detect if DEBUG=False and ALLOWED_HOSTS is empty.
...
Refs #19875 .
2013-06-09 15:08:29 -04:00
Chris Streeter
69373f3420
Fixed #19925 - Added validation for REQUIRED_FIELDS being a list
...
Thanks Roman Alexander for the suggestion.
2013-06-07 19:58:41 -04:00
Andrew Godwin
315ab41e41
Initial stab at a migrate command, it's probably quite a way off.
2013-06-07 18:47:17 +01:00
Andrew Godwin
3c296382b8
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
django/db/models/fields/related.py
2013-06-07 11:15:34 +01:00
Florian Apolloner
c9d07d251f
Fixed loaddata for Django checkouts with non ASCII chars in the name.
2013-06-03 13:18:16 +02:00
Aymeric Augustin
6900cb79dc
Fixed small regression from 51aa000378
.
...
A test failed if the path to the Django checkout contained a dot.
Refs #20485 .
2013-06-03 11:48:03 +02:00
Aymeric Augustin
51aa000378
Fixed #20485 -- Refactored loaddata for speed.
...
Thanks Anssi for reporting this performance bottleneck.
2013-06-02 20:39:45 +02:00
Anssi Kääriäinen
369b6fab25
Fixed #18169 -- NoReverseMatch not silenced if from block.super
2013-06-01 00:59:04 +03:00
René Fleschenberg
5090c7b58b
Improved the usage message of the test command.
2013-05-31 13:16:54 -04:00
Tim Graham
59235816bd
Fixed #20509 - Proper parsing for dumpdata --pks option.
...
Thanks weipin for the report and Baptiste Mispelon for the patch.
2013-05-30 10:19:13 -04:00
Claude Paroz
8010289ea2
Fixed #15697 -- Made sqlindexes aware of auto-created tables
...
Thanks mbertheau for the report and Ash Christopher for the
initial patch.
2013-05-29 15:50:26 +02:00
Tim Graham
ded95ccdce
Fixed #20484 -- Added model validation for GenericIPAddressField
...
GenericIPAddressField must not allow blank for NOT NULL fields
Thanks Erik Romijn.
2013-05-28 15:12:47 -04:00
Ramiro Morales
0fa8d43e74
Replaced `and...or...` constructs with PEP 308 conditional expressions.
2013-05-26 23:47:50 -03:00
Preston Holmes
d228c1192e
Fixed #19866 -- Added security logger and return 400 for SuspiciousOperation.
...
SuspiciousOperations have been differentiated into subclasses, and
are now logged to a 'django.security.*' logger. SuspiciousOperations
that reach django.core.handlers.base.BaseHandler will now return a 400
instead of a 500.
Thanks to tiwoc for the report, and Carl Meyer and Donald Stufft
for review.
2013-05-25 16:27:34 -07:00
Andrew Jesaitis
31f6421b13
Fixed #19938 -- Consumed iterator only once in paginator's Page
...
Thanks Joshua Fialkoff for the report.
2013-05-25 16:27:26 +02:00
Donald Stufft
3de1288042
Fixed #11398 - Added a pre_syncdb signal
2013-05-23 01:09:22 -04:00
Claude Paroz
51998dffe7
Removed check for 0.15 version of gettext tools
...
gettext 0.15 has been released in July 2006.
2013-05-22 18:21:33 +02:00
Jorge Bastida
888c86dcf3
Fixed #20445 -- Raised original exception after command error
2013-05-20 18:59:37 +02:00
Marc Tamlyn
6d81d5d82e
Merge pull request #1181 from aaugustin/better-api-to-disable-atomic-requests
...
Changed API to disable ATOMIC_REQUESTS per view.
2013-05-20 00:26:06 -07:00
Aymeric Augustin
6633eeb886
Changed API to disable ATOMIC_REQUESTS per view.
...
A decorator is easier to apply to CBVs. Backwards compatibility isn't an
issue here, except for people running on a recent clone of master.
Fixed a few minor problems in the transactions docs while I was there.
2013-05-19 19:53:16 +02:00
Preston Holmes
6786920fd8
Fixed #16330 -- added --pks option in dumpdata command
...
Thanks to guettli for the initial ticket and patch, with additional work
from mehmetakyuz and Kevin Brolly.
2013-05-19 09:10:40 -07:00
Aymeric Augustin
cb86f707a0
Fixed #12747 -- Made reason phrases customizable.
2013-05-19 13:14:54 +02:00
Senko Rasic
c44a2c40fe
Fixed #18990 -- Loaddata now complains if fixture doesn't exist
...
If the fixture doesn't exist, loaddata will output a warning.
The fixture named "initial_data" is exceptional though; if it
doesn't exist, the warning is not emitted. This allows syncdb and
flush management commands to attempt to load it without causing
spurious warnings.
Thanks to Derega, ptone, dirigeant and d1ffuz0r for contributions
to the ticket.
2013-05-19 11:31:27 +02:00
Senko Rasic
cc3b3ba93a
Fixed #18990 : Loaddata now complains if fixture doesn't exist
...
The fixture named "initial_data" is exceptional though; if it
doesn't exist, the error is not raised. This allows syncdb and
flush management commands to attempt to load it without causing
an error if it doesn't exist.
2013-05-19 10:56:09 +02:00
Donald Stufft
398841d6d3
Merge branch 'allow-any-iterable-for-choices'
2013-05-18 11:31:16 -04:00
Donald Stufft
a19e9d80ff
Fixed #20430 - Enable iterable of iterables for model choices
...
Allows for any iterable, not just lists or tuples, to be used as
the inner item for a list of choices in a model.
2013-05-18 11:14:05 -04:00
Łukasz Langa
64e11a68f1
Fixed #13285 : populate_xheaders breaks caching
2013-05-18 17:03:43 +02:00
Jacob Burch
89955cc35f
Fixed #9595 -- Allow non-expiring cache timeouts.
...
Also, streamline the use of 0 and None between cache backends.
2013-05-18 15:39:42 +02:00
Baptiste Mispelon
9012a9e200
Fixed #20422 -- Applied makemessage's --ignore patterns to full path
...
Fix makemessage's --ignore patterns being applied to the full path
instead of the file name. Thanks to nnseva for the report and the
original patch.
2013-05-18 10:40:16 +02:00
Andrew Godwin
b31eea069c
Merge branch 'master' into schema-alteration
2013-05-18 10:21:31 +02:00
Claude Paroz
838f28974e
Fixed #20427 -- Moved a variable initialization in storage.py
...
This is fixing commit 4e70ad11d2
. Thanks mattias at elements.nl
for the report and Baptiste Mispelon for identifying the faulty
commit.
2013-05-17 18:31:52 +02:00
Aymeric Augustin
9c487b5974
Replaced an antiquated pattern.
...
Thanks Lennart Regebro for pointing it out.
2013-05-17 18:08:58 +02:00
Daniel Lindsley
33793f7c3e
Fixed #19934 - Use of Pillow is now preferred over PIL.
...
This starts the deprecation period for PIL (support to end in 1.8).
2013-05-14 19:32:04 -07:00
Tim Graham
2c62a509de
Fixed #20136 - Fixed and expanded the docs for loaddata and model signals.
...
Thanks brandon@ and Anssi for the report.
2013-05-11 19:34:02 -04:00
Andrew Godwin
cb4b0de49e
Merge branch 'master' into schema-alteration
2013-05-10 12:55:30 +01:00
Alex Gaynor
ea3a378c22
Added an HTTP status code to Django's WSGI application that was missing (reason unknown).
2013-05-08 12:45:31 -07:00
Claude Paroz
de8aa3a9a9
Fixed #20256 -- Corrected startproject --template help text
...
Thanks n0nam3 for the patch.
2013-05-08 09:55:40 +02:00
Tai Lee
99a6f0e77c
Fixed #20354 -- `makemessages` no longer crashes with `UnicodeDecodeError`
...
Handle the `UnicodeDecodeError` exception, send a warning to `stdout` with the
file name and location, and continue processing other files.
2013-05-07 21:22:05 +02:00
Aymeric Augustin
1267d2d9bc
Fixed #20330 -- Normalized spelling of "web server".
...
Thanks Baptiste Mispelon for the report.
2013-04-29 19:40:43 +02:00
Aymeric Augustin
4ff682c1ba
Fixed #18336 -- Doubled request_queue_size.
...
This reduces random failures to load static files with Google Chrome.
2013-04-28 10:47:07 +02:00
Andrew Godwin
7f3678dc4c
Merge branch 'master' into schema-alteration
...
Conflicts:
django/db/backends/__init__.py
django/db/backends/mysql/base.py
django/db/backends/oracle/base.py
django/db/backends/oracle/creation.py
django/db/backends/postgresql_psycopg2/base.py
django/db/backends/sqlite3/base.py
django/db/models/fields/related.py
2013-04-18 17:16:39 +01:00
Brendon Crawford
cd1ca26702
Adds generators support for email backends that do not support it.
2013-04-03 19:42:31 -07:00
Julien Phalip
2f81a0ca65
Fixed #20169 -- Ensured that the WSGI request's path is correctly based on the `SCRIPT_NAME` environment parameter or the `FORCE_SCRIPT_NAME` setting, regardless of whether or not those have a trailing slash. Thanks to bmispelon for the review.
2013-04-01 12:04:44 -07:00
Claude Paroz
dcf563071f
Fixed #5014 -- Guessed max_digits and decimal_places for SQLite
...
Decimal is treated as float on SQLite, hence inspectdb can only
guess max_digits and decimal_places arguments.
2013-04-01 18:32:57 +02:00
Christoph Sieghart
465b01f065
Fixed #19998 -- Fixed --ignorenonexistent support for XML based fixtures.
2013-03-30 11:59:50 +01:00
Preston Holmes
e79b857a07
Fixed #18985 -- ensure module level deprecations are displayed
...
Also don't compete with -W CLI option.
Thanks to Aymeric Augustin for the catch, and Claude Paroz for the patch.
2013-03-24 22:06:02 -07:00
Loic Bistuer
521765f63d
Fixed #19541 -- Fixed BaseHandler to enable reversing URLs in response middlewares
...
and streamed responses with respect to per-request urlconf.
2013-03-25 03:19:19 +07:00
Anssi Kääriäinen
97774429ae
Fixed #19385 again, now with real code changes
...
The commit of 266de5f9ae
included only
tests, this time also code changes included...
2013-03-24 18:40:40 +02:00
Aymeric Augustin
f5dbb566ee
Fixed #17550 -- Removed a workaround for a bug in flup 1.0.1.
...
This reverts commit 948a833eb7
.
flup appears to be dead, and this fix breaks legitimate uses of Django.
Refs #8490 .
2013-03-24 10:57:38 +01:00
Matthew Wood
a7960bcb35
Fixed #18972 -- Refactored bundled wsgi server's chunking algorithm.
...
Thanks to amosonn at yahoo.com for the report, @doda for the initial patch and
@datagrok for the revamped logic and test case.
2013-03-20 18:46:26 -04:00
konarkmodi
bc4111ba68
Fixed #18003 -- Preserved tracebacks when re-raising errors.
...
Thanks jrothenbuhler for draft patch, Konark Modi for updates.
2013-03-19 15:42:39 -07:00
Aymeric Augustin
31b5275235
Fixed #13260 -- Quoted arguments interpolated in URLs in reverse.
2013-03-18 23:58:22 +01:00
Aymeric Augustin
20a91cce04
Fixed #17037 -- Added a --all option to diffsettings.
2013-03-18 00:03:58 +01:00
Baptiste Mispelon
d5683bd06b
Fix #20058 : Make compilemessages use stdout instead of stderr.
2013-03-16 19:48:40 +01:00
Claude Paroz
2f121dfe63
Fixed #17051 -- Removed some 'invalid' field error messages
...
When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.
2013-03-14 17:03:43 +01:00
Claude Paroz
34d098665d
Add a specific error message for URLValidator
2013-03-14 15:26:30 +01:00
Baptiste Mispelon
4fa7f3cdd9
Fix #20022 : Correctly handle prefixes with url-unsafe characters in reverse().
2013-03-13 18:19:29 +01:00
Aymeric Augustin
83a416f5e7
Made atomic usable when autocommit is off.
...
Thanks Anssi for haggling until I implemented this.
This change alleviates the need for atomic_if_autocommit. When
autocommit is disabled for a database, atomic will simply create and
release savepoints, and not commit anything. This honors the contract of
not doing any transaction management.
This change also makes the hack to allow using atomic within the legacy
transaction management redundant.
None of the above will work with SQLite, because of a flaw in the design
of the sqlite3 library. This is a known limitation that cannot be lifted
without unacceptable side effects eg. triggering arbitrary commits.
2013-03-13 15:17:40 +01:00