innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity
30,058 Commits 25 Branches 361 Tags 501 MiB
Commit Graph

447 Commits

Author SHA1 Message Date
David Smith 911545da1d Increased test coverage for forms.ImageField.to_python(). 2020-04-09 08:45:31 +02:00
David Smith 5fbc0e07a9 Completed test coverage for forms.DurationField.to_python(). 2020-04-07 06:20:43 +02:00
David Smith be9dd70931
Fixed typo in tests/forms_tests/field_tests/test_imagefield.py test names. 2020-04-07 06:04:51 +02:00
David Smith 27746ab28a Fixed #7664 -- Allowed customizing suffixes of MultiWidget.widgets' names. 2020-03-24 20:05:18 +01:00
David Smith ccf32aca44 Fixed #8760 -- Changed ModelMultipleChoiceField to use invalid_list as a error message key. 2020-03-12 09:36:01 +01:00
David Smith 5cc2c63f90
Fixed typo in tests/forms_tests/widget_tests/test_clearablefileinput.py docstring. 2020-03-11 08:50:51 +01:00
Hasan Ramezani 49275c5488 Fixed #30261 -- Prevented Form._html_output() from mutating errors if hidden fields have errors. 2020-02-13 08:12:44 +01:00
Shubham singh ffcf1a8ebf Fixed #31118 -- Made FileInput to avoid the required attribute when initial data exists. 2020-01-08 09:15:31 +01:00
Claude Paroz 1487f16f2d Fixed #11385 -- Made forms.DateTimeField accept ISO 8601 date inputs. 
Thanks José Padilla for the initial patch, and Carlton Gibson for the
review.
 2020-01-06 10:52:09 +01:00
Claude Paroz 495d7a1ddf Reorganized forms.DateTimeField tests. 2020-01-03 10:36:58 +01:00
Jon Dufresne e703b93a65 Fixed #31080 -- Removed redundant type="text/javascript" attribute from <script> tags. 2019-12-11 09:49:54 +01:00
Peter Andersen 02eff7ef60 Fixed #31073 -- Prevented CheckboxInput.get_context() from mutating attrs. 2019-12-10 12:27:50 +01:00
Carlton Gibson ee4a19053a Fixed #31012 -- Reverted "Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget." 
This reverts commit f038214d91.

The initial issue was incorrect. Django 2.2, and before, did not
generate invalid HTML as reported. With f03821 in place invalid HTML
was generated.

Thanks to Kevin Brown for follow-up report and investigation.
 2019-11-21 20:53:31 +01:00
Nick Pope 7552de7866 Used more specific unittest assertions in tests. 
* assertIsNone()/assertIsNotNone() instead of comparing to None.
* assertLess() for < comparisons.
* assertIs() for 'is' expressions.
* assertIsInstance() for isinstance() expressions.
* rounding of assertAlmostEqual() for round() expressions.
* assertIs(..., True/False) instead of comparing to True/False.
* assertIs()/assertIsNot() for ==/!= comparisons.
* assertNotEqual() for == comparisons.
* assertTrue()/assertFalse() instead of comparing to True/False.
 2019-10-29 12:37:30 +01:00
Hasan Ramezani 6c6d24a4fe Refs #30908 -- Added test for nonexistent path in forms.FilePathField. 2019-10-29 08:39:56 +01:00
Hasan Ramezani a28d1b38e5 Fixed #30839 -- Fixed Field.__deepcopy__() so forms don't share error messages. 2019-10-08 10:07:05 +02:00
Min ho Kim 65e86948b8 Corrected several typos in string literals and test names. 2019-08-07 11:23:14 +02:00
Jon Dufresne d89053585e Improved error message when index in __getitem__() is invalid. 2019-07-23 20:12:08 +02:00
Jon Dufresne 42b9a23267 Fixed #30400 -- Improved typography of user facing strings. 
Thanks Claude Paroz for assistance with translations.
 2019-06-28 16:46:18 +02:00
Shubham Bhagat 26d16c07fd Fixed #30578 - Made SelectDateWidget respect a custom date format when USE_L10N is disabled. 2019-06-26 11:07:11 +02:00
Mariusz Felisiak b08a18f17b
Fixed LiveWidgetTests.test_textarea_trailing_newlines() crash on Chrome 75+. 2019-06-18 11:38:51 +02:00
Hasan Ramezani f038214d91 Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget. 
placeholder is required for "select" with "required" attribute.
 2019-05-08 12:46:30 +02:00
Jon Dufresne 8d76443aba Fixed #30399 -- Changed django.utils.html.escape()/urlize() to use html.escape()/unescape(). 2019-04-25 15:09:07 +02:00
Krisjanis Vaiders 79d3b905df Fixed #30358 -- Removed redundant assertion in FormsUtilsTestCase.test_error_dict_copy(). 2019-04-13 18:42:11 +02:00
Carlton Gibson d64808cacd Used a picklable argument for a subTest. 2019-03-21 13:56:05 -04:00
Hasan Ramezani 5fc5d93512 Fixed #29956 -- Allowed overriding an order field widget in formsets. 2019-03-21 11:51:01 +01:00
Mariusz Felisiak d77657737f
Simplified forms_tests.tests.test_formsets. 2019-03-12 15:46:39 +01:00
Andra Denis Ionescu 4c086d7da4 Fixed #29459 -- Initialized form data/files with empty MultiValueDicts. 2019-03-05 10:41:08 -05:00
Matthias Kestenholz 231b513926 Fixed #30179 -- Fixed form Media merging when pairwise merging is insufficient. 
Thanks gasman for the tests, and codingjoe and timgraham for the review.
 2019-02-27 16:39:17 -05:00
Matthias Kestenholz 959d0c078a Fixed #30153 -- Fixed incorrect form Media asset ordering after three way merge. 
Delaying merging assets as long as possible avoids introducing
incorrect relative orderings that cause a broken final result.
 2019-02-09 09:38:52 -05:00
Tim Graham 0004daa536
Used 4 space hanging indent for dictionaries. 
Thanks Mariusz Felisiak for auditing.
 2019-01-02 18:18:19 -05:00
Tim Graham 043bd70942 Updated test URL patterns to use path() and re_path(). 2018-12-31 10:47:32 -05:00
Basil Dubyk 35a08b8541 Fixed #17210 -- Made NullBooleanSelect use unknown/true/false as query data. 2018-11-14 13:43:34 -05:00
Sergey Fedoseev 8ef8bc0f64 Refs #28909 -- Simplifed code using unpacking generalizations. 2018-09-28 09:57:12 -04:00
Tim Graham 838d6dcb86 Refs #29426 -- Made UUIDField render values with dashes. 2018-08-18 08:20:21 -04:00
Tim Graham 730173d1c5 Fixed #29623 -- Fixed translation failure of DurationField's "overflow" error message. 2018-08-08 06:24:52 -04:00
luz.paz 97e637a87f Fixed typos in comments and docs. 2018-08-01 16:09:22 -04:00
Tim Graham 76852c3989 Refs #29600 -- Added test for datetime_safe usage in SelectDateWidget.value_from_datadict(). 2018-07-26 16:51:40 -04:00
Morgan Aubert 704443acac Fixed #29363 -- Added SimpleTestCase.assertWarnsMessage(). 2018-05-09 11:40:28 -04:00
CHI Cheng 4660ce5a69 Fixed #29375 -- Removed empty action attribute on HTML forms. 2018-05-02 09:20:04 -04:00
safu9 9fd9f8bbb2 Fixed #29284 -- Made ImageField render with accept="image/*"' HTML attribute. 2018-04-04 13:16:03 -04:00
Claude Paroz f3b69f9757 Fixed #29273 -- Prevented initial selection of empty choice in multiple choice widgets. 
Regression in b52c73008a.
 2018-04-02 08:52:53 -04:00
Mariusz Felisiak 362813d628
Fixed hanging indentation in various code. 2018-03-16 10:54:34 +01:00
Tim Graham 87dc0844a6 Fixed #29200 -- Fixed label rendering when using RadioSelect and CheckboxSelectMultiple with MultiWidget. 2018-03-15 09:10:23 -04:00
François Freitag 06172d7bc2 Consolidated ModelChoiceField tests. 2018-03-01 14:05:35 -05:00
Herbert Parentes Fortes Neto d368784bac Fixed #28171 -- Added an exception if Form's empty_permitted and use_required_attribute arguments conflict. 2018-02-15 13:44:26 -05:00
Tim Graham d0a42a14c0 Fixed imports per isort 4.3.1. 
Partially reverted 9bcf73d788.
 2018-02-02 14:44:07 -05:00
Mariusz Felisiak 9bcf73d788 Fixed imports per isort 4.3.0. 2018-02-01 09:29:46 +01:00
Vlastimil Zíma fbc3c29e7c Fixed #29036 -- Fixed HTML5 required validation on SelectDateWidget if the attribute is added by JavaScript. 
Thanks Tim Graham for the initial patch.
 2018-01-30 19:09:31 -05:00
Tim Graham 3a4b11873a
Added tests for SelectDateWidget.value_from_datadict(). 2018-01-30 18:10:33 -05:00
Jon Dufresne ff05de760c Fixed #29038 -- Removed closing slash from HTML void tags. 2018-01-21 02:09:10 -05:00
Jon Dufresne 47d238b696 Fixed #29041 -- Changed SelectMultiple's multiple attribute to HTML5 boolean syntax. 2018-01-20 11:19:06 -05:00
Tim Graham 4bcec02368 Added tests for django.forms.formsets.all_valid(). 2018-01-12 12:40:21 -05:00
Fabio Bonelli c886f3dee3 Fixed #29006 -- Fixed DecimalField.clean() crash on sNaN values. 2018-01-10 20:30:44 -05:00
Tim Graham 1c95737ebe Reduced redundancy in DecimalField tests with subTest(). 2018-01-10 20:30:24 -05:00
Tim Graham ec2ce4517a Fixed #28882 -- Fixed cleaning of disabled MultiValueFields. 
Thanks avalanchy for the initial patch.
 2018-01-05 15:49:54 -05:00
Daniil 7c7bc6391a Fixed #28874 -- Prevented double escaping of errors on hidden form fields. 2017-12-11 07:30:47 -05:00
Nick Pope e014f91a70 Fixed #28890 -- Removed newlines between MultiWidget's subwidgets. 
Regression in b52c73008a.
 2017-12-05 11:22:36 -05:00
Srinivas Reddy Thatiparthy 55b5393bd2 Fixed #28474 -- Made DurationField raise ValidationError for inputs that raised OverflowError. 2017-10-25 18:05:13 -04:00
Josh Schneier e8c4596329 Fixed #28562 -- Fixed DecimalValidator handling of positive exponent scientific notation. 2017-09-27 09:42:04 -04:00
Tim Graham 2bd207ada0 Refs #15667 -- Removed support for Widget.render() methods without the renderer argument. 
Per deprecation timeline.
 2017-09-22 12:51:18 -04:00
Josh Schneier 48c394a6fc Fixed #28555 -- Made CharField convert whitespace-only values to the empty_value when strip is enabled. 2017-09-05 12:41:38 -04:00
caleb logan 9e2bf65d6a Fixed #28530 -- Prevented SelectDateWidget from localizing years in output. 2017-08-29 14:56:08 -04:00
Collin Anderson 751f7a6d9b Added Media.__repr__(). 
It makes it easier to debug MediaOrderConflictWarnings
(refs #28377).
 2017-08-26 20:57:45 -04:00
Alejandro Zamora 90d7b912b9 Fixed #28201 -- Added ProhibitNullCharactersValidator and used it on CharField form field. 2017-08-12 20:14:14 -04:00
Tim Graham d04b324969 Fixed #28421 -- Split some long FormSet tests and made other cosmetic cleanups. 
Thanks Windson for the initial patch.
 2017-08-11 17:43:50 -04:00
Mads Jensen a51c4de194 Used assertRaisesMessage() to test Django's error messages. 2017-07-29 19:07:23 -04:00
Srinivas Reddy Thatiparthy b306c0c1a3 Fixed #28264 -- Made FilePathField sort files and directories when recursive=True. 2017-07-29 09:15:46 -04:00
Windson yang f32d24652b Fixed #28321 -- Prevented FormSet.full_clean() from adding errors from deleted forms. 2017-07-24 18:55:41 -04:00
Johannes Hoppe c19b56f633 Fixed #28377 -- Made combining form Media retain relative asset order. 
Thanks Florian Apolloner, Mariusz Felisiak, and Tim Graham for reviews.
 2017-07-20 11:06:30 -04:00
Roman Selivanov d4da39685b Fixed #28414 -- Fixed ClearableFileInput rendering as a subwidget of MultiWidget. 2017-07-19 14:28:06 -04:00
Srinivas Reddy Thatiparthy 71ff9a74cb Created a dedicated test directory for FilePathField tests. 2017-07-17 16:40:34 -04:00
Srinivas Reddy Thatiparthy 5debbdfcc8 Fixed #28387 -- Fixed has_changed() for disabled form fields that subclass it. 2017-07-14 13:06:51 -04:00
Tim Graham 221e6e1817 Fixed #28176 -- Restored the uncasted option value in ChoiceWidget template context. 2017-06-17 18:17:23 -04:00
Tim Graham 3b050fd0d0 Fixed #28303 -- Prevented localization of attribute values in the DTL attrs.html widget template. 2017-06-17 08:12:05 -04:00
Claude Paroz 43b574007e Fixed #28192 -- Required passing optional form field args as keyword args. 2017-06-03 10:49:01 -04:00
Claude Paroz 54caca2d34 Refs #28192 -- Fixed documentation of ChoiceField choices requirement 
Thanks Tim Graham for noticing the issue.
 2017-06-03 16:17:03 +02:00
Jon Dufresne 29a518006f Fixed #28265 -- Prevented renderer warning on Widget.render() with **kwargs. 2017-06-02 09:46:43 -04:00
Jon Dufresne 2c69824e5a Refs #23968 -- Removed unnecessary lists, generators, and tuple calls. 2017-06-01 19:08:59 -04:00
Manatsawin Hanmongkolchai a0c07d77fc Fixed #28242 -- Moved ImageField file extension validation to the form field. 2017-06-01 10:13:23 -04:00
Tim Graham 84fb50df67 Fixed a forms test after updated translations. 2017-05-31 19:29:34 -04:00
Jon Dufresne 21046e7773 Fixed #28249 -- Removed unnecessary dict.keys() calls. 
iter(dict) is equivalent to iter(dict.keys()).
 2017-05-27 19:08:46 -04:00
Tim Heap 5b6181f4d5 Fixed #27922 -- Added ErrorDict.get_json_data(). 2017-05-27 09:19:42 -04:00
Bruno Alla 6092ea8fa6 Refs #27804 -- Used subTest() in several tests. 2017-05-24 08:36:34 -04:00
Tim Graham d302e2c09c Fixed #28157 -- Fixed choice ordering in form fields with grouped and non-grouped options. 
Regression in b52c73008a.
 2017-05-03 07:21:44 -04:00
Tim Graham f04a404917 Fixed #28130 -- Fixed formset min_num validation with initial, unchanged forms. 
Regression in f5c6295797.
 2017-04-28 09:32:40 -04:00
Tim Graham 851874fe0a Removed obsolete Widget.format_output() in tests. 
Obsolete since b52c73008a.
 2017-04-24 13:41:34 -04:00
Jon Dufresne 581879a510 Fixed #28075 -- Prevented ChoiceWidget from localizing option values. 2017-04-21 12:14:40 -04:00
Tim Graham af1f986360 Fixed #28059 -- Restored class attribute in <ul> of widgets that use multiple_input.html. 
Regression in b52c73008a
 2017-04-20 10:06:34 -04:00
Tim Graham c09bf8d767 Fixed #28058 -- Restored empty BoundFields evaluating to True. 
Regression in b52c73008a
 2017-04-17 08:32:29 -04:00
Raphael Michel bde814142a Fixed #22654 -- Broken decimal validation 2017-04-07 12:45:08 +02:00
Stefan Wehrmeyer 1aa8e8605c Fixed #27989 -- Preserved empty QueryDicts for form's data/files args. 2017-04-01 18:43:39 -04:00
Claude Paroz e487ffd3f0 Fixed #27866 -- Made ChoiceWidget.format_value() return a list 
Thanks Tim Graham for the review.
 2017-04-01 12:24:05 +02:00
heathervm 7d1e237753 Fixed #27993 -- Fixed model form default fallback for SelectMultiple. 2017-03-31 10:10:08 -04:00
Jon Dufresne 7edeeb74fe Fixed #27957 -- Removed technical terms from InlineForeignKeyField/ModelMultipleChoiceField error messages. 2017-03-20 13:12:55 -04:00
Adonys Alea Boffill cd2ad26cc9 Fixed #27724 -- Fixed SelectDateWidget redisplay if a year isn't chosen. 2017-03-18 15:14:52 -04:00
Adonys Alea Boffill fb48ad348a Added tests for SelectDateWidget.format_value(). 2017-03-18 14:58:31 -04:00
Tim Graham 6b4f018b2b Replaced type-specific assertions with assertEqual(). 
Python docs say, "it's usually not necessary to invoke these methods directly."
 2017-03-17 07:51:48 -04:00
Claude Paroz 540ae68a5c Fixed #27920 -- Restored empty RadioSelect choice producing value="" 
Regression in b52c73008a.
Thanks Tim Graham for the review.
 2017-03-14 18:23:06 +01:00
Tim Graham 75f0070a54 Fixed #27308 -- Fixed BytesWarnings in the test suite. 2017-02-17 16:04:45 -05:00