8f6860863e
Fixed #30722 -- Added default rate-limiting requests to admin's Select2 widget.
2019-08-27 13:47:36 +02:00
691def10a0
Fixed #30727 -- Made Subquery pickle without evaluating their QuerySet.
...
Subquery expression objects, when pickled, were evaluating the QuerySet
objects saved in its _constructor_args attribute.
2019-08-27 13:05:20 +02:00
03dbdfd9bb
Fixed #29019 -- Added ManyToManyField support to REQUIRED_FIELDS.
2019-08-26 14:48:40 +02:00
5dac63bb84
Refs #27804 -- Used subTest() in utils_tests/test_encoding.py.
2019-08-26 11:58:06 +02:00
579909a13f
Refs #30591 -- Fixed introspection of check and unique column constraints on MariaDB.
...
Unnamed unique and check columns constraints have the same name as
a column. Ensure uniqueness by using custom names.
Thanks Adnan Umer for the report.
2019-08-26 09:15:37 +02:00
6b402b28b3
Fixed typo in tests/prefetch_related/tests.py comment.
2019-08-26 08:14:29 +02:00
bb9e82f274
Fixed #29955 -- Added support for distance expression to the dwithin lookup.
...
This was missed when adding support to other distance lookups in
refs #25499 .
Thanks Peter Bex for the report and Mariusz for testcases.
2019-08-23 21:28:28 +02:00
92c72b68b7
Fixed broken OracleDbshellTests tests after 9386586f31.
2019-08-23 21:25:21 +02:00
9386586f31
Replaced subprocess commands by run() wherever possible.
2019-08-23 10:53:36 +02:00
7bd9633320
Fixed typos in test names and a comment.
2019-08-23 10:46:43 +02:00
521308e575
Fixed #30715 -- Fixed crash of ArrayField lookups on ArrayAgg annotations over AutoField.
2019-08-23 10:43:08 +02:00
5b4c6b58a0
Fixed #30064 -- Added form to validate admin search fields query input.
2019-08-22 14:09:49 +02:00
85ac838d9e
Fixed #21039 -- Added AddIndexConcurrently/RemoveIndexConcurrently operations for PostgreSQL.
...
Thanks to Simon Charettes for review.
Co-Authored-By: Daniel Tao <daniel.tao@gmail.com>
2019-08-21 13:10:06 +02:00
22394bd3a1
Fixed #29667 -- Prohibited whitespaces in path() URLs.
2019-08-20 11:53:10 +02:00
21e559495b
Fixed #29979 , Refs #17337 -- Extracted AutoField field logic into a mixin and refactored AutoFields.
...
This reduces duplication by allowing AutoField, BigAutoField and
SmallAutoField to inherit from IntegerField, BigIntegerField and
SmallIntegerField respectively. Doing so also allows for enabling the
max_length warning check and minimum/maximum value validation for auto
fields, as well as providing a mixin that can be used for other possible
future auto field types such as a theoretical UUIDAutoField.
2019-08-20 09:22:25 +02:00
b10d322c41
Moved migrations.test_operations.OperationTestBase to migrations.test_base.
...
Co-Authored-By: Daniel Tao <daniel.tao@gmail.com>
2019-08-19 16:06:14 +02:00
85458e94e3
Fixed #29260 -- Skipped an UPDATE when adding a model instance with primary key that has a default.
2019-08-19 13:28:35 +02:00
d1c2e6dd04
Refs #28428 -- Made FileField.upload_to support pathlib.Path.
2019-08-18 20:34:58 +02:00
af69842dbd
Refs #28428 -- Added test for a callable FileField.upload_to that returns pathlib.Path.
2019-08-18 20:34:54 +02:00
0468159763
Refs #30426 -- Changed default SECURE_CONTENT_TYPE_NOSNIFF to True.
2019-08-18 13:17:49 +02:00
8b4a43dda7
Fixed #29545 -- Fixed using filter lookups againts nested subquery expressions.
...
Made sql.Where resolve lhs of its child nodes. This is necessary to
allow filter lookups against nested subquery expressions to properly
resolve their OuterRefs to Cols.
Thanks Oskar Persson for the simplified test case.
2019-08-17 11:24:35 +02:00
6805c0f99f
Fixed #30701 -- Updated patch_vary_headers() to handle an asterisk according to RFC 7231.
2019-08-16 15:25:42 +02:00
8a281aa7fe
Fixed #30687 -- Fixed using of OuterRef() expressions in distance lookups.
2019-08-16 06:50:33 +02:00
8289fc55ff
Refs #30449 -- Made RelatedOnlyFieldListFilter respect ModelAdmin.ordering.
2019-08-15 10:29:10 +02:00
00035672a4
Fixed #30449 -- Fixed RelatedFieldListFilter/RelatedOnlyFieldListFilter to respect model's Meta.ordering.
...
Regression in 6d4e5feb79
2019-08-15 10:29:05 +02:00
1f8382d34d
Fixed #30672 -- Fixed crash of JSONField/HStoreField key transforms on expressions with params.
...
Regression in 4f5b58f5cd
2019-08-14 15:25:35 +02:00
eed2e740f7
Fixed #30461 -- Made GeoIP2 and GEOIP_PATH setting accept pathlib.Path as library path.
...
Thanks Nikita Krokosh for the initial patch.
2019-08-13 19:44:10 +02:00
88c0b907e7
Refs #30461 -- Added django.utils._os.to_path().
2019-08-13 17:17:39 +02:00
c19ad2da4b
Fixed #30704 -- Fixed crash of JSONField nested key and index transforms on expressions with params.
...
Thanks Florian Apolloner for the report and helping with tests.
2019-08-13 08:42:17 +02:00
4f7328ce8a
Corrected multiple typos.
2019-08-12 12:53:36 +02:00
d7673d9eda
Switched to use `HTTP_X_FORWARDED_PROTO` custom header in tests.
...
This is the conventional name: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Proto
2019-08-12 12:51:26 +02:00
f7e9db14bb
Refs #25367 -- Added test for Exists() lookup rhs.
2019-08-12 09:39:26 +02:00
8b3e1b6e9e
Refs #11964 -- Made constraint support check respect required_db_features.
...
This will notably silence the warnings issued when running the test
suite on MySQL.
2019-08-12 06:44:37 +02:00
73ac9e3f04
Fixed #30677 -- Improved error message for urlencode() and Client when None is passed as data.
2019-08-11 20:15:23 +02:00
503f60ff57
Fixed #29008 -- Fixed crash of 404 debug page when URL path converter raises Http404.
2019-08-09 22:48:08 +02:00
8d3519071e
Fixed #30673 -- Relaxed system check for db_table collision when database routers are installed by turning the error into a warning.
2019-08-08 21:14:06 +02:00
65e86948b8
Corrected several typos in string literals and test names.
2019-08-07 11:23:14 +02:00
052388aba4
Fixed #30676 -- Added --pdb option to test runner.
2019-08-07 08:16:31 +02:00
c5075360c5
Fixed #30680 -- Removed obsolete system check for SECURE_BROWSER_XSS_FILTER setting.
2019-08-05 18:44:08 +02:00
0e02e496cd
Added tests for using ArrayField's IndexTransform/SliceTransform on expressions with params.
2019-08-05 14:16:25 +02:00
25f21bd237
Fixed #28393 -- Added helpful error messages for invalid AutoField/FloatField/IntegerField values.
...
Co-authored-by: Diederik van der Boor <vdboor@edoburu.nl>
Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
2019-08-05 08:41:29 +02:00
4edad1ddf6
Fixed #30668 -- Made QuerySet.filter() raise NotSupportedError if any of source expressions is not filterable.
2019-08-02 15:06:00 +02:00
194d1dfc18
Fixed #30661 -- Added models.SmallAutoField.
2019-08-02 11:39:01 +02:00
955b382600
Fixed #30599 -- Prevented ManifestFilesMixin.read_manifest() from silencing errors other than FileNotFoundError.
2019-08-02 08:35:28 +02:00
246689452d
Added test for handling of non-existent manifest in ManifestFilesMixin.read_manifest().
2019-08-02 08:35:25 +02:00
ff111ea5e3
Refs #30664 -- Fixed migrations crash when altering AutoField/BigAutoField with quoted db_column on PostgreSQL.
2019-08-01 12:06:32 +02:00
e4684220af
Fixed #30664 -- Fixed migrations crash when altering table on SQLite or altering AutoField/BigAutoField on PostgreSQL for models with quoted db_table.
2019-08-01 12:06:32 +02:00
76ed1c49f8
Fixed CVE-2019-14235 -- Fixed potential memory exhaustion in django.utils.encoding.uri_to_iri().
...
Thanks to Guido Vranken for initial report.
2019-08-01 09:24:54 +02:00
7deeabc7c7
Fixed CVE-2019-14234 -- Protected JSONField/HStoreField key and index lookups against SQL injection.
...
Thanks to Sage M. Abdullah for the report and initial patch.
Thanks Florian Apolloner for reviews.
2019-08-01 09:24:54 +02:00
4b78420d25
Fixed CVE-2019-14233 -- Prevented excessive HTMLParser recursion in strip_tags() when handling incomplete HTML entities.
...
Thanks to Guido Vranken for initial report.
2019-08-01 09:24:54 +02:00
7f65974f82
Fixed CVE-2019-14232 -- Adjusted regex to avoid backtracking issues when truncating HTML.
...
Thanks to Guido Vranken for initial report.
2019-08-01 09:24:54 +02:00
5f24e7158e
Fixed #30665 -- Added support for distinct argument to Avg() and Sum().
2019-07-31 11:22:50 +02:00
cb3c2da128
Moved test for distinct Count() to a separate test case.
2019-07-31 10:41:17 +02:00
f618e033ac
Fixed #30160 -- Added support for LZMA and XZ templates to startapp/startproject management commands.
2019-07-31 10:02:13 +02:00
c95d063e77
Refs #30160 -- Simplified and improved tests for django.utils.archive.
...
The file executable should have 0o775 permission not only u=x.
The file no_permissions should have 0o644 u=r.
2019-07-31 09:46:24 +02:00
e3fc9af4ab
Refs #30593 -- Fixed introspection of check constraints columns on MariaDB.
2019-07-30 16:32:13 +02:00
b2aad9ad4d
Refs #30593 -- Added _parse_constraint_columns() hook to introspection on MariaDB.
2019-07-30 16:32:13 +02:00
421c4cd2ee
Removed redundant ArchiveTest.test_extract_method() test.
...
The extract() function has the same code as used in the test method
for Archive.extract().
2019-07-30 11:33:53 +02:00
0509148c24
Refs #30160 -- Made destination path a required argument of extract().
2019-07-30 11:27:56 +02:00
c7bef16a74
Fixed #30411 -- Improved formatting of text tracebacks in technical 500 templates.
...
Co-Authored-By: Daniel Hahler <git@thequod.de>
2019-07-29 11:09:54 +02:00
3c6d32e0b2
Fixed #30552 -- Fixed loss of SRID when calling reverse() on LineString/Point.
...
Thanks Mariusz Felisiak for contributing the Point part.
2019-07-27 20:12:46 +02:00
4122d9d3f1
Refs #28147 -- Fixed setting of OneToOne and Foreign Key fields to None when using attnames.
...
Regression in 519016e5f2
2019-07-27 12:04:56 +02:00
619c9a4f49
Added tests for using attnames to assign OneToOne and Foreign Key fields.
2019-07-27 12:03:45 +02:00
4b4e68a7a6
Fixed #30567 -- Made WSGIHandler pass FileResponse.block_size to wsgi.file_wrapper.
2019-07-26 07:31:51 +02:00
1853383969
Fixed #27995 -- Added error messages on unsupported operations following union(), intersection(), and difference().
2019-07-25 12:39:55 +02:00
5ed20b3aa3
Fixed #30657 -- Allowed customizing Field's descriptors with a descriptor_class attribute.
...
Allows model fields to override the descriptor class used on the model
instance attribute.
2019-07-25 08:15:20 +02:00
fc75694257
Fixed #30647 -- Fixed crash of autoreloader when extra directory cannot be resolved.
2019-07-24 14:08:37 +02:00
fed5e19369
Removed unused BaseReloader.watch_file().
...
Unused since its introduction in c8720e7696
2019-07-24 13:32:02 +02:00
d89053585e
Improved error message when index in __getitem__() is invalid.
2019-07-23 20:12:08 +02:00
2ff517ccb6
Fixed #30506 -- Fixed crash of autoreloader when path contains null characters.
2019-07-23 10:03:23 +02:00
9f11939dd1
Fixed typos in comments and a test name.
2019-07-19 18:24:06 +02:00
1fc2c70f76
Fixed #30593 -- Added support for check constraints on MariaDB 10.2+.
2019-07-19 11:05:06 +02:00
a3417282ac
Fixed #29824 -- Added support for database exclusion constraints on PostgreSQL.
...
Thanks to Nick Pope and Mariusz Felisiak for review.
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-07-16 18:04:41 +02:00
cf79f92abe
Simplified tests for PostgreSQL constraints.
2019-07-16 16:56:44 +02:00
e47b8293a7
Fixed #30636 -- Fixed options ordering when cloning test database on MySQL.
...
--defaults-file must be given before other options.
2019-07-16 07:25:43 +02:00
402e6d292f
Fixed #30602 -- Made Extract raise ValueError when using unsupported lookups for DurationField.
2019-07-12 08:08:35 +02:00
7a42cfcfdc
Refs #30557 -- Fixed crash of ordering by ptr fields when Meta.ordering contains F() expressions.
...
Thanks Can Sarıgöl for the report.
Follow up to 8c5f9906c5
2019-07-11 13:40:36 +02:00
8c5f9906c5
Fixed #30557 -- Fixed crash of ordering by ptr fields when Meta.ordering contains expressions.
2019-07-11 11:24:59 +02:00
52545e788d
Fixed #28289 -- Fixed crash of RawSQL annotations on inherited model fields.
2019-07-11 08:27:15 +02:00
a9c6ab0356
Fixed #30619 -- Made runserver --nothreading use single threaded WSGIServer.
...
Browsers often use multiple connections with Connection: keep-alive.
If --nothreading is specified, the WSGI server cannot accept new
connections until the old connection is closed, causing hangs.
Force Connection: close when --nothreading option is used.
2019-07-10 13:22:17 +02:00
00d4e6f8b5
Updated Select2 to version 4.0.7.
2019-07-10 12:31:16 +02:00
ed668796f6
Fixed #30543 -- Fixed checks of ModelAdmin.list_display for fields accessible only via instance.
...
Co-Authored-By: Andrew Simons <andrewsimons@bubblegroup.com>
2019-07-10 10:37:34 +02:00
7991111af1
Fixed #30621 -- Fixed crash of __contains lookup for Date/DateTimeRangeField when the right hand side is the same type.
...
Thanks Tilman Koschnick for the report and initial patch.
Thanks Carlton Gibson the review.
Regression in 6b048b364c
2019-07-10 10:33:36 +02:00
ee6e93ec87
Fixed #30628 -- Adjusted expression identity to differentiate bound fields.
...
Expressions referring to different bound fields should not be
considered equal.
Thanks Julien Enselme for the detailed report.
Regression in bc7e288ca9
2019-07-10 07:46:08 +02:00
febe136d4c
Fixed #30397 -- Added app_label/class interpolation for names of indexes and constraints.
2019-07-08 14:57:56 +02:00
8233144ca0
Changed django.db.models.indexes.Index imports to django.db.models.Index.
2019-07-08 14:19:46 +02:00
bc91f27a86
Refs #29444 -- Added support for fetching a returned non-integer insert values on Oracle.
...
This is currently not actively used, since the ORM will ask the
SQL compiler to only return auto fields.
2019-07-08 08:53:08 +02:00
53209f7830
Fixed #30613 -- Moved index name validation to system checks.
2019-07-05 09:30:21 +02:00
c238e65e29
Fixed #30596 -- Fixed SplitArrayField.has_changed() for non-string base fields.
...
Thanks to Evgeniy Krysanov for the report and the idea to use to_python.
Thanks to Mariusz Felisiak for the test case.
2019-07-03 13:35:51 +02:00
54dcfbc367
Fixed #29744 -- Fixed caching of URLResolver for a default URLconf.
...
get_resolver() for a default URLconf (passing no argument) and for
settings.ROOT_URLCONF should return the same cached object.
2019-07-03 11:37:28 +02:00
55b68de643
Fixed #30608 -- Fixed non-unicode EmailMessage crash when domain name for localhost is non-ASCII.
...
Assisted by felixxm.
2019-07-03 10:49:03 +02:00
a5308514fb
Fixed #27801 -- Made createsuperuser fall back to environment variables for password and required fields.
2019-07-02 12:55:09 +02:00
fbb83fefd4
Fixed typos in comments and docs.
2019-07-02 09:36:17 +02:00
090ca6512f
Fixed #30604 -- Made mail_admins()/mail_managers() raise ValueError if ADMINS/MANAGERS is set incorrectly.
2019-07-02 07:34:07 +02:00
5d03f2bc01
Fixed #30595 -- Added error message when no objects found to sql* management commands.
2019-07-01 13:47:54 +02:00
54d0f5e62f
Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_SSL_HEADER if set.
...
An HTTP request would not be redirected to HTTPS when the
SECURE_PROXY_SSL_HEADER and SECURE_SSL_REDIRECT settings were used if
the proxy connected to Django via HTTPS.
HttpRequest.scheme will now always trust the SECURE_PROXY_SSL_HEADER if
set, rather than falling back to the request scheme when the
SECURE_PROXY_SSL_HEADER did not have the secure value.
Thanks to Gavin Wahl for the report and initial patch suggestion, and
Shai Berger for review.
2019-07-01 07:48:04 +02:00
8fc8c958a5
Fixed broken selenium tests after 42b9a23267.
2019-06-30 20:35:05 +02:00
42b9a23267
Fixed #30400 -- Improved typography of user facing strings.
...
Thanks Claude Paroz for assistance with translations.
2019-06-28 16:46:18 +02:00
2b03e8e9e8
Fixed #30584 -- Fixed management command when using subparsers with dest parameter.
2019-06-28 12:51:26 +02:00
f03b7bd114
Fixed #28408 -- Added error message when updating with annotated expressions on joined fields.
...
Co-Authored-By: Simon Charette <charette.s@gmail.com>
2019-06-28 07:55:32 +02:00
fb54aca540
Added test for serializing child model without inherited fields.
2019-06-27 15:10:22 +02:00
895b15771e
Fixed #28725 -- Prevented serializing inherited ManyToManyFields in child model.
2019-06-27 15:10:22 +02:00
4305fbe8b1
Fixed GeoIPTest.test04_city() failure with the latest GeoIP2 database.
2019-06-27 15:09:28 +02:00
26d16c07fd
Fixed #30578 - Made SelectDateWidget respect a custom date format when USE_L10N is disabled.
2019-06-26 11:07:11 +02:00
a289e79679
Fixed #30594 -- Added 'private' Cache-Control directive to never_cache() decorator.
2019-06-26 09:25:24 +02:00
8454f6dea4
Fixed #30588 -- Fixed crash of autoreloader when __main__ module doesn't have __file__ attribute.
2019-06-26 06:44:10 +02:00
698df6a009
Fixed typos in test comments.
2019-06-25 11:12:45 +02:00
325d5d6445
Fixed #30477 -- Made reverse lookup use Field.get_db_prep_value() from the target field.
2019-06-25 10:20:33 +02:00
76b993a117
Fixed #26431 -- Prevented django.urls.resolve() from returning missing optional parameters.
...
Previous behavior was inconsistent with django.urls.reverse() and
caused that translate_url() created an incorrect URL when an optional
parameter was missing.
2019-06-24 11:47:56 +02:00
d640c71fa3
Refs #26431 -- Added tests for resolving URL and translate_url() with provided optional parameter.
2019-06-24 11:30:26 +02:00
b24e763846
Added tests for terminated path with optional arguments in django.urls.reverse().
2019-06-24 11:30:26 +02:00
19895e897c
Refs #30451 -- Added asgiref to the tests requirements.
2019-06-24 08:10:23 +02:00
87b1ad6e73
Fixed #30421 -- Allowed symmetrical intermediate table for self-referential ManyToManyField.
2019-06-21 15:03:17 +02:00
a9179ab032
Fixed typo in BasicExpressionsTests.test_object_update_fk() test.
2019-06-21 12:00:42 +02:00
7f19e37135
Refs #30451 -- Added more tests for ASGIRequest and ASGIHandler.
2019-06-20 12:29:58 +02:00
a415ce70be
Fixed #30451 -- Added ASGI handler and coroutine-safety.
...
This adds an ASGI handler, asgi.py file for the default project layout,
a few async utilities and adds async-safety to many parts of Django.
2019-06-20 12:29:43 +02:00
cce47ff65a
Fixed #30565 -- Closed HttpResponse when wsgi.file_wrapper closes file-like object.
2019-06-20 11:48:49 +02:00
b903bb438f
Refs #30485 -- Removed non-representative test that emitted a warning.
...
Previously, when running the Django test suite with warnings enabled,
the following was emitted:
/usr/lib64/python3.7/urllib/parse.py:915: BytesWarning: str() on a bytearray instance
v = quote_via(str(v), safe, encoding, errors)
This occurred due to the bytearray() being passed to
urllib.parse.urlencode() which eventually calls str() on it. The test
does not represent desired real world behavior. Rather than test for and
assert strange unspecified behavior that emits a warning, remove it.
This was also discussed in PR #11374 .
2019-06-19 13:03:52 +02:00
2cbd3967e0
Fixed #29834 -- Fixed column mismatch crash with QuerySet.values()/values_list() and order_by() on combined querysets.
2019-06-19 12:11:28 +02:00
14d026cccb
Fixed #30572 -- Prevented values()/values_list() on combined queryset from mutating the list of columns in querysets.
2019-06-19 10:44:53 +02:00
b08a18f17b
Fixed LiveWidgetTests.test_textarea_trailing_newlines() crash on Chrome 75+.
2019-06-18 11:38:51 +02:00
6e8303d49b
Fixed typos in FakePayload docstring and SimplifiedURLTests test name.
2019-06-17 12:38:04 +02:00
87f5d07eed
Fixed #12952 -- Adjusted admin log change messages to use form labels instead of field names.
2019-06-14 18:20:29 +02:00
1564e42ad3
Refs #30512 , #15042 -- Added local-only address to sanitize_email() tests cases.
...
email.headerregistry.parser.get_mailbox() returns a token with a `token_type` attribute.
If `token_type` is `’invalid-mailbox’` then RFC violations have been detected. Emails with only the local part, and no domain, are correctly parsed but are marked as `’invalid-mailbox’`.
As per #15042 , local-only are supported, to enable sending to addresses on localhost.
sanitize_email() does not currently check `token_type`. This test is added to avoid a regression in case this is revisited in the future.
2019-06-13 17:29:58 +02:00
2628ea9515
Fixed #30512 -- Used email.headerregistry.parser for parsing emails in sanitize_address().
2019-06-13 16:22:15 +02:00
fde9b7d35e
Fixed #30128 -- Fixed handling timedelta timezone in database functions.
2019-06-13 09:29:43 +02:00
3dca8738cb
Simplified GISFunctionsTests.test_point_on_surface().
2019-06-12 12:59:02 +02:00
b616f65855
Added missing support for PointOnSurface function on MariaDB.
2019-06-12 10:51:43 +02:00
198a0adef2
Removed obsolete comment from GISFunctionsTests.test_asgeojson().
2019-06-12 09:43:03 +02:00
2e00119e39
Fixed GISFunctionsTests.test_asgeojson() crash on MariaDB 10.2+.
2019-06-12 09:43:03 +02:00
9e38ed0536
Fixed #27486 -- Fixed Python 3.7 DeprecationWarning in intword and filesizeformat filters.
...
intword and filesizeformat passed floats to ngettext() which is
deprecated in Python 3.7. The rationale for this warning is documented
in BPO-28692: https://bugs.python.org/issue28692 .
For filesizeformat, the filesize value is expected to be an int -- it
fills %d string formatting placeholders. It was likely coerced to a
float to ensure floating point division on Python 2. Python 3 always
does floating point division, so coerce to an int instead of a float to
fix the warning.
For intword, the number may contain a decimal component. In English, a
decimal component makes the noun plural. A helper function,
round_away_from_one(), was added to convert the float to an integer that
is appropriate for ngettext().
2019-06-11 20:34:59 +02:00
53ea535f13
Refs #27486 -- Added tests for filesizeformat filter.
2019-06-11 20:18:36 +02:00
34f8eeea4a
Fixed #30548 -- Improved exception when expression contains mixed types.
2019-06-10 19:48:53 +02:00
3ee0834a46
Fixed #30556 -- Avoided useless query and hasher call in ModelBackend.authenticate() when credentials aren't provided.
...
There's no need to fetch a user instance from the database unless
a username and a password are provided as credentials.
2019-06-10 11:12:31 +02:00
e065b29387
Refs #27804 -- Used subTest() in filesizeformat tests and HumanizeTests.
2019-06-10 08:46:11 +02:00
dcb8f00d06
Fixed #29379 -- Added autocomplete attribute to contrib.auth.forms fields.
...
Thank you to Nick Pope for review.
Co-authored-by: CHI Cheng <cloudream@gmail.com>
2019-06-07 12:44:39 +02:00
c498f088c5
Fixed #30521 -- Fixed invalid HTML in default error pages.
2019-06-07 07:51:45 +02:00
3fb0a1a67f
Refs #30521 -- Added tests for content of default error pages.
2019-06-07 07:49:17 +02:00
d6ea4898c4
Fixed #30550 -- Fixed decoding of non-UTF-8 bytes objects in response.json().
2019-06-07 06:40:15 +02:00
498092377b
Refs #27804 -- Used subTest() in BinaryFieldTests.test_set_and_retrieve.
2019-06-07 06:04:56 +02:00
8ba20d9071
Refs #30512 -- Added tests for sanitizing email addresses with display name and two @ signs.
2019-06-06 15:05:56 +02:00
f841a776fe
Refs #30512 -- Used subTest() in MailTests.test_sanitize_address.
2019-06-06 14:50:40 +02:00
661e6cc2c9
Fixed #29706 -- Made RenameContentType._rename() save to the correct database.
2019-06-06 12:09:01 +02:00
581a0f4545
Refs #30226 -- Added User.get_user_permissions() method.
...
Added to mirror the existing User.get_group_permissions().
2019-06-05 13:56:37 +02:00
75337a6050
Fixed #30226 -- Added BaseBackend for authentication.
2019-06-05 13:39:46 +02:00
4b6dfe1622
Fixed #30542 -- Fixed crash of numerical aggregations with filter.
...
Filters in annotations crashed when used with numerical-type
aggregations (i.e. Avg, StdDev, and Variance). This was caused as the
source expressions no not necessarily have an output_field (such as the
filter field), which lead to an AttributeError: 'WhereNode' object has
no attribute output_field.
Thanks to Chuan-Zheng Lee for the report.
Regression in c690afb873
2019-06-05 08:06:26 +02:00
b916c27f9a
Fixed typo in tests/generic_views/test_base.py.
2019-06-04 20:09:07 -04:00
f9561144d7
Fixed #30520 -- Fixed crash of admin model inlines on custom fields without labels.
2019-06-04 10:27:12 +02:00
aa94f7c899
Fixed #30534 -- Fixed overriding a field's default in ModelForm.cleaned_data().
2019-06-04 08:28:49 +02:00
b27c9c953b
Fixed #28604 -- Prevented ManifestStaticFilesStorage from leaving intermediate files.
2019-06-03 13:11:55 +02:00
deeba6d920
Fixed CVE-2019-12308 -- Made AdminURLFieldWidget validate URL before rendering clickable link.
2019-06-03 11:36:12 +02:00
dffa3e1992
Fixed #30493 -- Fixed prefetch_related() for GenericRelation with different content types.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Thanks Simon Charette for the review.
2019-05-31 18:11:55 +02:00
ea6e684f34
Simplified m2m_recursive.tests.
2019-05-31 16:19:11 +02:00
f6075fb333
Fixed #26192 -- Fixed crash of ordering by constants on PostgreSQL.
...
Thanks Simon Charette for the review.
2019-05-31 07:38:48 +02:00
cc80979f01
Refs #26192 -- Added tests for ordering by constant value.
2019-05-31 07:38:48 +02:00
e2de49ec2e
Fixed #28520 -- Added --start-at/--start-after options to runtests.py.
2019-05-31 07:01:12 +02:00
ef7e0ae53b
Refs #28520 -- Added _module_match_label() hook to runtests.py.
2019-05-30 09:29:09 +02:00
480492fe70
Fixed #30523 -- Fixed updating file modification times on seen files in auto-reloader when using StatReloader.
...
Previously we updated the file mtimes if the file has not been seen
before - i.e on the first iteration of the loop.
If the mtime has been changed we triggered the notify_file_changed()
method which in all cases except the translations will result in the
process being terminated. To be strictly correct we need to update the
mtime for either branch of the conditional.
Regression in 6754bffa2b
2019-05-29 09:41:24 +02:00
0344565179
Fixed #30516 -- Fixed crash of autoreloader when re-raising exceptions with custom signature.
...
Regression in c8720e7696
2019-05-29 08:08:50 +02:00
a3f91891d2
Fixed #30315 -- Fixed crash of ArrayAgg and StringAgg with ordering when used in Subquery.
2019-05-28 10:05:50 +02:00
b2790f74d4
Fixed #30479 -- Fixed detecting changes in manage.py by autoreloader when using StatReloader.
...
Regression in c8720e7696
2019-05-28 08:31:33 +02:00
5ec44973dc
Fixed typo in RasterField test name.
2019-05-27 13:40:03 +02:00
aff61790a3
Refs #24944 -- Added test for overriding domain in email context in PasswordResetView.
2019-05-27 11:50:30 +02:00
0670b1b403
Fixed #30485 -- Adjusted django.utils.http.urlencode for doseq=False case.
2019-05-24 17:15:34 +02:00
85195dd237
Refs #9982 -- Added test for saving OneToOneField field after saving related object.
...
Fixed in 519016e5f2
2019-05-24 10:54:05 +02:00
45edd746cc
Used re.Pattern.findall() instead of re.findall() in inspectdb.tests.
2019-05-24 09:04:27 +02:00
58df8aa40f
Fixed #28780 -- Allowed specyfing a token parameter displayed in password reset URLs.
...
Co-authored-by: Tim Givois <tim.givois.mendez@gmail.com>
2019-05-24 08:40:25 +02:00
753b67c58d
Fixed #30497 -- Ignored document type in assertXMLEqual()/assertXMLNotEqual().
2019-05-24 07:29:42 +02:00
f8b8b00f01
Fixed #30501 -- Preventing QuerySet.reverse() from mutating expressions in QuerySet.order_by and Meta.ordering.
2019-05-23 20:33:37 +02:00
a2c31e12da
Fixed #30498 -- Fixed proxy class caching in lazy().
...
lazy() should prepare the proxy class only once (the first time it's
used) not on every call.
Regression in b4e76f30d1
2019-05-22 20:41:52 +02:00
1378d665a1
Fixed #28816 -- Prevented silencing data loss when decreasing CharField.max_length on PostgreSQL.
2019-05-21 14:15:43 +02:00
519016e5f2
Fixed #28147 -- Fixed loss of assigned parent when saving child after parent.
...
Thanks Erwin Junge for the initial patch.
2019-05-21 10:11:22 +02:00
266e7e0ecc
Refs #28147 -- Added test for saving nullable ForeignKey with to_field attribute after saving parent.
2019-05-21 10:08:09 +02:00
9d6f981a66
Fixed #28763 -- Allowed overriding the session cookie age with SessionStore.get_session_cookie_age().
2019-05-21 08:50:09 +02:00
514104cf23
Refs #29396 , #30494 -- Reduced code duplication in year lookups.
2019-05-21 07:25:09 +02:00
2b582a7b84
Fixed #29396 -- Added indirect values support to __year lookups.
...
Thanks Windson Yang for the initial patch.
2019-05-21 07:12:33 +02:00
4d1420947e
Fixed #30494 -- Disabled __year lookup optimization for indirect values.
...
The previous heuristics were naively enabling the BETWEEN optimization on
successful cast of the first rhs SQL params to an integer while it was
not appropriate for a lot of database resolved expressions.
Thanks Alexey Chernov for the report.
2019-05-21 07:11:26 +02:00
c38e7a79f4
Fixed #30488 -- Removed redundant Coalesce call in SQL generated by SearchVector.
...
Regression in 405c836336
2019-05-20 08:34:06 +02:00
04042b2b44
Fixed #30463 -- Fixed crash of deprecation message when Meta.ordering contains expressions.
...
Regression in 1b1f64ee5a
2019-05-18 19:29:00 +02:00
de4832c49b
Fixed #30196 -- Made FileResponse set Content-Disposition inline if filename is available.
2019-05-17 12:07:27 +02:00
5c19274643
Fixed #30453 -- Fixed crash of simple_tag() and inclusion_tag() when function is wrapped.
...
getfullargspec() doesn't work with wrapped functions.
2019-05-17 09:53:24 +02:00
8d010f3986
Fixed #30220 -- Added support for headless mode in selenium tests.
2019-05-17 08:14:54 +02:00
e286987a27
Fixed #30459 -- Delegated hide/show JS toggle to parent div.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2019-05-17 07:46:45 +02:00
59ffafa1d2
Fixed #30482 -- Prevented unnecessary evaluation of lookup.queryset in prefetch_related_objects().
2019-05-16 21:39:55 +02:00
8076ae68c1
Fixed #30483 -- Switched test requirement to psycopg2 package.
2019-05-16 15:42:32 +02:00
bd228cb599
Fixed mis-capitalisation in comment.
2019-05-15 12:14:59 +02:00
d329484534
Ensured that our django checkout is in the pythonpath during tests.
...
This fixes an issue with postgres_tests.test_integration.PostgresIntegrationTests
which would not find Django in a CI run.
2019-05-14 19:43:56 +02:00
c231a75112
Fixed #30436 -- Added check that on_delete is callable in ForeignKey and OneToOneField.
2019-05-13 07:25:42 +02:00
330638b89f
Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows.
...
Co-authored-by: Tim Graham <timograham@gmail.com>
Co-authored-by: Patryk Zawadzki <patrys@room-303.com>
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-05-12 07:05:24 +02:00
7c3732a1b4
Fixed #30470 -- Added assertHTMLEqual() support for all self closing tags.
...
Support for the following tags was added: area, embed, param, track, and
wbr.
The full list of self closing tags is documented at:
https://html.spec.whatwg.org/#void-elements
2019-05-10 12:04:07 +02:00
b7a33ee4f0
Fixed #30468 -- Fixed assertHTMLEqual() to handle all ASCII whitespace in a class attribute.
2019-05-09 17:18:18 +02:00
de6d3afb97
Refs #27804 -- Used subTest() in HTMLEqualTests.test_self_closing_tags.
2019-05-09 17:17:42 +02:00
e2feea5fc4
Fixed comment typo.
2019-05-09 17:04:50 +02:00
a3a4f5c144
Fixed #30310 -- Added support for looking up HttpHeaders.headers using underscores.
2019-05-09 16:26:52 +02:00
48235ba807
Refs #30399 -- Made assertHTMLEqual normalize character and entity references.
2019-05-09 15:55:32 +02:00
f038214d91
Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget.
...
placeholder is required for "select" with "required" attribute.
2019-05-08 12:46:30 +02:00
ef9f2eb69c
Refs #30462 -- Added test for conditional aggregation on annotated subquery.
2019-05-08 11:29:17 +02:00
b915b9f10f
Refs #27753 -- Deprecated django.utils.text.unescape_entities().
...
The function was undocumented and only required for compatibility with
Python 2.
Code should use Python's html.unescape() that was added in Python 3.4.
2019-05-08 08:00:59 +02:00
6b736dd074
Fixed #30349 -- Fixed QuerySet.exclude() on FilteredRelation.
...
Using annotated FilteredRelations raised a FieldError when coupled with
exclude(). This is due to not passing filtered relation fields to the
subquery created in split_exclude(). We fixed this issue by passing the
filtered relation data to the newly created subquery.
Secondly, in the case where an INNER JOIN is used in the excluded
subquery, the ORM would trim the filtered relation INNER JOIN in attempt
to simplify the query. This will also remove the ON clause filters
generated by the FilteredRelation. We added logic to not trim the INNER
JOIN if it is from FilteredRelation.
2019-05-07 14:47:50 +02:00
705ef6cfeb
Fixed #30447 -- Added 'is_in_european_union' in GeoIP2.city() dict.
2019-05-07 13:31:44 +02:00
0e2ed4fdd1
Refs #26678 -- Added tests for using the field the relation points to with RelatedManager.add()/remove()/set().
2019-05-07 09:02:06 +02:00
3166880301
Fixed #29352 -- Allowed specifying a Feed language.
2019-05-06 15:10:54 +02:00
86a3ad351e
Fixed #30339 -- Made Model.delete(keep_parents=True) preserves nested parent reverse relationships.
...
Thanks Simon Charette for the review.
2019-05-06 13:04:31 +02:00
8c5649bfb7
Fixed NonQueryWindowTests.test_unsupported_backend() on MySQL.
2019-05-03 13:49:02 +02:00
e683613649
Fixed #20122 -- Made pluralize template filter return '' on invalid input.
2019-05-03 11:35:20 +02:00
a9b8898242
Refs #11929 -- Fixed ordering of test YAML dumps.
...
Thanks Nick Pope for the review.
2019-05-03 10:48:18 +02:00
9006189c0e
Removed unused YamlSerializerTestCase.fwd_ref_str.
...
Unused since its introduction in febd5aeec6
2019-05-03 10:00:06 +02:00
567b9928a3
Fixed #29692 -- Fixed removing ordering parts for multiline RawSQL expressions.
2019-05-03 07:37:37 +02:00
ef082ebb84
Fixed #29529 -- Allowed models.fields.FilePathField to accept a callable path.
2019-05-02 11:11:56 +02:00
11971cd87c
Added tests for setting models.fields.FilePathField.path.
2019-05-02 11:11:50 +02:00
bceadd2788
Fixed #30396 -- Added system checks for uniqueness of indexes and constraints names.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-05-02 09:13:20 +02:00
6485a5f450
Fixed #30409 -- Allowed using foreign key's attnames in unique/index_together and Index's fields.
2019-05-01 11:51:27 +02:00
568eed9e79
Fixed #30245 -- Added -k option to DiscoverRunner.
2019-04-30 16:20:51 +02:00
719b746620
Fixed #30412 -- Fixed crash when adding check constraints with OR'ed condition on Oracle and SQLite.
2019-04-30 12:32:27 +02:00
6866c91b63
Fixed #30418 -- Added --skip-checks management command option.
2019-04-30 10:48:30 +02:00
a8b3f96f6a
Fixed #30408 -- Fixed crash when adding check constraints with LIKE operator on Oracle and PostgreSQL.
...
The LIKE operator wildcard generated for contains, startswith, endswith and
their case-insensitive variant lookups was conflicting with parameter
interpolation on CREATE constraint statement execution.
Ideally we'd delegate parameters interpolation in DDL statements on backends
that support it but that would require backward incompatible changes to the
Index and Constraint SQL generating methods.
Thanks David Sanders for the report.
2019-04-30 07:38:22 +02:00
673fe2e3ec
Fixed #30148 -- Logged COPY ... TO statements in connection.queries on PostgreSQL.
2019-04-29 14:20:17 +02:00
6754bffa2b
Fixed #30323 -- Fixed detecting changes by autoreloader when using StatReloader.
2019-04-29 11:41:00 +02:00
ed880d92b5
Added tests for queries log in CursorDebugWrapper.executemany().
2019-04-29 10:38:17 +02:00
0dd2308cf6
Fixed Python PendingDeprecationWarning in select_for_update.tests.
2019-04-29 08:47:33 +02:00
5627057f63
Refs #26022 -- Used context manager version of assertRaisesMessage in tests.
...
Follow up to 253adc2b8a
2019-04-29 08:05:07 +02:00
98296f86b3
Fixed #30351 -- Handled pre-existing permissions in proxy model permissions data migration.
...
Regression in 181fb60159
2019-04-27 20:18:22 +02:00
08a4ee0651
Fixed typos in test names.
2019-04-27 07:47:42 +02:00
ed3c59097a
Fixed #30361 -- Increased the default timeout of watchman client to 5 seconds and made it customizable.
...
Made the default timeout of watchman client customizable via
DJANGO_WATCHMAN_TIMEOUT environment variable.
2019-04-26 12:55:49 +02:00
efeceba589
Fixed #30312 -- Relaxed admin check from django.contrib.sessions to SessionMiddleware subclasses.
2019-04-26 11:31:06 +02:00
8d76443aba
Fixed #30399 -- Changed django.utils.html.escape()/urlize() to use html.escape()/unescape().
2019-04-25 15:09:07 +02:00
a5accc0368
Fixed #30318 -- Added check for importability of arguments of custom error handler views.
...
Thanks to Jon on Stack Overflow for reporting the issue.
2019-04-25 11:08:22 +02:00
fc9566d42d
Fixed #30393 -- Added validation of startapp's directory option.
2019-04-25 08:52:48 +02:00
0f22671ecb
Fixed #30388 -- Made inspectdb generate OneToOneFields rather than ForeignKey(unique/primary_key=True).
2019-04-25 08:09:32 +02:00
0a01ca80d7
Refs #30241 -- Fixed BytesWarning emitted in test_translation tests.
2019-04-24 15:31:03 +02:00
9141da1a80
Fixed #30366 -- Skipped StatReloaderTests on HFS+ filesystems.
...
When on MacOS High Sierra or below (<=10.13) it could be that a HFS+
filesystem is used. HFS+ has a time resolution of only one second
which can be too low for some of the tests.
2019-04-24 15:28:20 +02:00
8b3f1c35dd
Removed unnecessary assignments in various code.
2019-04-24 13:09:29 +02:00
80482e9249
Fixes #30342 -- Removed a system check for LANGUAGES_BIDI setting.
...
This partly reverts commit 4400d8296d
2019-04-24 10:54:03 +02:00
607ff4efa3
Refs #30254 -- Added tests for Model.__hash__() inheritance.
2019-04-24 09:59:09 +02:00
c00b4dbda2
Fixed #29810 -- Fixed crash of select_related() on FilteredRelation with empty result.
2019-04-23 13:48:33 +02:00
405c836336
Fixed #30385 -- Restored SearchVector(config) immutability.
...
Regression in 1a28dc3887#29582 . Thanks Andrew Brown for the report, Nick Pope for the
review.
2019-04-23 08:11:33 +02:00
12b7956fc3
Refs #25507 -- Added tests for using QuerySet.count() with a RawSQL annotation.
...
Fixed in 3f32154f40
2019-04-19 11:40:04 +02:00
49fb3f5f3e
Fixed #30341 -- Added support for the furlong unit in Distance.
2019-04-19 08:54:23 +02:00
a14c0fda15
Fixed #30328 -- Fixed crash of IntegerField.validators when limit_value in a custom validator is callable.
2019-04-19 07:58:27 +02:00
aed89adad5
Fixed #30367 -- Changed "pip install" to "python -m pip install" in docs, comments and hints.
2019-04-18 14:41:15 +02:00
ceab25bc6d
Refs #28762 -- Added test for aggregating over a function with ArrayField parameters.
...
Fixed in d87bd29c4f
2019-04-18 12:54:19 +02:00
654614b38e
Refs #28767 -- Added test for annotating Value() with empty list as an ArrayField.
...
Fixed in 3af695eda2
2019-04-18 12:06:39 +02:00
03db5fddfd
Fixed typos in docs, comments, and exception messages.
2019-04-18 09:33:53 +02:00
177fa08339
Fixed #30370 -- Added dbshell support for client TLS certificates on PostgreSQL.
2019-04-18 08:10:31 +02:00
d87bd29c4f
Fixed #30335 , #29139 -- Fixed crash when ordering or aggregating over a nested JSONField key transform.
2019-04-18 07:16:50 +02:00
f110de5c04
Fixed #30191 -- Selected only referenced fields during cascade deletion.
...
The non-referenced fields can only be deferred if no deletion signals
receivers are connected for their respective model as connected as these
receivers might expect all fields of the deleted model to be present.
Thanks Ed Morley for the report.
2019-04-17 13:41:23 +02:00
917fd9d03f
Fixed #27755 -- Added ModelAdmin.get_inlines() hook.
2019-04-17 07:16:04 +02:00
a4055adf70
Fixed #30368 -- Fixed prefetch_related() for GenericForeignKey when PK is also a FK.
2019-04-16 09:49:16 +02:00
0cb4062482
Refs #23758 -- Used RecursionError instead of RuntimeError to raise nested subquery errors.
...
RecursionError was introduced in Python 3.5 and subclasses RuntimeError.
2019-04-15 15:20:41 +02:00
c0969ee227
Refs #27149 -- Based recursive nested subquery detection on sys.getrecursionlimit().
...
This makes sure the test_avoid_infinite_loop_on_too_many_subqueries test
doesn't fail on systems with a non-default recursion limit.
2019-04-15 15:20:41 +02:00
Federico Jaramillo Martínez
Andrew Brown
Hasan Ramezani
Jon Dufresne
Mariusz Felisiak
Tim Gates
Simon Charette
Claude Paroz
Min ho Kim
Carlton Gibson
Mads Jensen
Nick Pope
Adnan Umer
zeyneloz
Simon Charette
swatantra
Ngalim Siregar
Andrew Godwin
Diederik van der Boor
aaktsipetrov
Florian Apolloner
Étienne Beaulé
Jerrod Martin
Piotr Domanski
Tom Forbes
Yann Sionneau
can
atsuo ishimoto
Johannes Hoppe
Chason Chaffin
Benjamin Woodruff
Nadège Michel
Shubham Bhagat
nsasaki128
daniel a rios
Chris Jerdonek
Sanyam Khurana
Joachim Jablon
Aymeric Augustin
Alexandre Varas
Tobias Bengfort
Tim Graham
Jones Ambrosi
RobertAKARobin
Nathan Gaberel
Caio Ariede
Ivor Bosloper
Mattia Procopio
Johan Lübcke
Rob
Ran Benita
Thomasina Lee
ruchit2801
ShingenPizza
Batuhan Taşkaya
Iain Watts
Ally Weir
Amir Hadi
luzpaz
Troon
Chris Adkins
Tobias Kunze
Stephen Brown
Mykola Kokalko
François Freitag
kingbuzzman
Daniel Hahler
Jacob Green
Aarni Koskela
Alasdair Nicol
oliver
Ville Skyttä
Martijn Jacobs
Matthias Kestenholz
Dustin Neighly
Scott Fitsimones
Ramiro Morales
Tomer Chachamu
Oleh Mykytiuk
Vinny Do