d7881d2020
Fixed #22229 -- Added primary key validation to BaseModelFormSet._construct_form().
2017-07-11 14:33:21 -04:00
a1be12fe19
Fixed #28345 -- Applied limit_choices_to during ModelForm.__init__().
...
field_for_model() now has an additional keyword argument,
apply_limit_choices_to, allowing it to continue to be used to create
form fields dynamically after ModelForm.__init__() is called.
Thanks Tim Graham for the review.
2017-06-30 15:57:48 -07:00
550cb3a365
Fixed #27818 -- Replaced try/except/pass with contextlib.suppress().
2017-06-28 14:07:55 -04:00
221e6e1817
Fixed #28176 -- Restored the uncasted option value in ChoiceWidget template context.
2017-06-17 18:17:23 -04:00
3b050fd0d0
Fixed #28303 -- Prevented localization of attribute values in the DTL attrs.html widget template.
2017-06-17 08:12:05 -04:00
3eb3907bb1
Refs #23919 -- Replaced stray super(ClassName, self) with super().
2017-06-10 20:46:43 -04:00
43b574007e
Fixed #28192 -- Required passing optional form field args as keyword args.
2017-06-03 10:49:01 -04:00
8e752d8437
Refs #28192 -- Made MultiValueField/ComboField fields argument required as documented.
2017-06-03 10:15:46 -04:00
29a518006f
Fixed #28265 -- Prevented renderer warning on Widget.render() with **kwargs.
2017-06-02 09:46:43 -04:00
2c69824e5a
Refs #23968 -- Removed unnecessary lists, generators, and tuple calls.
2017-06-01 19:08:59 -04:00
a0c07d77fc
Fixed #28242 -- Moved ImageField file extension validation to the form field.
2017-06-01 10:13:23 -04:00
21046e7773
Fixed #28249 -- Removed unnecessary dict.keys() calls.
...
iter(dict) is equivalent to iter(dict.keys()).
2017-05-27 19:08:46 -04:00
7afb476469
Fixed #28226 -- Replaced use of str.join() with concatenation.
2017-05-27 13:59:05 -04:00
5b6181f4d5
Fixed #27922 -- Added ErrorDict.get_json_data().
2017-05-27 09:19:42 -04:00
362fba87c9
Fixed #28159 -- Fixed BaseInlineFormSet._construct_form() crash when using save_as_new.
...
Regression in 4a246a02bd
2017-05-03 07:45:51 -04:00
d302e2c09c
Fixed #28157 -- Fixed choice ordering in form fields with grouped and non-grouped options.
...
Regression in b52c73008a
2017-05-03 07:21:44 -04:00
f04a404917
Fixed #28130 -- Fixed formset min_num validation with initial, unchanged forms.
...
Regression in f5c6295797
2017-04-28 09:32:40 -04:00
301de774c2
Refs #27795 -- Replaced many force_text() with str()
...
Thanks Tim Graham for the review.
2017-04-27 09:10:02 +02:00
92bc727271
Replaced temporary lists used for passing arguments with iterables.
2017-04-26 10:54:20 -04:00
3e91850dcc
Removed unneeded is True|False from bool expressions in widgets.py.
2017-04-21 12:34:18 -04:00
581879a510
Fixed #28075 -- Prevented ChoiceWidget from localizing option values.
2017-04-21 12:14:40 -04:00
af1f986360
Fixed #28059 -- Restored class attribute in <ul> of widgets that use multiple_input.html.
...
Regression in b52c73008a
2017-04-20 10:06:34 -04:00
c09bf8d767
Fixed #28058 -- Restored empty BoundFields evaluating to True.
...
Regression in b52c73008a
2017-04-17 08:32:29 -04:00
1aa8e8605c
Fixed #27989 -- Preserved empty QueryDicts for form's data/files args.
2017-04-01 18:43:39 -04:00
e487ffd3f0
Fixed #27866 -- Made ChoiceWidget.format_value() return a list
...
Thanks Tim Graham for the review.
2017-04-01 12:24:05 +02:00
7d1e237753
Fixed #27993 -- Fixed model form default fallback for SelectMultiple.
2017-03-31 10:10:08 -04:00
216bb2e8fb
Fixed #27975 -- Fixed crash if ModelChoiceField's queryset=None.
...
Regression in 9153d8fbd6385db9f48793662de789fc3d686841.
2017-03-22 08:51:12 -04:00
075e93c16a
Refs #27919 -- Changed Widget.get_context() attrs kwarg to an arg.
2017-03-21 09:14:45 -04:00
6ff356e891
Refs #27919 -- Passed ChoiceWidget.create_option() kwargs as expected.
2017-03-21 09:14:45 -04:00
7edeeb74fe
Fixed #27957 -- Removed technical terms from InlineForeignKeyField/ModelMultipleChoiceField error messages.
2017-03-20 13:12:55 -04:00
cd2ad26cc9
Fixed #27724 -- Fixed SelectDateWidget redisplay if a year isn't chosen.
2017-03-18 15:14:52 -04:00
44f9241c48
Refs #27563 -- Fixed ModelChoiceField.__deepcopy__() so forms don't share a queryset cache.
...
Thanks Luke Benstead for the report Simon Charettes for the fix.
2017-03-15 12:54:26 -04:00
540ae68a5c
Fixed #27920 -- Restored empty RadioSelect choice producing value=""
...
Regression in b52c73008a
2017-03-14 18:23:06 +01:00
8346680e1c
Refs #27795 -- Removed unneeded force_text calls
...
Thanks Tim Graham for the review.
2017-03-04 18:18:21 +01:00
3dcc351691
Refs #23919 -- Used yield from.
2017-02-23 20:06:01 -05:00
3eb679a869
Refs #27656 -- Updated django.forms/http docstring verbs according to PEP 257.
2017-02-20 19:57:33 -05:00
afcf44c101
Refs #23151 -- Removed RegexField's unused error_message parameter.
...
Should have been removed in b6ea1961eb
2017-02-20 19:09:09 -05:00
fb7e0e01af
Fixed #27850 -- Made RelatedFieldWidgetWrapper call render() of the wrapped widget.
2017-02-20 08:48:03 -05:00
0034e9af18
Fixed #5851 -- Allowed specifying different HTML attrs for SplitDateTimeWidget subwidgets.
...
Thanks Tim Graham and Nick Pope for review.
2017-02-07 11:33:37 -05:00
c651331b34
Converted usage of ugettext* functions to their gettext* aliases
...
Thanks Tim Graham for the review.
2017-02-07 09:04:04 +01:00
4353640ea9
Fixed #27805 -- Fixed ClearableFileInput's "Clear" checkbox on model fields with a default.
2017-02-06 20:31:04 -05:00
8838d4dd49
Refs #23919 -- Replaced kwargs.pop() with keyword-only arguments.
2017-02-01 11:41:56 -05:00
6d8979f4c2
Fixed #27758 -- Reallowed AdvancedModelIterator pattern after template widget rendering.
2017-01-31 09:41:51 -05:00
e07e743e0c
Refs #23919 -- Used DeclarativeFieldsMetaclass.__prepare__() for tracking form field order.
2017-01-27 12:46:21 -05:00
af598187ec
Removed unnecessary force_text() in BaseTemporalField.to_python().
...
This seems unneeded since its introduction in
da3aa22d04
2017-01-26 13:35:39 -05:00
d1bab24e01
Refs #23919 , #27778 -- Removed obsolete mentions of unicode.
2017-01-26 08:19:27 -05:00
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
0d74c41981
Replaced dict() usage with dict literals.
...
Literals are faster and more idiomatic.
2017-01-23 19:13:49 -05:00
f0573aad4b
Replaced "not var is ..." with "is not" in attrs.html.
2017-01-23 13:14:00 -05:00
5fa390ee81
Fixed #27759 -- Prevented forms attrs.html template from rendering False attrs.
...
Regression in b52c73008a
2017-01-23 08:49:00 -05:00
88183117c2
Fixed #27761 -- Fixed quote location in multiple_input.html forms templates.
2017-01-23 07:44:57 -05:00
ecd5944666
Removed ChoiceWidget.render() as it duplicates parent implementation.
2017-01-23 07:33:27 -05:00
6e55e1d88a
Refs #23919 -- Replaced six.reraise by raise
2017-01-22 20:08:04 +01:00
d170c63351
Refs #23919 -- Removed misc references to Python 2.
2017-01-21 20:02:00 -05:00
c22212220a
Refs #23919 -- Removed re.U and re.UNICODE (default on Python 3).
2017-01-21 14:28:16 -05:00
4e729feaa6
Refs #23919 -- Removed django.utils._os.upath()/npath()/abspathu() usage.
...
These functions do nothing on Python 3.
2017-01-20 08:01:02 -05:00
dc8834cad4
Refs #23919 -- Removed unneeded force_str calls
2017-01-20 08:44:31 +01:00
9695b14982
Refs #23919 -- Removed str() conversion of type and method __name__.
2017-01-19 11:31:07 -05:00
4c5ed3e683
Refs #23919 -- Removed __nonzero__() methods (for Python 2).
...
Thanks Tim for the review.
2017-01-19 11:26:26 -05:00
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
eb422e476f
Refs #23919 -- Removed obsolete __ne__() methods.
...
__ne__() defaults to the opposite of __eq__() on Python 3
when it doesn't return NotImplemented.
2017-01-18 21:44:00 -05:00
3cc5f01d9b
Refs #23919 -- Stopped using django.utils.lru_cache().
2017-01-18 21:42:40 -05:00
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
f3c43ad1fd
Refs #23919 -- Removed python_2_unicode_compatible decorator usage
2017-01-18 13:44:34 +01:00
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
58d3d14aea
Refs #26533 -- Removed support for Widget._format_value() per deprecation timeline.
2017-01-17 20:52:04 -05:00
742d666da5
Refs #24219 -- Removed django.forms.extras per deprecation timeline.
2017-01-17 14:09:28 -05:00
974d14534c
Fixed #27723 -- Set MultiWidget's subwidgets input type from attrs argument.
...
Regression in b52c73008a
2017-01-13 06:34:33 -05:00
6872ce2266
Fixed #27712 -- Reallowed Input widget's attrs argument to set the input type.
...
Regression in b52c73008a
2017-01-10 11:38:27 -05:00
12cefee5d8
Refs #15667 -- Prevented newlines in attrs.html widget rendering.
...
Removed the trailing newline from widget attrs.html template.
The solution may be revisited by fixing refs #9198 but not
for Django 1.11.
Thanks Dmitry Ivanchenko for the report and Preston Timmons for advice.
2017-01-06 19:11:32 -05:00
aaecf038ca
Fixed #27370 -- Prevented Select widget from using 'required' with a non-empty first value.
2016-12-28 10:45:22 -05:00
b52c73008a
Fixed #15667 -- Added template-based widget rendering.
...
Thanks Carl Meyer and Tim Graham for contributing to the patch.
2016-12-27 17:50:10 -05:00
4a51ba228b
Fixed #27642 -- Made forms.utils.flatatt() omit 'None' values from attrs.
2016-12-27 09:42:17 -05:00
181f492ad0
Fixed #27416 -- Prevented ModelFormSet from creating objects for invalid PKs in data.
2016-12-06 13:06:58 -05:00
6abd6c598e
Fixed #27563 -- Moved "apply limit_choices_to" code from BaseModelForm to fields_for_model().
2016-12-02 08:40:24 -08:00
d49551bc26
Fixed #27119 -- Cached BaseFormSet.management_form property
...
Thanks Tim Graham for the review.
2016-12-01 20:17:25 +01:00
abd434059e
Fixed #27250 -- Removed 'for ="..."' from CheckboxSelectMultiple's <label>.
2016-11-22 11:48:37 -05:00
8618a7eaa1
Fixed #27431 -- Prevented disabled form fields from appearing as changed.
2016-11-11 06:57:57 -05:00
656654fb5b
Fixed typo in django/forms/widgets.py comment.
2016-11-06 11:55:33 +01:00
09da1e79de
Fixed #27369 -- Prevented widgets from being shared between form field instances.
2016-11-06 07:16:56 +01:00
87c5e7efeb
Refs #27186 -- Fixed model form default fallback for CheckboxSelectMultiple.
2016-09-30 14:49:50 -04:00
3507d4e773
Fixed #27186 -- Fixed model form default fallback for MultiWidget, FileInput, SplitDateTimeWidget, SelectDateWidget, and SplitArrayWidget.
...
Thanks Matt Westcott for the review.
2016-09-22 12:20:58 -04:00
2c716c1dc7
Fixed #27256 -- Changed Select widget's selected attribute to use HTML5 boolean syntax.
2016-09-21 15:12:13 -07:00
9027e6c8a3
Fixed #27235 -- Removed some usage of mutable default arguments.
2016-09-16 15:48:08 -04:00
2ced2f785d
Replaced smart_* by force_* calls whenever possible
...
The smart_* version should only be used when a lazy string should keep
its lazy status.
2016-09-03 13:46:41 +02:00
d9c083cfee
Refs #27039 -- Fixed regression with field defaults in prefixed forms.
2016-09-01 09:13:21 -04:00
4bc6b93994
Fixed #27039 -- Fixed empty data fallback to model field default in model forms.
2016-08-24 17:50:10 -04:00
f5c6d3c8d9
Fixed #27068 -- Unified form field initial data retrieval.
2016-08-18 17:55:47 -07:00
6b842c5998
Made BoundField.initial use cached_property.
...
Follow up to fab46ce6f5
2016-08-12 12:43:24 -07:00
fab46ce6f5
Fixed #27037 -- Prevented required attribute on ClearableFileInput when initial data exists.
2016-08-12 13:59:01 -04:00
f5c6295797
Fixed #26844 -- Made formset's validate_min validation ignore empty forms.
2016-08-10 13:03:04 -04:00
74bb013cc1
Fixed #26905 -- Allowed using MultiValueDict-like objects as form data.
2016-08-09 19:46:24 -04:00
74105b2636
Fixed #27002 -- Prevented double query when rendering ModelChoiceField.
2016-08-08 13:41:05 -04:00
3569ba0333
Fixed #27015 -- Prevented HTML-invalid minlength/maxlength on hidden inputs
2016-08-06 10:22:17 +02:00
50e299dbfb
Fixed #26928 -- Changed forms' checked attribute to HTML5 boolean style.
2016-08-04 19:16:54 -04:00
c5ebfda002
Fixed #27001 -- Fixed a query count regression in ModelChoiceField with RadioSelect.
2016-08-03 10:45:55 -04:00
ac3aaaa740
Fixed #26927 -- Made subwidget iteration pass disabled and required attributes.
2016-08-01 10:36:17 -04:00
4e86168290
Fixed #26970 -- Fixed crash with disabled ModelMultipleChoiceField.
2016-07-30 13:31:48 -04:00
a5f85d891b
Fixed #26917 -- Fixed crash in disabled ModelChoiceFields.
...
Partially reverted refs #25532 to fix a regression in Django 1.10.
This reintroduces a crash for disabled forms.JSONField (refs #26949 ),
however, that issue is also present on Django 1.9.
Thanks Ryan Schave for the test.
2016-07-27 08:14:14 -04:00
a7b5dfd170
Fixed #26821 -- Fixed forms.Email/URLField crash on None value.
2016-07-14 12:59:14 -04:00
76e19da5b0
Fixed #26890 -- Fixed IntegerField crash on Unicode numbers.
2016-07-14 09:38:57 -04:00
26d0023ccc
Refs #15667 -- Fixed crash when indexing RadioFieldRenderer with ModelChoiceIterator.
...
Regression in 86573861a9
2016-06-18 10:33:37 -04:00
267dc4addd
Fixed #4136 -- Made ModelForm save empty values for nullable CharFields as NULL.
...
Previously, empty values were saved as strings.
2016-06-13 09:14:36 -04:00
5ec64f96b2
Fixed #26734 -- Made iterator class configurable on ModelChoiceField.
2016-06-09 11:10:26 -04:00
67d984413c
Refs #24227 -- Removed ManyToManyField special casing in model_to_dict().
2016-05-11 10:12:59 -04:00
86573861a9
Refs #15667 -- Removed choices argument from some RendererMixin methods.
...
RendererMixin will soon be removed but this removal and the corresponding
test changes stand on their own.
2016-04-28 18:48:52 -04:00
a5c8a6ce19
Fixed #21332 , #26538 -- Fixed inconsistent and duplicate form fields on inline formsets.
2016-04-26 10:26:25 -04:00
218175b09d
Fixed #26534 -- Fixed boolean form fields has_changed() with hidden input.
2016-04-24 15:06:30 -04:00
859eeaa0f0
Fixed #26533 -- Renamed Widget._format_value() to format_value().
2016-04-23 13:15:45 -04:00
a885bca1df
Fixed #26528 -- Allowed any iterable (e.g. tuple) as validators kwarg for form/model fields.
2016-04-22 09:38:47 +07:00
ec6121693f
Fixed #22383 -- Added support for HTML5 required attribute on required form fields.
2016-04-21 19:16:38 -04:00
500e5a6886
Fixed #26516 -- Added minlength attribute when forms.CharField.min_length is set.
2016-04-19 08:54:27 -04:00
3cb63b0e47
Refs #26502 -- Added choices to Form.__getitem__() KeyError message.
2016-04-14 09:15:09 -04:00
c339a5a6f7
Refs #16508 -- Renamed the current "virtual" fields to "private".
...
The only reason why GenericForeignKey and GenericRelation are stored
separately inside _meta is that they need to be cloned for every model
subclass, but that's not true for any other virtual field. Actually,
it's only true for GenericRelation.
2016-04-13 10:10:53 -04:00
df8d8d4292
Fixed E128 flake8 warnings in django/.
2016-04-08 09:51:06 -04:00
2cd2d18851
Fixed W503 flake8 warnings.
2016-04-04 17:14:26 -04:00
db19619545
Fixed #25532 -- Properly redisplayed JSONField form input values
...
Thanks David Szotten for the report and Tommy Beadle for code inspiration.
Thanks Tim Graham for the review.
2016-04-01 09:04:20 +02:00
1a403aa705
Fixed #25987 -- Made inline formset validation respect unique_together with an unsaved parent object.
...
Thanks Anton Kuzmichev for the report and Tim for the review.
2016-03-26 21:49:41 -04:00
5974cbe32e
Removed unnecessary type creation in modelforset_factory.
2016-03-25 12:50:35 -04:00
983c158da7
Refs #24227 -- Replaced M2M isinstance checks by field.many_to_many
...
Thanks Markus Holtermann, Collin Anderson and Tim Graham for the reviews.
2016-03-19 09:24:27 +01:00
d5f89ff6e8
Fixed #24974 -- Fixed inheritance of formfield_callback for modelform_factory forms.
2016-02-26 12:27:27 -05:00
b412681359
Fixed #26267 -- Fixed BoundField to reallow slices of subwidgets.
2016-02-24 07:02:51 -05:00
d43156e1e9
Fixed #26238 -- Raised explicit error for non-editable field in ModelForm
...
Thanks Luke Crouch for the report and Simon Charette for the review.
2016-02-21 00:24:20 +01:00
375e1cfe2b
Fixed #25349 -- Allowed a ModelForm to unset a fields with blank=True, required=False.
2016-02-19 14:18:53 -05:00
043383e3f3
Fixed #24727 -- Prevented ClearableFileInput from masking exceptions on Python 2
2016-02-15 22:51:46 +02:00
926e90132d
Fixed #25731 -- Removed unused choices kwarg for Select.render()
2016-02-02 18:03:19 -05:00
04564eb74d
Fixed #26129 -- Made invalid forms display initial values of disabled fields.
2016-01-28 18:43:48 -05:00
65c13f9675
Refs #25731 -- Removed unused MultipleHiddenInput choices
2016-01-25 10:20:58 -05:00
6b258befc2
Refs #26104 -- Replaced unnecessary force_str() with force_text().
2016-01-23 13:40:18 -05:00
956cde8004
Fixed #26104 -- Fixed TypeError when passing number to forms.DurationField.
2016-01-22 16:24:49 -05:00
d91cc25a2a
Fixed #25942 -- Fixed TypedChoiceField.has_changed with nullable field
...
This fixes a regression introduced by 871440361
2015-12-17 15:38:19 +01:00
cf546e11ac
Fixed #21221 -- Made form Media and static template tag use staticfiles if installed.
2015-12-10 14:30:19 -05:00
1155843a41
Fixed #25683 -- Allowed ModelChoiceField(queryset=...) to accept Managers.
...
This fixes a regression from refs #25496 .
2015-11-09 12:42:36 -05:00
f59a0401e5
Fixed #25567 -- Removed obsolete MEDIA_URL fallback in Media.absolute_path
2015-10-19 15:39:35 +02:00
6afa6818fc
Fixed #25496 -- Made ModelChoiceField respect prefetch_related().
2015-10-05 18:21:56 -04:00
a51070e743
Refs #25294 -- Added BoundField import for backwards compatibility.
2015-09-24 19:57:19 +02:00
a3fe4addcb
Refs #23162 -- Removed forms.Field._has_changed() method.
...
Per deprecation timeline.
2015-09-23 19:31:10 -04:00
b6ea1961eb
Refs #23151 -- Removed RegexField.error_message per deprecation timeline.
2015-09-23 19:31:10 -04:00
7cb3a48843
Fixed #25410 -- Fixed empty ClearableFileInput crash on Python 2.
...
Reverted "Fixes #24727 -- Prevented ClearableFileInput from masking
exceptions on Python 2" and added a regression test.
This reverts commit 5c412dd8a7
2015-09-23 10:26:19 -04:00
65a1055a36
Fixed #25431 -- Readded inline foreign keys to modelformset instances
...
Too much field exclusions in form's construct_instance() in _post_clean()
could lead to some unexpected missing ForeignKey values.
Fixes a regression from 45e049937#13776 .
2015-09-21 21:30:49 +02:00
75ed590032
Fixed #24636 -- Added model field validation for decimal places and max digits.
2015-09-18 14:30:20 -04:00
8550161e53
Refs #25294 -- Moved BoundField to django.forms.boundfield.
2015-09-16 14:43:38 -04:00
535809e121
Fixed #25294 -- Allowed custom BoundFields on forms.
2015-09-16 10:18:07 -04:00
b8b776aabe
Fixed typo in django/forms/utils.py docstring.
2015-09-14 08:49:15 -04:00
b1e33ceced
Fixed #23395 -- Limited line lengths to 119 characters.
2015-09-12 11:40:50 -04:00
3c5862ccb0
Fixed #24706 -- Made ModelForm._post_clean() handle a ValidationError raised when constructing the model instance.
...
Thanks Loïc Bistuer for review and advice.
2015-09-07 14:36:39 -04:00
97ac77e544
Removed BaseForm._raw_value().
...
Unused since efb0100ee6
2015-08-21 12:14:54 -04:00
8656cfc4e0
Removed forms.models.save_instance() function.
...
As of b11564fd36
2015-08-07 08:18:09 -04:00
f2b665f886
Fixed #25241 -- Corrected ModelForm.save() error message when saving invalid form with UUIDField pk.
2015-08-07 07:44:59 -04:00
Jon Dufresne
Mads Jensen
Tim Graham
Tom
Claude Paroz
Manatsawin Hanmongkolchai
Tim Heap
Alexander Kavanaugh
Stefan Wehrmeyer
heathervm
James Beith
Adonys Alea Boffill
Vytis Banaitis
Anton Samarchyan
Collin Anderson
Mariusz Felisiak
chillaranand
Simon Charette
Simon Charette
Aymeric Augustin
Dmitry
Josef Rousek
Preston Timmons
Illia Volochii
Hiroki Kiyohara
Diego Martín
Kenneth Veldman
Leila20
Michal Petrucha
Chris Lamb
Alex Hill
Andrew Nester
Marcin Nowak
Priy
David Sanders
Loïc Bistuer
Yoong Kang Lim
haxoza
Berker Peksag
jpic
Alexander Gaevsky
Johannes Hoppe
Marti Raudsepp
Moritz Sichert
Iulia Chiriac
Kholid Fuadi
Dražen Odobašić
Keryn Knight