a9e29fae10
Fixed #24435 -- Prevented m2m field removal and addition in migrations when changing blank
...
Thanks Mark Tranchant for the report an Tim Graham for the test and
review.
2015-03-04 14:26:49 +01:00
70123cf084
Fixed #24399 -- Made filesystem loaders use more specific exceptions.
2015-03-03 21:20:46 +01:00
358850781f
Fixed #24372 - Replaced TokenParser usage with traditional parsing.
2015-03-02 18:25:28 -05:00
8ca35d7c6a
Fixed Oracle build failure introduced by refs #24390 .
...
Used shorter column names to make the generated index name
fit within Oracle's limit of 30 characters
2015-03-03 00:01:21 +02:00
08572e8d12
Fixed #24294 -- Allowed staff_member_required decorator to handle args.
2015-03-02 13:15:34 -05:00
4e8b167e4d
Fixed MySQL build failure introduced by refs #24390 .
...
Added table_name back to _create_index_sql() to prevent
duplicate index names on MySQL.
2015-03-02 13:07:34 -05:00
f37c11eea3
Fixed #24390 -- Made migration index names deterministic.
2015-03-02 09:25:19 -05:00
80d6b6b863
Fixed #24409 -- Combined the app_directories and filesystem loader implementation.
...
Besides the directories they look in, these two loaders are functionally
the same. This removes unnecessary code duplication between the two.
2015-03-02 07:53:58 -05:00
4b8979e477
Fixed #17401 -- Made SelectDateWidget.render reflect wrong value
...
Thanks Marcin Wrobel for the initial patch.
2015-03-01 21:37:52 +01:00
3cf1c02695
Fixed #24413 -- Prevented translation fallback for English
...
Thanks Tomasz Kontusz for the report, Baptiste Mispelon for
analysis and Tim Graham for the review.
2015-02-28 10:07:12 +01:00
5cf96b49e4
Fixed #24418 -- Prevented crash in refresh_from_db with null fk
...
Thanks Johannes Lerch for the report, Tim Graham for the test case,
and Simon Charette for the review.
2015-02-27 20:23:07 +01:00
8a9f39d2b3
Removed binary input test line
...
That line was inconveniently introduced by the committer (me) in
3b966c2b73
2015-02-27 15:44:06 +01:00
3b966c2b73
Fixed #24229 -- Changed IntegerField to clean floats representing integers
2015-02-27 12:23:21 +01:00
65441bbdb0
Fixed #24391 -- Made BoundField.value() cache callable values.
2015-02-24 19:50:55 -05:00
4c2f546b55
Fixed #24395 -- Ensured inline ModelsForms have an updated related instance.
2015-02-24 11:49:00 -05:00
8e129b42ad
Cleaned up template directory handling in template tests.
2015-02-24 14:00:03 +01:00
32c108a221
Combined TemplateTests and TemplateRegressionTests.
2015-02-24 14:00:03 +01:00
25a0b5cdcd
Moved test_token_smart_split into ParserTests.
2015-02-24 14:00:03 +01:00
3d8fee6051
Moved ifchanged tests into syntax_tests/test_if_changed.py.
2015-02-24 14:00:02 +01:00
f6d087b628
Moved cache tests into syntax_tests/test_cache.py.
2015-02-24 14:00:02 +01:00
250a3d1993
Moved RequestContextTests into test_context.
2015-02-24 14:00:02 +01:00
ff67ce5076
Moved TemplateTagLoading cases into test_custom.
2015-02-24 14:00:02 +01:00
06ffc764a9
Moved include tests into syntax_tests/test_include.py.
2015-02-24 14:00:02 +01:00
441a47e1ef
Moved ssi tests into syntax_tests/test_ssi.py.
2015-02-24 14:00:02 +01:00
1827aa9024
Cleaned up template loader tests.
2015-02-24 14:00:02 +01:00
2be6b52656
Fixed typos in flatpages_tests comments.
2015-02-24 06:30:33 -05:00
903d1a57ab
Made migrations tests write to a temporary directory.
...
This is preferrable to writing in the current working directory because
it eliminates the risk to leak unwanted files, which can result in very
weird test failures.
Also this will help if we ever try to run these tests concurrently.
2015-02-23 22:22:58 +01:00
952ce778c6
Fixed a test failure under Windows and Python 2.
2015-02-23 18:36:15 +01:00
a8fe12417f
Normalized usage of the tempfile module.
...
Specifically stopped using the dir argument.
2015-02-23 16:55:27 +01:00
934400759d
Guaranteed removal of temporary files during tests.
...
Dropped the DJANGO_TEST_TEMP_DIR environment variable.
Before this change, proper removal depended on the developer passing
dir=os.environ['DJANGO_TEST_TMP_DIR'] to tempfile functions.
2015-02-23 16:55:26 +01:00
1306cd1e8a
Fixed #24377 -- Fixed model inline formsets with primary key's that have defaults.
2015-02-23 08:44:27 -05:00
f95122e541
Fixed #24381 -- removed ForeignObjectRel opts and to_opts
...
These cached properies were causing problems with pickling, and in
addition they were confusingly defined: field.rel.model._meta was
not the same as field.rel.opts.
Instead users should use field.rel.related_model._meta inplace of
field.rel.opts, and field.rel.to._meta in place of field.rel.to_opts.
2015-02-23 07:24:43 -05:00
78d43a5e10
Fixed #24366 -- Optimized traversal of large migration dependency graphs.
...
Switched from an adjancency list and uncached, iterative depth-first
search to a Node-based design with direct parent/child links and a
cached, recursive depth-first search. With this change, calculating
a migration plan for a large graph takes several seconds instead of
several hours.
Marked test `migrations.test_graph.GraphTests.test_dfs` as an expected
failure due to reaching the maximum recursion depth.
2015-02-23 12:38:53 +01:00
c688460df6
Removed rmtree_errorhandler.
...
The stated reason for its introduction in d18d37ce
2015-02-22 23:09:42 +01:00
88a5f17d25
Fixed #24389 -- Isolated the CSRF view from the TEMPLATES setting.
...
Thanks uranusjr for the report and analysis.
2015-02-22 15:46:35 +01:00
ea3168dc6c
Fixed #24376 -- added verbose_name arg to UUIDField
2015-02-21 13:27:49 -05:00
787dd6519a
Removed obsolete reference to media directory.
2015-02-21 17:52:24 +01:00
bd059e3f8c
Removed workaround for SVN limitations.
...
In addition to simplifying the code, this reduces the number of writes.
2015-02-21 17:52:24 +01:00
2bb5b0e098
Avoided collecting admin static files in tests.
...
This makes the staticfiles tests 2.5 times faster.
2015-02-21 17:46:26 +01:00
1d9d39fa1c
Removed TestServeAdminMedia.
...
It should have been removed when the ADMIN_MEDIA_PREFIX setting was deprecated.
2015-02-21 17:46:26 +01:00
fa5f936b48
Fixed allow_migrate signature in one of the tests.
...
Refs #24351 .
2015-02-21 23:13:14 +07:00
1d1d5d1c31
Fixed #24341 -- Added specific error messages to RangeField subclasses
2015-02-20 16:49:15 -05:00
bad5f262bf
Fixed #24328 -- cleaned up Options._get_fields() implementation
2015-02-20 13:00:12 -05:00
bed504d70b
Fixed #24351 , #24346 -- Changed the signature of allow_migrate().
...
The new signature enables better support for routing RunPython and
RunSQL operations, especially w.r.t. reusable and third-party apps.
This commit also takes advantage of the deprecation cycle for the old
signature to remove the backward incompatibility introduced in #22583 ;
RunPython and RunSQL won't call allow_migrate() when when the router
has the old signature.
Thanks Aymeric Augustin and Tim Graham for helping shape up the patch.
Refs 22583.
2015-02-20 21:34:09 +07:00
c490e410af
Fixed #24373 -- Added run_validators to ArrayField.
...
Thanks to DavidMuller for the report.
2015-02-20 11:51:46 +00:00
32d4db66b9
Update converters to take a consistent set of parameters.
...
As suggested by Anssi. This has the slightly strange side effect of
passing the expression to Expression.convert_value has the expression
passed back to it, but it allows more complex patterns of expressions.
2015-02-20 11:35:52 +00:00
4755f8fc25
Fixed #24343 -- Ensure db converters are used for foreign keys.
...
Joint effort between myself, Josh, Anssi and Shai.
2015-02-20 11:35:51 +00:00
c8074d62f8
Fixed typo in error message in the test.
2015-02-19 19:36:20 -05:00
1bfcc950ab
Set context.template instead of context.engine while rendering.
...
This opens more possibilities, like accessing context.template.origin.
It also follows the chain of objects instead of following a shortcut.
2015-02-19 22:08:11 +01:00
efb1f99f94
Fixed #20889 -- Prevented BadHeaderError when Python inserts newline
...
Workaround for http://bugs.python.org/issue20747 .
In some corner cases, Python 2 inserts a newline in a header value
despite `maxlinelen` passed in Header constructor.
Thanks Tim Graham for the review.
2015-02-19 20:18:31 +01:00
ceadc94f09
Fixed #24307 : Avoided redundant column nullability modifications on Oracle
...
Thanks Joris Benschop for the report, and Tim Graham for the tests.
2015-02-19 02:39:41 +02:00
f7d34fe741
Fixed #24362 : Made test run each migration operation in its own schema editor
...
Thanks Tim Graham for pointing out the fix.
2015-02-18 22:47:15 +02:00
15dc8d1c9d
Fixed #24291 - Fixed migration ModelState generation with unused swappable models
...
Swapped out models don't have a _default_manager unless they have
explicitly defined managers. ModelState.from_model() now accounts for
this case and uses an empty list for managers if no explicit managers
are defined and a model is swapped out.
2015-02-18 19:05:10 +01:00
b8d6cdbcc9
Refs #24324 -- Skipped fixtures_regress tests that fail on Python 2 on a non-ASCII path.
2015-02-18 07:25:36 -05:00
307c0f299a
Refs #24324 -- Fixed Python 2 test failures when path to Django source contains non-ASCII characters.
2015-02-17 19:03:03 -05:00
ad50b6c853
Fixed "environment can only contain strings" in model_regress test on Windows.
2015-02-17 13:54:18 -05:00
d316b43d0a
Refs #24324 -- Fixed UnicodeDecodeError in model_regress test on non-ASCII path.
2015-02-17 07:32:48 -05:00
8b39f33d78
Fixed #24290 -- Skipped postgres_tests if not running with PostgreSQL.
2015-02-17 06:34:13 -05:00
3adc5f1ee6
Fixed #24335 -- Bumped required psycopg2 version to 2.4.5 (2.5 for contrib.postgres).
2015-02-16 18:07:27 -05:00
664c038f2c
Moved contrib.contenttypes tests out of contrib.
2015-02-16 17:45:38 -05:00
d538e37e1b
Added tests for get_related_models_recursive
2015-02-16 19:31:52 +01:00
273bc4b667
Refs #24282 -- Added failing test case for assigning models of wrong type to FK
...
Thanks Jeff Singer for the test case.
2015-02-16 19:31:51 +01:00
cc22b009e0
Refs #24264 -- Added failing test case for updating a FK when changing a PK
...
When the primary key column is altered, foreign keys of referencing
models must be aware of a possible data type change as well and thus
need to be re-rendered.
Thanks Tim Graham for the report.
2015-02-16 19:31:51 +01:00
58d0dd9260
Refs #24225 -- Added failing test case for removing a previously added field in migrations
...
When a related field is deleted, the related model must be updated. As
unchanged models are shared in migration states, the related model must
be re-rendered so that the change applies to a new copy of the related
model.
Thanks Henrik Heimbuerger for the report.
2015-02-16 19:31:51 +01:00
f668bac9d2
Fixed #24345 -- Isolated sitemaps_tests from contenttypes_tests; refs #11505
2015-02-16 08:42:43 -05:00
c5a77721e2
Merged ManyRelatedObjectsDescriptor and ReverseManyRelatedObjectsDescriptor
...
and made all "many" related objects descriptors inherit from
ForeignRelatedObjectsDescriptor.
2015-02-16 20:40:04 +07:00
15b711b5ee
Deprecated TEMPLATE_DEBUG setting.
2015-02-15 20:47:04 +01:00
e0b3926026
Isolated auth_tests from contenttypes_tests; refs #11505 .
2015-02-14 22:04:48 -05:00
49647bec6e
Added missing return value to DurationField.prepare_value(); refs #24339 .
2015-02-14 18:38:50 -05:00
76356d963c
Fixed #24318 -- Set the transaction isolation level with psycopg >= 2.4.2.
2015-02-14 18:51:11 +01:00
8a21d25033
Fixed #24339 -- Fixed crash with empty DurationField form field.
2015-02-14 07:37:18 -05:00
1791a7e75a
Fixed #15779 -- Allowed 'add' primary key in admin edition
...
Thanks Marwan Alsabbagh for the report, and Simon Charette and
Tim Graham for the reviews.
2015-02-14 11:19:55 +01:00
47ee7b48ad
Fixed #24338 -- Accepted Template wrapper in {% extends %}.
...
Explicitly checking for django.template.Template subclasses is
preferrable to duck-typing because both the django.template.Template and
django.template.backends.django.Template have a render() method.
Thanks spectras for the report.
2015-02-14 10:21:06 +01:00
18c0aaa912
Fixed #24289 -- Reversed usage of Field.many_to_one and one_to_many.
...
Thanks Carl Meyer and Tim Graham for the reviews and to all involved
in the discussion.
2015-02-14 02:28:24 +07:00
5c995dcfc2
Fixed #24320 - Used field.value_to_string() in serialization of foreign key.
...
This fixes serialization of a ForeignKey to a UUIDField as the
test indicates.
2015-02-13 12:37:23 -05:00
002425fe39
Fixed #24315 -- Fixed auth.views.password_reset_confirm() with a UUID user.
2015-02-13 09:56:31 -05:00
fdf20093e0
Fixed #24334 -- Allowed admin password reset to work with non-digit custom user model primary key.
...
Thanks Loic for help and Simon for review.
2015-02-13 09:42:49 -05:00
f287bec583
Fixed #24184 -- Prevented automatic soft-apply of migrations
...
Previously Django only checked for the table name in CreateModel
operations in initial migrations and faked the migration automatically.
This led to various errors and unexpected behavior. The newly introduced
--fake-initial flag to the migrate command must be passed to get the
same behavior again. With this change Django will bail out in with a
"duplicate relation / table" error instead.
Thanks Carl Meyer and Tim Graham for the documentation update, report
and review.
2015-02-13 14:29:59 +01:00
b4e1090ab2
Removed explicit pointers to migration modules for contrib apps in runtest
...
Thanks Tim Graham for the patch
2015-02-13 14:29:45 +01:00
b06935a486
Refs #22962 -- Made test case use non-conflicting table names
2015-02-13 14:01:54 +01:00
00a889167f
Fixed #24295 -- Allowed ModelForm meta to specify form field classes.
...
Thanks Carl Meyer and Markus Holtermann for the reviews.
2015-02-13 19:13:05 +07:00
e8cf4f8abe
Fixed #24332 -- Fixed contrib.sites create_default_site() when 'default' DATABASES is empty.
2015-02-13 07:01:28 -05:00
bd4afef984
Refs #14030 -- Added tests for Value aggregates
2015-02-13 10:06:46 +11:00
de0241eb98
Fixed #24319 -- Added validation for UUID model field
2015-02-13 09:45:53 +11:00
d64baaef3b
Fixed #24333 -- Fixed admin history view crash with non-integer slug.
2015-02-12 14:19:44 -05:00
9239f1dda7
Refs #24215 -- Prevented pending lookup pollution by abstract models.
2015-02-12 13:07:09 -05:00
d7509c5246
Added a test for UUIDField serialization; refs #24320 .
2015-02-12 09:54:42 -05:00
e4999bf671
Added missing import from last commit.
2015-02-12 08:18:10 -05:00
27eeb64a96
Fixed #17716 -- Prevented include('...', app_name='...') without a namespace.
2015-02-12 08:07:58 -05:00
0f7f5bc9e7
Fixed #24161 -- Stored the user primary key as a serialized value in the session.
...
This allows using a UUIDField primary key along with the JSON session
serializer.
Thanks to Trac alias jamesbeith for the report and Simon Charette
for the initial patch.
2015-02-12 07:38:16 -05:00
93b3ef9b2e
Fixed #24321 -- Improved `utils.http.same_origin` compliance with RFC6454
2015-02-12 08:58:35 +01:00
e2d6e14662
Refs #14030 -- Improved expression support for python values
2015-02-12 08:46:25 +11:00
07cfe1bd82
Refs #14497 -- Handled empty readonly admin FileFields
2015-02-11 13:00:56 -05:00
8ec306a3a9
Moved contrib.webdesign tests out of contrib.
2015-02-11 12:30:07 -05:00
7cf3a5786b
Updated docs and runtests.py for removal of tests from contrib.
2015-02-11 10:29:54 -05:00
ad0be620ae
Moved contrib.gis tests out of contrib.
2015-02-11 10:29:54 -05:00
5ab327a389
Moved non-documented auth test models to the new test location.
2015-02-11 10:29:48 -05:00
2d7aca3da0
Moved contrib.auth tests out of contrib.
2015-02-11 10:19:22 -05:00
8192a164de
Moved contrib.humanize tests out of contrib.
2015-02-11 10:19:22 -05:00
00da46091a
Moved contrib.redirects tests out of contrib.
2015-02-11 10:19:22 -05:00
b3cd9e0d07
Moved contrib.messages tests out of contrib.
2015-02-11 10:19:22 -05:00
fac3a34cbb
Moved contrib.sessions tests out of contrib.
2015-02-11 10:19:22 -05:00
fbc467c26b
Moved contrib.sitemaps tests out of contrib.
2015-02-11 10:19:22 -05:00
d8341bf024
Moved contrib.sites tests out of contrib.
2015-02-11 10:19:22 -05:00
d3a725054f
Moved contrib.flatpages tests out of contrib.
2015-02-11 10:19:22 -05:00
197dd4b8f1
Prevented some test commands from needlessly running system checks.
...
This is a performance optimization and also fixes test errors with the
upcoming merge of contrib tests into tests/. The tests failed on MySQL
because the models with GeometryField were being checked but the
non-GIS MySQL backend didn't know how to handle them.
2015-02-11 10:14:38 -05:00
19188826b4
Fixed #24146 -- Allowed model._meta.get_field() to be used after apps.models_ready
2015-02-10 19:55:06 -05:00
1b8af4cfa0
Disallowed importing concrete models without an application.
...
Removed fragile algorithm to find which application a model belongs to.
Fixed #21680 , #21719 . Refs #21794 .
2015-02-10 21:41:19 +01:00
c970018f41
Removed Django 1.7 MIDDLEWARE_CLASSES upgrade check.
2015-02-09 19:16:07 -05:00
5b75b01939
Refactored an admin_view test case.
...
Used setUpTestData, client login/logout and manager's count() method.
Thanks to Tim for the review.
2015-02-09 15:08:05 -05:00
8a590c4b7b
Moved a custom admin template test to a more appropriate case.
...
Thanks to Tim for the review.
2015-02-09 15:07:49 -05:00
50aa1a790c
Replaced some more hardcoded admin URLs
2015-02-09 17:29:53 +01:00
2d7c27d387
Fixed #24302 -- Added DurationField.formfield()
2015-02-09 10:20:01 -05:00
e144e0e237
Removed unnecessary parentheses in model check messages.
2015-02-09 08:53:58 -05:00
4d73303ee9
Fixed #24249 -- Improved field shadowing validation in model multi-inheritance.
2015-02-09 08:37:55 -05:00
32e6a7d3a5
Replaced hardcoded URLs in admin_* tests
...
Refs #15779 . This will allow easier admin URL changes, when needed.
Thanks Simon Charette for the review.
2015-02-08 20:55:09 +01:00
9033003d97
Added check_apps_ready() to Apps.get_containing_app_config()
2015-02-08 14:52:19 -05:00
540ca563de
Fixed #24181 -- Fixed multi-char THOUSAND_SEPARATOR insertion
...
Report and original patch by Kay Cha.
2015-02-08 20:00:57 +01:00
58afd30b59
Tested DecimalField with scientific notation
...
Refs #15775 .
2015-02-06 22:30:50 +01:00
db77915c9f
Fixed E265 comment style
2015-02-06 09:30:35 -05:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
20b74b10be
Added a test for refs #24279
...
This issue was fixed in afe0bb7b13
2015-02-06 07:43:59 -05:00
23a5ec0782
Added trailing comma.
...
Sorry, I couldn't stand the inconsistency between the two databases anymore.
2015-02-06 12:58:45 +01:00
d39073b8ae
Hid Django installation message when verbosity is 0.
...
This message was introduced to help people figure out quickly when they
aren't running the tests against the copy of Django they're editing.
There's no reason to display it when verbosity is set to 0. It defaults
to 1.
2015-02-06 12:56:53 +01:00
bbe28496d3
Removed old import aliases.
2015-02-05 19:37:01 -05:00
0f54cf28c0
Added UUIDField.deconstruct()
2015-02-05 19:15:02 -05:00
235124d3ea
Fixed small regression caused by 0204714b0b
...
Since 1.7 models need to declare an explicit app_label if they are not
in an application in INSTALLED_APPS or were imported before their
application was loaded.
2015-02-06 00:45:07 +01:00
0204714b0b
Cleaned up schema tests
...
Thanks Tim Graham for the review.
2015-02-05 20:11:48 +01:00
44ad691558
Fixed #24265 -- Preserved template backend loading exceptions.
...
If importing or initializing a template backend fails, attempting to
access this template backend again must raise the same exception.
2015-02-05 20:06:18 +01:00
31d3a35579
Fixed #24273 -- Allowed copying RequestContext more than once.
...
Thanks Collin Anderson for the report.
2015-02-05 13:21:50 +01:00
71ada3a8e6
Fixed #6707 -- Added RelatedManager.set() and made descriptors' __set__ use it.
...
Thanks Anssi Kääriäinen, Carl Meyer, Collin Anderson, and Tim Graham for the reviews.
2015-02-05 12:45:08 +07:00
caa3562d5b
Fixed #24242 -- Improved efficiency of utils.text.compress_sequence()
...
The function no longer flushes zfile after each write as doing so can
lead to the gzipped streamed content being larger than the original
content; each flush adds a 5/6 byte type 0 block. Removing this means
buf.read() may return nothing, so only yield if that has some data.
Testing shows without the flush() the buffer is being flushed every 17k
or so and compresses the same as if it had been done as a whole string.
2015-02-04 13:04:00 -05:00
2730dad0d7
Fixed #24197 -- Added clearing of staticfiles caches on settings changes during tests
...
Cleared caching in staticfiles_storage and get_finder when
relevant settings are changed.
2015-02-04 10:53:04 -05:00
23c4cbc0fa
Cleaned up formatting in template_tests.test_custom.
2015-02-04 09:47:24 -05:00
7145c8a62a
Removed EverythingNode
...
At the same time, made sure that empty nodes in where clause match
everything.
2015-02-04 09:26:40 -05:00
2be621e44c
Fixed #14497 -- Improved admin widget for "read only" FileFields
...
Based on patch by Adam J Forster, Paul Collins, and Julien.
2015-02-04 09:05:23 -05:00
7d363ed432
Fixed typos of "select_related" in docs and tests.
2015-02-04 07:31:43 -05:00
79f27f2b61
Fixed #15321 -- Honored ancestors unique checks.
...
Thanks to Tim for the review.
2015-02-03 18:56:53 -05:00
1fc458b5a3
Removed a useless check in runtests.py
...
Added in 3e97535907
2015-02-03 18:32:00 -05:00
c0cc8f69e7
Refactored tests that rely on an ImportError for Python 3.5 compatibility
...
A change in Python test discovery [1] causes the old packages that raised
an error to be discovered; now we use a common directory that's
ignored during discovery. Refs #23763 .
[1] http://bugs.python.org/issue7559
2015-02-03 18:30:46 -05:00
65e005f8cd
Fixed #24266 -- Changed get_parent_list to return a list ordered by MRO.
...
Thanks to Aron Podrigal for the initial patch and Tim for the review.
2015-02-03 16:40:31 -05:00
0e489c19f1
Reverted "Fixed #24146 -- Fixed a missing fields regression in admin checks."
...
This reverts commit e8171daf0c
2015-02-03 15:23:39 -05:00
9ec8aa5e5d
Fixed #24149 -- Normalized tuple settings to lists.
2015-02-03 14:59:45 -05:00
cd0ceaa102
Fixed #24252 -- Forced lazy __str__ to utf-8 on Python 2
...
Thanks Stanislas Guerra for the report and Tomas Ehrlich for
the review.
2015-02-03 18:23:41 +01:00
250aa7c39b
Fixed #24240 -- Allowed GZipping a Unicode StreamingHttpResponse
...
make_bytes() assumed that if the Content-Encoding header is set, then
everything had already been dealt with bytes-wise, but in a streaming
situation this was not necessarily the case.
make_bytes() is only called when necessary when working with a
StreamingHttpResponse iterable, but by that point the middleware has
added the Content-Encoding header and thus make_bytes() tried to call
bytes(value) (and dies). If it had been a normal HttpResponse,
make_bytes() would have been called when the content was set, well
before the middleware set the Content-Encoding header.
This commit removes the special casing when Content-Encoding is set,
allowing unicode strings to be encoded during the iteration before they
are e.g. gzipped. This behaviour was added a long time ago for #4969 and
it doesn't appear to be necessary any more, as everything is correctly
made into bytes at the appropriate places.
Two new tests, to show that supplying non-ASCII characters to a
StreamingHttpResponse works fine normally, and when passed through the
GZip middleware (the latter dies without the change to make_bytes()).
Removes the test with a nonsense Content-Encoding and Unicode input - if
this were to happen, it can still be encoded as bytes fine.
2015-02-03 18:18:12 +01:00
cd4282816d
Fixed #18651 -- Enabled optional assignments for simple_tag().
2015-02-03 10:44:33 -05:00
8adc59038c
Fixed #23617 -- Added get_pk_value_on_save()
...
The method is mainly intended for use with UUIDField. For UUIDField we
want to call the field's default even when primary key value is
explicitly set to None to match the behavior of AutoField.
Thanks to Marc Tamlyn and Tim Graham for review.
2015-02-03 09:23:44 -05:00
118b11221f
Fixed #24263 -- Prevented extra queries on BaseDateDetailView with a custom queryset.
...
Thanks jekka-ua for the report and patch.
2015-02-03 09:12:37 -05:00
2133f3157e
Fixed #24168 -- Allowed selecting a template engine in a few APIs.
...
Specifically in rendering shortcuts, template responses, and class-based
views that return template responses.
Also added a test for render_to_response(status=...) which was missing
from fdbfc980
2015-02-03 08:29:45 +01:00
62df1834b8
Fixed expressions test on Python 3.5; refs #23763 .
2015-01-31 19:59:17 -05:00
75303b01a9
Fixed #24245 -- Added introspection for database defaults.
...
Needed for tests for migrations handling of database defaults.
2015-01-31 12:33:11 -05:00
293fd5da5b
Reverted "Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows."
...
This reverts commit da79ccca1d
2015-01-30 12:51:12 -05:00
4c3bfe9053
Fixed #24211 -- Removed ValuesQuerySet() and ValuesListQuerySet().
...
Thanks Anssi Kääriäinen, Marc Tamlyn, and Tim Graham for the reviews.
2015-01-30 22:02:58 +07:00
5b74134f27
Fixed #24145 -- Added PUT & PATCH to CommonMiddleware APPEND_SLASH redirect error.
2015-01-29 15:23:01 -05:00
eb4cdfbdd6
Fixed #23940 -- Allowed model fields to be named `exact`.
...
An explicit `__exact` lookup in the related managers filters
was interpreted as a reference to a foreign `exact` field.
Thanks to Trac alias zhiyajun11 for the report, Josh for the investigation,
Loïc for the test name and Tim for the review.
2015-01-29 14:40:20 -05:00
18f3e79b13
Removed threading fallback imports.
...
Django imports threading in many other places without fallback.
2015-01-28 10:23:25 -05:00
cd91486213
Fixed flake8 warning.
2015-01-28 07:00:52 -05:00
24b2bc635e
Fixed #24137 -- Switched to HTTP reason phrases from Python stdlib.
2015-01-28 06:59:40 -05:00
7171bf755b
Refs #14030 -- Added repr methods to all expressions
2015-01-28 10:59:30 +11:00
f218a2ff45
Refs #24060 -- Added a test demonstrating reverse order isn't mutable
2015-01-28 10:59:30 +11:00
ac650d02cb
Fixed #24209 -- Prevented crash when parsing malformed RFC 2231 headers
...
Thanks Tom Christie for the report and review.
2015-01-27 20:12:22 +01:00
728b6fd9ca
Fixed #24219 -- Moved SelectDateWidget together with the other widgets
...
and deprecated django.forms.extras.
Thanks Berker Peksag and Tim Graham for the reviews.
2015-01-27 22:40:02 +07:00
3a4c9e1b43
Cleaned up some forms tests.
...
Thanks Berker Peksag and Tim Graham for the reviews. Refs #24219 .
2015-01-27 22:39:57 +07:00
8196e4bdf4
Fixed #24154 -- Backends can now check support for expressions
2015-01-27 12:20:06 +11:00
511be35779
Fixed #24220 - Allowed lazy objects for success_url
2015-01-26 17:58:55 +01:00
0386b97706
Fixed test_runner test failure on Python 3.5; refs #23763 .
...
Python change is http://bugs.python.org/issue22032
2015-01-23 16:23:32 -05:00
f8e4e4a935
Fixed warning leak in static.serve() test
...
Partial forward port of b1bf8d64fb#24193 .
2015-01-23 09:09:48 +01:00
4669b6a807
Fixed #24170 -- Implemented decompress for BaseRangeField widgets
2015-01-22 19:36:15 +00:00
38c17871bb
Fixed #24104 -- Fixed check to look on field.many_to_many instead of class instance
2015-01-22 18:41:19 +01:00
d450af8a26
Fixed small inconsistency when handling aggregate's default_alias.
...
Refs #14030 .
2015-01-22 00:44:14 +07:00
039465a6a7
Fixed typos in code comments.
2015-01-20 12:18:03 -05:00
64ecb3f07d
Refs #24163 -- Fixed failing Oracle test when migrating from ForeignKey to OneToOneField
...
Thanks Tim Graham for review
2015-01-20 16:19:11 +01:00
0ae94d0d31
Fixes #24169 -- More arrayfield specific lookups.
...
varchar()[] cannot compare itself to text[]
Thanks to joelburton for the patch.
2015-01-20 09:52:23 +00:00
61c102d010
Fixed #24183 -- Fixed wrong comparisons in Substr
2015-01-20 12:09:15 +11:00
7f20041bca
Fixed #24155 -- Maintained kwargs and import order in migration writer
...
Thanks Tomas Dobrovolny for the report and Tim Graham for the review.
2015-01-20 01:24:41 +01:00
b19b81b396
Fixed #24153 -- Fixed cookie test compatibility with Python 3.4.3+
2015-01-19 15:12:57 -05:00
378a0d27d6
Advanced deprecation warnings for Django 1.9.
2015-01-19 12:22:41 -05:00
33457cd3b0
Removed IPAddressField per deprecation timeline; refs #20439 .
2015-01-19 11:12:57 -05:00
5792e6a88c
Fixed #24163 -- Removed unique constraint after index on MySQL
...
Thanks Łukasz Harasimowicz for the report.
2015-01-19 16:52:26 +01:00
69c6a6868f
Fixed #24174 -- Fixed extra order by descending
2015-01-19 12:51:27 +11:00
2fa2068406
Removed an unused import and a flake8 exclude that caused it to be missed.
2015-01-18 20:02:15 -05:00
b84100e8e2
Removed usage of deprecated removetags in a template test.
2015-01-18 18:32:47 -05:00
6e13c0490d
Changed RedirectView.permanent to False per deprecation timeline; refs #21587 .
2015-01-18 17:43:06 -05:00
2b039d966f
Removed obsolete SQL generation methods.
2015-01-18 15:58:06 -05:00
7e8cf74dc7
Removed support for syncing apps without migrations per deprecation timeline.
...
Kept support for creating models without migrations when running tests
(especially for Django's test suite).
2015-01-18 15:58:06 -05:00
67a76500a5
Removed support for admin validators per deprecation timeline; refs #16905 .
2015-01-18 14:43:21 -05:00
2cd00424c4
Removed support for callable QuerySet arguments per deprecation timeline; refs #11629 .
2015-01-18 14:01:25 -05:00
d029fafea1
Removed utils.module_loading.import_by_path() per deprecation timeline; refs #21674 .
2015-01-18 12:51:15 -05:00
c3336e7e4f
Removed dumpdata --natural option and serializers use_natural_keys parameter.
...
Per deprecation timeline; refs #13252 .
2015-01-17 20:18:34 -05:00
8d959f73be
Removed obsolete deprecation warning in runtests.py
2015-01-17 19:41:46 -05:00
0622bca5d1
Removed the validate management command per deprecation timeline.
2015-01-17 19:12:03 -05:00
714277cb4c
Removed support for SplitDateTimeWidget with DateTimeField per deprecation timeline.
...
refs #8898
2015-01-17 18:49:44 -05:00
2c9e95639e
Removed ModelAdmin.get_formsets() per deprecation timeline; refs #20702 .
2015-01-17 18:02:35 -05:00
3b570dbcdb
Removed BaseDatabaseValidation.validate_field() per deprecation timeline.
2015-01-17 14:58:09 -05:00
65d55c4093
Cleaned up migration writer tests
2015-01-17 20:29:50 +01:00
bd93032191
Removed ssi/url tags from future per deprecation timeline; refs #21939 .
2015-01-17 13:29:52 -05:00
e278407b20
Removed unused imports from previous commit.
2015-01-17 13:22:52 -05:00
4a03d348c7
Removed BaseCommand.requires_model_validation per deprecation timeline.
2015-01-17 12:59:07 -05:00
df3f3bbe29
Removed utils.text.javascript_quote() per deprecation timeline; refs #21725 .
2015-01-17 12:41:49 -05:00
f0a1df0b01
Removed deprecated Chinese language codes; refs #18149 .
2015-01-17 11:23:43 -05:00
4aa089a9a9
Removed support for custom SQL per deprecation timeline.
2015-01-17 10:16:06 -05:00
a420f83e7d
Fixed #24055 -- Keep reference to view class for resolve()
2015-01-17 22:09:10 +07:00
67235fd4ef
Removed support for initial_data fixtures per deprecation timeline.
2015-01-17 09:59:25 -05:00
f635d75935
Removed support for old-style test database settings per deprecation timeline.
2015-01-17 09:55:18 -05:00
d038c547b5
Removed django.core.cache.get_cache() per deprecation timeline; refs #21012 .
2015-01-17 09:55:18 -05:00
1b0365ad34
Removed django.utils.tzinfo per deprecation timeline; refs #17262 .
2015-01-17 09:32:33 -05:00
fed25f1105
Removed compatibility with Python 3.2.
2015-01-17 09:00:17 -05:00
c820892eed
Removed django.utils.datastructures.SortedDict per deprecation timeline.
2015-01-17 08:40:23 -05:00
41f0d3d3bc
Removed FastCGI support per deprecation timeline; refs #20766 .
2015-01-17 08:32:31 -05:00
37b7776a01
Removed django.utils.datastructures.MergeDict per deprecation timeline; refs #18659 .
2015-01-17 08:13:36 -05:00
75f107b884
Removed request.REQUEST per deprecation timeline; refs #18659 .
2015-01-17 08:05:18 -05:00
61ad1ea92b
Removed django.utils.functional.memoize per deprecation timeline.
...
refs #21351 .
2015-01-17 07:55:32 -05:00
9ce36512fa
Removed backwards compatibility shims for "util" modules per deprecation timeline.
...
refs #17627 .
2015-01-17 07:40:12 -05:00
b952c3fc60
Removed django.utils.unittest per deprecation timeline.
2015-01-17 07:32:22 -05:00
ce78b954cf
Removed django.utils.importlib per deprecation timeline.
2015-01-17 07:14:21 -05:00
1c8b637ed9
Removed django.utils.dictconfig per deprecation timeline.
2015-01-17 07:13:51 -05:00
39d95fb6ad
Fixed #24092 -- Widened base field support for ArrayField.
...
Several issues resolved here, following from a report that a base_field
of GenericIpAddressField was failing.
We were using get_prep_value instead of get_db_prep_value in ArrayField
which was bypassing any extra modifications to the value being made in
the base field's get_db_prep_value. Changing this broke datetime
support, so the postgres backend has gained the relevant operation
methods to send dates/times/datetimes directly to the db backend instead
of casting them to strings. Similarly, a new database feature has been
added allowing the uuid to be passed directly to the backend, as we do
with timedeltas.
On the other side, psycopg2 expects an Inet() instance for IP address
fields, so we add a value_to_db_ipaddress method to wrap the strings on
postgres. We also have to manually add a database adapter to psycopg2,
as we do not wish to use the built in adapter which would turn
everything into Inet() instances.
Thanks to smclenithan for the report.
2015-01-16 16:15:16 -05:00
e8171daf0c
Fixed #24146 -- Fixed a missing fields regression in admin checks.
...
This allows using get_field() early in the app loading process.
Thanks to PirosB3 and Tim Graham.
2015-01-16 14:47:09 -05:00
b4ac232907
Fixed #24099 -- Removed contenttype.name deprecated field
...
This finsishes the work started on #16803 .
Thanks Simon Charette, Tim Graham and Collin Anderson for the
reviews.
2015-01-16 20:21:34 +01:00
5338ff4808
Fixed #24160 -- Fixed model_regress test on Windows; refs #24007 .
2015-01-16 11:59:08 -05:00
28db4af80a
Fixed #24135 -- Made RenameModel rename many-to-many tables.
...
Thanks Simon and Markus for reviews.
2015-01-15 20:34:33 -05:00
3f9ec12d9c
Fixed #23712 -- Fixed KeyError with BaseForm._html_output()
2015-01-15 20:19:53 -05:00
faf0d66a80
Fixed #23850 -- Fixed a migrations test failure on Mac OS X & Python 3
2015-01-15 19:45:43 -05:00
39b58ad95a
Fixed #24148 -- Documented a bug with case expressions in SQLite < 3.7.0
2015-01-15 19:42:05 -05:00
67dbc56ec8
Made an expressions_case test work without Pillow.
2015-01-15 14:02:58 -05:00
9801d419b9
Skipped a problematic file_storage test on Windows.
2015-01-14 15:00:27 -05:00
2d5da57f48
Fixed incorrect error message in Options.get_fields()
2015-01-14 14:51:05 -05:00
28308078f3
Fixed #22603 -- Reorganized classes in django.db.backends.
2015-01-14 14:16:20 -05:00
a6f144fd4f
Fixed a static view test on Windows.
2015-01-14 13:56:49 -05:00
88786afbff
Fixed #24147 -- Prevented managers leaking model during migrations
...
Thanks Tim Graham for the review.
2015-01-14 16:09:33 +01:00
baf2542c4f
Fixed DoS possibility in ModelMultipleChoiceField.
...
This is a security fix. Disclosure following shortly.
Thanks Keryn Knight for the report and initial patch.
2015-01-13 13:03:06 -05:00
a3bebfdc34
Ensured views.static.serve() doesn't use large memory on large files.
...
This issue was fixed in master by refs #24072 .
2015-01-13 13:03:06 -05:00
69b5e66738
Fixed is_safe_url() to handle leading whitespace.
...
This is a security fix. Disclosure following shortly.
2015-01-13 13:03:06 -05:00
316b8d4974
Stripped headers containing underscores to prevent spoofing in WSGI environ.
...
This is a security fix. Disclosure following shortly.
Thanks to Jedediah Smith for the report.
2015-01-13 13:03:05 -05:00
65246de7b1
Fixed #24031 -- Added CASE expressions to the ORM.
2015-01-12 18:15:34 -05:00
21b858cb67
Fixed #24060 -- Added OrderBy Expressions
2015-01-13 09:39:55 +11:00
f48e2258a9
Fixed #24133 -- Replaced formatting syntax in success_url placeholders
...
Thanks Laurent Payot for the report, and Markus Holtermann, Tim Graham
for the reviews.
2015-01-12 22:51:22 +01:00
5f7230e12f
Fixed #24124 (again) -- Updated tests with new default context_processors.
...
Thanks Collin for the review.
2015-01-12 22:31:44 +01:00
6b5113ec94
Made debug views not crash when there isn't a default template engine.
2015-01-12 21:01:34 +01:00
79deb6a071
Accounted for multiple template engines in template responses.
2015-01-12 21:01:34 +01:00
a3e783fe11
Deprecated passing a Context to a generic Template.render.
...
A deprecation path is required because the return type of
django.template.loader.get_template changed during the
multiple template engines refactor.
test_csrf_token_in_404 was incorrect: it tested the case when the
hardcoded template was rendered, and that template doesn't depend on the
CSRF token. This commit makes it test the case when a custom template is
rendered.
2015-01-12 21:01:34 +01:00
71b7668b75
Rewrapped TemplateSyntaxError in Jinja2 backend.
...
Changed import style to avoid confusion between Django's and Jinja2's
APIs.
2015-01-12 21:01:34 +01:00
4c413e231c
Fixed #17785 -- Preferred column names in get_relations introspection
...
Thanks Thomas Güttler for the report and the initial patch, and
Tim Graham for the review.
2015-01-12 19:58:47 +01:00
b75c707943
Fixed #24089 -- Added check for when ModelAdmin.fieldsets[1]['fields'] isn't a list/tuple.
2015-01-12 13:47:58 -05:00
eeb88123e7
Fixed #24129 -- Added indicator that migrations are rendering the initial state
...
Thanks Tim Graham for the review.
2015-01-12 19:23:46 +01:00
9f51d0c86d
Fixed test from refs #23913 when running tests in reverse.
2015-01-12 13:20:44 -05:00
bbbed99f62
Fixed #24123 -- Used all available migrations to generate the initial migration state
...
Thanks Collin Anderson for the input when creating the patch and Tim Graham for the review.
2015-01-12 18:39:18 +01:00
a7c256cb54
Fixed #9893 -- Allowed using a field's max_length in the Storage.
2015-01-12 09:09:18 -05:00
b5c1a85b50
Fixed #24118 -- Added --debug-sql option for tests.
...
Added a --debug-sql option for tests and runtests.py which outputs the
SQL logger for failing tests. When combined with --verbosity=2, it also
outputs the SQL for passing tests.
Thanks to Berker, Tim, Markus, Shai, Josh and Anssi for review and
discussion.
2015-01-12 08:16:08 +00:00
68a439a18d
Removed supports_binary_field flag as all backends support them
...
It was mainly for MySQL on Python 3, but now the current
recommended MySQL driver for Python 3 (mysqlclient) does support
binary fields, it is unneeded. Refs #20377 .
2015-01-11 23:34:47 +01:00
Markus Holtermann
Preston Timmons
Shai Berger
Andrei Kulakov
Tim Graham
László Károlyi
Claude Paroz
Jon Dufresne
Michael Angeletti
Stanislas Guerra
Nik Nyby
Aymeric Augustin
Aymeric Augustin
Anssi Kääriäinen
Marten Kenbeek
Loic Bistuer
foresmac
Marc Tamlyn
Andriy Sokolovskiy
Josh Smeaton
Simon Charette
Lukas Klein
Collin Anderson
Daniel Pyrathon
Aron Podrigal
Varun Sharma
Matthew Somerville
mlavin
Riccardo Magliocchetti
Josh Schneier
darkryder
Samuel Colvin
Raul Cumplido
Tomáš Ehrlich
Ng Zhi An
Andriy Sokolovskiy
Adam Taylor
Yang Liu
Michał Modzelewski
Carl Meyer
Muthiah Annamalai
Pavel Shpilev