5a6f70b428
Refs #27656 -- Updated django.core docstring verbs according to PEP 257.
2017-02-21 11:58:42 -05:00
8838d4dd49
Refs #23919 -- Replaced kwargs.pop() with keyword-only arguments.
2017-02-01 11:41:56 -05:00
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
dc8834cad4
Refs #23919 -- Removed unneeded force_str calls
2017-01-20 08:44:31 +01:00
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
c716fe8782
Refs #23919 -- Removed six.PY2/PY3 usage
...
Thanks Tim Graham for the review.
2017-01-18 16:21:28 +01:00
bcae045de0
Refs #26487 -- Removed unneeded ehlo() calls in SMTP backend.
...
starttls(), login(), and other connection methods already call
the method as needed.
2016-12-23 09:22:23 -05:00
9b9c8c4a81
Fixed #27368 -- Modifed BaseEmailBackend.__enter__() to close the connection if an exception occurs.
...
Fixes unclosed socket ResourceWarning in mail test.
Thanks Claude Paroz for the review.
2016-10-21 05:59:07 -07:00
d5c0eb7d68
Removed unused variable in django/core/mail/backends/smtp.py.
2016-10-05 11:16:45 -04:00
602bffe758
Fixed #27210 -- Allowed SMTPBackend to fail silently on a socket connection error.
2016-09-27 14:34:49 -04:00
42dc9d0400
Fixed #26210 -- Prevented SMTP backend from trying to send mail after a connection failure.
2016-09-21 16:45:10 -04:00
fe252c0a5a
Fixed #27131 -- Passed proper string type to SMTP connection login
...
Passing an Unicode string on Python 2 was crashing the connection.
Thanks slavugan@gmail.com for the report, and Tim Graham for the review.
2016-08-31 09:00:41 +02:00
004ba05bca
Fixed #27036 -- Made locmem email backend's send_messages() accept generators.
2016-08-08 20:13:29 -04:00
ec009ef1d8
Fixed #25986 -- Fixed crash sending email with non-ASCII in local part of the address.
...
On Python 3, sending emails failed for addresses containing non-ASCII
characters due to the usage of the legacy Python email.utils.formataddr()
function. This is fixed by using the proper Address object on Python 3.
2016-05-06 14:34:11 -04:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
8d789449c7
Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC.
2014-10-12 22:01:24 +02:00
5472d18e31
Fixed #23461 -- Added EMAIL_TIMEOUT setting
2014-09-13 09:33:21 -04:00
00535e8e6b
Fixed #20743 -- Added support for keyfile/certfile in SMTP connections.
...
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
2014-09-10 11:14:20 -04:00
1101467ce0
Limited lines to 119 characters in django/
...
refs #23395 .
2014-09-05 09:22:16 -04:00
4aa80149e7
Fixed #22327 -- Turned BaseEmailBackend into a context manager
...
Changed the BaseEmailBackend to allow usage as context manager to open
and close connections.
2014-03-31 14:08:51 -04:00
9d2c5b0420
Undelete the `return True` removed in 4e0a2fe.
...
This is quite important otherwise we don't close our connections to the
SMTP server.
2014-01-12 23:38:28 +00:00
bfe9052831
Decode mails using the message encoding.
2013-12-30 23:54:12 +01:00
c988745cca
Changed console and filebackend to use msg.as_bytes to output the data as it would get send via smtp.
2013-12-30 23:46:05 +01:00
5dfd824d38
Introduced as_bytes for SafeMIMEText (and other SafeMIME-classes).
...
This is to provide a consistent interface (namely bytes) for the smtp
backend which after all sends bytes over the wire; encoding with as_string
yields different results since mails as unicode are not really specified.
as_string stays for backwardscompatibilty mostly and some debug outputs.
But keep in mind that the output doesn't match as_bytes!
2013-12-28 18:35:17 +01:00
7548aa8ffd
More attacking E302 violators
2013-11-02 13:12:09 -07:00
3afde36d03
Undelete the login() call inadvertantly removed in 4e0a2fe59c
...
Refs #21271 .
2013-10-25 11:23:19 +02:00
4e0a2fe59c
Fixed #21271 -- Added timeout parameter to SMTP EmailBackend.
...
Thanks Tobias McNulty and Tim Graham for discussions and code review.
Thanks Andre Cruz the suggestion and initial patch.
2013-10-24 20:38:00 -04:00
9bf5610890
Start attacking E231 violations
2013-10-24 10:30:03 -07:00
1dae4ac177
Whitespace cleanup.
...
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
2013-10-10 16:49:20 -04:00
20472aa827
Fixed #21189 : Cleaned up usage of bare except clauses.
...
Thanks to berkerpeksag for the report and to claudep
for the review.
2013-10-05 11:50:03 +02:00
b2b763448f
Fixed #20841 -- Added messages to NotImplementedErrors
...
Thanks joseph at vertstudios.com for the suggestion.
2013-09-10 11:09:59 -04:00
59ebe39812
Fixed #17471 -- Added smtplib.SMTP_SSL connection option for SMTP backend
...
Thanks dj.facebook at gmail.com for the report and initial patch
and Areski Belaid and senko for improvements.
2013-07-11 22:00:08 +02:00
cd1ca26702
Adds generators support for email backends that do not support it.
2013-04-03 19:42:31 -07:00
850630b4b7
Replaced deprecated sslerror by ssl.SSLError
...
The exact conditions on which this exception is raised are not
known, but this replacement is the best guess we can do at this
point.
2013-01-03 22:16:43 +01:00
ffa50ca352
Fixed #19382 -- Stopped smtp backend raising exception when already closed
...
Thanks Sebastian Noack for the report and the initial patch.
2013-01-03 20:41:45 +01:00
1b3f832ab7
Fixed #19134 -- Allowed closing smtp backend when the server is stopped
...
Thanks Sebastian Noack for the report and the initial patch.
2013-01-03 18:49:00 +01:00
1620c27936
Fixed #19186 -- Fixed sending mail with unicode content on Python 3
...
Thanks alex_po for the report and Luke Plant for the analysis.
2012-11-14 10:43:33 +01:00
8599f64e54
Fixed #18861 -- Triggered message validation with locmem email backend
...
Thanks Bruno Renié for the report and the initial patch.
2012-09-22 15:17:13 +02:00
335a9f9cf1
Removed many uses of bare "except:", which were either going to a) silence real issues, or b) were impossible to hit.
2012-09-07 15:08:07 -04:00
3cb2457f46
[py3] Replaced basestring by six.string_types.
2012-07-22 09:29:54 +02:00
e0fce8706d
Switch to using context managers for acquiring and releasing locks.
2012-06-23 08:11:15 -07:00
3904b74a3f
Fixed #18013 -- Use the new 'as' syntax for exceptions.
...
Thanks Clueless for the initial patch.
Note that unittest has been purposely left out (external package only used by Python 2.6).
2012-04-29 20:57:15 +02:00
3bd23ee96f
Fixed #15750 -- Handle empty mail server credentials gracefully. Thanks, LeandroSouza and bedmondmark.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16494 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-03 17:56:05 +00:00
13864703bc
Removed a bunch more Python 2.4 workarounds now that we don't support that version. Refs #15702 -- thanks to jonash for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15927 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-28 02:11:19 +00:00
11997218ee
Fixed #15042 -- Ensured that email addresses without a domain can still be mail recipients. Patch also improves the IDN handling introduced by r15006, and refactors the test suite to ensure even feature coverage. Thanks to net147 for the report, and to Łukasz Rekucki for the awesome patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15211 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-15 05:55:24 +00:00
d4ef841495
Fixed #14301 -- Further refine changes made in r14216 to support non-ASCII characters in email addresses. Thanks, Claude Peroz and Andi Albrecht.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15006 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-21 15:26:49 +00:00
90a9f81d37
Fixed #12147 -- Replaced use of try-except-finally to allow for Python 2.4 support. Thanks to knutin for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11721 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-11-04 11:38:06 +00:00
77b602a4ab
Fixed #11849 -- Corrected handling of use_tls in the SMTP mail handler. Thanks to aromano for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11714 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-11-04 01:59:05 +00:00
aba5389326
Fixed #10355 -- Added an API for pluggable e-mail backends.
...
Thanks to Andi Albrecht for his work on this patch, and to everyone else that contributed during design and development.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11709 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-11-03 12:53:26 +00:00
Anton Samarchyan
Vytis Banaitis
chillaranand
Claude Paroz
Simon Charette
Tim Graham
Jon Dufresne
Vesteinn Snaebjarnarson
levental
Antoine Fontaine
Sergei Maertens
Florian Apolloner
José Padilla
Andi Albrecht
Daniel Neuhäuser
Marc Tamlyn
Alex Gaynor
SusanTan
Baptiste Mispelon
Gregor MacGregor
Brendon Crawford
Alex Gaynor
Aymeric Augustin
Jannis Leidel
Adrian Holovaty
Russell Keith-Magee