Jacob Kaplan-Moss
2570954a9a
Fixed #3453 : introduced a new template variable resolution system by Brian Harring (thanks!). The upshot is that variable resolution is about 25% faster, and you should see a measurable performance increase any time you've got long or deeply nested loops.
...
Variable resolution has changed behind the scenes -- see the note in templates_python.txt -- but template.resolve_variable() still exists. This should be fully backwards-compatible.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6399 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-21 04:00:32 +00:00
Adrian Holovaty
03652c7f2b
Fixed #3091 -- django.contrib.comments views now accept extra_context and context_processors arguments. Thanks, Eric Floehr and __hawkeye__
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6236 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-14 22:36:15 +00:00
Malcolm Tredinnick
9d7dc0c4bf
Fixed #4189 -- Fixed crashes in a couple of corner cases in the comments app. Not a perfect fix (see ticket), but it will do as a holdover until the new comments framework is in place.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5848 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-08-11 10:50:39 +00:00
Gary Wilson Jr
212ee65be7
Fixed #2101 -- Renamed `maxlength` argument to `max_length` for oldforms `FormField`s and db model `Field`s. This is fully backwards compatible at the moment since the legacy `maxlength` argument is still supported. Using `maxlength` will, however, issue a `PendingDeprecationWarning` when used.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5803 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-08-05 05:14:46 +00:00
Malcolm Tredinnick
29891add3d
Fixed #4887 -- Fixed another place where template tag arguments are used
...
directly as function keyword args. Thanks, Brian Rosner.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5715 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-07-16 04:54:49 +00:00
Malcolm Tredinnick
953badbea5
Merged Unicode branch into trunk (r4952:5608). This should be fully
...
backwards compatible for all practical purposes.
Fixed #2391 , #2489 , #2996 , #3322 , #3344 , #3370 , #3406 , #3432 , #3454 , #3492 , #3582 , #3690 , #3878 , #3891 , #3937 , #4039 , #4141 , #4227 , #4286 , #4291 , #4300 , #4452 , #4702
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5609 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-07-04 12:11:04 +00:00
Malcolm Tredinnick
880e3cfaa6
Backed out the changes in [5482] for a bit whilst some more investigation into
...
side-effects is done. Refs #4565 .
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5511 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-22 07:15:04 +00:00
Malcolm Tredinnick
bccb8897e6
Fixed #4565 -- Changed template rendering to use iterators, rather than
...
creating large strings, as much as possible. This is all backwards compatible.
Thanks, Brian Harring.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5482 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-17 07:11:37 +00:00
Malcolm Tredinnick
8728e0f353
Fixed #4404 -- Fixed LatestCommentsFeed query problem. Thanks, SmileyChris.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5408 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-01 11:58:17 +00:00
Malcolm Tredinnick
439cb4047f
Fixed #4040 -- Changed uses of has_key() to "in". Slight performance
...
improvement and forward-compatible with future Python releases. Patch from Gary
Wilson.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5091 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-04-26 13:30:48 +00:00
Malcolm Tredinnick
5dfe74f221
Fixed #3185 -- Made values for login, logout and post-login redirect URLs
...
configurable. This is a combined patch from Vasily Sulatskov, Marc Fargas and
Collin Grady.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5072 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-04-25 08:49:57 +00:00
Russell Keith-Magee
7be1f44053
Fixed #3473 -- Corrected access to get in manager (probably introduced as part of magic-removal conversion).
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4873 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-03-31 02:23:34 +00:00
Malcolm Tredinnick
6c4757729b
Revert [4485] in order to fix accidental mod_python breakage. Refs #2920 .
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4486 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-02-11 23:50:35 +00:00
Russell Keith-Magee
0e924c70b1
Refs #2920 -- Replaced implicit uses of _() with explicit imports or calls to gettext(). At some point post 0.96, we need to remove the calls that put _ into the builtins.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4485 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-02-11 06:20:52 +00:00
Adrian Holovaty
706fcec164
Copied django.forms to django.oldforms and changed all code to reference django.oldforms instead of django.forms. Updated docs/forms.txt to add 'Forwards-compatibility' section that says you should not be using django.oldforms for any new projects.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4208 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-12-15 18:00:50 +00:00
Jacob Kaplan-Moss
a14dba5eed
Fixed #2848 : broken doctest in comment app. Thanks, dummy@habmalnefrage.de
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4049 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-11-07 05:20:00 +00:00
Jacob Kaplan-Moss
ed27ff9aa9
Fixed ngettext bug in comments post view
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3936 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-10-25 21:56:17 +00:00
Adrian Holovaty
6b384e828d
Fixed #2826 -- Added .is_authenticated() check before login() in comments views
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3929 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-10-24 17:00:03 +00:00
Jacob Kaplan-Moss
1687b025dc
Part 3 of pedant day: replaced all tabs in Django with spaces. Python the way Guido intended it, baby!
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3415 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-21 20:48:17 +00:00
Jacob Kaplan-Moss
5c5ca53b70
Fixed bug in comment feed turned up by pyflakes.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3413 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-21 19:12:51 +00:00
Jacob Kaplan-Moss
17d0bd1512
Fixed a bunch of spurious imports, typos, and other small errors turned up by a pass through PyFlakes. This covers about the first third of the errors.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3411 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-21 17:11:13 +00:00
Malcolm Tredinnick
51705f60b1
Fixed #2332 -- Introduced is_authenticated() method on User and AnonymousUser classes. Recommended its use over is_anonymous in the docs. Changed internal Django use to match this recommendation. Thanks to SmileyChris and Gary Wilson for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3360 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-19 02:09:26 +00:00
Adrian Holovaty
4b11b43d0b
Fixed #2283 -- Fixed XHTML-strict validation error in comment templates
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3283 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-07 03:57:50 +00:00
Jacob Kaplan-Moss
aab3a418ac
Merged multi-auth branch to trunk. See the authentication docs for the ramifications of this change. Many, many thanks to Joseph Kocherhans for the hard work!
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3226 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-06-28 16:37:02 +00:00
Adrian Holovaty
2837455878
Fixed #2168 -- Made comment templates more accessible
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3203 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-06-26 00:48:12 +00:00
Adrian Holovaty
fd16f1468a
Fixed #1981 -- Fixed bug in feeds.py for comments
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2983 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-26 04:21:36 +00:00
Adrian Holovaty
7f2ca03c0e
Fixed #1997 -- Changed comments.py views to use relative URL for redirects. Thanks, phil@produxion.net
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2981 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-26 04:06:46 +00:00
Adrian Holovaty
a0872543a7
Fixed #1722 -- Fixed bug in CommentManager.user_is_moderator(). Thanks, Jure Cuhalev
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2848 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-05 12:52:15 +00:00
Jacob Kaplan-Moss
ceecba2973
Fixed #1740 -- django.contrib.comments no longer uses old-style DB API (thanks, ubernostrum)
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2823 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-03 19:23:44 +00:00
Adrian Holovaty
f69cf70ed8
MERGED MAGIC-REMOVAL BRANCH TO TRUNK. This change is highly backwards-incompatible. Please read http://code.djangoproject.com/wiki/RemovingTheMagic for upgrade instructions.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2809 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-02 01:31:56 +00:00
Adrian Holovaty
aae4f9701c
Removed use of deprecated template_loader from [2230]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2233 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-02-02 15:00:34 +00:00
Georg Bauer
1d6a56dae2
fixed #1287 - comment forms are now translateable and overrideable
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2230 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-02-02 10:25:15 +00:00
Adrian Holovaty
3ede006fc9
Fixed #911 -- Made template system scoped to the parser instead of the template module. Also changed the way tags/filters are registered and added support for multiple arguments to {% load %} tag. Thanks, rjwittams. This is a backwards-incompatible change for people who've created custom template tags or filters. See http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges for upgrade instructions.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@1443 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-11-26 22:46:31 +00:00
Adrian Holovaty
cfc5786d03
Fixed missing {% load i18n %} tag in comments FREE_COMMENT_FORM template
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@1378 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-11-23 21:56:21 +00:00
Adrian Holovaty
d215cbd63a
Added translation strings to django.contrib.comments. Taken from new-admin.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@1364 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-11-23 15:42:09 +00:00
Jacob Kaplan-Moss
1da036040c
Added feed configurations for django.contrib.comments
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@1281 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-11-18 16:20:26 +00:00
Adrian Holovaty
a7efb3939f
Converted load_and_render() calls to render_to_response() because of [664].
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@665 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-09-22 22:26:56 +00:00
Adrian Holovaty
a269a2058a
Converted django.contrib.comments.views.* to use load_and_render
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@661 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-09-22 05:32:47 +00:00
Adrian Holovaty
e07fee6511
Fixed bug in contrib comment_form template tag when hard-coded object IDs are used
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@590 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-09-01 03:06:47 +00:00
Adrian Holovaty
cb6aa1035b
Fixed #407 -- Code no longer assumes request.META['REMOTE_ADDR'] exists. Thanks, sune.kirkeby@gmail.com
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@580 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-08-31 16:27:59 +00:00
Adrian Holovaty
5569c75eb6
Refactored comment templatetags to remove redundant 'tag_name' parameter. Also added an 'extra_kwargs' hook to CommentListNode
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@578 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-08-30 21:33:12 +00:00
Adrian Holovaty
25264c8604
Fixed #122 -- BIG, BACKWARDS-INCOMPATIBLE CHANGE. Changed model syntax to use fieldname=FieldClass() syntax. See ModelSyntaxChangeInstructions for important information on how to change your models
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@549 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-08-25 22:51:30 +00:00
Adrian Holovaty
07889c13a6
Fixed #1 -- Added anonymous session support via middleware and request.session. Removed the former request.session, which wasn't being used anyway. Removed auth.Session model. See the BackwardsIncompatibleChanges wiki page for IMPORTANT notes on code you'll have to change and a DB table you'll have to create.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@518 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-08-16 22:54:05 +00:00
Adrian Holovaty
006e9e789b
Fixed #180 -- Removed 'enctype' from FREE_COMMENT_FORM template in contrib.comments.templatetags
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@377 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-08-01 20:07:31 +00:00
Adrian Holovaty
8b36eb11d3
Gave comments.FreeComment a get_absolute_url() method
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@354 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-30 18:56:36 +00:00
Adrian Holovaty
786c750c40
Fixed #163 -- Added 'pk' database API option, which is a shorthand for (primary_key)__exact
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@316 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-26 16:11:43 +00:00
Adrian Holovaty
8b3c05afa5
Fixed #146 -- Changed order_by and ordering parameters to be less verbose. The old syntax is still supported but will not be supported by first release.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@292 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-22 13:02:27 +00:00
Jacob Kaplan-Moss
1b8c4c4556
Argh: fixed another bug in [244]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@246 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-20 17:12:12 +00:00
Jacob Kaplan-Moss
067f56d93d
Fixed really dumb bug in [244]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@245 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-20 17:09:39 +00:00
Jacob Kaplan-Moss
890bd5b0d2
Added "reversed" option to get_comment_list templatetag to return comments in most-recent-first order.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@244 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-20 17:07:30 +00:00
Adrian Holovaty
897d24b220
Fixed #95 -- Added SECRET_KEY setting instead of hard-coding keys that are shared for every Django installation. 'django-admin.py startproject' now creates a random SECRET_KEY. The auth and comments modules, and the admin middleware, all use SECRET_KEY now, instead of hard-coded values.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@230 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-20 00:37:45 +00:00
Adrian Holovaty
f4c581158d
Renamed CMSRequest to DjangoRequest, and CMSContext to DjangoContext. Old code will still work.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@57 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-15 17:09:01 +00:00
Adrian Holovaty
fda1f68492
Fixed bug in [29]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@31 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-14 18:37:10 +00:00
Adrian Holovaty
d9d6345e3f
Fixed bug in [29]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@30 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-14 18:34:52 +00:00
Adrian Holovaty
f98724e57a
Fixed bug in django.contrib.comments urlconf
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@29 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-14 18:32:59 +00:00
Adrian Holovaty
0bc849ff89
Created django.contrib and moved comments into it
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@28 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-07-14 18:20:03 +00:00