Tim Graham
fd8a7a5313
Fixed #29723 -- Fixed crash if InlineModelAdmin.has_add_permission() doesn't accept the obj argument.
...
* Refs #27991 -- Added testing for ModelAdmin.get_inline_instances() if the inline's has_add_permission() doesn't accept 'obj'.
* Fixed #29723 -- Fixed crash if InlineModelAdmin.has_add_permission() doesn't accept the obj argument.
2018-08-30 11:22:50 +02:00
mackong
c832885a3e
Fixed #29426 -- Made UUID inputs in the admin match the width of a UUID.
2018-08-18 10:16:22 -04:00
Jon Dufresne
09ee3b6fe3
Fixed #29663 -- Made admin change view redirect to changelist with view permission.
2018-08-17 11:13:06 -04:00
Jon Dufresne
57f16655cd
Added ModelAdmin._response_post_save() to avoid code duplication.
2018-08-17 10:51:57 -04:00
Jon Dufresne
cd790ed1a6
Refs #8936 -- Added ModelAdmin.has_view_or_change_permission().
2018-08-16 09:49:06 -04:00
Clément Mangin
64e1a271f5
Fixed #29637 -- Fixed admin change form crash if the user doesn’t have the add permission to a TabularInline.
...
Regression in 825f0beda8
.
2018-08-10 11:20:43 -04:00
Carlton Gibson
958c7b301e
Fixed #29419 -- Allowed permissioning of admin actions.
2018-06-18 15:07:29 -04:00
Paulo
553617e613
Fixed #29487 -- Accounted for object level permissions when calculating change view's read-only fields.
...
Thanks Matthew Frazier for the report and fix.
2018-06-15 21:54:22 -04:00
Henk Kahlfuß
3eb9127678
Fixed #23869 -- Made ModelAdmin.get_deleted_objects() use has_delete_permission() for permissions checking.
2018-06-15 10:31:08 -04:00
Carlton Gibson
b30f9b131c
Refs #29419 , #8936 -- Removed change permission requirement for admin actions.
...
Partially reverted 825f0beda8
.
2018-06-13 14:49:28 -04:00
Tim Graham
e9bd1a3e12
Refs #28462 -- Fixed 'invalid escape sequence' warning on Python 3.6+.
2018-06-06 11:40:24 -04:00
Adam Donaghy
b18650a263
Fixed #28462 -- Decreased memory usage with ModelAdmin.list_editable.
...
Regression in 917cc288a3
.
2018-06-01 10:41:05 -04:00
Ramiro Morales
f40e71a957
Fixed #29417 -- Corrected two admin page titles for view-only users.
2018-05-23 11:02:37 -04:00
olivierdalang
825f0beda8
Fixed #8936 -- Added a view permission and a read-only admin.
...
Co-authored-by: Petr Dlouhy <petr.dlouhy@email.cz>
Co-authored-by: Olivier Dalang <olivier.dalang@gmail.com>
2018-05-16 06:44:55 -04:00
Jon Dufresne
be6ca89396
Fixed #27991 -- Added obj arg to InlineModelAdmin.has_add_permission().
...
Thanks Vladimir Ivanov for the initial patch.
2018-04-04 19:21:50 -04:00
Becky Smith
8116e588db
Fixed #17962 -- Added ModelAdmin.get_deleted_objects().
2018-02-24 20:41:43 -05:00
Tim Graham
9822d88ca0
Removed using argument from admin's get_deleted_objects().
2018-02-24 09:21:13 -05:00
Tim Graham
16436f3751
Removed unused opts argument from admin's get_deleted_objects().
...
Unused since e12b3199d0
.
2018-02-21 13:32:13 -05:00
Alexander Gaevsky
ef2512b2ff
Fixed #25790 -- Allowed disable column sorting in the admin changelist.
...
Thanks Ramiro Morales for completing the patch.
2018-02-07 17:46:28 -05:00
Jon Dufresne
ff05de760c
Fixed #29038 -- Removed closing slash from HTML void tags.
2018-01-21 02:09:10 -05:00
Дилян Палаузов
a38ae914d8
Fixed #28996 -- Simplified some boolean constructs and removed trivial continue statements.
2018-01-12 12:44:50 -05:00
Vasilis Aggelou
777f216d55
Fixed #15522 -- Added ModelAdmin.delete_queryset() to customize "delete selected objects" deletion.
2018-01-05 18:28:45 -05:00
Tim Graham
acc8dd4142
Fixed #28984 -- Made assorted code simplifications.
2018-01-03 13:24:02 -05:00
Дилян Палаузов
4c599ece57
Fixed #28930 -- Simplified code with any() and all().
2017-12-26 17:11:15 -05:00
Nick Pope
d13a9e44de
Fixed #28909 -- Simplified code using tuple/list/set/dict unpacking.
2017-12-11 07:08:45 -05:00
Sergey Fedoseev
b728ab22e1
Simplified BaseModelAdmin.lookup_allowed() a bit.
2017-12-06 23:54:51 +05:00
Tim Graham
81057645f6
Fixed #28871 -- Fixed initialization of autocomplete widgets in "Add another" inlines.
...
Also allowed autocomplete widgets to work on AdminSites with a name other
than 'admin'.
2017-12-01 22:14:32 -05:00
Krzysztof Nazarewski
244cc40155
Fixed #26184 -- Allowed using any lookups in ModelAdmin.search_fields.
...
Thanks Krzysztof Nazarewski for the initial patch.
2017-11-18 19:33:52 -05:00
Claude Paroz
0cf00769ad
Fixed #28585 -- Calculated admin's change form multipart context variable from forms and formsets
...
Thanks Tim Graham for the review.
2017-11-07 19:06:32 -05:00
Sjoerd Job Postmus
df41b5a05d
Fixed #28593 -- Added a simplified URL routing syntax per DEP 0201.
...
Thanks Aymeric Augustin for shepherding the DEP and patch review.
Thanks Marten Kenbeek and Tim Graham for contributing to the code.
Thanks Tom Christie, Shai Berger, and Tim Graham for the docs.
2017-09-20 18:04:42 -04:00
Johannes Hoppe
94cd8efc50
Fixed #14370 -- Allowed using a Select2 widget for ForeignKey and ManyToManyField in the admin.
...
Thanks Florian Apolloner and Tim Graham for review and
contributing to the patch.
2017-09-18 13:48:02 -04:00
Mariusz Felisiak
0ec0e5029c
Removed unnecessary parens in various code.
2017-09-13 21:20:29 -04:00
Mariusz Felisiak
0214f367bc
Merged isinstance() calls.
2017-09-13 15:00:45 -04:00
Tim Graham
e5bd585c6e
Fixed #28543 -- Prevented ManyToManyField.value_from_object() from being lazy.
...
Previously, it was a QuerySet which could reevaluate to a new value if the
model's data changes. This is inconsistent with other Field.value_from_object()
methods.
This allows reverting the fix in the admin for refs #27998 .
2017-08-31 09:34:44 -04:00
Sergey Fedoseev
fac74b84a3
Used OrderedDict.fromkeys() to initialize OrderedDict with None values.
2017-08-23 11:40:17 -04:00
Simon Meers
7bba82453c
Fixed #28496 -- Added ModelAdmin.get_changelist_instance().
2017-08-22 08:17:26 -04:00
Johannes Hoppe
c19b56f633
Fixed #28377 -- Made combining form Media retain relative asset order.
...
Thanks Florian Apolloner, Mariusz Felisiak, and Tim Graham for reviews.
2017-07-20 11:06:30 -04:00
Lincoln Smith
15b465c584
Fixed #27998 -- Made ManyToManyField changes logged in admin's object history.
2017-06-14 13:07:06 -04:00
Tim Graham
c16aa69101
Factored shared Inline/ModelAdmin.get_fields() logic into BaseModelAdmin.
...
BaseModelAdmin.get_fields() was previously unused/untested.
2017-06-07 17:11:02 -04:00
Tim Graham
5a52d932ef
Replaced Model._get_pk_val() with pk property.
...
Model.pk was added after _get_pk_val() and many places weren't simplified.
2017-06-05 15:20:34 -04:00
Paulo
b7f99f84bc
Fixed #28262 -- Fixed incorrect DisallowedModelAdminLookup when a nested reverse relation is in list_filter.
2017-06-05 10:29:54 -04:00
Jon Dufresne
21046e7773
Fixed #28249 -- Removed unnecessary dict.keys() calls.
...
iter(dict) is equivalent to iter(dict.keys()).
2017-05-27 19:08:46 -04:00
Claude Paroz
301de774c2
Refs #27795 -- Replaced many force_text() with str()
...
Thanks Tim Graham for the review.
2017-04-27 09:10:02 +02:00
Claude Paroz
8346680e1c
Refs #27795 -- Removed unneeded force_text calls
...
Thanks Tim Graham for the review.
2017-03-04 18:18:21 +01:00
Anton Samarchyan
b27166b769
Fixed #27356 -- Fixed ModelAdmin.lookup_allowed() for some nested relations.
2017-02-07 19:33:26 -05:00
Claude Paroz
c651331b34
Converted usage of ugettext* functions to their gettext* aliases
...
Thanks Tim Graham for the review.
2017-02-07 09:04:04 +01:00
Anton Samarchyan
5411821e3b
Refs #27656 -- Updated django.contrib docstring verb style according to PEP 257.
2017-02-04 16:39:28 -05:00
Tim Graham
29f607927f
Fixed spelling of "nonexistent".
2017-02-03 08:01:45 -05:00
Claude Paroz
3b2e28fc85
Used model_ngettext in two more places
2017-01-31 08:48:17 +01:00
Claude Paroz
fee42fd99e
Refs #23919 -- Replaced usage of django.utils.http utilities with Python equivalents
...
Thanks Tim Graham for the review.
2017-01-26 19:49:03 +01:00
chillaranand
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
Claude Paroz
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
Claude Paroz
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
Claude Paroz
f3c43ad1fd
Refs #23919 -- Removed python_2_unicode_compatible decorator usage
2017-01-18 13:44:34 +01:00
Claude Paroz
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
Tim Graham
8ea541e6a2
Refs #2856 -- Removed redundant escaping in admin's "Perhaps it was deleted?" message.
2017-01-04 10:22:17 -05:00
Karen Tracey
27267afc41
Fixed #2856 -- Replaced some 404s with messages in admin.
...
Instead of a 404, return a redirect to admin index page with a message
indicating that the requested object does not exist. This avoids the
admin returning 404 from "Recent Actions" links for deleted objects.
2017-01-03 11:31:05 -05:00
Adonys Alea Boffill
8ba01d1e42
Fixed #26543 -- Prevented "confirm form submission" browser prompt when reloading after an admin actions failure.
2016-12-23 17:29:24 -05:00
Michael Scott
1e629928e9
Fixed #27313 -- Allowed overriding admin popup response template.
2016-12-14 18:10:56 -05:00
Vinay Karanam
4a246a02bd
Refs #17235 -- Made MultiPartParser leave request.POST immutable.
2016-12-07 08:28:46 -05:00
Ramin Farajpour Cami
0a63ef3f61
Fixed #27463 -- Fixed E741 flake8 warnings.
2016-11-14 17:40:28 -05:00
Ramin Farajpour Cami
967be82443
Fixed E305 flake8 warnings.
2016-11-14 12:30:46 -05:00
Zach Borboa
bf91be83d5
Fixed #24941 -- Added ModelAdmin.get_exclude().
...
Thanks Ola Sitarska for the initial patch.
2016-10-07 18:49:28 -04:00
Tim Graham
e1b4360adc
Fixed #27273 -- Added a construct_change_message() admin utility function.
2016-10-05 08:02:33 -04:00
François Freitag
aa9569fce1
Fixed #27218 -- Returned LogEntry instances from ModelAdmin.log_*() methods.
2016-10-04 14:08:53 -04:00
Claude Paroz
67eee5e4fa
Fixed #27302 -- Fixed ModelAdmin.construct_change_message() changed field detection
...
Thanks Ramiro Morales for the report and Tim Graham for the review.
2016-10-01 20:14:27 +02:00
Jibodeah
9459ec82aa
Fixed #26170 -- Made ModelAdmin views run transactions on the correct database.
...
Thanks juntatalor for the initial patch.
2016-09-14 16:06:39 -04:00
Mattias Loverot
2315114090
Fixed #27067 -- Deprecated string_concat() in favor of format_lazy().
2016-08-25 16:12:40 -04:00
Berker Peksag
3c97ba2a0d
Replaced property() usage with decorator in a couple places.
2016-08-24 17:23:16 -04:00
Stanislav Karpov
b387189d86
Fixed #26919 -- Added the action form's media in the changelist view.
2016-08-11 19:35:31 -04:00
Pyie Zone
054e74420b
Refs #16501 , #26474 -- Added xregexp.js source file.
2016-06-06 09:25:02 -04:00
Collin Anderson
38c43b2a5c
Refs #24227 -- Partially reverted replacement of M2M isinstance checks by field.many_to_many.
...
This fixes django-taggit and reflects some places where duck-typing may not
be appropriate.
2016-05-11 10:29:01 -04:00
marysia
b9290b1d49
Fixed #26449 -- Merged admin's FORMFIELD_FOR_DBFIELD_DEFAULTS with formfield_overrides.
...
Useful for overriding the DateTimeField widget.
2016-05-07 19:52:45 -04:00
Markus Amalthea Magnuson
08cd6a0e56
Fixed #16327 -- Redirected "Save as new" to change view instead of the changelist.
2016-04-20 11:31:44 -04:00
Tim Graham
df8d8d4292
Fixed E128 flake8 warnings in django/.
2016-04-08 09:51:06 -04:00
Tim Graham
2cd2d18851
Fixed W503 flake8 warnings.
2016-04-04 17:14:26 -04:00
Akshesh
49ac10b4de
Fixed #26235 -- Handled ProtectedError in a POST to admin's delete_view().
2016-03-21 19:25:27 -04:00
Claude Paroz
983c158da7
Refs #24227 -- Replaced M2M isinstance checks by field.many_to_many
...
Thanks Markus Holtermann, Collin Anderson and Tim Graham for the reviews.
2016-03-19 09:24:27 +01:00
bphillips
917cc288a3
Fixed #11313 -- Made ModelAdmin.list_editable more resilient to concurrent edits.
...
Allowed admin POSTed bulk-edit data to use modeladmin.get_queryset()
so that the ids in the POST data have a chance to match up even if
the objects on the current page changed based on the ordering.
2016-02-01 16:05:01 -05:00
Myk Willis
62f3acc70a
Fixed incorrect permissions check for admin's "Save as new".
...
This is a security fix.
2016-02-01 11:57:00 -05:00
Alexander Gaevsky
c79852acee
Fixed #14402 -- Removed clearing of help_text for ManyToManyField's raw_id_fields.
2016-01-30 12:42:47 -05:00
Tim Graham
3541ca1504
Refs #25165 -- Fixed JSON serialization for delete popup in the admin.
2016-01-09 13:35:58 -05:00
Claude Paroz
cf7894be88
Fixed #21113 -- Made LogEntry.change_message language independent
...
Thanks Tim Graham for the review.
2016-01-08 20:34:59 +01:00
Alexander Gaevsky
ade54ffa34
Refs #25165 -- Fixed JSON serialization for add/edit popup in the admin.
...
Forwardport of test in o839d71d8562abe0b245024e55ca1d02a45e58fd from stable/1.9.x
(refs #25997 ).
2016-01-08 12:28:32 -05:00
Tim Graham
822a03b3e4
Refs #25165 -- Fixed failure of admin's "Add another" popup to close.
...
Thanks Thomas Grainger for the fix.
2016-01-08 11:41:01 -05:00
Marten Kenbeek
16411b8400
Fixed #26013 -- Moved django.core.urlresolvers to django.urls.
...
Thanks to Tim Graham for the review.
2015-12-31 14:21:29 -05:00
Tim Graham
dbb0df2a0e
Fixed #25985 -- Updated signature of ModelAdmin.formfield_for_* to make request a positional argument.
2015-12-29 12:49:14 -05:00
Karen Tracey
5399ccc0f4
Fixed #494 -- Added ability to specify classes on admin inline fieldsets.
...
This includes the ability to collapse inlines by specifying a class named
'collapse'.
2015-12-21 13:50:06 -05:00
Johannes Hoppe
cf546e11ac
Fixed #21221 -- Made form Media and static template tag use staticfiles if installed.
2015-12-10 14:30:19 -05:00
Thomas Grainger
d638cdc42a
Fixed #25165 -- Removed inline JavaScript from the admin.
...
This allows setting a Content-Security-Policy HTTP header
(refs #15727 ).
Special thanks to blighj, the original author of this patch.
2015-12-05 15:51:57 -05:00
Anton Baklanov
80bcbecd4a
Fixed #19361 -- Added link to object's change form in admin's post-save message.
...
Thanks Roel Kramer for tests.
2015-11-19 15:04:32 -05:00
Simon Charette
9dcfecb7c6
Fixed #25622 -- Accounted for generic relations in the admin to field validation
...
Thanks to Jonathan Liuti for the report and Tim Graham for the review.
2015-10-29 13:13:19 -04:00
Malcolm Box
1d8eb0cae5
Fixed #25374 -- Made ModelAdmin checks work on instances instead of classes.
...
This allows dynamically-generated attributes to be specified in
checked ModelAdmin attributes without triggering errors.
2015-09-11 09:28:34 -04:00
Ola Sitarska
f2f8972def
Fixed #25135 -- Deprecated the contrib.admin allow_tags attribute.
...
Thanks Jaap Roes for the idea and initial patch.
2015-09-08 19:13:43 -04:00
Edward Henderson
f8cc464452
Fixed #16501 -- Added an allow_unicode parameter to SlugField.
...
Thanks Flavio Curella and Berker Peksag for the initial patch.
2015-07-17 13:48:58 -04:00
jpic
fedef7b2c6
Fixed #24908 -- Fixed duplicate readonly field rendering.
...
ModelAdmin added readonly_fields to exclude, but would not undeclare
them if they were overridden.
2015-07-02 13:37:30 -04:00
Trey Hunner
788071e22d
Moved jQuery to a vendor/jquery subdirectory.
2015-06-07 22:23:42 +02:00
Loek van Gent
0207bdd2d4
Fixed #24474 -- Allowed configuring the admin's empty change list value.
2015-06-04 21:06:26 -04:00
Piotr Jakimiak
4157c502a5
Removed unnecessary arguments in .get method calls
2015-05-13 20:51:18 +02:00
Adam Zapletal
0894643e40
Fixed #23387 -- Kept "Save as new" button after validation errors in admin.
...
When "Save as new" is chosen and errors occur, only show the "Save as new"
button and not the other save buttons.
Thanks to Tino de Bruijn for doing the real work on this fix.
2015-05-02 19:41:10 -04:00