Commit Graph

10038 Commits

Author SHA1 Message Date
Mariusz Felisiak d2f02aa56b [2.2.x] Fixed #30870 -- Fixed showing that RunPython operations are irreversible by migrate --plan.
Thanks Hasan Ramezani for the initial patch and Kyle Dickerson for the
report.

Backport of 06d34aab7c from master.
2019-10-14 11:45:47 +02:00
Louise Grandjonc 323467e286 [2.2.x] Fixed #30826 -- Fixed crash of many JSONField lookups when one hand side is key transform.
Regression in 6c3dfba892.

Backport of 7d1bf29977 from master
2019-10-11 11:52:32 +02:00
Pablo García 38af257988 [2.2.x] Fixed #30810 -- Fixed WatchmanReloaderTests.test_setting_timeout_from_environment_variable test.
client_timeout is an instance attribute.

Backport of 2fd610eb30 from master
2019-09-27 08:36:48 +02:00
Simon Charette 7806e45454 [2.2.x] Fixed #30769 -- Fixed a crash when filtering against a subquery JSON/HStoreField annotation.
This was a regression introduced by 7deeabc7c7
to address CVE-2019-14234.

Thanks Tim Kleinschmidt for the report and Mariusz for the tests.

Backport of 6c3dfba892 from master
2019-09-16 08:53:31 +02:00
Simon Charette 964dd4f4f2 [2.2.x] Fixed #30754 -- Prevented inclusion of aliases in partial index conditions.
SQLite doesn't repoint table aliases in partial index conditions on table
rename which breaks the documented table alteration procedure.

Thanks Pēteris Caune for the report.

Backport of 34decdebf1 from master
2019-09-10 10:04:12 +02:00
Mariusz Felisiak 6624a3de28
[2.2.x] Fixed test_json.TestQuerying.test_key_transform_expression() on Python 3.5. 2019-08-15 19:38:12 +02:00
zeyneloz c2732e6839 [2.2.x] Fixed #30449 -- Fixed RelatedFieldListFilter/RelatedOnlyFieldListFilter to respect model's Meta.ordering.
Regression in 6d4e5feb79.

Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>

Backport of 00035672a4 from master
2019-08-15 13:14:17 +02:00
Mariusz Felisiak 52a7759a49 [2.2.x] Fixed #30672 -- Fixed crash of JSONField/HStoreField key transforms on expressions with params.
Regression in 4f5b58f5cd.

Thanks Florian Apolloner for the report and helping with tests.

Backport of 1f8382d34d from master.
2019-08-14 15:29:13 +02:00
Adnan Umer 1265a26b2f [2.2.x] Fixed #30673 -- Relaxed system check for db_table collision when database routers are installed by turning the error into a warning.
Backport of 8d3519071e from master.
2019-08-08 21:40:06 +02:00
Florian Apolloner cf694e6852 [2.2.x] Fixed CVE-2019-14235 -- Fixed potential memory exhaustion in django.utils.encoding.uri_to_iri().
Thanks to Guido Vranken for initial report.
2019-07-29 11:06:54 +02:00
Mariusz Felisiak 4f5b58f5cd [2.2.x] Fixed CVE-2019-14234 -- Protected JSONField/HStoreField key and index lookups against SQL injection.
Thanks to Sage M. Abdullah for the report and initial patch.
Thanks Florian Apolloner for reviews.
2019-07-29 11:06:54 +02:00
Florian Apolloner e34f3c0e9e [2.2.x] Fixed CVE-2019-14233 -- Prevented excessive HTMLParser recursion in strip_tags() when handling incomplete HTML entities.
Thanks to Guido Vranken for initial report.
2019-07-29 11:06:54 +02:00
Florian Apolloner c3289717c6 [2.2.X] Fixed CVE-2019-14232 -- Adjusted regex to avoid backtracking issues when truncating HTML.
Thanks to Guido Vranken for initial report.
2019-07-29 11:00:01 +02:00
Tom Forbes 4d6449e125 [2.2.x] Fixed #30647 -- Fixed crash of autoreloader when extra directory cannot be resolved.
Backport of fc75694257 from master.
2019-07-24 14:38:24 +02:00
Tom Forbes 2d2859bec2 [2.2.x] Fixed #30506 -- Fixed crash of autoreloader when path contains null characters.
Backport of 2ff517ccb6 from master.
2019-07-23 10:41:50 +02:00
Mariusz Felisiak 1088a9777d [2.2.x] Fixed #30621 -- Fixed crash of __contains lookup for Date/DateTimeRangeField when the right hand side is the same type.
Thanks Tilman Koschnick for the report and initial patch.
Thanks Carlton Gibson for the review.

Regression in 6b048b364c.
Backport of 7991111af1 from master
2019-07-10 10:34:49 +02:00
Simon Charette 9dee8515d6 [2.2.x] Fixed #30628 -- Adjusted expression identity to differentiate bound fields.
Expressions referring to different bound fields should not be
considered equal.

Thanks Julien Enselme for the detailed report.

Regression in bc7e288ca9.

Backport of ee6e93ec87 from master
2019-07-10 08:04:45 +02:00
Carlton Gibson 77706a3e47 [2.2.x] Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_SSL_HEADER if set.
An HTTP request would not be redirected to HTTPS when the
SECURE_PROXY_SSL_HEADER and SECURE_SSL_REDIRECT settings were used if
the proxy connected to Django via HTTPS.

HttpRequest.scheme will now always trust the SECURE_PROXY_SSL_HEADER if
set, rather than falling back to the request scheme when the
SECURE_PROXY_SSL_HEADER did not have the secure value.

Thanks to Gavin Wahl for the report and initial patch suggestion, and
Shai Berger for review.

Backport of 54d0f5e62f from master
2019-07-01 07:50:48 +02:00
Mariusz Felisiak 395cf7c375 [2.2.x] Fixed GeoIPTest.test04_city() failure with the latest GeoIP2 database.
Backport of 4305fbe8b1 from master
2019-06-30 19:46:40 +02:00
Tom Forbes bdc1de2199 [2.2.x] Fixed #30588 -- Fixed crash of autoreloader when __main__ module doesn't have __file__ attribute.
Backport of 8454f6dea4 from master
2019-06-26 06:44:57 +02:00
Étienne Beaulé 4e6f0024f1 [2.2.x] Fixed #30542 -- Fixed crash of numerical aggregations with filter.
Filters in annotations crashed when used with numerical-type
aggregations (i.e. Avg, StdDev, and Variance). This was caused as the
source expressions no not necessarily have an output_field (such as the
filter field), which lead to an AttributeError: 'WhereNode' object has
no attribute output_field.

Thanks to Chuan-Zheng Lee for the report.

Regression in c690afb873 and two following
commits.

Backport of 4b6dfe1622 from master.
2019-06-05 09:15:21 +02:00
Carlton Gibson afddabf842 [2.2.x] Fixed CVE-2019-12308 -- Made AdminURLFieldWidget validate URL before rendering clickable link.
Backport of deeba6d920 from master.
2019-06-03 11:37:28 +02:00
Tom Forbes 7089502b98 [2.2.x] Fixed #30523 -- Fixed updating file modification times on seen files in auto-reloader when using StatReloader.
Previously we updated the file mtimes if the file has not been seen
before - i.e on the first iteration of the loop.

If the mtime has been changed we triggered the notify_file_changed()
method which in all cases except the translations will result in the
process being terminated. To be strictly correct we need to update the
mtime for either branch of the conditional.

Regression in 6754bffa2b.

Backport of 480492fe70 from master
2019-05-29 09:43:10 +02:00
Tom Forbes ace0bec804 [2.2.x] Fixed #30516 -- Fixed crash of autoreloader when re-raising exceptions with custom signature.
Regression in c8720e7696.

Backport of 0344565179 from master
2019-05-29 08:30:22 +02:00
Caio Ariede 1172f078eb [2.2.x] Fixed #30315 -- Fixed crash of ArrayAgg and StringAgg with ordering when used in Subquery.
Backport of a3f91891d2 from master.
2019-05-28 10:39:28 +02:00
Tom Forbes 5bf2c87ece [2.2.x] Fixed #30479 -- Fixed detecting changes in manage.py by autoreloader when using StatReloader.
Regression in c8720e7696.

Backport of b2790f74d4 from master
2019-05-28 09:01:29 +02:00
Thomasina Lee 3d4e53bcb1 [2.2.x] Fixed #30488 -- Removed redundant Coalesce call in SQL generated by SearchVector.
Regression in 405c836336.

Backport of c38e7a79f4 from master
2019-05-20 09:12:32 +02:00
ruchit2801 db7d7901ee [2.2.x] Fixed #30463 -- Fixed crash of deprecation message when Meta.ordering contains expressions.
Regression in 1b1f64ee5a.

Backport of 04042b2b44 from master
2019-05-18 20:05:31 +02:00
Claude Paroz 34a357d519 [2.2.x] Fixed #30459 -- Delegated hide/show JS toggle to parent div.
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>

Backport of e286987a27 from master
2019-05-17 08:04:59 +02:00
can 58391b4d16 [2.2.x] Fixed #30412 -- Fixed crash when adding check constraints with OR'ed condition on Oracle and SQLite.
Backport of 719b746620 from master
2019-04-30 13:43:02 +02:00
Simon Charette f36239fa19 [2.2.x] Fixed #30408 -- Fixed crash when adding check constraints with LIKE operator on Oracle and PostgreSQL.
The LIKE operator wildcard generated for contains, startswith, endswith and
their case-insensitive variant lookups was conflicting with parameter
interpolation on CREATE constraint statement execution.

Ideally we'd delegate parameters interpolation in DDL statements on backends
that support it but that would require backward incompatible changes to the
Index and Constraint SQL generating methods.

Thanks David Sanders for the report.

Backport of a8b3f96f6a from master
2019-04-30 08:54:30 +02:00
Tom Forbes d326c743ef [2.2.x] Fixed #30323 -- Fixed detecting changes by autoreloader when using StatReloader.
Backport of 6754bffa2b from master
2019-04-29 12:18:29 +02:00
Carlton Gibson 4f8ebdd098 [2.2.x] Fixed #30351 -- Handled pre-existing permissions in proxy model permissions data migration.
Regression in 181fb60159.

Backport of 98296f86b3 from master
2019-04-27 21:08:46 +02:00
Jacob Green e45763193f [2.2.x] Fixed #30361 -- Increased the default timeout of watchman client to 5 seconds and made it customizable.
Made the default timeout of watchman client customizable via
DJANGO_WATCHMAN_TIMEOUT environment variable.

Backport of ed3c59097a from master
2019-04-26 13:35:47 +02:00
Aarni Koskela a4095dadc4 [2.2.x] Fixed #30312 -- Relaxed admin check from django.contrib.sessions to SessionMiddleware subclasses.
Backport of efeceba589 from master
2019-04-26 11:51:28 +02:00
Alasdair Nicol 3c3df7db8e [2.2.x] Fixed #30318 -- Added check for importability of arguments of custom error handler views.
Thanks to Jon on Stack Overflow for reporting the issue.

Backport of a5accc0368 from master
2019-04-25 11:38:35 +02:00
Simon Charette 88bf635c35 [2.2.x] Fixed #30385 -- Restored SearchVector(config) immutability.
Regression in 1a28dc3887.

The usage of CONCAT to allow SearchVector to deal with non-text fields
made the generated expression non-IMMUTABLE which prevents a functional
index to be created for it.

Using a combination of COALESCE and ::text makes sure the expression
preserves its immutability.

Refs #29582. Thanks Andrew Brown for the report, Nick Pope for the
review.

Backport of 405c836336 from master
2019-04-23 08:32:36 +02:00
Scott Fitsimones 95811c3de9 [2.2.x] Fixed #30328 -- Fixed crash of IntegerField.validators when limit_value in a custom validator is callable.
Backport of a14c0fda15 from master
2019-04-19 08:21:29 +02:00
Mariusz Felisiak bb54a2daee
[2.2.x] Removed unused imports. 2019-04-18 07:49:35 +02:00
can e85317d731 [2.2.x] Fixed #30335, #29139 -- Fixed crash when ordering or aggregating over a nested JSONField key transform.
Backport of d87bd29c4f from master.
2019-04-18 07:37:48 +02:00
Tobias Kunze 5289d4faec [2.2.x] Refs #30325 -- Added tests for using count()/exists() with custom managers and reverse M2M relations.
Backport of 9ac8520fcd from master
2019-04-15 12:39:56 +02:00
Mariusz Felisiak e8de1cc94c [2.2.x] Fixed #30325 -- Reverted "Fixed #29725 -- Removed unnecessary join in QuerySet.count() and exists() on a many-to-many relation."
This reverts commit 1299421cad due to
a regression with custom managers.

Backport of 5f7991c42c from master
2019-04-15 12:39:42 +02:00
Florian Apolloner 896cc71901
[2.2.x] Fixed #30350 -- Prevented recreation of migration for operations with a range object.
Thanks to Mariusz Felisiak for helping with the patch.

Backport of 2e38f2015a from master.
2019-04-14 12:58:34 +02:00
Florian Apolloner b88ffef7ea [2.2.x] Fixed #30330 -- Fixed setting of primary key to None during fast-delete.
Regression in bc7dd8490b.

Backport of afc708cf6d from master
2019-04-08 21:44:17 +02:00
Simone Pellizzari 268ed9cd8a [2.2.x] Fixed #30332 -- Fixed crash of ordering by expressions with params in ArrayAgg and StringAgg.
Backport of d0315584b5 from master.
2019-04-06 15:15:40 +02:00
Nick Pope 9da25fb832 [2.2.x] Fixed #30324 -- Forced utf-8 encoding when loading the template for the technical 500 debug page.
Regression in 50b8493.
Related to ea542a9.

Backport of efb257a017 from master
2019-04-05 16:37:22 +02:00
msg 1279fb4a00 [2.2.x] Fixed #30307 -- Fixed incorrect quoting of database user password when using dbshell on Oracle.
Regression in acfc650f2a.

Backport of 755673e1bc from master
2019-04-04 10:07:57 +02:00
Tim Graham 917aa556a9 [2.2.x] Fixed #30289 -- Prevented admin inlines for a ManyToManyField's implicit through model from being editable if the user only has the view permission.
Backport of 8335d59200 from master.
2019-03-30 17:44:58 -04:00
sage 4a6d3f2580 [2.2.x] Fixed #30295 -- Fixed max_lengths.tests.MaxLengthORMTests when run in isolation.
Backport of 5a92bb0725 from master.
2019-03-28 12:05:57 -04:00
Matthias Kestenholz a86ffb3e0f [2.2.x] Fixed #30280 -- Restored Model.get_FIELD_display()'s coercion of lazy strings.
Reverted cc79c7ee63.

Backport of ea071870f9 from master.
2019-03-22 13:01:15 -04:00