289fc1bfa5
Refs #23919 -- Removed str_prefix usage
2017-01-20 15:43:28 +01:00
7aba69145d
Refs #23919 -- Removed django.test.mock Python 2 compatibility shim.
2017-01-20 08:17:20 -05:00
042b7350a0
Refs #23919 -- Removed unneeded str() calls
2017-01-20 14:13:55 +01:00
4e729feaa6
Refs #23919 -- Removed django.utils._os.upath()/npath()/abspathu() usage.
...
These functions do nothing on Python 3.
2017-01-20 08:01:02 -05:00
109b33f64c
Refs #23919 -- Simplified assertRaisesRegex()'s that accounted for Python 2.
2017-01-20 08:49:47 +01:00
dc8834cad4
Refs #23919 -- Removed unneeded force_str calls
2017-01-20 08:44:31 +01:00
eb0b921c29
Refs #23919 -- Removed SessionBase.iterkeys(), itervalues(), iteritems().
...
These methods only work on Python 2.
2017-01-19 14:15:00 -05:00
9ee47ce7b4
Refs #23919 -- Removed enum ImportError handling for Python 2.
2017-01-19 13:55:20 -05:00
9695b14982
Refs #23919 -- Removed str() conversion of type and method __name__.
2017-01-19 11:31:07 -05:00
4c5ed3e683
Refs #23919 -- Removed __nonzero__() methods (for Python 2).
...
Thanks Tim for the review.
2017-01-19 11:26:26 -05:00
e5c67f0991
Refs #23919 -- Removed reset_warning_registry() workaround for Python < 3.4.2.
2017-01-19 10:56:00 -05:00
5320fa77c3
Refs #23919 -- Removed obsolete contextlib.closing() calls (for Python 2).
2017-01-19 08:50:28 -05:00
7d20094996
Fixed spelling mistakes in code and comments.
2017-01-19 07:52:41 -05:00
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
a556396339
Refs #23919 -- Replaced io.open() with open().
...
io.open() is an alias for open() on Python 3.
2017-01-18 21:45:12 -05:00
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
c716fe8782
Refs #23919 -- Removed six.PY2/PY3 usage
...
Thanks Tim Graham for the review.
2017-01-18 16:21:28 +01:00
f3c43ad1fd
Refs #23919 -- Removed python_2_unicode_compatible decorator usage
2017-01-18 13:44:34 +01:00
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
6192bffb13
Refs #26601 -- Removed obsolete system check for MIDDLEWARE_CLASSES setting.
2017-01-17 20:52:05 -05:00
98760ab0b2
Refs #25079 -- Removed obsolete system check for TEMPLATE_* settings.
2017-01-17 20:52:05 -05:00
0bf3228eec
Increased the default PBKDF2 iterations for the 1.11 release cycle.
2017-01-17 20:52:05 -05:00
f847308200
Advanced deprecation warnings for Django 2.0.
2017-01-17 20:52:05 -05:00
d334f46b7a
Refs #26601 -- Removed support for old-style middleware using settings.MIDDLEWARE_CLASSES.
2017-01-17 20:52:04 -05:00
631f4ab061
Removed Manager.use_for_related_fields and Meta.manager_inheritance_from_future.
...
Per deprecation timeline. Refs ed0ff913c6
2017-01-17 20:52:04 -05:00
60ca37d2e5
Refs #24046 -- Removed mark_for_escaping() per deprecation timeline.
2017-01-17 20:52:04 -05:00
0dfc5479a8
Refs #26058 -- Removed deprecated FileField.get_directory_name()/get_filename().
2017-01-17 20:52:04 -05:00
9d0e8c1e7f
Refs #26320 -- Removed implicit OneToOnField parent_link per deprecation timeline.
2017-01-17 20:52:04 -05:00
1691782652
Refs #26509 -- Removed contrib.gis.utils.precision_wkt() per deprecation timeline.
2017-01-17 20:52:04 -05:00
2b20e4148f
Refs #19567 -- Removed deprecated javascript_catalog() and json_catalog() views.
2017-01-17 20:52:03 -05:00
eba093e8b0
Refs #25847 -- Removed support for User.is_(anonymous|authenticated) as methods.
...
Per deprecation timeline.
2017-01-17 20:52:03 -05:00
b70094f040
Refs #26226 -- Removed support for related manager classes without a _apply_rel_filters() method.
...
Per deprecation timeline.
2017-01-17 20:52:03 -05:00
5139832398
Refs #26285 -- Removed MySQL __search lookup per deprecation timeline.
2017-01-17 20:52:03 -05:00
bfe0d54514
Refs #26230 -- Removed support for model name query lookups when using Meta.default_related_name.
...
Per deprecation timeline.
2017-01-17 20:52:03 -05:00
2d7fb77987
Refs #23832 -- Removed deprecated non-timezone aware Storage API.
2017-01-17 20:52:03 -05:00
740f63a3df
Refs #26263 -- Removed deprecated Context.has_key().
2017-01-17 20:52:03 -05:00
bcf3532ede
Refs #26154 -- Removed deprecated CommaSeparatedIntegerField.
2017-01-17 20:52:02 -05:00
9d304b26cf
Refs #20223 -- Removed deprecated django.utils.functional.allow_lazy().
2017-01-17 20:52:02 -05:00
7e63e84572
Refs #25773 -- Removed deprecated geos.MultiPolygon.cascaded_union property.
2017-01-17 20:52:02 -05:00
997c9f7099
Refs #25665 -- Removed deprecated getter/setter of Point.tuple.
2017-01-17 20:52:02 -05:00
19d8e64ac3
Refs #25665 -- Removed deprecated getters/setters of Point coordinate properties.
2017-01-17 20:52:02 -05:00
a0149848f7
Refs #25665 -- Removed GEOSGeometry.get/set_srid() per deprecation timeline.
2017-01-17 20:52:01 -05:00
ed251246cc
Refs #25550 -- Removed support for direct assignment to the reverse side of a related set.
2017-01-17 20:52:01 -05:00
e0910dcc92
Refs #25604 -- Removed makemigrations --exit option per deprecation timeline.
2017-01-17 20:52:01 -05:00
75cf9b5ac0
Refs #13110 -- Removed SyndicationFeed.add_item()'s enclosure argument.
...
Per deprecation timeline.
2017-01-17 20:52:01 -05:00
d67a46e104
Refs #25135 -- Removed support for the contrib.admin allow_tags attribute.
...
Per deprecation timeline.
2017-01-17 20:52:01 -05:00
7510b872e7
Refs #25190 -- Removed callable_obj parameter to assertRaisesMessages().
...
Per deprecation timeline.
2017-01-17 20:52:01 -05:00
8377abd59e
Refs #25120 -- Removed template.loaders.eggs.Loader per deprecation timeline.
2017-01-17 20:52:00 -05:00
ad393beeb7
Refs #21927 -- Removed include()'s app_name argument per deprecation timeline.
...
Also removed support for passing a 3-tuple to include() and support for
setting an instance namespace without an application namespace.
Thanks Marten Kenbeek for completing the patch.
2017-01-17 20:52:00 -05:00
5d8da093a9
Refs #15053 -- Removed support for non-recursive template loading.
...
Per deprecation timeline.
2017-01-17 20:52:00 -05:00
56a5760543
Refs #25184 -- Removed contrib.gis.geoip per deprecation timeline.
2017-01-17 20:52:00 -05:00
a0d166306f
Removed GeoManager and GeoQuerySet per deprecation timeline.
2017-01-17 20:51:56 -05:00
ddd3268975
Refs #21127 -- Required on_delete for ForeignKey/OneToOneField.
...
Per deprecation timeline.
2017-01-17 14:09:28 -05:00
0f454f5d4d
Refs #23960 -- Removed the host parameter for SimpleTestCase.assertRedirects().
...
Per deprecation timeline.
2017-01-17 14:09:28 -05:00
f032bbc8b1
Refs #18651 -- Removed assignment_tag per deprecation timeline.
2017-01-17 14:09:28 -05:00
742d666da5
Refs #24219 -- Removed django.forms.extras per deprecation timeline.
2017-01-17 14:09:28 -05:00
03087f80d1
Refs #24205 -- Removed Signal.disconnect()'s weak argument.
...
Per deprecation timeline.
2017-01-17 14:09:28 -05:00
f01ad1cb6a
Refs #27683 -- Allowed setting isolation level in DATABASES ['OPTIONS'] on MySQL.
2017-01-17 11:16:15 -05:00
65e321b781
Refs #25809 -- Made a few late review comments for BrinIndex.
2017-01-16 13:23:20 -05:00
1df89a60c5
Fixed #25307 -- Fixed QuerySet.annotate() crash with conditional expressions.
...
Thanks Travis Newport for the tests and Josh Smeaton for contributing
to the patch.
2017-01-16 10:03:15 -05:00
e585c43be9
Fixed #25809 -- Added BrinIndex support in django.contrib.postgres.
...
Thanks Tim Graham and Markus Holtermann for review.
2017-01-15 13:37:18 +01:00
236ebe94bf
Fixed #27149 -- Added Subquery and Exists database expressions.
...
Thanks Josh Smeaton for Oracle fixes.
2017-01-14 09:12:24 -05:00
84c1826ded
Fixed #27718 -- Added QuerySet.union(), intersection(), difference().
...
Thanks Mariusz Felisiak for review and Oracle assistance.
Thanks Tim Graham for review and writing docs.
2017-01-14 08:32:07 -05:00
2e55790838
Refs #25226 -- Cloned ArrayField.base_field on deconstruction.
...
This prevents the base_field from sharing attributes with the one used
during migrations.
2017-01-14 06:31:34 -05:00
f4c0eec713
Fixed #27699 -- Added negative timedelta support to parse_duration()
2017-01-14 11:17:54 +01:00
8ade277ab1
Fixed tests that rely on hardcoded id with keepdb
2017-01-14 15:41:49 +11:00
bcce6bb7c7
Changed a test to be consistent when run in parallel.
...
This particular test was sometimes failing when running the test suite
in parallel. The `id` was different depending on the order the tests
were run. The test was incorrectly comparing model primary keys rather
than ensuring they didn't change.
2017-01-14 15:41:49 +11:00
4e48cfc108
Fixed #27709 -- Fixed get_for_models() for proxies with an empty cache.
...
Thanks Peter Inglesby for the report and tests.
2017-01-13 10:02:01 -05:00
ede59ef6f3
Fixed #27518 -- Prevented possibie password reset token leak via HTTP Referer header.
...
Thanks Florian Apolloner for contributing to this patch and
Collin Anderson, Markus Holtermann, and Tim Graham for review.
2017-01-13 09:17:54 -05:00
91023d79ec
Removed available_apps on TestCase subclasses.
...
TestCase subclasses are wrapped in a transaction that prevents any data from
being persisted between test runs andi thus don't require limiting the tables
to be flushed to a subset of available apps like TransactionTestCase subclasses
do.
2017-01-13 08:50:03 -05:00
dc1193085d
Made contenttypes and auth apps unavailable when not necessary in tests.
2017-01-13 08:50:03 -05:00
974d14534c
Fixed #27723 -- Set MultiWidget's subwidgets input type from attrs argument.
...
Regression in b52c73008a
2017-01-13 06:34:33 -05:00
3226536127
Split AuthTemplateTests into test methods.
2017-01-12 13:18:49 -05:00
0b2e5da6ed
Fixed #27721 -- Added interface name to shell's IPython/bython import error.
2017-01-12 13:12:21 -05:00
1358a67bf9
Fixed #27713 -- Clarified NoReverseMatch error message when no view is found.
2017-01-11 21:40:18 -05:00
f3b7c05936
Refs #16614 -- Made QuerySet.iterator() use server-side cursors on PostgreSQL.
...
Thanks to Josh Smeaton for the idea of implementing server-side cursors
in PostgreSQL from the iterator method, and Anssi Kääriäinen and Kevin
Turner for their previous work. Also Simon Charette and Tim Graham for
review.
2017-01-11 09:25:37 -05:00
53bffe8d03
Fixed #24452 -- Fixed HashedFilesMixin correctness with nested paths.
2017-01-11 09:21:29 -05:00
7156a6c9c4
Fixed #27717 -- Allowed migration optimization across AlterModelOptions.
2017-01-10 18:38:48 -05:00
6872ce2266
Fixed #27712 -- Reallowed Input widget's attrs argument to set the input type.
...
Regression in b52c73008a
2017-01-10 11:38:27 -05:00
9daf8c43bd
Fixed #26961 -- Made admin checks run when DEBUG=False.
2017-01-10 07:02:13 -05:00
d57ecf40eb
Fixed #27673 -- Made admin's checks run at check time instead of during registration.
...
Thanks Morgan Aubert for the test.
2017-01-10 07:02:13 -05:00
ed8c0c941d
Fixed #27688 -- Made messages' add_message() request check use ducktyping.
2017-01-09 18:03:10 -05:00
7dc8d9238a
Skipped unnecessary system checks in user_commands test.
2017-01-09 17:23:24 -05:00
ee1c1c696b
Made prefetch_related SQL inspection tests less brittle.
...
After refs #16614 , integers might appear outside the WHERE clause.
2017-01-09 11:18:32 -05:00
9932e1bf52
Fixed test isolation in a couple migrations tests.
...
Without this, tests from refs #27432 fail when running with --reverse.
2017-01-09 08:02:09 -05:00
d27643354e
Require Jinja2 >= 2.9.2 in test requirements.
...
While our code also works with any Jinja2 >2.7,<2.9 use >2.9.2 for
simplicity reasons in the requirements file.
2017-01-08 18:43:24 +01:00
f8e36047da
Fixed #27700 -- Optimized inspectdb tests by specifying database tables.
2017-01-07 15:41:42 -05:00
853fe6f697
Pinned jinja2<2.9 in test requirements.
...
Kept the build green until a regression is fixed:
https://github.com/pallets/jinja/issues/640
2017-01-07 15:35:29 -05:00
334096dfac
Simplified a contenttypes check test with mock.
2017-01-07 10:24:40 -05:00
cd86f03591
Refs #26961 -- Fixed invalid ModelAdmins in tests.
2017-01-07 10:06:51 -05:00
8b734d2f99
Fixed #27432 -- Made app_label arguments limit showmigrations --plan output.
2017-01-06 19:50:31 -05:00
d976760260
Fixed #27693 , Refs #27257 -- Fixed iexact lookup on JSONField keys.
...
Thanks Harris Lapiroff for the report.
2017-01-06 19:25:32 -05:00
8516f7c49b
Fixed #27698 -- Added django.test.utils.ContextList.get()
2017-01-06 19:23:42 -05:00
12cefee5d8
Refs #15667 -- Prevented newlines in attrs.html widget rendering.
...
Removed the trailing newline from widget attrs.html template.
The solution may be revisited by fixing refs #9198 but not
for Django 1.11.
Thanks Dmitry Ivanchenko for the report and Preston Timmons for advice.
2017-01-06 19:11:32 -05:00
97c1931c4f
Fixed #24423 -- Reorganized i18n tag tests.
2017-01-06 10:33:07 -05:00
9390533951
Fixed #27696 -- Measured email long lines on encoded content
...
Thanks Pavel Pokrovskiy for the report and Tim Graham for the review.
2017-01-06 16:04:59 +01:00
0793182694
Cosmetic edits for messages_tests.
2017-01-05 09:31:23 -05:00
c85831e4b7
Fixed #27658 -- Prevented collectstatic from overwriting newer files in remote storages.
...
Thanks revimi for the initial patch.
2017-01-04 12:50:31 -05:00
f60d4e704d
Tested collectstatic's deleting of files/symlinks when toggling --link.
2017-01-04 12:49:57 -05:00
8ea541e6a2
Refs #2856 -- Removed redundant escaping in admin's "Perhaps it was deleted?" message.
2017-01-04 10:22:17 -05:00
bff4abacad
Refs #15035 -- Corrected a bug and improved comments for a staticfiles test.
2017-01-03 19:22:19 -05:00
1c12df4aa6
Fixed #25912 -- Added binary left/right shift operators to F expressions.
...
Thanks Mariusz Felisiak for review and MySQL advice.
2017-01-03 14:15:46 -05:00
f0ef0c49e9
Fixed #26621 -- Corrected simplify_regex()'s handling of named capture groups.
2017-01-03 13:55:11 -05:00
fd2f7e4767
Fixed #27681 -- Fixed binary &/| operators for negative values on MySQL.
2017-01-03 12:41:44 -05:00
27267afc41
Fixed #2856 -- Replaced some 404s with messages in admin.
...
Instead of a 404, return a redirect to admin index page with a message
indicating that the requested object does not exist. This avoids the
admin returning 404 from "Recent Actions" links for deleted objects.
2017-01-03 11:31:05 -05:00
946dd5bde2
Refs #25004 -- Fixed test failure introduced by OpenLayers 3 update.
2017-01-03 11:11:00 -05:00
c04207cd38
Replaced some GIS has_X_method skips with supports_X_aggr/has_X_function.
2017-01-03 09:49:00 -05:00
2ebfda38e6
Fixed #25004 -- Updated OpenLayers-based widget to OpenLayers 3
...
Thanks Tim Graham for the review.
2017-01-02 19:45:52 +01:00
6128c1736d
Refs #27637 -- Fixed timesince, timeuntil on New Year's Eve in a leap year.
2017-01-02 08:40:44 -05:00
69b7d4b116
Fixed #27458 -- Fixed invalid sequence/index names when using "USER"."TABLE" db_table on Oracle.
2016-12-30 17:11:12 -05:00
e3f095b086
Fixed #26478 -- Made {% for %} reject invalid unpacking vars with quotes or vertical bars.
2016-12-30 09:22:40 -05:00
9f16ea21c4
Used assertRaisesMessage() in {% for %} tests.
2016-12-30 09:22:04 -05:00
fae56427e1
Fixed #27649 -- Bumped required cx_Oracle to 5.2.
...
Removed obsolete workarounds from 1aa4889808dcf3be7a62
2016-12-29 12:45:25 -05:00
5eff8a7783
Fixed #25415 -- Made DiscoverRunner run system checks.
2016-12-29 12:33:24 -05:00
391c450fba
Refs #25415 -- Made MySQL backend skip field validation of unsupported models.
2016-12-29 12:01:48 -05:00
0b5d4c49d6
Fixed #27622 -- Allowed test client to accept vendor tree JSON content types.
2016-12-29 08:32:15 -05:00
813805833a
Fixed #27631 -- Prevented execution of transactional DDL statements when unsupported.
...
Executing a DDL statement during a transaction on backends that don't support
it silently commits, leaving atomic() in an incoherent state.
While schema_editor.execute() could technically be used to execute DML
statements such usage should be uncommon as these are usually performed through
the ORM. In other cases schema_editor.connection.execute() can be used to
circumvent this check.
Thanks Adam and Tim for the review.
2016-12-28 19:43:32 -05:00
5cf4894836
Fixed #27628 -- Fixed unarchiving a file without permission data.
2016-12-28 19:14:58 -05:00
6a74950513
Fixed #27258 -- Prohibited django.Template.render() with non-dict context.
...
Thanks Shivang Bharadwaj for the initial patch.
2016-12-28 16:03:20 -05:00
4e89082f31
Refs #15667 -- Fixed form renderer test for Python 2 non-ASCII path.
2016-12-28 15:57:55 -05:00
6d947e8c32
Refs #25415 -- Fixed/silenced check errors in Django's test suite.
2016-12-28 15:16:10 -05:00
e3e80da7a5
Fixed #27651 -- Allowed M2M to concrete and proxy through model.
2016-12-28 12:48:17 -05:00
aaecf038ca
Fixed #27370 -- Prevented Select widget from using 'required' with a non-empty first value.
2016-12-28 10:45:22 -05:00
6dbe56ed78
Fixed #27632 -- Unified query parameters by their values on Oracle.
2016-12-28 08:14:14 -05:00
b52c73008a
Fixed #15667 -- Added template-based widget rendering.
...
Thanks Carl Meyer and Tim Graham for contributing to the patch.
2016-12-27 17:50:10 -05:00
51cde873d9
Fixed #27648 -- Deprecated (iLmsu) regex groups in url() patterns.
2016-12-27 15:59:13 -05:00
544b2ef29f
Fixed #27640 -- Fixed HttpResponse's __repr__() without a 'Content-Type' header.
2016-12-27 14:42:58 -05:00
4a51ba228b
Fixed #27642 -- Made forms.utils.flatatt() omit 'None' values from attrs.
2016-12-27 09:42:17 -05:00
3e5c5e6754
Fixed #27637 -- Fixed timesince, timeuntil in leap year edge case.
2016-12-27 09:29:11 -05:00
cd7efa2033
Fixed #25492 -- Checked deferred foreign key constraints before dropping them.
...
This allows running foreign key data and schema altering operations in the
same migration on PostgreSQL.
Thanks Tim for review.
2016-12-24 13:53:11 -05:00
a4cac17200
Fixed #27498 -- Fixed filtering on annotated DecimalField on SQLite.
2016-12-24 10:38:48 -05:00
96181080ba
Refs #26384 -- Isolated a test model in schema tests.
2016-12-23 21:43:49 -05:00
8ba01d1e42
Fixed #26543 -- Prevented "confirm form submission" browser prompt when reloading after an admin actions failure.
2016-12-23 17:29:24 -05:00
9710677c10
Fixed typo in m2m_through_regress test methods.
2016-12-23 15:32:30 -05:00
8669cf0e68
Fixed #27626 -- Moved MEDIA_URL/STATIC_URL validation to a system check.
2016-12-23 10:55:00 -05:00
b8741c0058
Refs #18823 -- Corrected field name in an m2m manager error message.
2016-12-23 09:31:26 -05:00
39a8843802
Used assertRaisesMessage() in m2m_through_regress tests.
...
The "needs to have a value for field" messages are incorrect and
reference nonexistent fields since the commit in which they were
introduced (refs #18823 ).
2016-12-23 09:31:26 -05:00
8fb82a315a
Used @override_settings for SECURE_PROXY_SSL_HEADER tests.
2016-12-22 18:52:50 -05:00
da79240050
Fixed #26632 -- Skipped admin.E111 list_display_links check if get_list_display() is overridden.
2016-12-22 09:32:11 -05:00
bf4516a628
Added tests for django.utils.autoreload.
2016-12-22 09:01:28 -05:00
96271533d2
Moved modeladmin check tests to a separate file.
2016-12-21 17:23:57 -05:00
a04e795667
Wrapped an import per isort.
2016-12-21 17:05:59 -05:00
bf6392bb75
Fixed #27600 -- Suppressed the REPL during shell's reading from stdin.
...
Thanks Adam Chainz for review and guidance.
2016-12-21 17:05:33 -05:00
24fa728a47
Fixed #27612 -- Added a check for duplicate URL instance namespaces.
2016-12-21 16:54:15 -05:00
1206d7fa57
Refs #25753 -- Reset l10n cache when format settings change
...
Thanks Jaap Roes for the initial patch.
2016-12-21 17:40:08 +01:00
0b4d517263
Fixed #27584 -- Fixed display of render time template errors.
2016-12-20 10:36:33 -05:00
e8d8fb3295
Added a test for NullBooleanField.formfield().
2016-12-20 07:57:25 -05:00
c27104a9c7
Fixed #27611 -- Doc'd that CSRF_COOKIE_HTTPONLY setting offers no security.
2016-12-19 17:56:58 -05:00
1a04b1762b
Refs #25484 -- Made non-staticfiles {% static %} tag quote its output.
2016-12-19 16:18:06 -05:00
Claude Paroz
Tim Graham
Srinivas Reddy Thatiparthy
Simon Charette
james mike dupont
Simon Charette
Aymeric Augustin
Mads Jensen
Josh Smeaton
Matthew Schinckel
Florian Apolloner
Jinank Jain
Romain Garrigues
Mariusz Felisiak
Peter Inglesby
Marten Kenbeek
François Freitag
David Sanders
Ed Morley
Adam Chainz
Raffaele Salmaso
Florian Apolloner
Sebastian Spiegel
Dmitry
Andy Craze
anabelensc
Ketan Bhatt
Karen Tracey
vinay karanam
Andrew Nester
Tim Martin
Anton Samarchyan
Anton Samarchyan
Shivang Bharadwaj
Josef Rousek
Preston Timmons
roboslone
Illia Volochii
Adonys Alea Boffill
Adam Chainz
Andrey Kuzminov
Phil Tysoe
jpic
Preston Timmons