d89ba464dd
Changes to `ImageFileDescriptor` and `ImageField` to fix a few cases of setting image dimension fields.
...
* Moved dimension field update logic out of `ImageFileDescriptor.__set__` and into its own method on `ImageField`.
* New `ImageField.update_dimension_fields` method is attached to model instance's `post_init` signal so that:
* Dimension fields are set when defined before the ImageField.
* Dimension fields are set when the field is assigned in the model constructor (fixes #11196 ), but only if the dimension fields don't already have values, so we avoid updating the dimensions every time an object is loaded from the database (fixes #11084 ).
* Clear dimension fields when the ImageField is set to None, which also causes dimension fields to be cleared when `ImageFieldFile.delete()` is used.
* Added many more tests for ImageField that test edge cases we weren't testing before, and moved the ImageField tests out of `file_storage` and into their own module within `model_fields`.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10858 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-28 05:46:09 +00:00
7638651cc3
Fixed #11204 -- Corrected typo in the pluralize doc. Thanks martin and SmileyChris.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10849 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-27 16:26:56 +00:00
9b19fd7a76
Fixed #11209 -- Added a note to doc on connection.queries that the logged sql may not inlude parameter quoting.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10847 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-27 16:20:11 +00:00
bdf33b37da
Fixed #11215 -- Replaced erroneous catch with except in testing doc.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10845 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-27 16:03:51 +00:00
5dc30c9fd2
Fixed #11205 -- Made the links to the str method description look the same as the links to the unicode method description in the tutorial part 1. Having one be fully qualified while the other was not was odd-looking.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10843 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-26 16:46:56 +00:00
5e20adcdf6
Fixed #11202 -- Removed mod_python information from FAQ, as it is no longer the recommended deployment option, in favor of more general pointers to the docs and wiki where deployment is discussed in depth.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10841 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-26 16:27:12 +00:00
a251e0ab7e
Fixed #11070 -- Removed JING_PATH setting, which was no longer used. Thanks for the patch, seanl
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10840 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-26 05:32:52 +00:00
9848f888ba
Made some small improvements to docs/topics/http/sessions.txt
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10839 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-26 05:29:28 +00:00
5d9983d084
Fixed #8857 -- Corrected ref in modelforms documentation and added ref to file upload documentation in form documentation. Thanks Kyle Fox and prairiedogg.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10837 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-24 06:46:02 +00:00
e258961e4f
Fixed #11188 -- Removed incorrect doc note about step being unsupported when slicing query sets.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10835 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-23 12:58:31 +00:00
077a94c550
Fixed #10867 : make the makemessages command ignore files and only process directories. Thanks, diegobz.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10833 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-20 20:05:14 +00:00
c935d7ffe3
Fixed #11134 : signals recievers that disconnect during their processing no longer mess things up for other handlers. Thanks, Honza Kral.
...
While I was at it I also cleaned up the formatting of the docstrings a bit.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10831 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-20 16:13:55 +00:00
ca365b4113
Polish translation updated.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10830 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-20 11:03:10 +00:00
4567b44909
Modified a test from r10787 so that the comparison order is reliable. Thanks to Alex Gaynor and Tom Tobin for the report via IRC.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10828 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-20 00:19:13 +00:00
8c8625bde3
Fixed #11149 -- Don't call save_form_data on file-type fields multiple times when saving a model form.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10826 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-19 23:13:33 +00:00
2e24596001
Fixed #11116 -- Corrected the deletion of proxy objects. Thanks to Samuel Adam for the fix.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10824 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-19 13:42:38 +00:00
b9b9ca334e
Fixed #9308 -- Corrected the updated of nullable foreign key fields when deleting objects. Thanks to Bob Thomas for the fix, and markshep for the improvements on the test case.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10822 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-19 12:44:17 +00:00
ae95edf91d
Fixed #11138 -- Corrected the description of behavior related to the max_num parameter for model formsets.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10819 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-18 16:00:29 +00:00
5a5842ccf2
Fixed #11137 -- Add missing base class in proxy model extra managers doc. Thanks ekarulf.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10818 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-18 15:36:18 +00:00
a6a0b29318
Fixed #10400 : Added a note in the file uploads doc about the correct form type needed for file uploads to work. Thanks claudep and timo.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10816 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 18:45:25 +00:00
b2d2aba77e
Fixed #10817 -- Corrected some grammar in the forms doc. Thanks nickretallack@gmail.com.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10814 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 18:10:10 +00:00
21c6f98076
Fixed #10846 : Corrected typo in modwsgi.txt and updated reference to deployment in The Django Book. Thanks timo.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10812 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 18:04:29 +00:00
b527a59da8
Fixed #10855 : Reference doc on creating superusers in the tutorial at the point where an account is needed, so that readers who neglected to create one earlier (or who forgot the password) don't get stuck or think they have to start all over. Thanks cwolf127 and timo.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10810 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 17:54:51 +00:00
33e77db6a2
Fixed #10925 -- Clarified the location of some code referenced in the tutorial. Thanks rm and timo.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10808 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 17:43:15 +00:00
5a4ad739b7
Fixed #10971 -- Corrected code example involving redirect_chain in the testing doc. Thanks yourcelf.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10807 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 17:36:04 +00:00
c8e071b00d
Fixed #11031 -- Added doc for some additional roles needed when testing Oracle. Thanks JirkaV and Matt Boersma.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10805 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 17:24:59 +00:00
3465ac05a6
Fixed #11034 : Corrected serialization example in admin actions doc. Thanks timo and kaikuehne.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10804 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 17:13:33 +00:00
21cee79ee4
Fixed #11054 -- Corrected typo in auth-remote-user.txt. Thanks Jan Hülsbergen.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10803 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 16:57:50 +00:00
50745cc31e
Fixed #11066 -- Corrected 15 duplicate "the"s found in docs and code comments. Thanks kaikuehne.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10801 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 16:45:28 +00:00
92e5249a67
Fixed #11130 -- Corrected code example in custom template tag doc. Thanks phyfus.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10799 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 16:31:02 +00:00
2cbec63f0b
Fixed #11106 -- Corrected typo in models doc. Thanks mnieber.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10797 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 16:20:11 +00:00
7ba62f2c15
Fixed #11128 -- Misc. fixes and improvements to the model forms doc. Thanks Ramiro and Alex.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10795 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-17 16:12:05 +00:00
975ec181ea
Fixed #9206 -- Added documentation on savepoints, and how to use them to recover from errors in PostgreSQL. Thanks to Richard Davies for the draft text.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10791 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-16 06:23:06 +00:00
56f3ed7f54
Fixed import statement in admin_views test to work with Python 2.3.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10789 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-15 15:01:40 +00:00
a00be66311
Fixed #11120 -- Corrected handling of inlines attached to inherited classes, broken by r10756. Thanks to George Song and Michael Strickland for the simultaneous reports.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10787 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-15 12:44:51 +00:00
bed1418034
Add a proper cross-reference to the mention of HttpRequest in the comment moderation docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10786 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-15 02:57:53 +00:00
bcb0d124b4
Corrected tests from [10784]; instead of retrieving two comments, it was retrieving one comment twice.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10785 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-15 02:54:55 +00:00
d246401552
Fixed #11113 : fixed a couple of issues that slipped through the cracks when comment moderation was added to `django.contrib.comments`.
...
The is a potentially backwards-incompatible change for users already relying on the internals of comment moderaration. To wit:
* The moderation system now listens to the new `comment_will_be_posted`/`comment_was_posted` signals instead of `pre/post_save`. This means that import request-based information is available to moderation as it should be.
* Some experimental code from `django.contrib.comments.moderation` has been removed. It was never intended to be merged into Django, and was completely untested and likely buggy.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10784 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 15:20:50 +00:00
3da3716252
Fixed #10348 : ChangeList no longer overwrites a select_related provided by `ModelAdmin.queryset()`.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10782 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 15:09:33 +00:00
d987b378ce
Fixed #11039 : documented that aggregation and generic relations don't mix. Thanks, psmith.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10781 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 02:38:27 +00:00
5bdee2556e
Fixed #11022 : documented that the admin bulk delete action calls `QuerySet.delete()`, not `Model.delete()`. Thanks, Idan Gazit.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10780 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 02:35:16 +00:00
e508bfd27f
Fixed #10992 : fixed a bug saving inlines with custom primary key fields. Thanks, Zain.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10777 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 02:23:53 +00:00
690cb616ce
Fixed #10886 : corrected a mistaken example in the admin docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10776 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 02:17:40 +00:00
fc458dd710
Fixed #10795 : added a link to model formsets docs from the formsets docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10774 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 02:13:08 +00:00
bc514fe87e
Fixed #10273 : added an explanation of `SetPasswordForm` and `UserChangeForm` to the docs. Thanks, Tarken.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10772 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 02:02:58 +00:00
de642e4d3d
Fixed #10272 : documented the signatures for the contrib.auth views. Thanks, Idan Gazit.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10770 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 02:01:17 +00:00
66ff7db385
Fixed #11046 : fixed a use of the deprecated cycle tag syntax in the template documentation.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10768 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 01:53:57 +00:00
7215ffe8a4
Fixed #10243 , #11043 -- Corrected handling of formsets over a ForeignKey that uses to_field, and by extension, fixed the admin for handling fields of that type. Thanks to apollo13 for the initial patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10756 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-13 14:04:29 +00:00
96b5b6b34c
Fixed #10643 : fixed the formtools security hash to handle allowed empty forms or forms without changed data.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10753 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-12 22:02:38 +00:00
fce800f3fd
Fixed #10034 : the formtools security hash function is now friendlier to browsers that submit leading/trailing whitespace in form fields.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10752 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-12 21:54:58 +00:00
Gary Wilson Jr
Karen Tracey
Adrian Holovaty
Brian Rosner
Jacob Kaplan-Moss
Jarek Zgoda
Russell Keith-Magee
Matt Boersma
James Bennett