Claude Paroz
fe252c0a5a
Fixed #27131 -- Passed proper string type to SMTP connection login
...
Passing an Unicode string on Python 2 was crashing the connection.
Thanks slavugan@gmail.com for the report, and Tim Graham for the review.
2016-08-31 09:00:41 +02:00
Michael Schwarz
72d541b61c
Fixed #27007 -- Handled non-UTF-8 bytes objects for text/* attachments.
...
The fallback logic which allows non-UTF-8 encoded files to be passed to
attach_file() even when a `text/*` mime type has been specified is
moved to attach(). Both functions now fall back to a content type of
`application/octet-stream`.
A side effect is that a file's content is decoded in memory instead of
opening it in text mode and reading it into a string.
Some mimetype-related logic in _create_attachment() has become
obsolete as the code moved from attach_file() to attach() already
handles this.
2016-08-12 16:35:09 -04:00
Antoine Fontaine
004ba05bca
Fixed #27036 -- Made locmem email backend's send_messages() accept generators.
2016-08-08 20:13:29 -04:00
Claude Paroz
04b7b28812
Fixed #26802 -- Prevented crash when attaching bytes as text message
...
Thanks Tim Graham for the review.
2016-07-08 11:58:05 +02:00
Anton I. Sipos
c3495bb984
Fixed #12666 -- Added EMAIL_USE_LOCALTIME setting.
...
When EMAIL_USE_LOCALTIME=True, send emails with a Date header
in the local time zone.
2016-06-04 09:55:50 -04:00
Vasiliy Faronov
31e0314979
Fixed #26580 -- Updated references to obsolete RFC 2822.
...
Didn't rename django.utils.feedgenerator.rfc2822_date()
as some external code may rely on it.
2016-05-10 11:24:51 -04:00
Sergei Maertens
ec009ef1d8
Fixed #25986 -- Fixed crash sending email with non-ASCII in local part of the address.
...
On Python 3, sending emails failed for addresses containing non-ASCII
characters due to the usage of the legacy Python email.utils.formataddr()
function. This is fixed by using the proper Address object on Python 3.
2016-05-06 14:34:11 -04:00
Claude Paroz
836d475afe
Fixed #22561 -- Prevented too long lines in email messages
...
Thanks NotSqrt for the excellent report and Tim Graham for the review.
2016-04-19 09:35:24 +02:00
Tim Graham
df8d8d4292
Fixed E128 flake8 warnings in django/.
2016-04-08 09:51:06 -04:00
Konrad Świat
c6da621def
Fixed #24623 -- Fixed EmailMessage.attach_file() with text files on Python 3.
...
Thanks tkrapp for the report and Tim Graham for the review.
2015-07-25 07:42:30 -04:00
Tim Graham
6e3fe089dd
Replaced six.BytesIO with io.BytesIO
2015-07-20 08:19:47 -04:00
Tim Graham
7da3923ba0
Sorted imports in __init__.py files.
2015-06-27 11:53:33 -04:00
Tim Graham
7f1168e387
Removed support for Python 3.3.
2015-06-18 08:36:50 -04:00
medmunds
5993b52e6d
Fixed #24416 -- Added support for lazy email addresses.
2015-03-13 12:33:49 -04:00
Tim Graham
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
Tim Graham
fed25f1105
Removed compatibility with Python 3.2.
2015-01-17 09:00:17 -05:00
Martin Blech
e023ceb453
Fixed #23910 -- Added reply_to parameter to EmailMessage
...
Thanks to Berker Peksag and Tim Graham for the review and suggestions.
2014-11-28 06:00:06 -05:00
Martin Blech
abf87333a1
Fixed #23924 -- Made EmailMessage raise TypeError for type checks
2014-11-27 18:43:45 -05:00
Tim Graham
ebb927c4c9
Removed workaround for lack of os.getpid() in Jython.
...
The Jython bug was fixed in http://bugs.jython.org/issue1518
(tested on Jython 2.7b3); also updated make_msgid() to be more like
the version in Python 3.2+; refs #23905 .
Thanks Simon Charette for testing and review.
2014-11-24 14:01:15 -05:00
Berker Peksag
a5bd7f2cb2
Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText.
2014-11-24 13:28:58 -05:00
Florian Apolloner
8d789449c7
Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC.
2014-10-12 22:01:24 +02:00
Thomas Chaumeny
b2aad7b836
Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282.
...
Thanks Collin Anderson for the review.
2014-09-29 00:01:38 +07:00
Claude Paroz
e1fbb68e4e
Updated comment about Python issue
2014-09-27 22:48:30 +02:00
José Padilla
5472d18e31
Fixed #23461 -- Added EMAIL_TIMEOUT setting
2014-09-13 09:33:21 -04:00
Andi Albrecht
00535e8e6b
Fixed #20743 -- Added support for keyfile/certfile in SMTP connections.
...
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
2014-09-10 11:14:20 -04:00
Tim Graham
1101467ce0
Limited lines to 119 characters in django/
...
refs #23395 .
2014-09-05 09:22:16 -04:00
Alex Gaynor
1dcc603eff
Fixed several typos in Django
2014-05-28 17:39:14 -07:00
Daniel Neuhäuser
4aa80149e7
Fixed #22327 -- Turned BaseEmailBackend into a context manager
...
Changed the BaseEmailBackend to allow usage as context manager to open
and close connections.
2014-03-31 14:08:51 -04:00
Berker Peksag
5d263dee30
Fixed #21674 -- Deprecated the import_by_path() function in favor of import_string().
...
Thanks Aymeric Augustin for the suggestion and review.
2014-02-08 11:12:19 -05:00
Marc Tamlyn
9d2c5b0420
Undelete the `return True` removed in 4e0a2fe
.
...
This is quite important otherwise we don't close our connections to the
SMTP server.
2014-01-12 23:38:28 +00:00
Florian Apolloner
bfe9052831
Decode mails using the message encoding.
2013-12-30 23:54:12 +01:00
Florian Apolloner
c988745cca
Changed console and filebackend to use msg.as_bytes to output the data as it would get send via smtp.
2013-12-30 23:46:05 +01:00
Florian Apolloner
5dfd824d38
Introduced as_bytes for SafeMIMEText (and other SafeMIME-classes).
...
This is to provide a consistent interface (namely bytes) for the smtp
backend which after all sends bytes over the wire; encoding with as_string
yields different results since mails as unicode are not really specified.
as_string stays for backwardscompatibilty mostly and some debug outputs.
But keep in mind that the output doesn't match as_bytes!
2013-12-28 18:35:17 +01:00
Florian Apolloner
280c1a65cc
Worked around a bug in python 3.3.3. Refs #21093
2013-12-28 15:25:16 +01:00
Florian Apolloner
f28ea02308
Fixed #21093 -- Ensured that mails are not base64 encoded on python 3.3.3+.
...
Thanks to Arfrever for the report and Aymeric for the review.
2013-12-28 12:42:33 +01:00
Alex Gaynor
7548aa8ffd
More attacking E302 violators
2013-11-02 13:12:09 -07:00
Tim Graham
36ded01527
Fixed #21302 -- Fixed unused imports and import *.
2013-11-02 15:24:56 -04:00
Claude Paroz
3afde36d03
Undelete the login() call inadvertantly removed in 4e0a2fe59c
...
Refs #21271 .
2013-10-25 11:23:19 +02:00
SusanTan
4e0a2fe59c
Fixed #21271 -- Added timeout parameter to SMTP EmailBackend.
...
Thanks Tobias McNulty and Tim Graham for discussions and code review.
Thanks Andre Cruz the suggestion and initial patch.
2013-10-24 20:38:00 -04:00
Alex Gaynor
9bf5610890
Start attacking E231 violations
2013-10-24 10:30:03 -07:00
Tim Graham
1dae4ac177
Whitespace cleanup.
...
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
2013-10-10 16:49:20 -04:00
Tim Graham
cec11a3336
Used "is" for comparisons with None.
2013-10-10 09:35:56 -04:00
Baptiste Mispelon
20472aa827
Fixed #21189 : Cleaned up usage of bare except clauses.
...
Thanks to berkerpeksag for the report and to claudep
for the review.
2013-10-05 11:50:03 +02:00
Gregor MacGregor
b2b763448f
Fixed #20841 -- Added messages to NotImplementedErrors
...
Thanks joseph at vertstudios.com for the suggestion.
2013-09-10 11:09:59 -04:00
Aymeric Augustin
365c3e8b73
Replaced "not PY3" by "PY2", new in six 1.4.0.
2013-09-02 12:11:02 +02:00
Ramiro Morales
ececbe77ff
Fixed #12422 -- Don't override global email charset behavior for utf-8.
...
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
2013-08-21 07:44:20 -03:00
Ramiro Morales
f9d1d5dc13
Fixed #18967 -- Don't base64-encode message/rfc822 attachments.
...
Thanks Michael Farrell for the report and his work on the fix.
2013-08-20 22:17:26 -03:00
Justin Michalicek
ac09558760
Fixed #20817 -- Added html_message parameter to django.core.mail.send_mail()
2013-07-29 09:53:47 -04:00
Tim Graham
2456ffa42c
Fixed #20746 -- Removed Python 2.6 specific code/docs
2013-07-14 13:02:55 -04:00
Claude Paroz
59ebe39812
Fixed #17471 -- Added smtplib.SMTP_SSL connection option for SMTP backend
...
Thanks dj.facebook at gmail.com for the report and initial patch
and Areski Belaid and senko for improvements.
2013-07-11 22:00:08 +02:00