97121cb96e
Fixed #18026 -- Don't return an anonymous dict if extra_data in storage is empty.
2013-01-12 15:50:18 +01:00
a170c3f755
Removed some now dead code from deletion (thanks to Carl Meyer for noticing it).
2013-01-11 20:59:29 -08:00
bcdb4898ca
Fixed #19488 -- Made i18n_patterns redirect work with non-slash-ending paths
...
Thanks Daniel Gerzo for the report and the initial patch.
2013-01-11 21:27:51 +01:00
f08e739bc2
Fixed #19585 -- Fixed loading cookie value as a dict
...
This regression was introduced by the 'unicode_literals' patch.
2013-01-11 21:09:33 +01:00
4e2e8f39d1
Fixed #4833 -- Validate email addresses with localhost as domain
2013-01-11 20:45:46 +01:00
f9a46d7bc9
Made dev server autoreloader ignore filenames reported as None.
...
Useful under Jython. Thanks Thomas Bartelmess for the report and patch.
Ref #9589 .
2013-01-11 15:31:39 -03:00
eb6c107624
Fixed #19360 -- Raised an explicit exception for aggregates on date/time fields in sqlite3
...
Thanks lsaffre for the report and Chris Medrela for the initial
patch.
2013-01-11 18:10:28 +01:00
71d76ec011
Fixed #10239 - Added docs for modelform_factory
...
Thanks ingenieroariel for the suggestion and slurms for the review.
2013-01-11 06:00:19 -05:00
cdad0b28d4
Fixed #19573 -- Allow override of username field label in AuthenticationForm
2013-01-10 09:06:04 +01:00
62f842e2e5
Fixed #19581 -- ensure unique html ids with CheckboxSelectMultiple widgets
...
ID check is now done the same way as MultipleHiddenInput.
2013-01-09 16:06:56 -08:00
efa3f71cc4
Remove inaccurate comment regarding language names.
2013-01-09 11:55:58 -07:00
cfa70d0c94
Fixed #19546 - ensure that deprecation warnings are shown during tests
...
refs #18985
2013-01-09 08:19:22 -08:00
f58efd07ff
Fixed #19576 -- Use `six.with_metaclass` uniformously accross code base.
2013-01-08 20:13:43 +01:00
55da775ce1
Fixed #17541 -- Fixed non-saved/nullable fk querying
2013-01-08 21:02:38 +02:00
34ee7d9875
Updated deprecated test assertions
2013-01-08 19:08:15 +01:00
23ca3a0194
Fixed #16759 -- Remove use of __deepcopy__ in qs.clone()
...
The original problem was that queryset cloning was really expensive
when filtering with F() clauses. The __deepcopy__ went too deep copying
_meta attributes of the models used. To fix this the use of
__deepcopy__ in qs cloning was removed.
This commit results in some speed improvements across the djangobench
benchmark suite. Most query_* tests are 20-30% faster, save() is 50%
faster and finally complex filtering situations can see 2x to order
of magnitude improvments.
Thanks to Suor, Alex and lrekucki for valuable feedback.
2013-01-08 19:17:13 +02:00
c698c55966
Created special PostgreSQL text indexes when unique is True
...
Refs #19441 .
2013-01-07 17:54:30 +01:00
a2396a4c8f
Fixed #19173 -- Made EmptyQuerySet a marker class only
...
The guarantee that no queries will be made when accessing results is
done by new EmptyWhere class which is used for query.where and having.
Thanks to Simon Charette for reviewing and valuable suggestions.
2013-01-06 19:18:28 +02:00
a843539af2
Fixed #12914 -- Use yaml faster C implementation when available
...
Thanks Beuc for the report and the initial patch.
2013-01-05 18:04:00 +01:00
b740da3504
Fixed #19192 -- Allowed running tests with dummy db backend
...
Thanks Simon Charette for the initial patch, and Jan Bednařík for
his work on the ticket.
2013-01-04 13:55:20 +01:00
850630b4b7
Replaced deprecated sslerror by ssl.SSLError
...
The exact conditions on which this exception is raised are not
known, but this replacement is the best guess we can do at this
point.
2013-01-03 22:16:43 +01:00
6248833d9e
Added documentation for the 'db' argument of the post-syncdb signal.
2013-01-03 22:04:55 +01:00
ffa50ca352
Fixed #19382 -- Stopped smtp backend raising exception when already closed
...
Thanks Sebastian Noack for the report and the initial patch.
2013-01-03 20:41:45 +01:00
1b3f832ab7
Fixed #19134 -- Allowed closing smtp backend when the server is stopped
...
Thanks Sebastian Noack for the report and the initial patch.
2013-01-03 18:49:00 +01:00
84ea85fb90
Updated comment about PostGIS bug 2035
...
PostGIS 2.0.2 has been released on December 3rd 2012, with the
fix included.
2013-01-03 17:37:44 +01:00
3fc43c964e
Fixed #19545 -- Make sure media/is_multipart work with empty formsets
2013-01-03 15:16:23 +01:00
a051a9d929
Fixed PR 478 -- Removed superfluous try/except block.
2013-01-02 22:46:36 +01:00
07fbc6ae0e
Fixed #19547 -- Caching of related instances.
...
When &'ing or |'ing querysets, wrong values could be cached, and crashes
could happen.
Thanks Marc Tamlyn for figuring out the problem and writing the patch.
2013-01-02 22:21:46 +01:00
884f77bd15
Removed unusable parameters to empty_form property
2013-01-01 21:00:52 +01:00
c5ce0e8a68
Updated our six module to follow upstream changes.
...
This includes fixes for the java/jython detection and a new license header.
Thanks to Thomas Bartelmess for the report.
2013-01-01 16:21:32 +01:00
7cb0cd5aff
Replaced six.reraise with a simple raise.
2013-01-01 13:20:36 +01:00
a4a4b139cd
Replaced e.message with e.args[0] in 3aa4b8165d.
2013-01-01 13:14:55 +01:00
009235b138
Merge pull request #182 from kspi/patch-1
...
Correct Lithuanian short date format.
2013-01-01 04:08:25 -08:00
cf7afeb2d1
Fixed a NameError in geoip/libgeoip if the GeoIP library is not found.
...
Thx to Bouke Haarsma for the report.
2013-01-01 12:24:02 +01:00
3aa4b8165d
Fixed #19457 -- ImageField size detection failed for some files.
...
This was caused by PIL raising a zlib truncated stream error since we fed
the parser with chunks instead of the whole image.
2013-01-01 11:54:56 +01:00
bacb097ac3
Fixed #19519 again -- Regression in LiveServerTestCase after fd1279a4.
2013-01-01 10:14:11 +01:00
3570ff734e
Fixed #17078 -- Made shell use std IPython startup.
...
This allows for a behavior more in line with what is expected by Ipython
users, e.g. the user namespace is initialized from config files, startup
files.
Thanks Benjamin Ragan-Kelley from the IPython dev team for the patch.
2012-12-31 19:40:02 -03:00
9180146d21
Fixed #19453 -- Ensured that the decorated function's arguments are obfuscated in the @sensitive_variables decorator's frame, in case the variables associated with those arguments were meant to be obfuscated from the decorated function's frame.
...
Thanks to vzima for the report.
2012-12-31 09:34:08 -08:00
acc5396e6d
Fixed #19519 -- Fired request_finished in the WSGI iterable's close().
2012-12-31 12:47:34 +01:00
a53c474026
Fixed #16241 -- Ensured the WSGI iterable's close() is always called.
...
Thanks Graham Dumpleton for the report.
2012-12-31 12:45:20 +01:00
d11038acb2
Fixed #19537 -- Made CheckboxInput._has_changed handle 'False' string
...
Thanks dibrovsd@gmail.com for the report.
2012-12-31 10:18:59 +01:00
cee40c7d79
Added further flexibility to ModelAdmin for controlling post-save redirections.
...
Refs #19505 .
2012-12-30 21:33:21 -08:00
f80a1934cd
Fixed GIS regression in get_default_columns()
...
I changed the normal compiler's get_default_columns() but didn't change
the copy-pasted code in GIS compiler's get_default_columns().
Refs #19385
2012-12-30 12:10:15 +02:00
ce3c71faf1
Minor improvement to proxy model handling
...
Refs #19385
2012-12-30 11:20:27 +02:00
807eff7439
Made use of PathInfo.direct flag in trim_joins
...
Refs #19385
2012-12-30 11:20:13 +02:00
68985db482
Added Query.join_parent_model()
...
This simplifies especially compiler.py a lot, where almost the same
code was repeated multiple times.
Refs #19385
2012-12-30 11:19:35 +02:00
4511aeb6b8
Moved join path generation to Field
...
Refs #19385
2012-12-30 11:19:19 +02:00
9ef3cab40b
Made sure join_field is always available in .join()
...
Refs #19385
2012-12-30 11:18:25 +02:00
a7b7d6320c
Merge pull request #595 from bmispelon/patch-1
...
Fixed a typo in WidthRatioNode.
2012-12-29 13:39:52 -08:00
0b09b1a7ca
Merge pull request #609 from mitar/patch-3
...
Fixed typo in collectstatic output.
2012-12-29 13:35:52 -08:00
4e5369a596
Silenced warnings in the tests of deprecated features.
2012-12-29 22:32:07 +01:00
ef017a5f00
Advanced pending deprecation warnings.
...
Also added stacklevel argument, fixed #18127 .
2012-12-29 21:59:07 +01:00
130829334c
Removed csrf_response_exempt and csrf_view_exempt.
2012-12-29 21:59:07 +01:00
2ecf56ea3f
Removed legacy ways of calling cache_page.
2012-12-29 21:59:07 +01:00
9f9a4cdecd
Removed truncate_words and truncate_html_words.
2012-12-29 21:59:07 +01:00
e00d1b6dc6
Removed obsolete compatibility functions for old Pythons.
2012-12-29 21:59:07 +01:00
5d5e1f5afa
Removed support is_safe and needs_autoescape as function attributes.
2012-12-29 21:59:07 +01:00
641acf76e7
Removed IGNORABLE_404_STARTS/ENDS settings.
2012-12-29 21:59:07 +01:00
4a6490a4a0
Removed HttpRequest.raw_post_data.
2012-12-29 21:59:07 +01:00
d1c72d9e01
Removed django.core.management.setup_environ and execute_manager.
2012-12-29 21:59:07 +01:00
59351247bd
Removed django.core.cache.backends.memcached.CacheClass.
2012-12-29 21:59:07 +01:00
ebd2598596
Removed django.contrib.markup.
2012-12-29 21:59:07 +01:00
f27a4ee327
Removed django.contrib.localflavor.
...
Each localflavor lives on as a separate app.
2012-12-29 21:59:06 +01:00
b2d20e9826
Removed legacy shortcut for importing GeoIP.
2012-12-29 21:58:12 +01:00
d4ea02b992
Removed the legacy form wizard.
2012-12-29 21:58:12 +01:00
052271168b
Removed django.contrib.databrowse.
...
RIP -- you served us well.
2012-12-29 21:58:12 +01:00
02f3daadd6
Removed interpolation of post_url_continue in the admin.
2012-12-29 21:58:12 +01:00
59ddb79e90
Removed django.conf.urls.defaults.
2012-12-29 21:58:12 +01:00
fb9f1b9bfb
Removed backwards-compatibility shim for #16288 .
...
Also unit-tested django.utils.log.RequireDebugTrue for consistency.
2012-12-29 21:58:12 +01:00
e9c24bef74
Fix #19524 -- Incorrect caching of parents of unsaved model instances.
...
Thanks qcwxezdas for the report. Refs #13839 .
2012-12-28 23:34:54 +01:00
cb98806101
Update django/contrib/staticfiles/management/commands/collectstatic.py
...
Fixed small output error.
2012-12-27 20:37:12 +01:00
db278c3bf9
Fixed #19525 -- Reverted dcd4383107 and 05d333ba3b.
...
Refs #9893 , #18515 .
Thanks Russell for the report.
2012-12-27 09:37:57 +01:00
0907d3c6f5
Fixed #16408 -- Re-fixed value conversion with Spatialite backend
2012-12-26 12:45:41 +01:00
1c8be95a86
Prevented caching of streaming responses.
...
The test introduced in 4b278131#17758 , #7581 .
2012-12-24 20:28:07 +01:00
35d1cd0b28
Fixed #19505 -- A more flexible implementation for customizable admin redirect urls.
...
Work by Julien Phalip.
Refs #8001 , #18310 , #19505 . See also 0b908b92a2
2012-12-24 15:44:19 -03:00
4a71b84266
Fixed #19204 -- Replaced python2-style exception syntax.
...
Thanks to garrison for the report and patch.
2012-12-24 14:05:36 +01:00
8bc410b445
Fixed HTML comparisons of class="foo bar" and class="bar foo" in tests
...
Refs #17758
2012-12-24 02:11:32 +00:00
c31c2c92b8
Made admin generated changelist URLs independent of dict ordering
2012-12-24 01:33:24 +00:00
6b9f130278
Sort HTML attributes on generated forms
2012-12-24 00:47:17 +00:00
8d35fd4c32
Use new TestCase methods for equality comparisons
2012-12-24 00:24:14 +00:00
089d9ca1df
Add assertJSONEqual method to TestCase
2012-12-24 00:18:50 +00:00
dc704516c2
Add assertInHTML method to TestCase
2012-12-24 00:15:36 +00:00
0dc3fc954f
Fixed #19509 -- Fixed crypt/bcrypt non-ascii password encoding
...
Also systematically added non-ascii passwords in hashers test suite.
Thanks Vaal for the report.
2012-12-22 16:04:10 +01:00
1e4a27d087
Fixed #19468 -- Decoded request.path correctly on Python 3.
...
Thanks aliva for the report and claudep for the feedback.
2012-12-22 13:32:39 +01:00
d9a0b6ab36
Fixed #19487 -- Used str in the test client's WSGI environ.
...
This regression was introduced by the unicode_literals patch. The WSGI
spec mandates that environ contains native strings.
2012-12-22 10:38:27 +01:00
e277301c2c
Fixed #19387 -- Preserved SafeData status in contrib.messages
...
Thanks Anton Baklanov for the report and the patch.
2012-12-21 10:09:32 +01:00
4007c8f6eb
Fixed a regression in distinct_on
...
Caused by regression fix for #19500 .
2012-12-20 22:50:06 +02:00
d407164c04
Fixed #18854 -- Join promotion in disjunction cases
...
The added promotion logic is based on promoting any joins used in only
some of the childs of an OR clause unless the join existed before the
OR clause addition.
2012-12-20 21:45:15 +02:00
3dcd435a0e
Fixed #19500 -- Solved a regression in join reuse
...
The ORM didn't reuse joins for direct foreign key traversals when using
chained filters. For example:
qs.filter(fk__somefield=1).filter(fk__somefield=2))
produced two joins.
As a bonus, reverse onetoone filters can now reuse joins correctly
The regression was caused by the join() method refactor in commit
68847135bc
2012-12-20 21:27:00 +02:00
c04c03daa3
Fixed #19401 -- Ensure that swappable model references are case insensitive.
...
This is necessary because get_model() checks are case insensitive, and if the swapable check isn't, the
swappable logic gets tied up in knots with models that are partially swapped out.
Thanks to chris@cogdon.org for the report and extensive analysis, and Preston for his work on the draft patch.
2012-12-20 16:10:19 +08:00
3989ce52ef
Fixed #18172 -- Made models with __iter__ usable in ModelMultipleChoiceField
...
Thanks to Patryk Zawadzki for the patch.
2012-12-19 22:51:12 +02:00
6534a95ac3
Fixed #19470 - Clarified widthratio example.
...
Thanks orblivion for the suggestion.
2012-12-18 08:20:01 -05:00
55972ee5c7
Fixed #19441 -- Created PostgreSQL varchar index when unique=True
...
Thanks Dylan Verheul for the report and Anssi Kääriäinen for the
review.
2012-12-18 09:56:30 +01:00
c64b57d166
Replaced '__' with LOOKUP_SEP in sql/query.py
...
Thanks to Simon Charette for report.
2012-12-17 21:15:01 +02:00
ac8eb82abb
Fixed typo in WidthRatioNode's error.
2012-12-17 10:35:36 +01:00
bbabfdccce
Fixed #19485 -- Python 3 compatibility for c2a6b2a4.
...
Refs #9589 .
2012-12-17 09:46:26 +01:00
12a96bfa26
Fixed #19197 -- fixed convert_values() for nullable numeric fields
...
Cleaned up the implementation of base convert_values() a little, and
made sure it accepts None as a value for numeric fields.
There are no tests attached. The reason is that not all of the
convert_values() accept None as a value for numeric fields (for example
sqlite3.convert_values()).
The reason the base convert_values() needs to accept None is that this
situation might arise in custom compilers for 3rd party backends. It
is easy to keep the convert_values() working, so lets do that.
2012-12-16 23:26:16 +02:00
ed711c4bd5
Fixed #19483 -- Improved import error message in contrib.comments
...
Thanks Valentin Lorentz for the report and the suggested fix.
2012-12-16 21:12:45 +01:00
704ee33f50
Fixed #16679 -- Use caching to speed up signal sending
2012-12-16 21:46:02 +02:00
507c081484
Fixed #18718 - Documented django.utils.encoding.filepath_to_uri
2012-12-16 14:39:37 -05:00
69597e5bcc
Fixed #10790 -- Refactored sql.Query.setup_joins()
...
This is a rather large refactoring. The "lookup traversal" code was
splitted out from the setup_joins. There is now names_to_path() method
which does the lookup traveling, the actual work of setup_joins() is
calling names_to_path() and then adding the joins found into the query.
As a side effect it was possible to remove the "process_extra"
functionality used by genric relations. This never worked for left
joins. Now the extra restriction is appended directly to the join
condition instead of the where clause.
To generate the extra condition we need to have the join field
available in the compiler. This has the side-effect that we need more
ugly code in Query.__getstate__ and __setstate__ as Field objects
aren't pickleable.
The join trimming code got a big change - now we trim all direct joins
and never trim reverse joins. This also fixes the problem in #10790
which was join trimming in null filter cases.
2012-12-16 17:23:26 +02:00
f811649710
Fixed #18816 -- Removed "trim" argument from add_filter()
...
The trim argument was used by split_exclude() only to trim the last
join from the given lookup. It is cleaner to just trim the last part
from the lookup in split_exclude() directly so that there is no need
to burden add_filter() with the logic needed for only split_exclude().
2012-12-16 16:56:28 +02:00
d7b49f5b0d
Fixed #19469 -- Removed opts.get_ordered_objects() and related code
...
The code was dead-code since 2006.
2012-12-16 16:22:09 +02:00
9facca28b6
Corrected tests depending on the error message on the AuthenticationForm.
...
Refs #19368 , and the fix introduced in 27f8129d64
2012-12-16 07:18:45 +08:00
27f8129d64
Fixed #19368 -- Ensured that login error messages adapt to changes in the User model.
...
Thanks to un33k for the report.
2012-12-15 22:44:47 +08:00
47e1df896b
Fixed #19412 -- Added PermissionsMixin to the auth.User heirarchy.
...
This makes it easier to make a ModelBackend-compliant (with regards to
permissions) User model.
Thanks to cdestigter for the report about the relationship between
ModelBackend and permissions, and to the many users on django-dev that
contributed to the discussion about mixins.
2012-12-15 22:44:47 +08:00
730c0d2e72
Fixed a couple of docstring typos.
2012-12-15 10:22:22 -03:00
c2a6b2a43f
Fixed #9589 -- Made development web server more robust in the presence of a wider variety of code errors.
...
Thanks goes to contributor with Trac user 'berto' for the patch.
2012-12-15 10:17:25 -03:00
a001f3c31e
Fixed #2304 -- Documented TRANSACTIONS_MANAGED.
2012-12-14 21:15:48 +01:00
088d3bc2f8
Fixed #19462 -- Made assertQuerysetEqual detect undefined ordering
...
If there are more than one values to compare against and the qs isn't
ordered then assertQuerysetEqual will raise a ValueError.
2012-12-13 13:33:11 +02:00
6ed6a18a03
Fixed #19432 -- Provided better error message for get_object_or_404
...
Thanks Kit Sunde for the report and Brian Holdefehr for the initial
patch.
2012-12-12 22:05:00 +01:00
27560924ec
Fixed a security issue in get_host.
...
Full disclosure and new release forthcoming.
2012-12-10 22:11:40 +01:00
a2f2a39956
Fixed #18856 -- Ensured that redirects can't be poisoned by malicious users.
2012-12-10 22:11:39 +01:00
be9f2919e0
Edited the middleware doc for completeness, clarity, and consistency.
2012-12-09 22:30:01 +01:00
49519328b4
Fixed #19392 -- Improved error for old-style url tags with dashes.
...
Thanks dloewenherz for the report.
2012-12-09 16:17:56 +01:00
35492f8fc4
Fixed #19439 -- Removed unused template tag library in change_password.html
...
Thanks ppetrid for the report.
2012-12-08 12:52:09 +01:00
04e6542b5a
Fixed #19423 -- Prevented ModelAdmin sharing widgets due to formfield_overrides
...
Thanks joebuyer at manycycles.com for the report and Simon Charette
for the review.
2012-12-08 12:41:11 +01:00
6140795150
Fixed a string detection in ogrinspect.py
2012-12-08 12:19:39 +01:00
c91667338a
Fixed #19357 -- Allow non-ASCII chars in filesystem paths
...
Thanks kujiu for the report and Aymeric Augustin for the review.
2012-12-08 11:13:52 +01:00
66dfcc10b3
Fixed #18574 -- Make BaseFormSet.is_valid call its underlying forms' is_valid
...
Thanks Simon Charette for the report and the initial patch.
2012-12-06 20:00:56 +01:00
34dcf51e06
Fixed #19367 -- Fixed saving ContentFile in filesystem storage
...
This was not working properly when ContentFile was initialized with
an unicode string.
Thanks Alexey Boriskin for the report and the test.
2012-12-06 17:14:44 +01:00
553838a285
Fixed #19429 -- Applied linebreaksbr to read-only fields in inlines
...
Applied to inlines what ec9d6b1122
2012-12-06 09:52:02 +01:00
45f00dbb93
Minor idiomatic and docstring edits in ar localflavor.
2012-12-04 19:48:39 -03:00
795ac7deda
Fixed #19378 -- Ensured get_success_url returns a non-lazy URL
2012-12-04 13:22:42 +01:00
501c7a221c
Merge pull request #573 from tominsam/master
...
Fixed #19070 : urlize template filter raises exception in some cases
2012-12-04 02:18:10 -08:00
b64d30405a
Fixed #18697 -- Made values accepted for two customizable admin templates consistent.
...
Thanks and at cloverfastfood dot com for the report.
2012-12-04 01:13:01 -03:00
88e1715639
Fixed #19318 -- Ensured that the admin's SimpleListFilter options can be displayed as selected even if the lookup's first element is not a string.
2012-12-03 11:53:15 -08:00
5fa5621f57
Fixed #19416 -- Fixed multi-line commands in initial SQL files
...
Thanks Aymeric Augustin for detecting this regression.
2012-12-03 20:47:08 +01:00
6d27547d20
Merge pull request #569 from orblivion/master
...
Fixed typo in ValuesQuerySet._as_sql docstring
2012-12-03 08:51:40 -08:00
74809fdcc7
cope with unsplittable urls in smarl_urlquote.
2012-12-03 12:13:24 +00:00
baae4b8187
Fixed #19397 -- Crash on binary files in project templates.
...
Thanks gw 2012 at tnode com for the report.
2012-12-03 10:45:18 +01:00
2e2c4968f6
Fixed #17050 -- Added some CSS class names to the admin index pages to facilitate per-app or per-model style customizations. Thanks to scytale for the report and to H0ff1 and thiderman for their work on the patch.
2012-12-02 20:54:34 -08:00
0ff1d4fa49
Typeo in ValuesQuerySet._as_sql docstring
2012-12-01 18:55:26 -08:00
90d3af380e
Fixed #19015 -- Removed ISO formats from localized formats.py
...
ISO formats are automatically appended to the list of input
formats. Kept only when it is specified in first position, as it
has a special meaning in localize_input.
Thanks Bojan Mihelac for the report.
2012-12-01 14:15:06 +01:00
349c4c37f8
Fixed #19015 -- Add ISO input formats to all formats
2012-12-01 14:05:52 +01:00
c0efbc7b53
Fixed #19347 -- Removed unused variable definition in FetchFromCacheMiddleware
...
Thanks gregplaysguitar at gmail.com for the report.
2012-12-01 13:52:26 +01:00
a0cd6dd11e
Fixed #19349 -- Fixed re-rendering of ReadOnlyPasswordHashWidget
...
Thanks tim.bowden at mapforge.com.au for the report, Andreas Hug
for the patch and Anton Baklanov for the review.
2012-12-01 12:22:43 +01:00
84a5294788
Added missing custom user skip decorator
...
PermissionDeniedBackendTest references User model.
2012-11-30 22:54:42 -08:00
0eeae15056
Fixed #19354 -- Do not assume usermodel.pk == usermodel.id
...
Thanks markteisman at hotmail.com for the report.
2012-11-29 21:45:43 +01:00
d913a8b412
Fixed #19356 -- Increased session key entropy.
2012-11-29 16:36:43 +01:00
514ce1d35f
Fixed two docstring/comment typos.
2012-11-28 20:28:30 -03:00
cc3c4a9d55
Fixed #19366 -- Prevented GEOSIndexError when comparing geometries
...
Thanks Craig de Stigter for the report and collaboration on the
patch.
2012-11-28 22:34:02 +01:00
6ebf115206
Fixed #14694 -- Made ``defer()`` work with reverse relations
...
Reverse o2o fields are now usable with defer.
2012-11-28 18:17:10 +02:00
c10aaa70a4
Fixed #19370 -- Made date filter properly handle midnight value
2012-11-27 21:24:16 +01:00
d37483c533
Removed duplicate opts.pk_index() method
2012-11-27 21:54:46 +02:00
86644e065f
Refactored gis/spatialite connection initialization
...
The connection state is now initialized in get_new_connection().
Refs #19274 .
2012-11-27 19:47:22 +02:00
905ea9619b
Made sure global settings are changed in test db creation
...
There was an assumption that changing connection.settings_dict changed
also the settings.DATABASES values. This assumption is now gone.
2012-11-27 19:47:20 +02:00
1893467784
Fixed #19274 -- Made db connection creation overridable in subclasses
...
Connection creation was done in db backend ._cursor() call. This
included taking a new connection if needed, initializing the session
state for the new connection and finally creating the connection.
To allow easier modifying of these steps in subclasses (for example to
support connection pools) the _cursor() now calls get_new_connection()
and init_connection_state() if there isn't an existing connection. This
was done for all non-gis core backends. In addition the parameters used
for taking a connection are now created by get_connection_params().
We should also do the same for gis backends and encourage 3rd party
backends to use the same pattern. The pattern is not enforced in code,
and as the backends are private API this will not be required by
documentation either.
2012-11-27 19:47:19 +02:00
2ea80b94d7
Fixed #19362 -- Detected invalid use of @python_2_unicode_compatible.
...
Thanks m3wolf for the report and akaariai for reproducing the problem.
2012-11-27 09:45:37 +01:00
29d59a879e
Fixed #17911 -- Ensure that admin readonly fields' display values are shown in change forms when the raw value is None.
2012-11-25 23:13:30 +01:00
05dbc07c52
Merge pull request #476 from wraithan/patch-1
...
Indented comments consistently in project template
2012-11-25 12:04:52 -08:00
e18968e0f2
Merge pull request #518 from vanschelven/patch-1
...
Fixed interpolation in a translated string.
Refs #14678 .
2012-11-25 11:59:34 -08:00
ae206d78f6
Fixed #17646 -- Added a get_list_filter() method to ModelAdmin. Thanks to rasca for the suggestion and to mateusgondim for the patch.
2012-11-25 20:39:23 +01:00
7644800070
Change exception type to reduce confusion.
...
TemplateSyntaxError is expected at compile time, not at run time.
Refs #19280 .
2012-11-25 19:51:42 +01:00
a5d47415f4
Enabled SimpleTestCase to be decorated by override_settings
...
Refs #18417 . Also fixed some test case classes which subclassed
the wrong parent.
2012-11-25 19:06:17 +01:00
9f7cefd505
Fixed #18417 -- Raised exception when unittest.TestCase is decorated with override_settings
2012-11-25 19:06:17 +01:00
612357f8ef
Fixed #19355 -- Improved LiveServerThread's handling of exceptions. Thanks to flub for the report.
2012-11-25 12:55:23 +01:00
9d7130e066
Merge pull request #554 from zedr/master
...
Minor spelling error in a docstring
2012-11-24 13:47:09 -08:00
d266919584
Fixed #19280 -- Raised an explicit exception for the old {% url %} syntax.
2012-11-24 22:10:51 +01:00
abd0e76d2d
Fixed #19293 -- Updated Czech input formats
...
Thanks vzima for the report.
2012-11-24 19:18:54 +01:00
35a0fff28a
Fixed #18722 -- Adjusted width of sortable columns in admin
...
Thanks Simon Charette for the report.
2012-11-24 17:12:59 +01:00
a962bc7c45
Updated User manager when testing custom AUTH_USER_MODEL
...
This is giving more real test conditions when AUTH_USER_MODEL is
set with override_settings.
2012-11-24 16:00:00 +01:00
08b4a22293
Updated stale docstring of setup_joins
2012-11-24 16:26:05 +02:00
bf1871d874
Fixed #19237 -- Improved strip_tags utility
...
The previous pattern didn't properly addressed cases where '>'
was present inside quoted tag content.
2012-11-24 12:16:52 +01:00
be64dd35fb
Fixed #19343 -- Deadlock with TransactionTestCase + TEST_MIRROR + multi_db.
...
Thanks Jeremy Dunck for the review.
2012-11-24 09:48:21 +01:00
f2d8004967
Removed some stray debug lines introduced accidentally in c8985a8.
2012-11-24 15:26:36 +08:00
c8985a8a73
Fixed #19806 -- Ensure that content types and permissions aren't created for swapped models.
...
Thanks to rizumu for the report.
2012-11-24 13:43:20 +08:00
0a0a0d66b3
Fixed #19351 -- SQLite bulk_insert of more than 500 single-field objs
2012-11-24 01:13:12 +02:00
a27582484c
Fixed SQLite's collapsing of same-valued instances in bulk_create
...
SQLite used INSERT INTO tbl SELECT %s UNION SELECT %s, the problem
was that there should have been UNION ALL instead of UNION.
Refs #19351
2012-11-24 01:12:17 +02:00
90b86291d0
Fixed #18375 -- Removed dict-ordering dependency for F-expressions
...
F() expressions reuse joins like any lookup in a .filter() call -
reuse multijoins generated in the same .filter() call else generate
new joins. Also, lookups can now reuse joins generated by F().
This change is backwards incompatible, but it is required to prevent
dict randomization from generating different queries depending on
.filter() kwarg ordering. The new way is also more consistent in how
joins are reused.
2012-11-23 19:53:04 +02:00
7b9a1fb964
Fixed cursor commit command in PostGIS backend
...
Thanks Bruno Renié for noticing the error.
2012-11-23 17:20:36 +01:00
2bca9a4eda
Fix spelling error in the docstring
2012-11-23 16:20:18 +00:00
fbd1df8e16
Fixed #19152 -- Allowed PostGIS tests to be run without template
...
From version 2, a PostGIS template is no longer required to create
a GIS-enabled database.
2012-11-23 16:06:31 +01:00
891c530624
Fixed #18984 -- Avoided a deadlock in test teardown.
...
Thanks Jeremy Dunck for the report.
2012-11-22 20:55:50 +01:00
a026e480da
Fixed #16039 -- Made post_syncdb handlers multi-db aware.
...
Also reverted 8fb7a90026#17055 .
2012-11-22 20:53:59 +01:00
ea6b95dbec
Fixed #19316 -- Set View args/kwargs/request before dispatch
2012-11-22 20:13:01 +01:00
9e11253497
Merge pull request #511 from ryankask/username-password-admin
...
Allowed custom User models to use the UserAdmin's change password view.
Fix #19056 (again).
2012-11-22 06:50:37 -08:00
7b2d95eb30
Clarified usage of as_view kwargs for setting arguments on class based views
...
Thanks Dave McLain for the patch.
2012-11-22 09:07:21 -05:00
3fb83729b9
Merge branch 'ticket_19325' of https://github.com/hannesstruss/django into hannesstruss-ticket_19325
2012-11-22 10:05:08 +01:00
48e8b5e944
Add orphans support to MultipleObjectMixin
...
Fixes #7005
2012-11-21 16:50:23 +13:00
fbfa654a15
Paginator._get_page hook
...
This allows for Paginator subclasses to easily override the Page class
that gets used.
Took the opportunity to also do some non-invasive PEP8 tidying of the
paginator module.
2012-11-21 15:19:44 +13:00
8fdb28219d
Fixed #19331 (again) use the right admin named URL.
...
This allows us to get the trailing slash in URLs without having to
manually assemble and hard-code them.
See also commits e9497a, a222d6, f51eab, 5a9e12.
2012-11-20 21:05:32 -03:00
8c21c53c8b
Fixed #19331 -- Added missing trailing slash in auth admin template
...
Thanks ppetrid at yawd.eu for the report.
2012-11-20 19:19:50 +01:00
f9891f2087
Fixed #19325 - Made email backend of AdminEmailHandler configurable
2012-11-20 11:23:12 +01:00
d179794c6b
Fix typo in comment
2012-11-19 19:31:21 -06:00
edf7ad36fa
Fixed #18658 -- Improved ModelAdmin.message_user API
...
Thanks to Lowe Thiderman for the patch and tests
2012-11-19 16:03:09 -08:00
9b755a298a
Fixed #19291 -- Completed deprecation of ADMIN_MEDIA_PREFIX.
2012-11-17 22:38:19 +01:00
778b8bdcf4
Merge pull request #467 from tomchristie/page-kwarg
...
Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page".
2012-11-17 12:27:01 -08:00
730977046b
Merge pull request #466 from kenthauser/ticket_19025
...
#19025 Add `form` to formwizard context (includes tests)
2012-11-17 12:23:48 -08:00
1520748dac
Fixed #2550 -- Allow the auth backends to raise the PermissionDenied exception to completely stop the authentication chain. Many thanks to namn, danielr, Dan Julius, Łukasz Rekucki, Aashu Dwivedi and umbrae for working this over the years.
2012-11-17 20:24:54 +01:00
e0363c688d
Fixed #19114 -- Fixed LogEntry unicode representation
...
Thanks niko at neagee.net for the report and Emil Stenstrom for
the patch.
2012-11-17 19:19:59 +01:00
2a67374b51
Fixed #19036 -- Fixed base64 uploads decoding
...
Thanks anthony at adsorbtion.org for the report, and johannesl for
bringing the patch up-to-date.
2012-11-17 17:25:21 +01:00
9e7723f851
Refactor loaddata for readability.
...
Thanks Claude Paroz and Daniel Moisset for review and feedback.
2012-11-17 13:18:01 -03:00
ec9d6b1122
Fixed #19226 -- Applied linebreaksbr to read-only fields in admin
...
Thanks shadow for the report, and Melevir and thiderman for the
patch.
2012-11-17 17:06:24 +01:00
8c69278764
Fixed #18989 -- Removed unused condition in CursorWrapper
...
Thanks zimnyx for the report.
2012-11-17 16:34:14 +01:00
233f86443c
Merge pull request #490 from gabrielhurley/reverse-prefix-special-chars
...
Fixed #18210 -- Escaped special characters in reverse prefixes.
2012-11-17 06:49:18 -08:00
4a5e8087ac
Fixed #19136 -- Properly escape gettext context prefixes in the i18n JavaScript view template.
2012-11-17 15:37:30 +01:00
44046e8a38
Fixed #18985 -- made DeprecationWarnings loud
...
Capture warnings in Python >= 2.7 and route through
console handler, which is subject to DEBUG==True
Thanks to dstufft for the idea, and claudep for initial patch
2012-11-16 17:07:38 -08:00
d8ee46afff
comment_will_be_sent can cause a 400, not a 403
...
Doc cleanup for django.contrib.comments.signals.comment_will_be_sent
If a receiver returns False, an HttpResponse with status code 400
is returned. A test case already exists confirming this behavior.
Updated docs to reflect reality.
2012-11-16 10:19:54 -05:00
ff0d3126af
Fixed #19296 -- Applied test connection sharing for spatialite
...
Thanks pegler at gmail.com for the report and the initial patch.
2012-11-16 14:32:36 +01:00
5e3b99d4cf
Update django/contrib/flatpages/forms.py
...
Translate before passing in the variables (i.e. close the bracket earlier).
If you translate after passing in the variables the translated value will contain the actual values for 'url' and 'site' and will therefore not be translated.
(I'm not actually using django's flatpages, but I ran into this apparent error when doing a global grep on my own project)
2012-11-15 22:53:08 +01:00
7cfb567e45
Another regression fix for select_related handling
...
This time gis compiler.get_default_columns() wasn't up to date. Thanks
to CI another regression fixed.
Refs #13781
2012-11-15 21:33:56 +02:00
1194a96999
Fixed a regression in select_related
...
The regression was caused by the fix for #13781 (commit
f51e409a5f
2012-11-15 20:17:57 +02:00
f51e409a5f
Fixed #13781 -- Improved select_related in inheritance situations
...
The select_related code got confused when it needed to travel a
reverse relation to a model which had different parent than the
originally travelled relation.
Thanks to Trac aliases shauncutts for report and ungenio for original
patch (committed patch is somewhat modified version of that).
2012-11-15 17:15:21 +02:00
92d7f541da
Fixed #19058 -- Fixed Oracle GIS crash
...
The problem is the same as in #10888 which was reintroduced when
bulk_insert was added. Thanks to Jani Tiainen for report, patch and
also testing the final patch on Oracle GIS.
2012-11-15 16:08:06 +02:00
550ddc66b4
Fixed #19272 -- Fixed gettext_lazy returned type on Python 2
...
Thanks tyrion for the report.
2012-11-14 10:50:15 +01:00
1620c27936
Fixed #19186 -- Fixed sending mail with unicode content on Python 3
...
Thanks alex_po for the report and Luke Plant for the analysis.
2012-11-14 10:43:33 +01:00
ebcf6b36ff
Fixed select_related performance regressions
...
The regression was caused by select_related fix for Oracle, commit
c159d9cec0
2012-11-13 22:52:58 +02:00
ce1af8d702
Removed use of SortedDict for query.alias_refcount
...
This will have a smallish impact on performance. Refs #19276 .
2012-11-13 22:48:25 +02:00
fa18b0ac89
Some changes to SortedDict to make it faster under py2
...
Refs #19276
2012-11-13 22:48:25 +02:00
09a39ca082
Negligible spacing fix in utils/log.py
2012-11-12 14:19:11 -06:00
6c69de80bd
Tweaked cache key creation to avoid strict typing.
...
This is a provisional change. See #19221 for details.
2012-11-11 21:23:45 +01:00
4c5cea7073
Merge pull request #218 from mgrouchy/ticket_18582
...
Fixed #18582 -- Added a no-op close to BaseCache
2012-11-11 07:18:45 -08:00
cc0ac26f4a
Fixed #19273 -- Fixed DB cache backend on pg 9.0+ and py3
...
There was a problem caused by Postgres 9.0+ having bytea_output default
value of 'hex' and cache backend inserting the content as 'bytes' into
a column of type TEXT. Fixed by converting the bytes value to a string
before insert.
2012-11-10 19:42:20 +02:00
bfdedb687a
Allow custom User models to use the UserAdmin's change password view.
2012-11-10 15:48:46 +00:00
04a7ea3283
Removed an impossible code path in cache function
2012-11-10 15:42:27 +01:00
34162698cc
Fixed #14264 -- Ensured settings.configure configures logging
...
Thanks Matt McDonald for the patch.
2012-11-10 12:05:58 +01:00
4d817b3887
Fixed #19262 -- Support cookie pickling in SimpleTemplateResponse
...
Refs #15863 .
2012-11-09 21:07:53 +01:00
1b307d6c8f
Fixed #19261 -- Delayed Queryset evaluation in paginators
...
Thanks trbs for the report and the patch.
2012-11-09 19:41:57 +01:00
aea8bf0662
Added missing encoding preamble to gis tests.
...
'coverage html' did fail without it.
Thanks to Claude Paroz for figuring it out.
2012-11-09 15:16:06 +01:00
9942adac17
Made Page class inherit collections.Sequence
2012-11-08 16:13:23 +01:00
cafb266954
Fixed #17144 -- MySQL again groups by PK only
...
Thanks to Christian Oudard for the report and tests.
2012-11-08 00:56:32 +02:00
9a09558e9f
Fixed #19257 -- Don't swallow command's KeyError in call_command
...
Thanks Giovanni Bajo for the report.
2012-11-07 18:28:53 +01:00
79dd751b0b
Fixed #14315 -- Made memcached backend handle negative incr/decr values
...
Thanks Michael Manfre for the report and initial patch and
Tobias McNulty for the review.
2012-11-06 12:22:42 +01:00
11fd00c46e
Fixed #19254 -- Bug in SESSION_FILE_PATH handling.
...
Thanks simonb for the report.
Refs #18194 .
2012-11-06 10:19:14 +01:00
78f66691ee
Fixed #8627 -- Prevented textareas to swallow first newline content
...
Browsers consider the first newline in textareas as some display
artifact, not real content. Hence they are not sending it back to
the server. If we want to keep initial newlines, we have to add one
when we render the textarea.
Thanks bastih for the report and initial patch.
2012-11-05 20:27:06 +01:00
39ec43b478
Removed unnecessary import after b98083ce3d
2012-11-05 09:32:08 +01:00
6bd61194d4
Fixed py3 compatibility for 5a00a57aa5
2012-11-04 23:38:41 -08:00
4d766b3c9a
Merge pull request #495 from aisipos/ticket_18949
...
Fixed #18949 -- Improve performance of model_to_dict with many-to-many
2012-11-04 15:57:45 -08:00
e44ab5bb4f
Fixed #18949 -- Improve performance of model_to_dict with many-to-many
...
When calling model_to_dict, improve performance of the generated SQL by
using values_list to determine primary keys of many to many objects. Add
a specific test for this function, test_model_to_dict_many_to_many
Thanks to brian for the original report and suggested fix.
2012-11-04 15:52:05 -08:00
5a00a57aa5
Fixed #19240 -- include pagination error details in ListView 404
...
Thanks to seawolf for the patch
2012-11-04 15:52:00 -08:00
8d3f932f18
Merge pull request #494 from mrj0/model_split
...
model_split: Fixed #19236 - fixed error for abstract models with a split method
2012-11-04 14:20:26 -08:00
088f68252d
use six.string_types for python3
2012-11-04 14:16:32 -08:00
b98083ce3d
Remove some bizzare and unnecesary code.
2012-11-04 13:58:40 -08:00
fcd3d4c68f
model_split: Fixed #19236 - fixed error for abstract models with a split method
2012-11-04 13:43:54 -08:00
4285571c5a
Fixed #5805 -- it is now possible to specify multi-column indexes. Thanks to jgelens for the original patch.
2012-11-04 10:16:06 -08:00
fc10418fba
Fixed #18963 -- Used a subclass-friendly pattern
...
for Python 2 object model compatibility methods.
2012-11-03 22:07:35 +01:00
973f539ab8
Fixed #15152 -- Avoided crash of CommonMiddleware on broken querystring
2012-11-03 21:28:33 +01:00
90e530978d
Fixed #18210 -- Escaped special characters in reverse prefixes.
...
Ensured that special characters passed in to reverse via the
prefix argument are properly escaped so that calls to
django.utils.regex_helpers.normalize and/or string formatting
operations don't result in exceptions.
Thanks to toofishes for the error report.
2012-11-03 13:06:57 -07:00
3e98d98b69
Prevented host resolution when running dev server
...
Refs #19075 , #2494 .
Thanks Karen Tracey for spotting the issue.
2012-11-03 20:12:24 +01:00
095eca8dd8
Fixed #19101 -- Decoding of non-ASCII POST data on Python 3.
...
Thanks Claude Paroz.
2012-11-03 13:03:15 +01:00
ac2052ebc8
Fixed #17549 -- Added a clickable link for URLFields in admin change list.
2012-11-03 11:57:33 +01:00
965cc0b1ff
Deprecated depth kwarg on select_related.
...
This is the start of a deprecation path for the depth kwarg on
select_related. Removing this will allow us to update select_related so
it chains properly and have an API similar to prefetch_related.
Thanks to Marc Tamlyn for spearheading and initial patch.
refs #16855
2012-11-02 22:03:33 -07:00
92fc263a28
Fixed a regression in gis introduced by Query.select_fields removal
2012-11-02 14:57:19 +02:00
af7ea808d8
Added WizardView.file_storage exception message and docs
...
Thanks Danilo Bargen for the patch.
2012-11-01 16:14:51 -04:00
d9213d09db
Fixed #16678 -- Wrote tests for contrib.redirects app
...
Thanks Julien Phalip for the report.
2012-11-01 19:47:41 +01:00
ba81164fb7
Add `form` to formwizard context (includes tests)
2012-10-31 09:58:28 -04:00
7f75460fd6
Fixed #19070 -- urlize filter no longer raises exceptions on 2.7
...
Thanks to claudep for the patch.
2012-10-31 10:58:14 +00:00
146ed13a11
Fixed #17083 -- Allowed sessions to use non-default cache.
2012-10-31 09:46:16 +01:00
68847135bc
Removed dupe_avoidance from sql/query and sql/compiler.py
...
The dupe avoidance logic was removed as it doesn't seem to do anything,
it is complicated, and it has nearly zero documentation.
The removal of dupe_avoidance allowed for refactoring of both the
implementation and signature of Query.join(). This refactoring cascades
again to some other parts. The most significant of them is the changes
in qs.combine(), and compiler.select_related_descent().
2012-10-31 08:19:44 +02:00
Stephan Jaekel
Alex Gaynor
Claude Paroz
Thomas Bartelmess
Nick Sandford
Tim Graham
Loic Raucy
Carl Meyer
Preston Holmes
Simon Charette
Anssi Kääriäinen
mpaolini
Aymeric Augustin
Florian Apolloner
Anton Baklanov
Ramiro Morales
Julien Phalip
Mitar
Luke Plant
Ian Clelland
Russell Keith-Magee
Patryk Zawadzki
Baptiste Mispelon
Andreas Hug
Marc Aymerich
Andrew Godwin
Sebastián Magrí
Tom Insam
orblivion
Tai Lee
Danilo Bargen
Edward Tjörnhammar
Vladimír Macek
Jonatan Heyman
Chris Khoo
Rigel Di Scala
Flavio Curella
George Hickman
Jannis Leidel
Chris Beaven
Hannes Struss
Riley Strong
Brandon Adams
vanschelven
Adrian Holovaty
Ryan Kaskel
Sean Breant
Alex Gaynor
Anton I. Sipos
Mike Johnson
Gabriel Hurley
Ulrich Petri
Kent Hauser