Mariusz Felisiak
6872ce2266
Fixed #27712 -- Reallowed Input widget's attrs argument to set the input type.
...
Regression in b52c73008a
.
2017-01-10 11:38:27 -05:00
Dmitry
12cefee5d8
Refs #15667 -- Prevented newlines in attrs.html widget rendering.
...
Removed the trailing newline from widget attrs.html template.
The solution may be revisited by fixing refs #9198 but not
for Django 1.11.
Thanks Dmitry Ivanchenko for the report and Preston Timmons for advice.
2017-01-06 19:11:32 -05:00
Josef Rousek
aaecf038ca
Fixed #27370 -- Prevented Select widget from using 'required' with a non-empty first value.
2016-12-28 10:45:22 -05:00
Preston Timmons
b52c73008a
Fixed #15667 -- Added template-based widget rendering.
...
Thanks Carl Meyer and Tim Graham for contributing to the patch.
2016-12-27 17:50:10 -05:00
Illia Volochii
4a51ba228b
Fixed #27642 -- Made forms.utils.flatatt() omit 'None' values from attrs.
2016-12-27 09:42:17 -05:00
Hiroki Kiyohara
181f492ad0
Fixed #27416 -- Prevented ModelFormSet from creating objects for invalid PKs in data.
2016-12-06 13:06:58 -05:00
Jon Dufresne
6abd6c598e
Fixed #27563 -- Moved "apply limit_choices_to" code from BaseModelForm to fields_for_model().
2016-12-02 08:40:24 -08:00
Claude Paroz
d49551bc26
Fixed #27119 -- Cached BaseFormSet.management_form property
...
Thanks Tim Graham for the review.
2016-12-01 20:17:25 +01:00
Diego Martín
abd434059e
Fixed #27250 -- Removed 'for ="..."' from CheckboxSelectMultiple's <label>.
2016-11-22 11:48:37 -05:00
Kenneth Veldman
8618a7eaa1
Fixed #27431 -- Prevented disabled form fields from appearing as changed.
2016-11-11 06:57:57 -05:00
Leila20
656654fb5b
Fixed typo in django/forms/widgets.py comment.
2016-11-06 11:55:33 +01:00
Michal Petrucha
09da1e79de
Fixed #27369 -- Prevented widgets from being shared between form field instances.
2016-11-06 07:16:56 +01:00
Tim Graham
87c5e7efeb
Refs #27186 -- Fixed model form default fallback for CheckboxSelectMultiple.
2016-09-30 14:49:50 -04:00
Tim Graham
3507d4e773
Fixed #27186 -- Fixed model form default fallback for MultiWidget, FileInput, SplitDateTimeWidget, SelectDateWidget, and SplitArrayWidget.
...
Thanks Matt Westcott for the review.
2016-09-22 12:20:58 -04:00
Jon Dufresne
2c716c1dc7
Fixed #27256 -- Changed Select widget's selected attribute to use HTML5 boolean syntax.
2016-09-21 15:12:13 -07:00
Chris Lamb
9027e6c8a3
Fixed #27235 -- Removed some usage of mutable default arguments.
2016-09-16 15:48:08 -04:00
Claude Paroz
2ced2f785d
Replaced smart_* by force_* calls whenever possible
...
The smart_* version should only be used when a lazy string should keep
its lazy status.
2016-09-03 13:46:41 +02:00
Alex Hill
d9c083cfee
Refs #27039 -- Fixed regression with field defaults in prefixed forms.
2016-09-01 09:13:21 -04:00
Tim Graham
4bc6b93994
Fixed #27039 -- Fixed empty data fallback to model field default in model forms.
2016-08-24 17:50:10 -04:00
Jon Dufresne
f5c6d3c8d9
Fixed #27068 -- Unified form field initial data retrieval.
2016-08-18 17:55:47 -07:00
Jon Dufresne
6b842c5998
Made BoundField.initial use cached_property.
...
Follow up to fab46ce6f5
.
2016-08-12 12:43:24 -07:00
Jon Dufresne
fab46ce6f5
Fixed #27037 -- Prevented required attribute on ClearableFileInput when initial data exists.
2016-08-12 13:59:01 -04:00
Andrew Nester
f5c6295797
Fixed #26844 -- Made formset's validate_min validation ignore empty forms.
2016-08-10 13:03:04 -04:00
Marcin Nowak
74bb013cc1
Fixed #26905 -- Allowed using MultiValueDict-like objects as form data.
2016-08-09 19:46:24 -04:00
Alex Hill
74105b2636
Fixed #27002 -- Prevented double query when rendering ModelChoiceField.
2016-08-08 13:41:05 -04:00
Claude Paroz
3569ba0333
Fixed #27015 -- Prevented HTML-invalid minlength/maxlength on hidden inputs
2016-08-06 10:22:17 +02:00
Jon Dufresne
50e299dbfb
Fixed #26928 -- Changed forms' checked attribute to HTML5 boolean style.
2016-08-04 19:16:54 -04:00
Alex Hill
c5ebfda002
Fixed #27001 -- Fixed a query count regression in ModelChoiceField with RadioSelect.
2016-08-03 10:45:55 -04:00
Jon Dufresne
ac3aaaa740
Fixed #26927 -- Made subwidget iteration pass disabled and required attributes.
2016-08-01 10:36:17 -04:00
Tim Graham
4e86168290
Fixed #26970 -- Fixed crash with disabled ModelMultipleChoiceField.
2016-07-30 13:31:48 -04:00
Tim Graham
a5f85d891b
Fixed #26917 -- Fixed crash in disabled ModelChoiceFields.
...
Partially reverted refs #25532 to fix a regression in Django 1.10.
This reintroduces a crash for disabled forms.JSONField (refs #26949 ),
however, that issue is also present on Django 1.9.
Thanks Ryan Schave for the test.
2016-07-27 08:14:14 -04:00
Priy
a7b5dfd170
Fixed #26821 -- Fixed forms.Email/URLField crash on None value.
2016-07-14 12:59:14 -04:00
Jon Dufresne
76e19da5b0
Fixed #26890 -- Fixed IntegerField crash on Unicode numbers.
2016-07-14 09:38:57 -04:00
Tim Graham
26d0023ccc
Refs #15667 -- Fixed crash when indexing RadioFieldRenderer with ModelChoiceIterator.
...
Regression in 86573861a9
2016-06-18 10:33:37 -04:00
Jon Dufresne
267dc4addd
Fixed #4136 -- Made ModelForm save empty values for nullable CharFields as NULL.
...
Previously, empty values were saved as strings.
2016-06-13 09:14:36 -04:00
David Sanders
5ec64f96b2
Fixed #26734 -- Made iterator class configurable on ModelChoiceField.
2016-06-09 11:10:26 -04:00
Tim Graham
67d984413c
Refs #24227 -- Removed ManyToManyField special casing in model_to_dict().
2016-05-11 10:12:59 -04:00
Tim Graham
86573861a9
Refs #15667 -- Removed choices argument from some RendererMixin methods.
...
RendererMixin will soon be removed but this removal and the corresponding
test changes stand on their own.
2016-04-28 18:48:52 -04:00
David Sanders
a5c8a6ce19
Fixed #21332 , #26538 -- Fixed inconsistent and duplicate form fields on inline formsets.
2016-04-26 10:26:25 -04:00
David Sanders
218175b09d
Fixed #26534 -- Fixed boolean form fields has_changed() with hidden input.
2016-04-24 15:06:30 -04:00
Tim Graham
859eeaa0f0
Fixed #26533 -- Renamed Widget._format_value() to format_value().
2016-04-23 13:15:45 -04:00
Loïc Bistuer
a885bca1df
Fixed #26528 -- Allowed any iterable (e.g. tuple) as validators kwarg for form/model fields.
2016-04-22 09:38:47 +07:00
Jon Dufresne
ec6121693f
Fixed #22383 -- Added support for HTML5 required attribute on required form fields.
2016-04-21 19:16:38 -04:00
Jon Dufresne
500e5a6886
Fixed #26516 -- Added minlength attribute when forms.CharField.min_length is set.
2016-04-19 08:54:27 -04:00
Tim Graham
3cb63b0e47
Refs #26502 -- Added choices to Form.__getitem__() KeyError message.
2016-04-14 09:15:09 -04:00
Michal Petrucha
c339a5a6f7
Refs #16508 -- Renamed the current "virtual" fields to "private".
...
The only reason why GenericForeignKey and GenericRelation are stored
separately inside _meta is that they need to be cloned for every model
subclass, but that's not true for any other virtual field. Actually,
it's only true for GenericRelation.
2016-04-13 10:10:53 -04:00
Tim Graham
df8d8d4292
Fixed E128 flake8 warnings in django/.
2016-04-08 09:51:06 -04:00
Tim Graham
2cd2d18851
Fixed W503 flake8 warnings.
2016-04-04 17:14:26 -04:00
Claude Paroz
db19619545
Fixed #25532 -- Properly redisplayed JSONField form input values
...
Thanks David Szotten for the report and Tommy Beadle for code inspiration.
Thanks Tim Graham for the review.
2016-04-01 09:04:20 +02:00
Simon Charette
1a403aa705
Fixed #25987 -- Made inline formset validation respect unique_together with an unsaved parent object.
...
Thanks Anton Kuzmichev for the report and Tim for the review.
2016-03-26 21:49:41 -04:00
Simon Charette
5974cbe32e
Removed unnecessary type creation in modelforset_factory.
2016-03-25 12:50:35 -04:00
Claude Paroz
983c158da7
Refs #24227 -- Replaced M2M isinstance checks by field.many_to_many
...
Thanks Markus Holtermann, Collin Anderson and Tim Graham for the reviews.
2016-03-19 09:24:27 +01:00
Yoong Kang Lim
d5f89ff6e8
Fixed #24974 -- Fixed inheritance of formfield_callback for modelform_factory forms.
2016-02-26 12:27:27 -05:00
Jon Dufresne
b412681359
Fixed #26267 -- Fixed BoundField to reallow slices of subwidgets.
2016-02-24 07:02:51 -05:00
Claude Paroz
d43156e1e9
Fixed #26238 -- Raised explicit error for non-editable field in ModelForm
...
Thanks Luke Crouch for the report and Simon Charette for the review.
2016-02-21 00:24:20 +01:00
haxoza
375e1cfe2b
Fixed #25349 -- Allowed a ModelForm to unset a fields with blank=True, required=False.
2016-02-19 14:18:53 -05:00
Berker Peksag
043383e3f3
Fixed #24727 -- Prevented ClearableFileInput from masking exceptions on Python 2
2016-02-15 22:51:46 +02:00
jpic
926e90132d
Fixed #25731 -- Removed unused choices kwarg for Select.render()
2016-02-02 18:03:19 -05:00
Tim Graham
04564eb74d
Fixed #26129 -- Made invalid forms display initial values of disabled fields.
2016-01-28 18:43:48 -05:00
jpic
65c13f9675
Refs #25731 -- Removed unused MultipleHiddenInput choices
2016-01-25 10:20:58 -05:00
Tim Graham
6b258befc2
Refs #26104 -- Replaced unnecessary force_str() with force_text().
2016-01-23 13:40:18 -05:00
Alexander Gaevsky
956cde8004
Fixed #26104 -- Fixed TypeError when passing number to forms.DurationField.
2016-01-22 16:24:49 -05:00
Claude Paroz
d91cc25a2a
Fixed #25942 -- Fixed TypedChoiceField.has_changed with nullable field
...
This fixes a regression introduced by 871440361
.
2015-12-17 15:38:19 +01:00
Johannes Hoppe
cf546e11ac
Fixed #21221 -- Made form Media and static template tag use staticfiles if installed.
2015-12-10 14:30:19 -05:00
Marti Raudsepp
1155843a41
Fixed #25683 -- Allowed ModelChoiceField(queryset=...) to accept Managers.
...
This fixes a regression from refs #25496 .
2015-11-09 12:42:36 -05:00
Claude Paroz
f59a0401e5
Fixed #25567 -- Removed obsolete MEDIA_URL fallback in Media.absolute_path
2015-10-19 15:39:35 +02:00
Tim Graham
6afa6818fc
Fixed #25496 -- Made ModelChoiceField respect prefetch_related().
2015-10-05 18:21:56 -04:00
Moritz Sichert
a51070e743
Refs #25294 -- Added BoundField import for backwards compatibility.
2015-09-24 19:57:19 +02:00
Tim Graham
a3fe4addcb
Refs #23162 -- Removed forms.Field._has_changed() method.
...
Per deprecation timeline.
2015-09-23 19:31:10 -04:00
Tim Graham
b6ea1961eb
Refs #23151 -- Removed RegexField.error_message per deprecation timeline.
2015-09-23 19:31:10 -04:00
Tim Graham
7cb3a48843
Fixed #25410 -- Fixed empty ClearableFileInput crash on Python 2.
...
Reverted "Fixes #24727 -- Prevented ClearableFileInput from masking
exceptions on Python 2" and added a regression test.
This reverts commit 5c412dd8a7
.
2015-09-23 10:26:19 -04:00
Claude Paroz
65a1055a36
Fixed #25431 -- Readded inline foreign keys to modelformset instances
...
Too much field exclusions in form's construct_instance() in _post_clean()
could lead to some unexpected missing ForeignKey values.
Fixes a regression from 45e049937
. Refs #13776 .
2015-09-21 21:30:49 +02:00
Iulia Chiriac
75ed590032
Fixed #24636 -- Added model field validation for decimal places and max digits.
2015-09-18 14:30:20 -04:00
Moritz Sichert
8550161e53
Refs #25294 -- Moved BoundField to django.forms.boundfield.
2015-09-16 14:43:38 -04:00
Moritz Sichert
535809e121
Fixed #25294 -- Allowed custom BoundFields on forms.
2015-09-16 10:18:07 -04:00
Kholid Fuadi
b8b776aabe
Fixed typo in django/forms/utils.py docstring.
2015-09-14 08:49:15 -04:00
Dražen Odobašić
b1e33ceced
Fixed #23395 -- Limited line lengths to 119 characters.
2015-09-12 11:40:50 -04:00
Keryn Knight
3c5862ccb0
Fixed #24706 -- Made ModelForm._post_clean() handle a ValidationError raised when constructing the model instance.
...
Thanks Loïc Bistuer for review and advice.
2015-09-07 14:36:39 -04:00
Tim Graham
97ac77e544
Removed BaseForm._raw_value().
...
Unused since efb0100ee6
.
2015-08-21 12:14:54 -04:00
Tim Graham
8656cfc4e0
Removed forms.models.save_instance() function.
...
As of b11564fd36
it's no longer
used elsewhere in Django and it isn't a documented public API.
Thanks Simon Charette for review.
2015-08-07 08:18:09 -04:00
Tim Graham
f2b665f886
Fixed #25241 -- Corrected ModelForm.save() error message when saving invalid form with UUIDField pk.
2015-08-07 07:44:59 -04:00
Curtis Maloney
c6c00fbfbb
Used @cached_property for BaseForm.changed_data.
2015-08-04 07:12:28 -04:00
Edward Henderson
f8cc464452
Fixed #16501 -- Added an allow_unicode parameter to SlugField.
...
Thanks Flavio Curella and Berker Peksag for the initial patch.
2015-07-17 13:48:58 -04:00
Claude Paroz
1ef4aeab40
Fixed #25078 -- Added support for disabled form fields
...
Thanks Keryn Knight and Tim Graham for the reviews.
2015-07-16 19:36:56 +02:00
George Brocklehurst
48af591b2d
Fixed #25124 -- Eased customization of SelectDateWidget subwidget.
2015-07-15 10:21:39 -04:00
Eric Carrillo
8ee6a3f1a8
Fixed #25085 -- Overrode Select widget's __deepcopy__()
2015-07-14 11:56:08 -04:00
Simon Litchfield
0ffa3943fb
Fixed #25097 -- Added BaseModelFormSet.delete_existing() hook.
2015-07-14 09:05:44 -04:00
Curtis
11cac1bd8e
Fixed #4960 -- Added "strip" option to CharField
2015-07-01 17:47:05 -04:00
Jason Hoos
a50b66da30
Fixed #24958 -- Fixed inline forms using UUID-PK parents with auto-PK children.
2015-06-26 09:09:09 -04:00
Tim Graham
aaacaeb096
Renamed RemovedInDjangoXYWarnings for new roadmap.
...
Forwardport of ae1d663b79
from stable/1.8.x plus more.
2015-06-24 16:08:20 -04:00
Andriy Sokolovskiy
cf6ce279c7
Fixed #24948 -- Fixed crash when uploading bitmap images in forms.ImageField
2015-06-16 14:37:58 -04:00
TMFGravyHands
339c01fb75
Allowed easier extendability of ChoiceFieldRenderer.
2015-06-11 10:15:52 -04:00
Matthew Schinckel
bbff3147f2
Made flatatt docstring match reality
...
The spirit of the docstring was correct, but referred to an outdated version of the function.
2015-06-08 13:57:25 +02:00
Markus Amalthea Magnuson
1884bf8e8e
Fixed #12437 -- Added css_classes to Form._html_output()
2015-06-06 19:23:06 -04:00
Russell Keith-Magee
5c35b4a8c9
Added release notes for feature added in fe21fb81
2015-06-05 11:42:58 +01:00
Russell Keith-Magee
fe21fb810a
Merge pull request #4757 from sergei-maertens/ticket_18166
...
Fixed #18166 -- Added ability to pass kwargs to the form constructor in a formset.
2015-06-05 11:10:28 +01:00
Alasdair Nicol
5987b3c46d
Removed comment from Form.changed_data; refs #24191
2015-06-04 13:51:26 -04:00
Sergei Maertens
238e2ac369
Fixed #18166 -- Added form_kwargs support to formsets.
...
By specifying form_kwargs when instantiating the formset, or overriding
the `get_form_kwargs` method on a formset class, you can pass extra
keyword arguments to the underlying `Form` instances.
Includes tests and documentation update.
2015-06-04 15:13:55 +02:00
Paweł Marczewski
4df7e8483b
Fixed #24788 -- Allowed Forms to specify a prefix at the class level.
2015-05-25 20:23:31 -04:00
Piotr Jakimiak
4157c502a5
Removed unnecessary arguments in .get method calls
2015-05-13 20:51:18 +02:00