David Smith
b9e872b593
Refs #32338 -- Removed 'for ="..."' from RadioSelect's <label>.
...
This improves accessibility for screen reader users.
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2021-06-22 10:59:29 +02:00
Nick Pope
46346f8ea0
Refs #32738 -- Added sanitize_strftime_format() to replace datetime_safe.
2021-05-12 14:42:17 +02:00
David Smith
54102d20b2
Improved performance of django.forms.ChoiceWidget.optgroups().
2021-01-27 21:10:11 +01:00
David Smith
6b01511f04
Removed unnecessary empty dict creation in ChoiceWidget.create_option().
...
build_atttrs() already creates an empty dict if extra_attrs is None.
2021-01-19 06:52:34 +01:00
David Smith
599f2f79e2
Fixed #30563 -- Optimized form Media by removing duplicated assets when adding.
2020-09-24 13:53:06 +02:00
Mariusz Felisiak
75d7af43c1
Corrected docstring quotes in various code.
2020-09-22 10:30:53 +02:00
Claude Paroz
00727d384b
Refs #30578 -- Made SelectDateWidget.format_value() independent of USE_L10N.
2020-07-10 13:00:37 +02:00
Mariusz Felisiak
0668164b4a
Fixed E128, E741 flake8 warnings.
2020-05-12 08:52:23 +02:00
Jon Dufresne
b2ef3d7157
Simplified Widget.get_context() a bit.
2020-05-06 06:46:58 +02:00
David Smith
27746ab28a
Fixed #7664 -- Allowed customizing suffixes of MultiWidget.widgets' names.
2020-03-24 20:05:18 +01:00
Shubham singh
ffcf1a8ebf
Fixed #31118 -- Made FileInput to avoid the required attribute when initial data exists.
2020-01-08 09:15:31 +01:00
Jon Dufresne
e703b93a65
Fixed #31080 -- Removed redundant type="text/javascript" attribute from <script> tags.
2019-12-11 09:49:54 +01:00
Peter Andersen
02eff7ef60
Fixed #31073 -- Prevented CheckboxInput.get_context() from mutating attrs.
2019-12-10 12:27:50 +01:00
Jon Dufresne
86a0231e0a
Refs #23919 -- Replaced super(...) with super() in metaclasses.
2019-11-28 15:34:29 +01:00
Carlton Gibson
ee4a19053a
Fixed #31012 -- Reverted "Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget."
...
This reverts commit f038214d91
.
The initial issue was incorrect. Django 2.2, and before, did not
generate invalid HTML as reported. With f03821 in place invalid HTML
was generated.
Thanks to Kevin Brown for follow-up report and investigation.
2019-11-21 20:53:31 +01:00
Hasan Ramezani
e3d0b4d550
Fixed #30899 -- Lazily compiled import time regular expressions.
2019-10-29 09:22:26 +01:00
Shubham Bhagat
26d16c07fd
Fixed #30578 - Made SelectDateWidget respect a custom date format when USE_L10N is disabled.
2019-06-26 11:07:11 +02:00
Hasan Ramezani
f038214d91
Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget.
...
placeholder is required for "select" with "required" attribute.
2019-05-08 12:46:30 +02:00
Matthias Kestenholz
231b513926
Fixed #30179 -- Fixed form Media merging when pairwise merging is insufficient.
...
Thanks gasman for the tests, and codingjoe and timgraham for the review.
2019-02-27 16:39:17 -05:00
Matthias Kestenholz
959d0c078a
Fixed #30153 -- Fixed incorrect form Media asset ordering after three way merge.
...
Delaying merging assets as long as possible avoids introducing
incorrect relative orderings that cause a broken final result.
2019-02-09 09:38:52 -05:00
Basil Dubyk
35a08b8541
Fixed #17210 -- Made NullBooleanSelect use unknown/true/false as query data.
2018-11-14 13:43:34 -05:00
Claude Paroz
f3b69f9757
Fixed #29273 -- Prevented initial selection of empty choice in multiple choice widgets.
...
Regression in b52c73008a
.
2018-04-02 08:52:53 -04:00
Tim Graham
87dc0844a6
Fixed #29200 -- Fixed label rendering when using RadioSelect and CheckboxSelectMultiple with MultiWidget.
2018-03-15 09:10:23 -04:00
Daniel Hahler
683341db43
Condensed some widgets code.
2018-03-03 13:35:09 -05:00
Mariusz Felisiak
074a2f7f58
Refs #28909 -- Simplifed code using unpacking generalizations.
2018-02-26 18:23:31 +01:00
Vlastimil Zíma
fbc3c29e7c
Fixed #29036 -- Fixed HTML5 required validation on SelectDateWidget if the attribute is added by JavaScript.
...
Thanks Tim Graham for the initial patch.
2018-01-30 19:09:31 -05:00
Tim Graham
5538729e4e
Fixed #29089 -- Avoided redundant date parsing in SelectDateWidget.format_value().
2018-01-30 18:11:05 -05:00
Jon Dufresne
ff05de760c
Fixed #29038 -- Removed closing slash from HTML void tags.
2018-01-21 02:09:10 -05:00
Jon Dufresne
47d238b696
Fixed #29041 -- Changed SelectMultiple's multiple attribute to HTML5 boolean syntax.
2018-01-20 11:19:06 -05:00
Jon Dufresne
90ca9412e4
Removed unnecessary microsecond truncation in SplitDateTimeWidget.
...
The microseconds are already truncated by the TimeInput subwidget.
2018-01-18 11:23:06 -05:00
Дилян Палаузов
a38ae914d8
Fixed #28996 -- Simplified some boolean constructs and removed trivial continue statements.
2018-01-12 12:44:50 -05:00
Nick Pope
d13a9e44de
Fixed #28909 -- Simplified code using tuple/list/set/dict unpacking.
2017-12-11 07:08:45 -05:00
Sergey Fedoseev
23a27f2c03
Simplified widgets.Select._choice_has_empty_value().
2017-12-08 08:14:25 +05:00
Tim Graham
2b81faab25
Fixed #28906 -- Removed unnecessary bool() calls.
2017-12-07 17:13:07 -05:00
Дилян Палаузов
c69e4bc691
Fixed #28769 -- Replaced 'x if x else y' with 'x or y'.
2017-11-07 09:08:46 -05:00
Tim Graham
6e4c6281db
Reverted "Fixed #27818 -- Replaced try/except/pass with contextlib.suppress()."
...
This reverts commit 550cb3a365
because try/except performs better.
2017-09-07 08:16:21 -04:00
Sergey Fedoseev
f0d9ede9e6
Removed useless itertools.chain() call in ChoiceWidget.optgroups().
2017-08-31 08:04:36 -04:00
caleb logan
9e2bf65d6a
Fixed #28530 -- Prevented SelectDateWidget from localizing years in output.
2017-08-29 14:56:08 -04:00
Collin Anderson
751f7a6d9b
Added Media.__repr__().
...
It makes it easier to debug MediaOrderConflictWarnings
(refs #28377 ).
2017-08-26 20:57:45 -04:00
Srinivas Reddy Thatiparthy
b5d47b18f1
Removed unnecessary else in SelectDateWidget.id_for_lable().
2017-08-07 22:01:45 -04:00
Johannes Hoppe
c19b56f633
Fixed #28377 -- Made combining form Media retain relative asset order.
...
Thanks Florian Apolloner, Mariusz Felisiak, and Tim Graham for reviews.
2017-07-20 11:06:30 -04:00
Roman Selivanov
d4da39685b
Fixed #28414 -- Fixed ClearableFileInput rendering as a subwidget of MultiWidget.
2017-07-19 14:28:06 -04:00
Mads Jensen
550cb3a365
Fixed #27818 -- Replaced try/except/pass with contextlib.suppress().
2017-06-28 14:07:55 -04:00
Tim Graham
221e6e1817
Fixed #28176 -- Restored the uncasted option value in ChoiceWidget template context.
2017-06-17 18:17:23 -04:00
Jon Dufresne
21046e7773
Fixed #28249 -- Removed unnecessary dict.keys() calls.
...
iter(dict) is equivalent to iter(dict.keys()).
2017-05-27 19:08:46 -04:00
Tim Graham
d302e2c09c
Fixed #28157 -- Fixed choice ordering in form fields with grouped and non-grouped options.
...
Regression in b52c73008a
.
2017-05-03 07:21:44 -04:00
Claude Paroz
301de774c2
Refs #27795 -- Replaced many force_text() with str()
...
Thanks Tim Graham for the review.
2017-04-27 09:10:02 +02:00
Jon Dufresne
92bc727271
Replaced temporary lists used for passing arguments with iterables.
2017-04-26 10:54:20 -04:00
Jon Dufresne
3e91850dcc
Removed unneeded is True|False from bool expressions in widgets.py.
2017-04-21 12:34:18 -04:00
Jon Dufresne
581879a510
Fixed #28075 -- Prevented ChoiceWidget from localizing option values.
2017-04-21 12:14:40 -04:00