Florian Apolloner
41d7a9a907
Moved test_templates to templates to prevent issues with regressiontests/templates later on.
2013-02-26 14:36:57 +01:00
Aymeric Augustin
8dd8400f7e
Updated an inaccurate comment.
...
Tests can run nearly as fast under PostgreSQL and MySQL as under SQLite
with a bit of configuration and the speedup is always a good thing.
2013-02-26 10:00:14 +01:00
Carl Meyer
6a8f95d812
Fixed a caching test on Python 3.
2013-02-25 18:12:55 -07:00
Łukasz Langa
6a057e1595
Fixed #18191 -- Don't consider Accept-Language redundantly in cache key.
...
Thanks to choongmin for the original patch.
2013-02-25 16:10:57 -07:00
Aymeric Augustin
e76147a83a
Fixed #19634 -- Added proper __hash__ methods.
...
Classes overriding __eq__ need a __hash__ such that equal objects have
the same hash.
Thanks akaariai for the report and regebro for the patch.
2013-02-25 23:05:20 +01:00
Carl Meyer
509798ae06
Use built-in fixture support rather than calling loaddata in setUp().
2013-02-25 12:13:10 -07:00
Aymeric Augustin
86b96038f2
Merge pull request #847 from fhahn/ticket_18176
...
Fixed #18176 -- Added test for year lookups with year < 1000
2013-02-25 09:26:56 -08:00
Carl Meyer
906dc8522a
Fixed #19854 -- Turn Django's own Selenium tests off by default.
2013-02-25 10:14:42 -07:00
Florian Hahn
f28c301a47
Fixed #18176 -- Added test for year lookups with year < 1000
...
Thanks Tomas Ehrlich for the initial test
2013-02-25 17:13:27 +01:00
Claude Paroz
6d52bcbb7c
Fixed #19903 -- Fixed unbalanced setUp/tearDown calls in LiveServerAddress test
2013-02-25 08:58:11 +01:00
Aymeric Augustin
7b49da1c38
Changed testing strategy used in 6b03179e
.
...
Avoid polluting the app cache as it causes unrelated test failures.
Refs #19688 .
2013-02-25 00:09:13 +01:00
Julien Phalip
ae2a8bb456
Fixed a test that was failing in Python 3.
...
The issue was that as of Python 3, the generators' `next()`
method becomes `__next()`. Thanks Alex Gaynor for noticing that.
Refs #19890 .
2013-02-24 13:47:14 -08:00
Julien Phalip
a8449d4362
Merge pull request #824 from ambv/languagecode
2013-02-24 12:56:14 -08:00
Simon Charette
6b03179e12
Fixed #19688 -- Allow model subclassing with a custom metaclass using six.with_metaclass
2013-02-24 17:32:34 +01:00
Christopher Medrela
636c45fc58
Fixed #19890 -- ifchanged templatetag rendered its content twice
...
The content of ifchanged template tag was rendered twice: first time, to
compare it with the previous value and the second time, to return the
rendered output.
2013-02-24 16:49:28 +01:00
Diederik van der Boor
8503120c10
Fixed #15849 -- Made IfChanged node thread safe.
...
Previously, the ifchanged node stored state on `self._last_seen`,
thereby giving undesired results when the node is reused by another
thread at the same time (e.g. globally caching a Template object).
Thanks to akaihola for the report and Diederik van der Boor and
Bas Peschier for the patch.
2013-02-24 16:06:55 +01:00
Zbigniew Siciarz
0a8402eb05
Test case and docs for custom context data in feeds
...
Thanks Paul Winkler for the initial patch. (Ref #18112 ).
2013-02-24 08:33:20 -06:00
Florian Apolloner
4506ae0497
Merge pull request #717 from slurms/ticket_19746
...
Fixed #19746 -- Allow deserialization of pk-less data
2013-02-24 06:31:14 -08:00
Łukasz Langa
8c8f94fe9d
Fixes #19763 - LocaleMiddleware should check for supported languages in settings.LANGUAGE_CODE
2013-02-24 14:43:45 +01:00
Tomek Paczkowski
99edbe0e27
Fixed #19253 -- Extracted template cache key building logic
...
Introduced a public function
django.core.cache.utils.make_template_fragment_key
Thanks @chrismedrela for fruitful cooperation.
2013-02-24 14:32:45 +01:00
Aymeric Augustin
7106a1e594
Merge pull request #819 from erikr/master
...
Fixed #16302 -- Ensured contrib.comments is IPv6 capable.
2013-02-24 05:02:00 -08:00
Erik Romijn
ade992c61e
Fixed #16302 -- Ensure contrib.comments is IPv6 capable
...
Changed the ip_address field for Comment to GenericIPAddressField. Added
instructions to the release notes on how to update the schema of existing
databases.
2013-02-24 13:58:38 +01:00
Bas Peschier
5a9b2bce24
Fixed #19810 -- MemcachedCache now uses pickle.HIGHEST_PROTOCOL
2013-02-24 13:56:15 +01:00
Wiktor Kolodziej
f07a5f0a21
Fixed #11295 : If ModelAdmin.queryset returns a filtered QS don't require a 2nd count call
...
Original patch rewritten, added tests and get_filters_params method for ChangeList class.
Thanks Alex for the report.
2013-02-24 13:23:23 +01:00
Florian Apolloner
e4ee3d8fca
Fixed a few ResourceWarnings.
2013-02-24 13:11:19 +01:00
Honza Král
e4e1287590
Merge pull request #817 from rybaktomasz/ticket_5568
...
Fixes #5568 -- DROP INDEX subcommand
2013-02-24 04:02:26 -08:00
Honza Kral
cbb9f629b8
Revert "fixes #19263" - Fails if not SQLite
...
This reverts commit 2b76f19f2b
.
2013-02-24 12:38:32 +01:00
Tomasz Rybak
d7429defe6
Add sqldropindexes to manage
...
Change patch from https://code.djangoproject.com/ticket/5568
to work on modern Django.
Add special case for MySQL which has different syntax for DROP INDEX.
Add unit tests for the new functionality.
2013-02-24 12:38:28 +01:00
Honza Kral
5a6a4249f3
Removing unneeded tearDown code.
2013-02-24 12:31:00 +01:00
George Song
44164c5c30
Fixed #19896 -- Committed after clearing cache in the database.
2013-02-24 12:15:02 +01:00
Florian Apolloner
f56ca3f0e6
Fixed the usage of the deprecated assertEquals.
2013-02-24 11:15:17 +01:00
Aymeric Augustin
c10ed58746
Caught warnings in the templates tests. Refs #17906 .
...
This was missing from f49e9a517f
.
2013-02-24 10:28:05 +01:00
Honza Král
fc38d6a92b
Merge pull request #813 from HiddenData/ticket-19263
...
fixes #19263 - EmptyResultSet in subquery causes incorrect SQL
2013-02-23 15:05:24 -08:00
Marcin Biernat
2b76f19f2b
fixes #19263
2013-02-23 23:53:46 +01:00
Honza Král
692902b227
Merge pull request #778 from viciu/19609
...
Fixed #19609 : admin Inlines doesn't display help_text for readonly fields
2013-02-23 14:34:57 -08:00
Honza Kral
ef1e6ef1eb
Merge branch 'ticket19872' of https://github.com/oinopion/django
2013-02-23 23:32:09 +01:00
Honza Kral
2b48fcc607
Fixed #18491 -- deleting a proxy doesn't show warning about cascade deletes
2013-02-23 23:20:34 +01:00
Tomek Paczkowski
b88abd6840
Fixed #19872
...
Made cached_property to behave as property when accessed via class.
2013-02-23 23:20:00 +01:00
Aleksandra Sendecka
32a7ab2148
Fixed #19526
...
CSS specifications governs that syntax is case insensitive.
This modifies CachedFilesMixin to support that.
2013-02-23 23:05:22 +01:00
Klaas van Schelven
1c11ee6345
Fixed #18829 -- Fixed ModelChoiceIterator length
...
Thanks facundo.olano at gmail.com for the report and thikonom for
the initial patch.
2013-02-23 22:27:07 +01:00
Alex Gaynor
150e202172
Some style fixes for stuff that was clearly brough tover from doctests.
2013-02-23 13:04:08 -08:00
Honza Král
10026c2ad0
Merge pull request #804 from oinopion/ticket18162
...
Fixes #18162 -- Specifying choices to Field overrides any form_class argument
2013-02-23 12:45:39 -08:00
Grzegorz Nosek
2cd0edaa47
Fixed 19895 -- Made second iteration over invalid queryset raise an exception too
...
When iteration over a queryset raised an exception, the result cache
remained initialized with an empty list, so subsequent iterations returned
an empty list instead of raising an exception
2013-02-23 14:35:27 -06:00
Łukasz Langa
539900f117
Fixes #17866 : Vary: Accept-Language header when language prefix used
2013-02-23 19:41:33 +01:00
Honza Kral
bfd4a71d41
One last final fix for 0ad76843
. Tested on py3 and py2
2013-02-23 19:27:37 +01:00
Honza Král
0a341ab40d
Merge pull request #791 from khalas/ticket_19811
...
Changed %r to %s in get_language_info error message
2013-02-23 10:16:23 -08:00
Tomek Paczkowski
b6f4a92ff4
Proposed fix for #18162 .
2013-02-23 19:01:38 +01:00
Konrad Hałas
48dc0cbf2a
Changed %r to %s in get_language_info error message.
2013-02-23 18:54:54 +01:00
Florian Apolloner
f368c25f10
Fixed errors introduced in 664855b74e
2013-02-23 18:47:36 +01:00
Florian Apolloner
5ae0c933a8
Fixed errors introduced in 21f333bcef
. Refs #17751
2013-02-23 18:43:34 +01:00
Claude Paroz
cc53d9b30b
Fixed #15877 -- Improved exception when ModelForm has no model class
...
Thanks theaspect at gmail.com for the report and volrath for the
patch.
2013-02-23 18:32:29 +01:00
Wiktor Kolodziej
67dd54dc84
Fixed #19609 : admin Inlines doesn't display help_text for readonly fields
...
Refactoring: field was renamed to field_name, since flatten_fieldsets returns field name, not field.
Original patch from Marc Aymerich Gubern
2013-02-23 18:24:32 +01:00
Honza Král
a05ab448f7
Merge pull request #781 from zsiciarz/ticket_19854
...
Fixed #19854 -- Added test runner option to skip Selenium tests
2013-02-23 08:55:34 -08:00
Zbigniew Siciarz
1cd2f51eb4
Added test runner option to skip Selenium tests ( #19854 ).
2013-02-23 17:45:26 +01:00
Claude Paroz
335a060fa6
Minor cleanups in templates test imports
2013-02-23 17:45:05 +01:00
Lennart Regebro
687d2e967d
Fixed #19827 -- Kept stacktrace in defaulttags exception reraising
...
Thanks Kronuz for the report and the initial patch.
2013-02-23 17:43:17 +01:00
Honza Král
0ad76843b5
Merge pull request #777 from khalas/ticket_19811
...
Fixed #19811 - Added language code fallback in get_language_info
2013-02-23 08:30:27 -08:00
Honza Král
129d2e8f85
Merge pull request #775 from HiddenData/ticket-18899
...
Fixed #18899 -- FileSystemStorage.save should support any file-like objects
2013-02-23 08:04:41 -08:00
Konrad Hałas
6bd6a56896
Fixed #19811 - Added language code fallback in get_language_info.
2013-02-23 17:02:07 +01:00
Aymeric Augustin
5278776a88
Merge pull request #751 from bmispelon/ticket-6271
2013-02-23 07:47:58 -08:00
Marcin Biernat
664855b74e
#18899 FileSystemStorage.save should support any file-like objects
2013-02-23 16:40:50 +01:00
Vladimir A Filonov
f49e9a517f
Fixed #17906 - Autoescaping {% cycle %} and {% firstof %} templatetags.
...
This commit adds "future" version of these two tags with auto-escaping
enabled.
2013-02-23 16:16:39 +01:00
Tomek Paczkowski
3dddbc0f23
Fixed #19816 : pre-evaluate queryset on m2m set
...
In ReverseManyRelatedObjectsDescriptor.__set__, evaluate possible
queryset to avoid problems when clear() would touch data this queryset
returns.
2013-02-23 15:50:33 +01:00
Baptiste Mispelon
069280a689
Used token.split_contents() for tokenisation in template tags accepting variables.
...
Fixed #6271 , #18260 .
2013-02-23 15:15:30 +01:00
Erik Romijn
21f333bcef
Fix #17751 : Added stripping of whitespace for IPAddressField/GenericIPAddressField
2013-02-23 14:44:57 +01:00
Claude Paroz
7ec2a21be1
Fixed #19686 -- Added HTML5 number input type
...
Thanks Simon Charette for his help on the patch. Refs #16630 .
2013-02-23 10:18:08 +01:00
Anssi Kääriäinen
dcf651c27e
Fixed Oracle specific failures in commands_sql tests
2013-02-23 01:08:48 +02:00
Anssi Kääriäinen
f565c6f999
Marked a test as expected failure. Refs #19884
2013-02-23 00:33:02 +02:00
Anssi Kääriäinen
88c726bea0
Skipped a test on Oracle
2013-02-23 00:33:02 +02:00
Anssi Kääriäinen
09fcb70c80
Fixed empty strings + to_field regression on Oracle
...
Querying the reverse side of nullable to_field relation, where both
sides can contain null values resulted in incorrect results. The reason
was not detecting '' as NULL.
Refs #17541
2013-02-23 00:05:31 +02:00
Baptiste Mispelon
f13bfbec70
Fixed #19882 -- Smarter tokenizing of {% for %} tag arguments.
2013-02-22 19:19:33 +01:00
Anssi Kääriäinen
3c6318e831
Fixed #19870 -- Regression in select_related in inheritance cases
...
There was a regression in case two models inherited the same parent,
and one contained a foreign key to other. When select_related travelled
the foreign key the other model reused the parent join made by the
first model. This was likely caused by Query.join_parent_model()
addition in commit 68985db482
.
Thanks to Trac alias loic84 for report & tests.
2013-02-21 12:01:23 +02:00
Anssi Kääriäinen
50677b29af
Made a couple of selenium tests wait for page loaded
...
The admin_widgets tests were issuing click() to the browser but
didn't wait for the effects of those clicks. This caused the resulting
request to be processed concurrently with the test case. When using
in-memory SQLite this caused weird failures.
Also added wait_page_loaded() to admin selenium tests for code
reuse.
Fixed #19856
2013-02-20 23:56:57 +02:00
Anssi Kääriäinen
e8fc3f3783
Added a test for negated Q object querying
...
The added test is from the patch in ticket #19672 (written by Ian
Kelly). Fixed #19672 , refs #19849 .
2013-02-20 21:45:36 +02:00
Anssi Kääriäinen
edf93127bf
Removed join() promote kwarg
...
The join promote=True was over-aggressive in select_related handling.
After that was removed, the only other user was query.combine(). That
use case is very easy to handle locally, so there is no more need for
the join(promote=True) flag.
Refs #19849 .
2013-02-20 21:43:44 +02:00
Anssi Kääriäinen
3fef304ff2
Refactored negated IS NULL handling
...
This one cleaned up add_filter() negated filter generation. As a side
effect split_exclude() was cleaned up, too.
Refs #19849
2013-02-20 21:34:01 +02:00
Alex Gaynor
b55cde054e
Added a db_constraint option to ForeignKeys.
...
This controls whether or not a database level cosntraint is created. This is useful in a few specialized circumstances, but in general should not be used!
2013-02-20 11:27:32 -08:00
Claude Paroz
ae2d04f726
Add test for collapsible fieldset functionality in admin
2013-02-20 13:48:49 +01:00
Aymeric Augustin
35c991aa06
Added a default limit to the maximum number of forms in a formset.
...
This is a security fix. Disclosure and advisory coming shortly.
2013-02-19 11:23:30 -07:00
Carl Meyer
1f39eafd60
Checked object permissions on admin history view.
...
This is a security fix. Disclosure and advisory coming shortly.
Patch by Russell Keith-Magee.
2013-02-19 11:23:30 -07:00
Carl Meyer
c6d69c12ea
Restrict the XML deserializer to prevent network and entity-expansion DoS attacks.
...
This is a security fix. Disclosure and advisory coming shortly.
2013-02-19 11:23:30 -07:00
Carl Meyer
d51fb74360
Added a new required ALLOWED_HOSTS setting for HTTP host header validation.
...
This is a security fix; disclosure and advisory coming shortly.
2013-02-19 11:23:29 -07:00
Anssi Kääriäinen
4b9fa49bc0
Avoided related_name conflicts in tests
2013-02-19 03:13:13 +02:00
Anssi Kääriäinen
607772b942
Removed accidentally committed file
2013-02-19 01:55:40 +02:00
Florian Hahn
3e71368423
Fixed #10870 -- Added aggreation + generic reverse relation test
2013-02-19 01:42:02 +02:00
Anssi Kääriäinen
b4492a8ca4
Fixed #19837 -- Refactored split_exclude() join generation
...
The refactoring mainly concentrates on making sure the inner and outer
query agree about the split position. The split position is where the
multijoin happens, and thus the split position also determines the
columns used in the "WHERE col1 IN (SELECT col2 from ...)" condition.
This commit fixes a regression caused by #10790 and commit
69597e5bcc
. The regression was caused
by wrong cols in the split position.
2013-02-19 01:10:49 +02:00
Aymeric Augustin
aea98e8c53
Simplified MySQL version checking.
...
Django used to check the version of MySQL before handling the first
request, which required:
- opening a connection
- closing it, to avoid holding it idle until the first request.
This code isn't necessary any longer since Django dropped support for
some versions of MySQL, and other database backends don't implement a
similar dance. For consistency and maintenability, remove it.
Reverts 4423757c0c
.
Closes #18135 .
2013-02-18 21:46:26 +01:00
Aymeric Augustin
92837ae569
Avoided firing the request_finished signal in tests.
...
* Avoided calling BaseHttpResponse.close(). The test client take care of
that since acc5396e
.
* Disconnected the request_finished signal when this method must be
called. The test client has a similar implementation since bacb097a
.
2013-02-18 14:32:45 +01:00
Claude Paroz
632361611c
Fixed #19833 -- Fixed import parameter encoding in get_runner
...
Thanks Danilo Bargen for the report.
2013-02-16 13:31:13 +01:00
Aymeric Augustin
e74e207cce
Fixed #17260 -- Added time zone aware aggregation and lookups.
...
Thanks Carl Meyer for the review.
Squashed commit of the following:
commit 4f290bdb60
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Wed Feb 13 21:21:30 2013 +0100
Used '0:00' instead of 'UTC' which doesn't always exist in Oracle.
Thanks Ian Kelly for the suggestion.
commit 01b6366f3c
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Wed Feb 13 13:38:43 2013 +0100
Made tzname a parameter of datetime_extract/trunc_sql.
This is required to work around a bug in Oracle.
commit 924a144ef8
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Wed Feb 13 14:47:44 2013 +0100
Added support for parameters in SELECT clauses.
commit b4351d2890
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Mon Feb 11 22:30:22 2013 +0100
Documented backwards incompatibilities in the two previous commits.
commit 91ef84713c
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Mon Feb 11 09:42:31 2013 +0100
Used QuerySet.datetimes for the admin's date_hierarchy.
commit 0d0de288a5
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Mon Feb 11 09:29:38 2013 +0100
Used QuerySet.datetimes in date-based generic views.
commit 9c0859ff7c
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 21:43:25 2013 +0100
Implemented QuerySet.datetimes on Oracle.
commit 68ab511a4f
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 21:43:14 2013 +0100
Implemented QuerySet.datetimes on MySQL.
commit 22d52681d3
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 21:42:29 2013 +0100
Implemented QuerySet.datetimes on SQLite.
commit f6800fd04c
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 21:43:03 2013 +0100
Implemented QuerySet.datetimes on PostgreSQL.
commit 0c829c23f4
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 21:41:08 2013 +0100
Added datetime-handling infrastructure in the ORM layers.
commit 104d82a777
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Mon Feb 11 10:05:55 2013 +0100
Updated null_queries tests to avoid clashing with the __second lookup.
commit c01bbb3235
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 23:07:41 2013 +0100
Updated tests of .dates().
Replaced .dates() by .datetimes() for DateTimeFields.
Replaced dates with datetimes in the expected output for DateFields.
commit 50fb7a5246
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 21:40:09 2013 +0100
Updated and added tests for QuerySet.datetimes.
commit a8451a5004
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 22:34:46 2013 +0100
Documented the new time lookups and updated the date lookups.
commit 29413eab2b
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Feb 10 16:15:49 2013 +0100
Documented QuerySet.datetimes and updated QuerySet.dates.
2013-02-16 09:19:04 +01:00
Claude Paroz
b19d83fc12
Improved input sanitizing with thousand separators
...
For languages with non-breaking space as thousand separator,
standard space input should also be allowed, as few people know
how to enter non-breaking space on keyboards. Refs #17217 .
Thanks Alexey Boriskin for the report and initial patch.
2013-02-15 16:37:52 +01:00
Claude Paroz
dcf8cd30ae
Updated FormattingTests test case to use settings contexts
2013-02-15 09:37:12 +01:00
Julien Phalip
7d5e35cdb4
Fixed #19829 -- Fixed index lookups for NumPy arrays in templates.
2013-02-14 23:29:15 -08:00
Michael van Tellingen
138de533ff
Fixed #19819 - Improved template filter errors handling.
...
Wrap the Parser.compile_filter method call with a try/except and call the
newly added Parser.compile_filter_error(). Overwrite this method in the
DebugParser to throw the correct error.
Since this error was otherwise catched by the compile_function try/except
block the debugger highlighted the wrong line.
2013-02-14 10:22:59 +01:00
Claude Paroz
ac4faa6dc3
Fixed #19693 -- Made truncatewords_html handle self-closing tags
...
Thanks sneawo for the report and Jonathan Loy for the patch.
2013-02-13 18:24:49 +01:00
Hiroki Kiyohara
e94f405d94
Fixed #18558 -- Added url property to HttpResponseRedirect*
...
Thanks coolRR for the report.
2013-02-13 10:29:32 +01:00
Anssi Kääriäinen
fafee74306
Removed try-except in django.db.close_connection()
...
The reason was that the except clause needed to remove a connection
from the django.db.connections dict, but other parts of Django do not
expect this to happen. In addition the except clause was silently
swallowing the exception messages.
Refs #19707 , special thanks to Carl Meyer for pointing out that this
approach should be taken.
2013-02-13 00:25:09 +02:00
Nick Sandford
278dad5b41
Fixed #19746 -- Allow deserialization of pk-less data
2013-02-12 17:10:42 +08:00
Simon Charette
a10f390804
Fixed #19044 -- Made `DeletionMixin` interpolate its `success_url`.
...
Thanks to nxvl and slurms for the initial patch, ptone for the review
and timo for the documentation tweaks.
2013-02-11 02:39:14 -05:00
Anssi Kääriäinen
604d8763dc
Fixed #19112 -- Reduced the amount of query params in a test
2013-02-10 21:08:19 +02:00
Anssi Kääriäinen
8ef3235034
Fixed #19720 -- Oracle ordering related delete regression
...
When a query had a complex where condition (a condition targeting more
than the base table) a subquery was used for deletion. However, the
query had default ordering from the model's meta and Oracle doesn't
work with ordered subqueries.
The regression was caused by fast-path deletion code introduced in
1cd6e04cd4
for fixing #18676 .
Thanks to Dylan Klomparens for the report.
2013-02-10 19:54:02 +02:00
Anssi Kääriäinen
a4e97cf315
Fixed #19707 -- Reset transaction state after requests
2013-02-10 13:55:54 +02:00
Claude Paroz
718afcafc2
Added tests for some sql_* management commands
2013-02-09 16:34:22 +01:00
Claude Paroz
f44922c795
Fixed #18906 -- Ignored to-be-deleted forms in formset validate_unique
...
Thanks c.pollock at bangor.ac.uk for the report.
2013-02-08 21:35:19 +01:00
Julien Phalip
db09a2de6e
Cleaned up some lingering signals in the test suite that were causing spurious failures with Pypy and Postgres.
2013-02-08 12:12:03 -08:00
Ramiro Morales
b5391515cd
Changed test assertion strategy used in 04d9730
.
2013-02-07 16:51:27 -03:00
Ramiro Morales
04d9730b12
Fixed #13085 -- Don't fail on creation of model with GFK to a model with __len__() returning zero.
...
Also, according to the comments on the ticket and its duplicates, added
tests execising saving an instance of a model with a GFK to:
* An unsaved object -- This actually doesn't generate the same failure
but another ORM-level exception. The test verifies it's the case.
* An instance of a model with a __nonzero__() method thant returns False
for it. This doesn't fail because that code path isn't executed.
* An instance of a model with a CharField PK and an empty value for it.
This doesn't fail.
2013-02-07 16:05:54 -03:00
Aymeric Augustin
720888a146
Fixed #15808 -- Added optional HttpOnly flag to the CSRF Cookie.
...
Thanks Samuel Lavitt for the report and Sascha Peilicke for the patch.
2013-02-07 09:48:08 +01:00
Julien Phalip
6afc85af47
Fixed a typo in the test suite that was causing some spurious failures with pypy.
2013-02-06 22:10:13 -08:00
Alexey Boriskin
d18f796a48
Fixed #19704 -- Make use of new ungettext_lazy function at appropriate places
2013-02-06 22:01:55 +01:00
Claude Paroz
d7504a3d7b
Improved regex in strip_tags
...
Thanks Pablo Recio for the report. Refs #19237 .
2013-02-06 21:20:43 +01:00
Simon Charette
5449240c54
Fixed #9800 -- Allow "isPermaLink" attribute in <guid> element of an RSS item.
...
Thanks @rtnpro for the patch!
2013-02-06 05:28:05 -05:00
Simon Charette
a097ee32d8
Fixed #17683 -- Make sure `BaseModelFormSet` respects defined widgets.
2013-02-05 05:39:35 -05:00
Simon Charette
ec469ade2b
Fixed #19689 -- Renamed `Model._meta.module_name` to `model_name`.
2013-02-05 04:16:07 -05:00
Claude Paroz
40260bc30b
Fixed error message test assertions under Python 3.3
...
Thanks Florian Apolloner for testing.
2013-02-04 18:00:19 +01:00
Claude Paroz
7c5b244826
Fixed #17061 -- Factored out importing object from a dotted path
...
Thanks Carl Meyer for the report.
2013-02-04 16:38:25 +01:00
Ramiro Morales
869c9ba306
Fixed #19730 -- Don't validate importability of settings by using i18n in management commands.
...
They are handled independently now and the latter can be influenced by
the new BaseCommand.leave_locale_alone internal option.
Thanks chrischambers for the report, Claude, lpiatek, neaf and gabooo for
their work on a patch, originally on refs. #17379 .
2013-02-03 23:40:38 -03:00
Anssi Kääriäinen
f556df90be
Fixed #19645 -- Added tests for TransactionMiddleware
2013-02-03 16:26:46 +02:00
Julien Phalip
bc7a219b1e
Fixed Python 3.2 compatibility for a test.
2013-02-02 20:57:38 -08:00
Julien Phalip
293f7a2114
Fixed #17797 -- Enabled support for PATCH requests in the dummy test client. Thanks to pfarmer for the suggestion and initial patch.
2013-02-02 18:22:40 -08:00
Ramiro Morales
08dc90bccf
Fixed #14305 -- Switched inspectdb to create unmanaged models.
...
Thanks Ian Kelly for the report and initial patch.
2013-02-02 21:11:32 -03:00
Nick Sandford
0694d2196f
Fixed #19445 -- Skip admin fieldsets validation when the ModelAdmin.get_form() method is overridden.
2013-02-02 14:53:46 -08:00
Aymeric Augustin
ace9d4efc3
Made ungettext_lazy usable for messages that do not contain the count.
...
Fixed #19160 (again). Thanks Alexey Boriskin.
2013-02-02 10:58:31 +01:00
Aymeric Augustin
db5049c9f7
Fixed the test introduced in 2ca37af6
under Python 3.
2013-02-02 10:42:01 +01:00
Ramiro Morales
2ca37af621
Added test to demonstrate issue 11387 isn't there anymore.
...
Thanks adurdin for the report and patch. Fixes #11387 .
2013-02-01 23:30:50 -03:00
Ramiro Morales
c4b6659269
Added test to demonstrate issue 11263 isn't there anymore.
...
Thanks veena for the report and jaklaassen for the patch. Fixes #11263 .
2013-02-01 23:30:50 -03:00
Claude Paroz
04141c525d
Fixed #19663 -- Allowed None in colorize() text parameter
...
Thanks Jonathan Liuti for the report and the initial patch, and
Simon Charette for the review.
2013-02-01 22:53:18 +01:00
Matt Robenolt
393c268e72
Fixed #19715 -- Simplified findstatic output when verbosity set to 0
2013-02-01 11:55:05 +01:00
Simon Charette
339944491c
Renamed inspectdb field names for clarity
2013-02-01 09:16:29 +01:00
Claude Paroz
7bbd17bf20
Fixed #19341 -- Detected NullBooleanField when introspecting models
...
Thanks Tim Bowden for the report.
2013-01-31 20:55:00 +01:00
Claude Paroz
3c0a81aaf0
Fixed #19709 -- Fixed TimeField introspection on MySQL
...
Thanks Eugene Grachev for the report.
2013-01-31 20:41:57 +01:00
Claude Paroz
eb03fe1642
Added introspection tests for most of Django model fields
2013-01-31 20:41:57 +01:00
Ramiro Morales
7947c9e3a6
Deprecated undocumented warnings manipulation testing tools.
2013-01-31 14:57:45 -03:00
Aymeric Augustin
9a4a1ce323
Fixed #19708 -- Exception in timezone.override(None).
...
Thanks rafales.
2013-01-31 16:01:50 +01:00
Aymeric Augustin
89cb771be7
Fixed #19692 -- Completed deprecation of mimetype in favor of content_type.
...
Thanks Tim for the report and initial patch.
2013-01-31 13:54:40 +01:00
Aymeric Augustin
3895ebc734
Added file forgotten in 23e319d7
.
2013-01-30 22:11:53 +01:00
Aymeric Augustin
23e319d729
Fixed #19076 -- Added content_type attribute to TemplateView.
...
Thanks Gavin Wahl.
2013-01-30 21:26:17 +01:00
Aymeric Augustin
3f1a0c0040
Fixed #19160 -- Made lazy plural translations usable.
...
Many thanks to Alexey Boriskin, Claude Paroz and Julien Phalip.
2013-01-30 20:28:16 +01:00
Ramiro Morales
47ddd6a408
Fixed #19552 -- Enhanced makemessages handling of ``{# #}``-style template comments.
...
They are simply ignored now. This allows for a more correct behavior when
they are placed before translatable constructs on the same line.
Previously, the latter were wrongly ignored because the former were
preserved when converting template code to the internal Python-syntax
form later fed to xgettext but Python has no ``/* ... */``-style
comments.
Also, special comments directed to translators are now only taken in
account when they are located at the end of a line. e.g.::
{# Translators: ignored #}{% trans "Literal A" %}{# Translators: valid, associated with "Literal B" below #}
{% trans "Literal B" %}
Behavior of ``{% comment %}...{% endcomment %}``tags remains unchanged.
Thanks juneih at redpill-linpro dot com for the report and Claude for
his work on the issue.
2013-01-29 19:13:23 -03:00
Tim Graham
ee26797cff
Fixed typos in docs and comments
2013-01-29 10:55:55 -07:00
Claude Paroz
f7394d2c32
Added HTML5 url input type
...
Refs #16630 .
2013-01-28 22:11:00 +01:00
Claude Paroz
4f16376274
Added HTML5 email input type
...
Refs #16630 .
2013-01-28 22:10:50 +01:00
Aymeric Augustin
c47fa3b481
Fixed #19676 -- Supported 'self' foreign keys in inspectdb.
...
Thanks Georgy Kutsurua for the report and Simon Charette for the patch.
2013-01-28 10:21:07 +01:00
Aymeric Augustin
f46d7314b5
Fixed #19677 -- Introspection of recursive foreign keys under SQLite.
...
Thanks Simon Charette.
2013-01-28 10:17:56 +01:00
Claude Paroz
4b3f7110ae
Fixed #16123 -- Ensured strptime receive proper string type
...
strptime generates an UnicodeEncodeError when using a non-ascii
unicode string on Python 2.
2013-01-26 20:53:09 +01:00
Aymeric Augustin
6605ac331a
Fixed #17158 -- Used a non-ambiguous representation of SQL queries
...
when a correct representation cannot be obtained.
2013-01-26 17:51:44 +01:00
Aymeric Augustin
55416e235d
Fixed #19589 -- assertRegexpMatches is deprecated in Python 3.3.
2013-01-26 13:47:11 +01:00
Aymeric Augustin
424eb67867
Fixed validation of email addresses when the local part contains an @.
...
See also BaseUserManager.normalize_email -- it uses rsplit.
Refs #4833 .
2013-01-26 12:20:57 +01:00
Claude Paroz
ebb504db69
Moved has_changed logic from widget to form field
...
Refs #16612 . Thanks Aymeric Augustin for the suggestion.
2013-01-25 20:50:46 +01:00
Ramiro Morales
ce27fb198d
Revert "Patch by Claude for #16084."
...
This reverts commit 2babab0bb3
.
2013-01-25 13:58:37 -03:00
Ramiro Morales
2babab0bb3
Patch by Claude for #16084 .
2013-01-25 13:23:33 -03:00
Claude Paroz
b9c8bbf372
Fixed #19665 -- Ensured proper stderr output for Command.run_from_argv
...
Thanks Stefan Koegl for the report and Simon Charette for the review.
2013-01-25 14:56:41 +01:00
Ramiro Morales
57d439e2d4
More i18n makemessages tests tweaks.
2013-01-24 07:51:14 -03:00
Claude Paroz
9893fa12b7
Fixed #19125 -- The startproject command should validate the name earlier
...
Thanks Łukasz Rekucki for the report and the patch.
2013-01-24 09:26:13 +01:00
Nick Sandford
93e79b45bc
Fixed #17416 -- Added widgets argument to inlineformset_factory and modelformset_factory
2013-01-24 08:58:17 +01:00
Ramiro Morales
456f9b9847
Simplified a i18n test.
2013-01-21 23:22:18 -03:00
Claude Paroz
8ce1e392fa
Fixed error introduced when testing patch for 013db6ba85
...
Shame on me.
2013-01-21 22:42:47 +01:00
Claude Paroz
013db6ba85
Fixed #18051 -- Allowed admin fieldsets to contain lists
...
Thanks Ricardo di Virgilio for the report, Mateus Gondim for the
patch and Nick Sandford for the review.
2013-01-21 22:34:36 +01:00
Claude Paroz
c6e0dedbdb
Fixed #19637 -- Ensured AdminEmailHandler fails silently
...
Thanks lsaffre for the report. Refs #19325 .
2013-01-21 20:32:36 +01:00
Anssi Kääriäinen
7aa538357c
Cleaned up testing models.py added for earliest()
...
The main cleanup was removal of non-necessary __unicode__ method. The
tests didn't break on py3 as the string representation was never used
in the tests.
Refs #17813 . Thanks to Simon Charette for spotting this issue.
2013-01-20 08:53:45 +02:00
Nick Sandford
fe54377dae
Fixed #17813 -- Added a .earliest() method to QuerySet
...
Thanks a lot to everybody participating in developing this feature.
The patch was developed by multiple people, at least Trac aliases
tonnzor, jimmysong, Fandekasp and slurms.
Stylistic changes added by committer.
2013-01-20 06:39:35 +02:00
Craig Blaszczyk
6158c79dbe
Made (make|compile)messages commands accept multiple locales at once.
...
Thanks Craig Blaszczyk for the initial patch. Refs #17181 .
2013-01-17 00:53:17 -03:00
Ramiro Morales
295650bd01
Simplified i18n commands tests.
2013-01-17 00:35:46 -03:00
Ramiro Morales
248aee1606
Modified makemessages so it creates .pot files once per invocation.
...
It creates a `locale/django.pot` file once instead of one
`locale/<locale_code>/django.pot` file for every locale involved.
Thanks Michal Čihař for the report and patch.
2013-01-16 20:48:06 -03:00
Ramiro Morales
eee865257a
Fixed #17008 -- Added makemessages option to not remove .pot files.
...
Thanks airstrike for the report and initial patch, Julien for an
enhanced patch and Jannis for reviewing.
2013-01-16 20:29:06 -03:00
Aymeric Augustin
50a985b09b
Fixed #19099 -- Split broken link emails out of common middleware.
2013-01-15 17:41:45 +01:00
Alex Gaynor
984e91e28f
Removed some uses of the deprecated assertEquals
2013-01-15 07:51:33 -08:00
David Cramer
a7ed09d13d
Improve test to ensure that post_delete was actually called
2013-01-14 13:34:55 -08:00
David Cramer
6045efa029
Move signal disconnect into finally block
2013-01-14 13:15:47 -08:00
David Cramer
272de9eb6b
Send post_delete signals immediately
...
In a normal relational construct, if you're listening for an event
that signals a child was deleted, you dont expect that the parent
was deleted already.
This change ensures that post_delete signals are fired immediately
after objects are deleted in the graph.
2013-01-14 13:15:47 -08:00
Claude Paroz
0171ba65db
Fixed #17574 -- Implemented missing get_key_columns in PostgreSQL backend
2013-01-12 21:46:08 +01:00
Claude Paroz
bcdb4898ca
Fixed #19488 -- Made i18n_patterns redirect work with non-slash-ending paths
...
Thanks Daniel Gerzo for the report and the initial patch.
2013-01-11 21:27:51 +01:00
Claude Paroz
f08e739bc2
Fixed #19585 -- Fixed loading cookie value as a dict
...
This regression was introduced by the 'unicode_literals' patch.
2013-01-11 21:09:33 +01:00
Claude Paroz
4e2e8f39d1
Fixed #4833 -- Validate email addresses with localhost as domain
2013-01-11 20:45:46 +01:00
Nick Sandford
eb6c107624
Fixed #19360 -- Raised an explicit exception for aggregates on date/time fields in sqlite3
...
Thanks lsaffre for the report and Chris Medrela for the initial
patch.
2013-01-11 18:10:28 +01:00
Claude Paroz
2e55cf580e
Adapted test assertion against yaml dump
...
Fixes #12914 (again).
2013-01-11 17:52:53 +01:00
Loic Raucy
62f842e2e5
Fixed #19581 -- ensure unique html ids with CheckboxSelectMultiple widgets
...
ID check is now done the same way as MultipleHiddenInput.
2013-01-09 16:06:56 -08:00
Florian Apolloner
ce580dd8ea
Fixed lockups in jenkins, refs #19546 .
2013-01-09 23:32:51 +01:00
Claude Paroz
e6949373b0
Skipped deprecation warning test on Python 2.6
...
Refs #19546 . On Python 2.6, DeprecationWarnings are visible by
default.
2013-01-09 20:02:09 +01:00
Preston Holmes
cfa70d0c94
Fixed #19546 - ensure that deprecation warnings are shown during tests
...
refs #18985
2013-01-09 08:19:22 -08:00
Anssi Kääriäinen
55da775ce1
Fixed #17541 -- Fixed non-saved/nullable fk querying
2013-01-08 21:02:38 +02:00
Claude Paroz
34ee7d9875
Updated deprecated test assertions
2013-01-08 19:08:15 +01:00
Anssi Kääriäinen
23ca3a0194
Fixed #16759 -- Remove use of __deepcopy__ in qs.clone()
...
The original problem was that queryset cloning was really expensive
when filtering with F() clauses. The __deepcopy__ went too deep copying
_meta attributes of the models used. To fix this the use of
__deepcopy__ in qs cloning was removed.
This commit results in some speed improvements across the djangobench
benchmark suite. Most query_* tests are 20-30% faster, save() is 50%
faster and finally complex filtering situations can see 2x to order
of magnitude improvments.
Thanks to Suor, Alex and lrekucki for valuable feedback.
2013-01-08 19:17:13 +02:00
Claude Paroz
c698c55966
Created special PostgreSQL text indexes when unique is True
...
Refs #19441 .
2013-01-07 17:54:30 +01:00
Anssi Kääriäinen
69a46c5ca7
Tests for various emptyqs tickets
...
The tickets are either about different signature between qs.none() and
qs or problems with subclass types (either EmptyQS overrided the custom
qs class, or EmptyQS was overridden by another class - values() did
this).
Fixed #15959 , fixed #17271 , fixed #17712 , fixed #19426
2013-01-06 19:18:29 +02:00
Anssi Kääriäinen
a2396a4c8f
Fixed #19173 -- Made EmptyQuerySet a marker class only
...
The guarantee that no queries will be made when accessing results is
done by new EmptyWhere class which is used for query.where and having.
Thanks to Simon Charette for reviewing and valuable suggestions.
2013-01-06 19:18:28 +02:00
Claude Paroz
b740da3504
Fixed #19192 -- Allowed running tests with dummy db backend
...
Thanks Simon Charette for the initial patch, and Jan Bednařík for
his work on the ticket.
2013-01-04 13:55:20 +01:00
Claude Paroz
ffa50ca352
Fixed #19382 -- Stopped smtp backend raising exception when already closed
...
Thanks Sebastian Noack for the report and the initial patch.
2013-01-03 20:41:45 +01:00
Claude Paroz
1b3f832ab7
Fixed #19134 -- Allowed closing smtp backend when the server is stopped
...
Thanks Sebastian Noack for the report and the initial patch.
2013-01-03 18:49:00 +01:00
Simon Charette
3fc43c964e
Fixed #19545 -- Make sure media/is_multipart work with empty formsets
2013-01-03 15:16:23 +01:00
Aymeric Augustin
a7b7efe78d
Minor fixes in the known_related_objects tests.
...
* Fixed JSON indentation.
* Avoided relying on implicit ordering.
2013-01-02 22:21:46 +01:00
Aymeric Augustin
07fbc6ae0e
Fixed #19547 -- Caching of related instances.
...
When &'ing or |'ing querysets, wrong values could be cached, and crashes
could happen.
Thanks Marc Tamlyn for figuring out the problem and writing the patch.
2013-01-02 22:21:46 +01:00
Aymeric Augustin
feb41c3246
Modernized middleware tests.
...
* Used override_settings consistently -- changes to DEBUG could leak.
* Took advantage of assertRaisesRegexp.
* Fixed indentation -- some code was indented at 2 spaces.
2013-01-01 23:00:34 +01:00
Anton Baklanov
3aa4b8165d
Fixed #19457 -- ImageField size detection failed for some files.
...
This was caused by PIL raising a zlib truncated stream error since we fed
the parser with chunks instead of the whole image.
2013-01-01 11:54:56 +01:00
Aymeric Augustin
bacb097ac3
Fixed #19519 again -- Regression in LiveServerTestCase after fd1279a4
.
2013-01-01 10:14:11 +01:00
Julien Phalip
9180146d21
Fixed #19453 -- Ensured that the decorated function's arguments are obfuscated in the @sensitive_variables decorator's frame, in case the variables associated with those arguments were meant to be obfuscated from the decorated function's frame.
...
Thanks to vzima for the report.
2012-12-31 09:34:08 -08:00
Aymeric Augustin
acc5396e6d
Fixed #19519 -- Fired request_finished in the WSGI iterable's close().
2012-12-31 12:47:34 +01:00
Claude Paroz
d11038acb2
Fixed #19537 -- Made CheckboxInput._has_changed handle 'False' string
...
Thanks dibrovsd@gmail.com for the report.
2012-12-31 10:18:59 +01:00
Julien Phalip
cee40c7d79
Added further flexibility to ModelAdmin for controlling post-save redirections.
...
Refs #19505 .
2012-12-30 21:33:21 -08:00
Aymeric Augustin
4e5369a596
Silenced warnings in the tests of deprecated features.
2012-12-29 22:32:07 +01:00
Aymeric Augustin
ef017a5f00
Advanced pending deprecation warnings.
...
Also added stacklevel argument, fixed #18127 .
2012-12-29 21:59:07 +01:00
Aymeric Augustin
2ecf56ea3f
Removed legacy ways of calling cache_page.
2012-12-29 21:59:07 +01:00
Aymeric Augustin
9f9a4cdecd
Removed truncate_words and truncate_html_words.
2012-12-29 21:59:07 +01:00
Aymeric Augustin
4a6490a4a0
Removed HttpRequest.raw_post_data.
2012-12-29 21:59:07 +01:00
Aymeric Augustin
d1c72d9e01
Removed django.core.management.setup_environ and execute_manager.
2012-12-29 21:59:07 +01:00
Aymeric Augustin
f27a4ee327
Removed django.contrib.localflavor.
...
Each localflavor lives on as a separate app.
2012-12-29 21:59:06 +01:00
Aymeric Augustin
052271168b
Removed django.contrib.databrowse.
...
RIP -- you served us well.
2012-12-29 21:58:12 +01:00
Aymeric Augustin
02f3daadd6
Removed interpolation of post_url_continue in the admin.
2012-12-29 21:58:12 +01:00
Aymeric Augustin
fb9f1b9bfb
Removed backwards-compatibility shim for #16288 .
...
Also unit-tested django.utils.log.RequireDebugTrue for consistency.
2012-12-29 21:58:12 +01:00
Anssi Kääriäinen
13a2b11425
Avoided having an indexed TextField installed unless using postgres
...
An index on TextField results in a warning message when running tests
on MySQL or SQLite, and the test using the TextField was PostgreSQL
only in any case.
2012-12-29 16:30:17 +02:00
Anssi Kääriäinen
ba4331f177
Fixed autopk issue in tests
2012-12-29 16:25:24 +02:00
Aymeric Augustin
e9c24bef74
Fix #19524 -- Incorrect caching of parents of unsaved model instances.
...
Thanks qcwxezdas for the report. Refs #13839 .
2012-12-28 23:34:54 +01:00
Aymeric Augustin
db278c3bf9
Fixed #19525 -- Reverted dcd4383107
and 05d333ba3b
.
...
Refs #9893 , #18515 .
Thanks Russell for the report.
2012-12-27 09:37:57 +01:00
Ramiro Morales
ad769efa85
Expanded tests added when fixing #14529 .
...
To make sure changes in 35d1cd0
don't break anything. Refs #19505 .
2012-12-24 17:48:48 -03:00
Aymeric Augustin
1c8be95a86
Prevented caching of streaming responses.
...
The test introduced in 4b278131
accidentally passed because of a
limitation of Python < 3.3.
Refs #17758 , #7581 .
2012-12-24 20:28:07 +01:00
Julien Phalip
35d1cd0b28
Fixed #19505 -- A more flexible implementation for customizable admin redirect urls.
...
Work by Julien Phalip.
Refs #8001 , #18310 , #19505 . See also 0b908b92a2
.
2012-12-24 15:44:19 -03:00
Aymeric Augustin
e8f07f0378
Fixed a randomly failing test under Python 3.
...
Refs #17758 .
2012-12-24 11:25:58 +01:00
Luke Plant
1ae64e96c1
Fixed a dependence on set-ordering in tests
2012-12-24 01:33:44 +00:00
Luke Plant
c31c2c92b8
Made admin generated changelist URLs independent of dict ordering
2012-12-24 01:33:24 +00:00
Ian Clelland
b9fc70141a
Don't rely on dictionary ordering in tests
2012-12-24 00:45:58 +00:00
Ian Clelland
585aa11d23
Use HTML parser to compare html snippets
2012-12-24 00:26:09 +00:00
Ian Clelland
8d35fd4c32
Use new TestCase methods for equality comparisons
2012-12-24 00:24:14 +00:00
Aymeric Augustin
1e4a27d087
Fixed #19468 -- Decoded request.path correctly on Python 3.
...
Thanks aliva for the report and claudep for the feedback.
2012-12-22 13:32:39 +01:00
Anssi Kääriäinen
d407164c04
Fixed #18854 -- Join promotion in disjunction cases
...
The added promotion logic is based on promoting any joins used in only
some of the childs of an OR clause unless the join existed before the
OR clause addition.
2012-12-20 21:45:15 +02:00
Anssi Kääriäinen
3dcd435a0e
Fixed #19500 -- Solved a regression in join reuse
...
The ORM didn't reuse joins for direct foreign key traversals when using
chained filters. For example:
qs.filter(fk__somefield=1).filter(fk__somefield=2))
produced two joins.
As a bonus, reverse onetoone filters can now reuse joins correctly
The regression was caused by the join() method refactor in commit
68847135bc
Thanks for Simon Charette for spotting some issues with the first draft
of the patch.
2012-12-20 21:27:00 +02:00
Russell Keith-Magee
c04c03daa3
Fixed #19401 -- Ensure that swappable model references are case insensitive.
...
This is necessary because get_model() checks are case insensitive, and if the swapable check isn't, the
swappable logic gets tied up in knots with models that are partially swapped out.
Thanks to chris@cogdon.org for the report and extensive analysis, and Preston for his work on the draft patch.
2012-12-20 16:10:19 +08:00
Patryk Zawadzki
3989ce52ef
Fixed #18172 -- Made models with __iter__ usable in ModelMultipleChoiceField
...
Thanks to Patryk Zawadzki for the patch.
2012-12-19 22:51:12 +02:00
Claude Paroz
55972ee5c7
Fixed #19441 -- Created PostgreSQL varchar index when unique=True
...
Thanks Dylan Verheul for the report and Anssi Kääriäinen for the
review.
2012-12-18 09:56:30 +01:00
Anssi Kääriäinen
85712a5355
Made sure connections are actually closed in backends tests
2012-12-16 23:26:16 +02:00
Claude Paroz
ed711c4bd5
Fixed #19483 -- Improved import error message in contrib.comments
...
Thanks Valentin Lorentz for the report and the suggested fix.
2012-12-16 21:12:45 +01:00
Anssi Kääriäinen
69597e5bcc
Fixed #10790 -- Refactored sql.Query.setup_joins()
...
This is a rather large refactoring. The "lookup traversal" code was
splitted out from the setup_joins. There is now names_to_path() method
which does the lookup traveling, the actual work of setup_joins() is
calling names_to_path() and then adding the joins found into the query.
As a side effect it was possible to remove the "process_extra"
functionality used by genric relations. This never worked for left
joins. Now the extra restriction is appended directly to the join
condition instead of the where clause.
To generate the extra condition we need to have the join field
available in the compiler. This has the side-effect that we need more
ugly code in Query.__getstate__ and __setstate__ as Field objects
aren't pickleable.
The join trimming code got a big change - now we trim all direct joins
and never trim reverse joins. This also fixes the problem in #10790
which was join trimming in null filter cases.
2012-12-16 17:23:26 +02:00
Russell Keith-Magee
9facca28b6
Corrected tests depending on the error message on the AuthenticationForm.
...
Refs #19368 , and the fix introduced in 27f8129d64
.
2012-12-16 07:18:45 +08:00
Anssi Kääriäinen
7eba5fbc02
Fixed a couple of stale tests caused by patch for #19462
...
Commit was 088d3bc2f8
2012-12-13 15:02:08 +02:00
Anssi Kääriäinen
088d3bc2f8
Fixed #19462 -- Made assertQuerysetEqual detect undefined ordering
...
If there are more than one values to compare against and the qs isn't
ordered then assertQuerysetEqual will raise a ValueError.
2012-12-13 13:33:11 +02:00
Claude Paroz
6ed6a18a03
Fixed #19432 -- Provided better error message for get_object_or_404
...
Thanks Kit Sunde for the report and Brian Holdefehr for the initial
patch.
2012-12-12 22:05:00 +01:00
Florian Apolloner
7e97f4f510
Fixed an order dependant test failure.
2012-12-11 16:25:47 +01:00
Florian Apolloner
1eb0da1c5b
Fixed a test failure in the comment tests.
2012-12-10 23:34:51 +01:00
Florian Apolloner
27560924ec
Fixed a security issue in get_host.
...
Full disclosure and new release forthcoming.
2012-12-10 22:11:40 +01:00
Florian Apolloner
a2f2a39956
Fixed #18856 -- Ensured that redirects can't be poisoned by malicious users.
2012-12-10 22:11:39 +01:00
Claude Paroz
0cdfa76e68
Amended an SQL test fixture to not include an id value
...
Some backends might need special handling for auto-increment values.
This was introduced in 5fa5621f57
. Thanks Michael Manfre for spotting
the issue.
2012-12-10 17:49:04 +01:00
Aymeric Augustin
49519328b4
Fixed #19392 -- Improved error for old-style url tags with dashes.
...
Thanks dloewenherz for the report.
2012-12-09 16:17:56 +01:00
Claude Paroz
8248d14029
Removed US localflavor-specific tests from core
...
Also fixes #9045 .
2012-12-08 21:07:59 +01:00
Claude Paroz
04e6542b5a
Fixed #19423 -- Prevented ModelAdmin sharing widgets due to formfield_overrides
...
Thanks joebuyer at manycycles.com for the report and Simon Charette
for the review.
2012-12-08 12:41:11 +01:00
Claude Paroz
c91667338a
Fixed #19357 -- Allow non-ASCII chars in filesystem paths
...
Thanks kujiu for the report and Aymeric Augustin for the review.
2012-12-08 11:13:52 +01:00
Andreas Hug
66dfcc10b3
Fixed #18574 -- Make BaseFormSet.is_valid call its underlying forms' is_valid
...
Thanks Simon Charette for the report and the initial patch.
2012-12-06 20:00:56 +01:00
Claude Paroz
34dcf51e06
Fixed #19367 -- Fixed saving ContentFile in filesystem storage
...
This was not working properly when ContentFile was initialized with
an unicode string.
Thanks Alexey Boriskin for the report and the test.
2012-12-06 17:14:44 +01:00
Marc Aymerich
553838a285
Fixed #19429 -- Applied linebreaksbr to read-only fields in inlines
...
Applied to inlines what ec9d6b1122
did for main fieldsets.
2012-12-06 09:52:02 +01:00
Anssi Kääriäinen
632cf32b43
Fixed #19391 -- Oracle specific failure in tests
...
The failure was caused by using None as a choice for a CharField. To
avoid Oracle's "" <-> NULL handling the field type was changed to
IntegerField.
2012-12-04 22:49:02 +02:00
Julien Phalip
c196e01100
Fixed the admin_filters tests for Postgres.
2012-12-04 10:36:56 -08:00
Claude Paroz
795ac7deda
Fixed #19378 -- Ensured get_success_url returns a non-lazy URL
2012-12-04 13:22:42 +01:00
Andrew Godwin
501c7a221c
Merge pull request #573 from tominsam/master
...
Fixed #19070 : urlize template filter raises exception in some cases
2012-12-04 02:18:10 -08:00
Ramiro Morales
b64d30405a
Fixed #18697 -- Made values accepted for two customizable admin templates consistent.
...
Thanks and at cloverfastfood dot com for the report.
2012-12-04 01:13:01 -03:00
Sebastián Magrí
88e1715639
Fixed #19318 -- Ensured that the admin's SimpleListFilter options can be displayed as selected even if the lookup's first element is not a string.
2012-12-03 11:53:15 -08:00
Claude Paroz
5fa5621f57
Fixed #19416 -- Fixed multi-line commands in initial SQL files
...
Thanks Aymeric Augustin for detecting this regression.
2012-12-03 20:47:08 +01:00
Tom Insam
161cafb6f6
another failing test case for square brackets.
2012-12-03 12:11:32 +00:00
Aymeric Augustin
baae4b8187
Fixed #19397 -- Crash on binary files in project templates.
...
Thanks gw 2012 at tnode com for the report.
2012-12-03 10:45:18 +01:00
Julien Phalip
2e2c4968f6
Fixed #17050 -- Added some CSS class names to the admin index pages to facilitate per-app or per-model style customizations. Thanks to scytale for the report and to H0ff1 and thiderman for their work on the patch.
2012-12-02 20:54:34 -08:00
Claude Paroz
349c4c37f8
Fixed #19015 -- Add ISO input formats to all formats
2012-12-01 14:05:52 +01:00
Claude Paroz
0eeae15056
Fixed #19354 -- Do not assume usermodel.pk == usermodel.id
...
Thanks markteisman at hotmail.com for the report.
2012-11-29 21:45:43 +01:00
Anssi Kääriäinen
163b471e9e
Converted a couple of assertEquals -> assertEqual
2012-11-28 23:44:50 +02:00
Tai Lee
6ebf115206
Fixed #14694 -- Made ``defer()`` work with reverse relations
...
Reverse o2o fields are now usable with defer.
2012-11-28 18:17:10 +02:00
Danilo Bargen
c10aaa70a4
Fixed #19370 -- Made date filter properly handle midnight value
2012-11-27 21:24:16 +01:00
Anssi Kääriäinen
64f6e0370a
Made some tests behave nicer re connection handling
2012-11-27 19:47:20 +02:00
Aymeric Augustin
2ea80b94d7
Fixed #19362 -- Detected invalid use of @python_2_unicode_compatible.
...
Thanks m3wolf for the report and akaariai for reproducing the problem.
2012-11-27 09:45:37 +01:00
Edward Tjörnhammar
29d59a879e
Fixed #17911 -- Ensure that admin readonly fields' display values are shown in change forms when the raw value is None.
2012-11-25 23:13:30 +01:00
Julien Phalip
ae206d78f6
Fixed #17646 -- Added a get_list_filter() method to ModelAdmin. Thanks to rasca for the suggestion and to mateusgondim for the patch.
2012-11-25 20:39:23 +01:00
Claude Paroz
f26b956e80
Fixed test failure following capitalization fix in 2f035a972
2012-11-25 19:54:38 +01:00
Aymeric Augustin
7644800070
Change exception type to reduce confusion.
...
TemplateSyntaxError is expected at compile time, not at run time.
Refs #19280 .
2012-11-25 19:51:42 +01:00
Aymeric Augustin
f89901dc05
Fixed two typos.
2012-11-25 19:31:53 +01:00
Claude Paroz
a5d47415f4
Enabled SimpleTestCase to be decorated by override_settings
...
Refs #18417 . Also fixed some test case classes which subclassed
the wrong parent.
2012-11-25 19:06:17 +01:00
Claude Paroz
9f7cefd505
Fixed #18417 -- Raised exception when unittest.TestCase is decorated with override_settings
2012-11-25 19:06:17 +01:00
Aymeric Augustin
d266919584
Fixed #19280 -- Raised an explicit exception for the old {% url %} syntax.
2012-11-24 22:10:51 +01:00
Aymeric Augustin
690cac3a34
Used a django.test.TestCase for compatibility with @override_settings.
...
These tests were silently skipped.
2012-11-24 22:10:51 +01:00
Anssi Kääriäinen
dc569c8801
Fixed ordering-related failure in m2m_through_regress tests
2012-11-24 16:03:21 +02:00
Chris Khoo
bf1871d874
Fixed #19237 -- Improved strip_tags utility
...
The previous pattern didn't properly addressed cases where '>'
was present inside quoted tag content.
2012-11-24 12:16:52 +01:00
Russell Keith-Magee
18d7c1ea3a
Simplified the deletions performed by the swappable_models test.
...
This is required to allow the test to run without error under SQLite in the CI environment.
2012-11-24 15:07:50 +08:00
Russell Keith-Magee
c8985a8a73
Fixed #19806 -- Ensure that content types and permissions aren't created for swapped models.
...
Thanks to rizumu for the report.
2012-11-24 13:43:20 +08:00
Anssi Kääriäinen
0a0a0d66b3
Fixed #19351 -- SQLite bulk_insert of more than 500 single-field objs
2012-11-24 01:13:12 +02:00
Anssi Kääriäinen
a27582484c
Fixed SQLite's collapsing of same-valued instances in bulk_create
...
SQLite used INSERT INTO tbl SELECT %s UNION SELECT %s, the problem
was that there should have been UNION ALL instead of UNION.
Refs #19351
2012-11-24 01:12:17 +02:00
Anssi Kääriäinen
90b86291d0
Fixed #18375 -- Removed dict-ordering dependency for F-expressions
...
F() expressions reuse joins like any lookup in a .filter() call -
reuse multijoins generated in the same .filter() call else generate
new joins. Also, lookups can now reuse joins generated by F().
This change is backwards incompatible, but it is required to prevent
dict randomization from generating different queries depending on
.filter() kwarg ordering. The new way is also more consistent in how
joins are reused.
2012-11-23 19:53:04 +02:00
Aymeric Augustin
2875b5dcab
Tweak a test to avoid hitting a limit with SQLite.
...
Django cannot delete more than 999 objects at a time with SQLite.
Refs #16426 , #16039 .
2012-11-23 10:02:18 +01:00
Tim Graham
0e3690d230
Fixed #18974 - Warned against using models.permalink
...
Thanks dstufft for the draft patch.
2012-11-22 16:08:51 -05:00
Aymeric Augustin
a026e480da
Fixed #16039 -- Made post_syncdb handlers multi-db aware.
...
Also reverted 8fb7a90026
. Refs #17055 .
2012-11-22 20:53:59 +01:00
George Hickman
ea6b95dbec
Fixed #19316 -- Set View args/kwargs/request before dispatch
2012-11-22 20:13:01 +01:00
Jannis Leidel
3fb83729b9
Merge branch 'ticket_19325' of https://github.com/hannesstruss/django into hannesstruss-ticket_19325
2012-11-22 10:05:08 +01:00
Julien Phalip
693b8a65ad
Modified a staticfiles test to use a unicode character that has just one single representation. The previously used character (ş) has two different representations (u'\u015f' and u's\u0327'), which caused spurious failures when the tests were run across multiple platforms (e.g. on a Linux VM hosted on a Mac).
2012-11-21 09:52:09 +01:00
Claude Paroz
b781354ad1
Updated assertions in pagination test
...
assertEquals is a deprecated assertion alias.
2012-11-21 09:06:21 +01:00
Chris Beaven
48e8b5e944
Add orphans support to MultipleObjectMixin
...
Fixes #7005
2012-11-21 16:50:23 +13:00
Chris Beaven
fbfa654a15
Paginator._get_page hook
...
This allows for Paginator subclasses to easily override the Page class
that gets used.
Took the opportunity to also do some non-invasive PEP8 tidying of the
paginator module.
2012-11-21 15:19:44 +13:00
Hannes Struss
f9891f2087
Fixed #19325 - Made email backend of AdminEmailHandler configurable
2012-11-20 11:23:12 +01:00
Preston Holmes
edf7ad36fa
Fixed #18658 -- Improved ModelAdmin.message_user API
...
Thanks to Lowe Thiderman for the patch and tests
2012-11-19 16:03:09 -08:00
Jannis Leidel
778b8bdcf4
Merge pull request #467 from tomchristie/page-kwarg
...
Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page".
2012-11-17 12:27:01 -08:00
Claude Paroz
e0363c688d
Fixed #19114 -- Fixed LogEntry unicode representation
...
Thanks niko at neagee.net for the report and Emil Stenstrom for
the patch.
2012-11-17 19:19:59 +01:00
Claude Paroz
2a67374b51
Fixed #19036 -- Fixed base64 uploads decoding
...
Thanks anthony at adsorbtion.org for the report, and johannesl for
bringing the patch up-to-date.
2012-11-17 17:25:21 +01:00
Claude Paroz
ec9d6b1122
Fixed #19226 -- Applied linebreaksbr to read-only fields in admin
...
Thanks shadow for the report, and Melevir and thiderman for the
patch.
2012-11-17 17:06:24 +01:00
Jannis Leidel
f79013843d
Fixed typo introduced in 4a5e8087ac
.
2012-11-17 16:00:19 +01:00
Jannis Leidel
233f86443c
Merge pull request #490 from gabrielhurley/reverse-prefix-special-chars
...
Fixed #18210 -- Escaped special characters in reverse prefixes.
2012-11-17 06:49:18 -08:00
Jannis Leidel
4a5e8087ac
Fixed #19136 -- Properly escape gettext context prefixes in the i18n JavaScript view template.
2012-11-17 15:37:30 +01:00
Preston Holmes
44046e8a38
Fixed #18985 -- made DeprecationWarnings loud
...
Capture warnings in Python >= 2.7 and route through
console handler, which is subject to DEBUG==True
Thanks to dstufft for the idea, and claudep for initial patch
2012-11-16 17:07:38 -08:00
Anssi Kääriäinen
71e14cf3aa
Fixed #18347 -- Removed autofield raw SQL inserts from tests
2012-11-15 17:31:08 +02:00
Anssi Kääriäinen
f51e409a5f
Fixed #13781 -- Improved select_related in inheritance situations
...
The select_related code got confused when it needed to travel a
reverse relation to a model which had different parent than the
originally travelled relation.
Thanks to Trac aliases shauncutts for report and ungenio for original
patch (committed patch is somewhat modified version of that).
2012-11-15 17:15:21 +02:00
Claude Paroz
550ddc66b4
Fixed #19272 -- Fixed gettext_lazy returned type on Python 2
...
Thanks tyrion for the report.
2012-11-14 10:50:15 +01:00
Claude Paroz
1620c27936
Fixed #19186 -- Fixed sending mail with unicode content on Python 3
...
Thanks alex_po for the report and Luke Plant for the analysis.
2012-11-14 10:43:33 +01:00
Aymeric Augustin
4c5cea7073
Merge pull request #218 from mgrouchy/ticket_18582
...
Fixed #18582 -- Added a no-op close to BaseCache
2012-11-11 07:18:45 -08:00
Claude Paroz
34162698cc
Fixed #14264 -- Ensured settings.configure configures logging
...
Thanks Matt McDonald for the patch.
2012-11-10 12:05:58 +01:00
Sean Breant
4d817b3887
Fixed #19262 -- Support cookie pickling in SimpleTemplateResponse
...
Refs #15863 .
2012-11-09 21:07:53 +01:00
Claude Paroz
1b307d6c8f
Fixed #19261 -- Delayed Queryset evaluation in paginators
...
Thanks trbs for the report and the patch.
2012-11-09 19:41:57 +01:00
Claude Paroz
45802e1248
Merged pagination tests
...
It is simpler/cleaner to have all pagination tests in a single file.
Refs #16122 .
2012-11-08 11:07:16 +01:00
Anssi Kääriäinen
cafb266954
Fixed #17144 -- MySQL again groups by PK only
...
Thanks to Christian Oudard for the report and tests.
2012-11-08 00:56:32 +02:00
Claude Paroz
79dd751b0b
Fixed #14315 -- Made memcached backend handle negative incr/decr values
...
Thanks Michael Manfre for the report and initial patch and
Tobias McNulty for the review.
2012-11-06 12:22:42 +01:00
Claude Paroz
78f66691ee
Fixed #8627 -- Prevented textareas to swallow first newline content
...
Browsers consider the first newline in textareas as some display
artifact, not real content. Hence they are not sending it back to
the server. If we want to keep initial newlines, we have to add one
when we render the textarea.
Thanks bastih for the report and initial patch.
2012-11-05 20:27:06 +01:00
Preston Holmes
6bd61194d4
Fixed py3 compatibility for 5a00a57aa5
2012-11-04 23:38:41 -08:00
Anton I. Sipos
fdea2621cd
Fixed #18949 -- Fix broken test interactions in ModelForms tests
...
A test in Model Forms test was specifically referring to a fixed
primary key, which was now being used up in a newly committed.
This has been worked around by specifying a higher primary
key.
2012-11-04 18:43:11 -08:00
Alex Gaynor
4d766b3c9a
Merge pull request #495 from aisipos/ticket_18949
...
Fixed #18949 -- Improve performance of model_to_dict with many-to-many
2012-11-04 15:57:45 -08:00
Anton I. Sipos
e44ab5bb4f
Fixed #18949 -- Improve performance of model_to_dict with many-to-many
...
When calling model_to_dict, improve performance of the generated SQL by
using values_list to determine primary keys of many to many objects. Add
a specific test for this function, test_model_to_dict_many_to_many
Thanks to brian for the original report and suggested fix.
2012-11-04 15:52:05 -08:00
Preston Holmes
5a00a57aa5
Fixed #19240 -- include pagination error details in ListView 404
...
Thanks to seawolf for the patch
2012-11-04 15:52:00 -08:00
Mike Johnson
fcd3d4c68f
model_split: Fixed #19236 - fixed error for abstract models with a split method
2012-11-04 13:43:54 -08:00
Alex Gaynor
4285571c5a
Fixed #5805 -- it is now possible to specify multi-column indexes. Thanks to jgelens for the original patch.
2012-11-04 10:16:06 -08:00
Aymeric Augustin
973f539ab8
Fixed #15152 -- Avoided crash of CommonMiddleware on broken querystring
2012-11-03 21:28:33 +01:00
Gabriel Hurley
90e530978d
Fixed #18210 -- Escaped special characters in reverse prefixes.
...
Ensured that special characters passed in to reverse via the
prefix argument are properly escaped so that calls to
django.utils.regex_helpers.normalize and/or string formatting
operations don't result in exceptions.
Thanks to toofishes for the error report.
2012-11-03 13:06:57 -07:00
Aymeric Augustin
095eca8dd8
Fixed #19101 -- Decoding of non-ASCII POST data on Python 3.
...
Thanks Claude Paroz.
2012-11-03 13:03:15 +01:00
Ulrich Petri
ac2052ebc8
Fixed #17549 -- Added a clickable link for URLFields in admin change list.
2012-11-03 11:57:33 +01:00
Tim Graham
feaf9f279a
Fixed #15361 - Documented performance considerations for QuerySet.get()
...
Thanks mmcnickle for the patch.
2012-11-02 17:58:24 -04:00
Andrew Godwin
7f75460fd6
Fixed #19070 -- urlize filter no longer raises exceptions on 2.7
...
Thanks to claudep for the patch.
2012-10-31 10:58:14 +00:00
Anssi Kääriäinen
68847135bc
Removed dupe_avoidance from sql/query and sql/compiler.py
...
The dupe avoidance logic was removed as it doesn't seem to do anything,
it is complicated, and it has nearly zero documentation.
The removal of dupe_avoidance allowed for refactoring of both the
implementation and signature of Query.join(). This refactoring cascades
again to some other parts. The most significant of them is the changes
in qs.combine(), and compiler.select_related_descent().
2012-10-31 08:19:44 +02:00
Claude Paroz
73245b3285
Prevented file_upload tests to leave files behind
...
Refs #19206 .
2012-10-30 22:27:55 +01:00
Claude Paroz
9a02851340
Fixed #17744 -- Reset default file storage with setting_changed signal
2012-10-30 22:23:28 +01:00
Claude Paroz
6de6988f99
Fixed #5076 -- Properly decode POSTs with non-utf-8 payload encoding
...
Thanks daniel at blogg.se for the report and Aymeric Augustin for
his assistance on the patch.
2012-10-30 09:00:32 +01:00
Claude Paroz
d30516e163
Prevented leftover files and dirs in admin_scripts tests
2012-10-29 19:08:07 +01:00
Luke Plant
4c4d08502c
Fixed #17991 - prefetch_related fails with GenericRelation and varchar ID field
...
Thanks to okke@formsma.nl for the report, and carmandrew@gmail.com for the tests.
2012-10-29 14:31:54 +00:00
Claude Paroz
f1cc2be0c5
Fixed #18575 -- Empty DATABASES should default to dummy backend
...
Thanks delormemarco@gmail.com for the report.
2012-10-28 23:44:03 +01:00
Aymeric Augustin
b4420d9602
Fixed #18964 -- floatformat test passes under py3k
...
Thanks Russell for the report.
2012-10-28 19:57:03 +01:00
Anssi Kääriäinen
611c4d6f1c
Fixed #18823 -- Ensured m2m.clear() works when using through+to_field
...
There was a potential data-loss issue involved -- when clearing
instance's m2m assignments it was possible some other instance's
m2m data was deleted instead.
This commit also improved None handling for to_field cases.
2012-10-28 17:31:35 +02:00
Anssi Kääriäinen
a5152bb646
Marked a test as expectedFailure on Oracle
2012-10-27 18:34:18 +03:00
Anssi Kääriäinen
2249bd275c
Fixed Oracle failure for "%" in table name
2012-10-27 05:26:42 +03:00
Aymeric Augustin
789ea3342d
Fixed comment_test tests under hash randomization.
...
Thanks clelland for the patch.
2012-10-26 22:47:45 +02:00
Aymeric Augustin
46d27a6b8d
Fixed feedgenerator tests under hash randomization
2012-10-26 22:40:35 +02:00
Aymeric Augustin
195bc37f1d
Fixed httpwrappers tests under hash randomization
2012-10-26 22:09:48 +02:00
Claude Paroz
be29329ccd
Fixed #16820 -- Treated '0' value as True for checkbox inputs
...
Thanks Dan Fairs for the report and the initial patch.
2012-10-26 20:44:00 +02:00
Luke Plant
fabe9c9e5f
Fixed test failure under Python 2.x introduced in 3e10d22df5
2012-10-26 02:45:15 +01:00
Luke Plant
3e10d22df5
Fixed test failures on Python 3.3 due to dict ordering assumptions.
...
Refs #19038
2012-10-26 02:13:09 +01:00
Luke Plant
c8508943a2
Fixed some test failures on Python 3.3 related to QueryDict
...
Refs #19038 .
2012-10-26 01:55:55 +01:00
Ian Clelland
bdcd2f6b10
Avoid dependence on exact Python exception messages
2012-10-26 01:40:33 +01:00
Ian Clelland
02dda22832
Don't use : as an invalid cookie character
...
Since http://bugs.python.org/issue2193 has been resolved in favour of
the colon in cookie names, we need to test invalid cookie removal using
a different character. "@" is still considered invalid by all sources.
2012-10-26 01:40:32 +01:00
Luke Plant
71734dfa72
Fixed #19039 - Python 3.3 fails unit test for duplicate bad cookies
...
Thanks to clelland for the report.
2012-10-26 00:50:25 +01:00
Luke Plant
f3a2bcdee9
Fixed #15040 - Boolean fields return 0 and 1 when loaded through select_related
...
Thanks to homm for the report and ramiro for the patch.
2012-10-26 00:25:59 +01:00
Aymeric Augustin
1d6b7f302a
Fixed timezone tests when dict randomization is on
...
Refs #17758 .
2012-10-25 23:14:17 +02:00
Anssi Kääriäinen
7de439f32d
Fixed #19187 -- Raise consistent error from qs.values().delete()
2012-10-25 17:16:56 +03:00
Anssi Kääriäinen
f64a5ef404
Fixed #19102 -- Fixed fast-path delete for modified SELECT clause cases
...
There was a bug introduced in #18676 which caused fast-path deletes
implemented as "DELETE WHERE pk IN <subquery>" to fail if the SELECT
clause contained additional stuff (for example extra() and annotate()).
Thanks to Trac alias pressureman for spotting this regression.
2012-10-25 17:16:44 +03:00
Tom Christie
f824a95177
Test for `ListView.page_kwarg`
2012-10-25 13:19:53 +01:00
Aymeric Augustin
da56e1bac6
Fixed #18796 -- Refactored conversion to bytes in HttpResponse
...
Thanks mrmachine for the review.
2012-10-25 08:49:51 +02:00
Aymeric Augustin
82b3e6ffcb
Fixed #13222 -- Made HttpResponse iterable once
...
response.content can be accessed many times as desired, and always
returns the same result.
iter(response) works only once and consumes the iterator.
2012-10-24 17:19:56 +02:00
Aymeric Augustin
495a8b8107
Fixed #6527 -- Provided repeatable content access
...
in HttpResponses instantiated with iterators.
2012-10-24 17:08:37 +02:00
Aymeric Augustin
83041ca802
Fixed a DeprecationWarning under Python 3.
2012-10-24 16:52:21 +02:00
Claude Paroz
9fd2f9c5f3
Fixed #19088 -- Always escape % inside blocktrans tag
...
Thanks vlinhart for the report and Łukasz Rekucki for the patch.
2012-10-23 18:49:22 +02:00
Carl Meyer
3541a10d49
Fixed #19164 -- Fixed diffsettings command broken in fix for #18545 .
...
Thanks Mario César for the report and draft patch.
2012-10-22 18:49:08 -06:00
Aymeric Augustin
ea57112d53
Reverted 6a64822bf4
.
...
This commit caused every test that does two or more assertContains to
fail, because of #6527 . It also made HttpResponse non-pickleable.
Refs #13222 .
2012-10-23 00:11:17 +02:00
Aymeric Augustin
6a64822bf4
Fixed #13222 -- Repeated iteration of HttpResponse
...
Thanks teepark for the report and grahamd for his insights.
2012-10-22 22:52:36 +02:00
Claude Paroz
e70170c2cb
Cleaned up i18n regression tests
2012-10-22 14:45:41 +02:00
Aymeric Augustin
5e629a015e
Added tests for conditional_content_removal.
...
Refs #7581 . Thanks mrmachine.
2012-10-21 22:40:31 +02:00
Claude Paroz
22471a41ba
Merge pull request #457 from JanBednarik/ticket_19142
...
Fixed #19142 -- Language codes can include numbers (RFC 3066)
2012-10-21 10:35:01 -07:00
Alex Gaynor
6b3d2bc981
Merge pull request #444 from mitar/patch-2
...
Allow reversed iteration over SortedDict.
2012-10-20 20:39:49 -07:00
Jan Bednařík
e6b34193c5
Fixed #19142 -- Language codes can include numbers (RFC 3066).
2012-10-21 01:25:35 +02:00
Jan Bednařík
b87e2f46c8
Fixed #19151 -- Added missing methods to EmptyQuerySet.
...
Added values() and values_list() methods to EmptyQuerySet.
2012-10-21 00:19:38 +02:00
Aymeric Augustin
d7c6a57d60
Used @override_settings in several tests.
2012-10-20 23:22:46 +02:00
Aymeric Augustin
4b27813198
Fixed #7581 -- Added streaming responses.
...
Thanks mrmachine and everyone else involved on this long-standing ticket.
2012-10-20 20:05:11 +02:00
Claude Paroz
cfb3eb2e3d
Used FakePayload in requests tests
2012-10-20 15:54:26 +02:00
Claude Paroz
dcbf08cce5
Fixed #19094 -- Improved FakePayload to support write, len and string input
...
Thanks Ondrej Slinták for the suggestion.
2012-10-20 15:36:24 +02:00
Claude Paroz
dfd4a71751
Fixed #5611 -- Restricted accepted content types in parsing POST data
...
Thanks paulegan for the report and Preston Holmes for the review.
2012-10-20 14:56:16 +02:00
Claude Paroz
681550ca6d
Removed custom WSGIRequestHandler.get_environ
...
We probably historically customized it for good reasons, but
currently, the differences with upstream Python are not
significant any longer.
Also fixes #19075 for which a test has been added.
2012-10-20 13:55:13 +02:00
Ramiro Morales
0b908b92a2
Fixed #8001 -- Made redirections after add/edit in admin customizable.
...
Also fixes #18310 .
2012-10-18 20:58:52 -03:00
Preston Holmes
4fb510fde4
Added missed poisoned host header tests
2012-10-18 11:10:46 -07:00
Claude Paroz
6b0a836c9c
Fixed assertXMLEqual when first node was a comment
2012-10-15 23:05:40 +02:00
Mitar
2811e543c6
Added tests for reversed iteration over SortedDict.
2012-10-15 12:12:10 -07:00
Ludovic Delaveau
7a44dc555a
Fixed #16479 - Forms generated from formsets use ErrorList instead of supplied error_class
...
Patch with tests from charettes, updated.
2012-10-13 15:28:20 +01:00
Adrian Holovaty
ffbc599f77
Removed country-specific localflavor tests.
...
They now live in separate django-contrib-XX packages.
2012-10-12 16:21:51 -05:00
Tim Graham
06f5da3d78
Fixed #16817 - Added a guide of code coverage to contributing docs.
...
Thanks Pedro Lima for the draft patch.
2012-10-11 06:11:52 -04:00
Anssi Kääriäinen
041ef9ed68
Removed some uses of F() expression & and |
...
Refs #16211
2012-10-10 03:31:11 +03:00
Michael Manfre
32ac067a6d
Fixed #18927 -- Fixed bulk_create tests when no has_bulk_insert
2012-10-10 01:39:43 +03:00
Anssi Kääriäinen
b625e8272b
Moved F() '&' and '|' to .bitand() and .bitor()
...
Done for consistency with Q() expressions and QuerySet combining. This
will allow usage of '&' and '|' as boolean logical operators in the
future. Refs #16211 .
2012-10-10 01:15:29 +03:00
Anssi Kääriäinen
a8b1861fc4
Revert "Fixed #16211 -- Added comparison and negation ops to F() expressions"
...
This reverts commit 28abf5f0eb
.
Conflicts:
docs/releases/1.5.txt
2012-10-10 01:15:29 +03:00
Anssi Kääriäinen
7f4dbdc036
Revert "Splitted expressions tests into smaller methods"
...
This reverts commit c2532825db
.
2012-10-10 01:15:29 +03:00
Claude Paroz
252cd271e8
Fixed test failure after IDN domain validation fix
...
Refs #17867 .
The address in test_email_regexp_for_performance used to take forever
(security issue), then was supposed to fail after the fix (commit 9f8287a3f
).
Now we are less strict with domain validation, due to new IDN domains,
hence the validation of this address pass now.
2012-10-09 22:44:43 +02:00
Aymeric Augustin
3190abcd75
Fixed #18153 -- Reverse OneToOne lookups on unsaved instances.
...
Thanks David Hatch and Anssi Kääriäinen for their inputs.
2012-10-09 21:36:35 +02:00
Aymeric Augustin
c9b4e9ac3a
Fixed #19095 -- invalid code in multidb tests.
2012-10-09 21:23:02 +02:00
Claude Paroz
273b96ef9d
Fixed #17867 -- Made email validation pass with IDN domains
...
Thanks Pierre Matri for the report and the initial patch.
2012-10-09 15:08:32 +02:00
Claude Paroz
8cb9968a91
Moved some email validation tests to validators tests
2012-10-09 15:08:32 +02:00
Claude Paroz
a8f888feb4
Improved assertion error messages in validators tests
2012-10-09 15:08:22 +02:00
Anssi Kääriäinen
a62d53c032
Fixed #19087 -- Ensured query's base table is never LOUTER joined
...
This fixes a regression created by join promotion logic refactoring:
01b9c3d519
Thanks to Ivan Virabyan for the report.
2012-10-08 18:40:09 +03:00
Claude Paroz
4797ad80da
[py3] Decoded the parsed source file encoding in debug view
2012-10-08 10:06:56 +02:00
Ramiro Morales
35e8dc5169
Removed ad-hoc support for usage of short names of built-in DB backends.
...
This non-standard naming was deprecated in Django 1.2.
2012-10-06 23:27:08 -03:00
Claude Paroz
117e99511e
Added assertXML[Not]Equal assertions
...
This is especially needed to compare XML when hash randomization
is on, as attribute order may vary. Refs #17758 , #19038 .
Thanks Taylor Mitchell for the initial patch, and Ian Clelland for
review and cleanup.
2012-10-06 13:14:50 +02:00
Russell Keith-Magee
cc337a74f1
Fixed #19069 -- Improved the error message when trying to query a swapped model.
...
Thanks to Preston Holmes for the suggestion.
2012-10-06 14:21:57 +08:00
Stephen Burrows
218abcc9e5
Fixed #14567 -- Made ModelMultipleChoiceField return EmptyQuerySet as empty value
2012-10-03 20:47:35 +03:00
Russell Keith-Magee
3b6f980bed
Fixed #19049 -- Ensure that swapped models aren't included in reverse field caches.
...
Thanks to Ivan Virabyan for the report.
2012-10-02 22:52:45 +08:00
Preston Holmes
55fa86a97f
Fixed postgres rollback issue with fixture test
2012-10-01 11:36:16 -07:00
Preston Holmes
e7723683dc
Fixed #9279 -- Added ignorenonexistent option to loaddata
...
Thanks to Roman Gladkov for the initial patch and Simon Charette for review.
2012-09-30 23:40:27 -07:00
Claude Paroz
8bd7b598b6
Fixed #18807 -- Made 404.html and 500.html optional
...
Thanks Aymeric Augustin for the report and Jannis Leidel for the
review.
2012-09-30 23:16:19 +02:00
Claude Paroz
08d675a98f
Fixed #7936 -- Added Last-Modified header to feeds
...
Thanks julianb for the report and the initial patch, and Roman
Gladkov for working on tests.
2012-09-30 22:40:25 +02:00
Anssi Kääriäinen
c2532825db
Splitted expressions tests into smaller methods
2012-09-30 17:51:11 +03:00