innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity
django1/tests/gis_tests/geoapp
History
Simon Charette c2d4926702 Fixed #31910 -- Fixed crash of GIS aggregations over subqueries. 
Regression was introduced by fff5186 but was due a long standing issue.

AggregateQuery was abusing Query.subquery: bool by stashing its
compiled inner query's SQL for later use in its compiler which made
select_format checks for Query.subquery wrongly assume the provide
query was a subquery.

This patch prevents that from happening by using a dedicated
inner_query attribute which is compiled at a later time by
SQLAggregateCompiler.

Moving the inner query's compilation to SQLAggregateCompiler.compile
had the side effect of addressing a long standing issue with
aggregation subquery pushdown which prevented converters from being
run. This is now fixed as the aggregation_regress adjustments
demonstrate.

Refs #25367.

Thanks Eran Keydar for the report.
 		2020-11-04 09:54:58 +01:00
..
fixtures
…
__init__.py
…
feeds.py Refs #23919 -- Removed encoding preambles and future imports 2017-01-18 09:55:19 +01:00
models.py Made runtests.py run gis_tests only when using a GIS database backend. 2017-05-04 20:29:19 -04:00
sitemaps.py Used 4 space hanging indent for dictionaries. 2019-01-02 18:18:19 -05:00
test_expressions.py Reverted "Fixed relative paths imports per isort 4.3.5." 2019-03-03 19:33:48 +01:00
test_feeds.py Switched setUp() to setUpTestData() where possible in Django's tests. 2018-11-27 09:35:17 -05:00
test_functions.py Refs #30446 -- Defined output_field of BoundingCircle() GIS database function. 2020-07-14 09:36:17 +02:00
test_indexes.py Fixed #30846 -- Made PostGIS backend respect Index's name argument. 2020-02-10 13:25:32 +01:00
test_regress.py Replaced @no_oracle skips with DatabaseFeatures.allows_group_by_lob. 2020-10-22 18:16:58 +02:00
test_serializers.py Made runtests.py run gis_tests only when using a GIS database backend. 2017-05-04 20:29:19 -04:00
test_sitemaps.py Switched setUp() to setUpTestData() where possible in Django's tests. 2018-11-27 09:35:17 -05:00
tests.py Fixed #31910 -- Fixed crash of GIS aggregations over subqueries. 2020-11-04 09:54:58 +01:00
urls.py Fixed #31459 -- Fixed handling invalid indentifiers in URL path conversion. 2020-04-15 11:29:35 +02:00