Few improvements.

1. Docker build now builds for arm64 as well.
2. Add bind option to specify on which interface the server should listen.
3. Automatically deduce maxmemory setting.

.github/workflows/ci.yml

@@ -20,10 +20,10 @@ jobs:
     strategy:
       matrix:
         # Test of these containers
-        container: ["ubuntu-dev", "alpine-dev"]
+        container: ["ubuntu-dev:20", "alpine-dev:latest"]
     timeout-minutes: 30
     container: 
-      image: ghcr.io/${{ github.repository_owner }}/${{ matrix.container }}:latest
+      image: ghcr.io/${{ github.repository_owner }}/${{ matrix.container }}
       credentials:
         username: ${{ github.repository_owner }}
         password: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/docker-release.yml

@@ -15,6 +15,13 @@ jobs:
       with:
         submodules: true
 
+    - 
+      name: Set up QEMU
+      id: qemu
+      uses: docker/setup-qemu-action@v1
+      with:          
+          platforms: arm64,amd64
+
     - name: Set up Docker Buildx
       uses: docker/setup-buildx-action@v1
 
@@ -29,7 +36,7 @@ jobs:
       uses: docker/build-push-action@v2
       with:
         context: .
-        platforms: linux/amd64
+        platforms: linux/amd64,linux/arm64
         push: ${{ github.event_name != 'pull_request' }}
         tags: |
           ghcr.io/${{ github.actor }}/dragonfly-alpine:latest
@@ -39,8 +46,8 @@ jobs:
       uses: docker/build-push-action@v2
       with:
         context: .
-        platforms: linux/amd64
+        platforms: linux/amd64,linux/arm64
         push: ${{ github.event_name != 'pull_request' }}
         tags: |
           ghcr.io/${{ github.actor }}/dragonfly-ubuntu:latest
-        file: tools/docker/Dockerfile.ubuntu-prod
+        file: tools/docker/Dockerfile.ubuntu-prod:20

helio

@@ -1 +1 @@
-Subproject commit 0ef31fbae12111fec2d49eab98922961ff871049
+Subproject commit 9b96ae52be8ccf35c959c366757ae30174d84a0e

src/server/dfly_main.cc

@@ -6,9 +6,11 @@
 #include <mimalloc.h>
 
 #include "base/init.h"
-#include "base/proc_util.h"
+#include "base/proc_util.h"  // for GetKernelVersion
 #include "facade/dragonfly_listener.h"
+#include "io/proc_reader.h"
 #include "server/main_service.h"
+#include "strings/human_readable.h"
 #include "util/accept_server.h"
 #include "util/uring/uring_pool.h"
 #include "util/varz.h"
@@ -17,10 +19,14 @@ DECLARE_uint32(port);
 DECLARE_uint32(memcache_port);
 DECLARE_uint64(maxmemory);
 DEFINE_bool(use_large_pages, false, "If true - uses large memory pages for allocations");
+DEFINE_string(bind, "",
+              "Bind address. If empty - binds on all interfaces. "
+              "It's not advised due to security implications.");
 
 using namespace util;
 using namespace std;
 using namespace facade;
+using strings::HumanReadableNumBytes;
 
 namespace dfly {
 
@@ -33,7 +39,12 @@ bool RunEngine(ProactorPool* pool, AcceptServer* acceptor) {
   Service service(pool);
 
   service.Init(acceptor);
-  acceptor->AddListener(FLAGS_port, new Listener{Protocol::REDIS, &service});
+  const char* bind_addr = FLAGS_bind.empty() ? nullptr : FLAGS_bind.c_str();
+
+  error_code ec =
+      acceptor->AddListener(bind_addr, FLAGS_port, new Listener{Protocol::REDIS, &service});
+
+  LOG_IF(FATAL, ec) << "Cound not open port " << FLAGS_port << ", error: " << ec.message();
 
   if (FLAGS_memcache_port > 0) {
     acceptor->AddListener(FLAGS_memcache_port, new Listener{Protocol::MEMCACHE, &service});
@@ -69,13 +80,23 @@ int main(int argc, char* argv[]) {
   CHECK_LT(kver.minor, 99u);
   dfly::kernel_version = kver.major * 100 + kver.minor;
 
+  if (FLAGS_maxmemory == 0) {
+    LOG(INFO) << "maxmemory has not been specified. Deciding myself....";
+
+    io::Result<io::MemInfoData> res = io::ReadMemInfo();
+    size_t available = res->mem_avail;
+    size_t maxmemory = size_t(0.8 * available);
+    LOG(INFO) << "Found " << HumanReadableNumBytes(available)
+              << " available memory. Setting maxmemory to " << HumanReadableNumBytes(maxmemory);
+    FLAGS_maxmemory = maxmemory;
+  }
+
   if (FLAGS_use_large_pages) {
     mi_option_enable(mi_option_large_os_pages);
   }
   mi_option_enable(mi_option_show_errors);
   mi_option_set(mi_option_max_warnings, 0);
 
-
   uring::UringPool pp{1024};
   pp.Run();
 

src/server/main_service.cc

@@ -40,7 +40,9 @@ extern "C" {
 DEFINE_uint32(port, 6379, "Redis port");
 DEFINE_uint32(memcache_port, 0, "Memcached port");
 DECLARE_string(requirepass);
-DEFINE_uint64(maxmemory, 0, "Limit on maximum-memory that is used by the database");
+DEFINE_uint64(maxmemory, 0,
+              "Limit on maximum-memory that is used by the database."
+              "0 - means the program will automatically determine its maximum memory usage");
 
 namespace dfly {
 
@@ -997,7 +999,6 @@ void Service::RegisterCommands() {
 
   server_family_.Register(&registry_);
 
-
   if (VLOG_IS_ON(1)) {
     LOG(INFO) << "Multi-key commands are: ";
     registry_.Traverse([](std::string_view key, const CI& cid) {

tools/docker/Dockerfile.ubuntu-prod

@@ -1,5 +1,5 @@
 # syntax=docker/dockerfile:1
-from ghcr.io/romange/ubuntu-dev as builder
+from ghcr.io/romange/ubuntu-dev:20 as builder
 
 WORKDIR /build
 COPY src/  ./src/