innov
/
dragonfly
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix Populate bug

This commit is contained in:
Roman Gershman 2022-01-26 22:11:35 +02:00
parent 5c5c789ac7
commit e68977a7bf
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
server/debugcmd.cc
View File

@ -106,8 +106,11 @@ void DebugCmd::Populate(CmdArgList args) {
vector<fiber> fb_arr(ranges.size()); vector<fiber> fb_arr(ranges.size());
for (size_t i = 0; i < ranges.size(); ++i) { for (size_t i = 0; i < ranges.size(); ++i) {
fb_arr[i] = ess_->pool()->at(i)->LaunchFiber([&] { auto range = ranges[i];
this->PopulateRangeFiber(ranges[i].first, ranges[i].second, prefix, val_size);
// whatever we do, we should not capture i by reference.
fb_arr[i] = ess_->pool()->at(i)->LaunchFiber([=] {
this->PopulateRangeFiber(range.first, range.second, prefix, val_size);
}); });
} }
for (auto& fb : fb_arr) for (auto& fb : fb_arr)
@ -119,10 +122,11 @@ void DebugCmd::Populate(CmdArgList args) {
void DebugCmd::PopulateRangeFiber(uint64_t from, uint64_t len, std::string_view prefix, void DebugCmd::PopulateRangeFiber(uint64_t from, uint64_t len, std::string_view prefix,
unsigned value_len) { unsigned value_len) {
this_fiber::properties<FiberProps>().set_name("populate_range"); this_fiber::properties<FiberProps>().set_name("populate_range");
VLOG(1) << "PopulateRange: " << from << "-" << (from + len - 1);
string key = absl::StrCat(prefix, ":"); string key = absl::StrCat(prefix, ":");
size_t prefsize = key.size(); size_t prefsize = key.size();
DbIndex db_indx = 0; // TODO DbIndex db_indx = cntx_->db_index();
std::vector<PopulateBatch> ps(ess_->size(), PopulateBatch{db_indx}); std::vector<PopulateBatch> ps(ess_->size(), PopulateBatch{db_indx});
SetCmd::SetParams params{db_indx}; SetCmd::SetParams params{db_indx};