1. remove some todo (#755)

This commit is contained in:
ning1875 2021-08-02 17:37:55 +08:00 committed by GitHub
parent e14d3eac4d
commit 72244b1983
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 8 deletions

View File

@ -223,7 +223,6 @@ func (pd *PromeDataSource) QueryData(inputs vos.DataQueryParam) []*vos.DataQuery
}
ctx, _ := context.WithTimeout(context.Background(), time.Second*30)
res := q.Exec(ctx)
// TODO 将err返回给前端
if res.Err != nil {
logger.Errorf("[prome_query_error][rangeQuery_exec_error][args:%+v][err:%+v]", input, res.Err)
q.Close()
@ -251,7 +250,6 @@ func (pd *PromeDataSource) QueryData(inputs vos.DataQueryParam) []*vos.DataQuery
name := m.Metric.Get(LABEL_NAME)
oneResp.Metric = name
oneResp.Ident = ident
// TODO 去掉point num
pNum := len(m.Points)
interval := int64(resolution / time.Second)
pNumExpect := int((inputs.End - inputs.Start) / interval)
@ -391,7 +389,6 @@ func (pd *PromeDataSource) CommonQuerySeries(cj *commonQueryObj) storage.SeriesS
// TODO 等待prometheus官方对 remote_read label_values 的支持
// Implement: https://github.com/prometheus/prometheus/issues/3351
func (pd *PromeDataSource) QueryTagKeys(recv vos.CommonTagQueryParam) *vos.TagKeyQueryResp {
// TODO 完成标签匹配模式
respD := &vos.TagKeyQueryResp{
Keys: make([]string, 0),
}

View File

@ -168,10 +168,9 @@ func handlePromqlVector(pv promql.Vector, r models.AlertRule) {
logger.Debugf("[proml.historyArr][metricsName:%v][Tags:%v]\n", metricsName, tagm)
event := &models.AlertEvent{
RuleId: r.Id,
RuleName: r.Name,
RuleNote: r.Note,
// TODO for expr 这些信息变化 hashid 也要变,
RuleId: r.Id,
RuleName: r.Name,
RuleNote: r.Note,
HashId: hashId,
IsPromePull: 1,
IsRecovery: 0,

View File

@ -38,7 +38,6 @@ func Query(reqs *vos.DataQueryParam) []*vos.HPoint {
return hisD
}
logger.Debugf("[reqs:%+v][queryResD:%+v]\n", reqs, queryResD[0])
// TODO 如何判断查询到的多条曲线? 与条件希望都是配置时就是一条曲线
fD := queryResD[0]
var values vos.HistoryDataS