diff --git a/src/modules/collector/log/strategy/strategy.go b/src/modules/collector/log/strategy/strategy.go index 8bf54cd9..09f08be7 100644 --- a/src/modules/collector/log/strategy/strategy.go +++ b/src/modules/collector/log/strategy/strategy.go @@ -66,7 +66,7 @@ func GetByID(id int64) (*stra.Strategy, error) { st, ok := globalStrategy[id] if !ok { - return nil, fmt.Errorf("ID : %d is not exists in global Cache") + return nil, fmt.Errorf("ID : %d is not exists in global Cache", id) } return st, nil diff --git a/src/modules/collector/sys/funcs/sys.go b/src/modules/collector/sys/funcs/sys.go index 082418a0..0559ccac 100644 --- a/src/modules/collector/sys/funcs/sys.go +++ b/src/modules/collector/sys/funcs/sys.go @@ -69,19 +69,19 @@ func EntityNumMetrics() []*dataobj.MetricValue { L := strings.Fields(data) if len(L) < 5 { - logger.Errorf("get entity num err:", data) + logger.Errorf("get entity num err: %v", data) return nil } arr := strings.Split(L[3], "/") if len(arr) != 2 { - logger.Errorf("get entity num err:", data) + logger.Errorf("get entity num err: %v", data) return nil } num, err := strconv.ParseFloat(arr[1], 64) if err != nil { - logger.Errorf("get entity num err:", err) + logger.Errorf("get entity num err: %v", err) return nil } diff --git a/src/modules/judge/judge/judge.go b/src/modules/judge/judge/judge.go index cb9dc1ea..29a592e8 100644 --- a/src/modules/judge/judge/judge.go +++ b/src/modules/judge/judge/judge.go @@ -95,7 +95,7 @@ func Judge(stra *model.Stra, exps []model.Exp, historyData []*dataobj.RRDData, f if len(exps) == 1 { bs, err := json.Marshal(history) if err != nil { - logger.Error("Marshal history:%v err:%v", history, err) + logger.Errorf("Marshal history:%v err:%v", history, err) } event := &dataobj.Event{ ID: fmt.Sprintf("s_%d_%s", stra.Id, firstItem.PrimaryKey()), diff --git a/src/modules/monapi/cron/stra.go b/src/modules/monapi/cron/stra.go index f44ff362..8369098b 100644 --- a/src/modules/monapi/cron/stra.go +++ b/src/modules/monapi/cron/stra.go @@ -62,14 +62,14 @@ func CleanStra() { for _, stra := range list { node, err := model.NodeGet("id", stra.Nid) if err != nil { - logger.Warning("get node failed, node id: %v, err: %v", stra.Nid, err) + logger.Warningf("get node failed, node id: %d, err: %v", stra.Nid, err) continue } if node == nil { logger.Infof("delete stra:%d", stra.Id) if err := model.StraDel(stra.Id); err != nil { - logger.Warning("delete stra: %d, err: %v", stra.Id, err) + logger.Warningf("delete stra: %d, err: %v", stra.Id, err) } } } diff --git a/src/modules/monapi/scache/init.go b/src/modules/monapi/scache/init.go index 1f04d22c..8d448731 100644 --- a/src/modules/monapi/scache/init.go +++ b/src/modules/monapi/scache/init.go @@ -90,7 +90,7 @@ func syncCollects() { ports, err := model.GetPortCollects() if err != nil { - logger.Warningf("get port collects err:%v %v", err) + logger.Warningf("get port collects err:%v", err) } for _, p := range ports { @@ -120,7 +120,7 @@ func syncCollects() { procs, err := model.GetProcCollects() if err != nil { - logger.Warningf("get port collects err:%v %v", err) + logger.Warningf("get port collects err:%v", err) } for _, p := range procs { @@ -149,7 +149,7 @@ func syncCollects() { logConfigs, err := model.GetLogCollects() if err != nil { - logger.Warningf("get log collects err:%v %v", err) + logger.Warningf("get log collects err:%v", err) } for _, l := range logConfigs {