From bff5a36577f3b3049c4aac71277b164cfd91b8dc Mon Sep 17 00:00:00 2001 From: daiao <358551898@qq.com> Date: Fri, 25 Nov 2016 11:32:45 +0800 Subject: [PATCH 1/3] =?UTF-8?q?pull=20request=E5=90=84=E7=A7=8D=E6=83=85?= =?UTF-8?q?=E5=86=B5=E7=BB=99=E5=87=BA=E6=8F=90=E7=A4=BA=20=E9=A1=B9?= =?UTF-8?q?=E7=9B=AE=E9=A1=B6=E5=A4=B4=E7=9A=84fork=E4=BF=A1=E6=81=AF?= =?UTF-8?q?=E5=BC=B9=E5=87=BA=E6=96=B0=E9=A1=B5=E9=9D=A2=E5=8F=8A=E9=BC=A0?= =?UTF-8?q?=E6=A0=87=E7=BB=8F=E8=BF=87=E6=89=8B=E5=9E=8B=E6=95=88=E6=9E=9C?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/controllers/pull_requests_controller.rb | 2 +- app/views/layouts/_base_project_top.html.erb | 4 ++-- app/views/pull_requests/_show.html.erb | 10 +--------- app/views/pull_requests/_show_container.html.erb | 11 +++++++++++ public/stylesheets/css/project.css | 4 ++-- 5 files changed, 17 insertions(+), 14 deletions(-) create mode 100644 app/views/pull_requests/_show_container.html.erb diff --git a/app/controllers/pull_requests_controller.rb b/app/controllers/pull_requests_controller.rb index a71f9c105..e4a2dc9df 100644 --- a/app/controllers/pull_requests_controller.rb +++ b/app/controllers/pull_requests_controller.rb @@ -227,7 +227,7 @@ class PullRequestsController < ApplicationController # Gets the comments on a merge request. # # @example - # Gitlab.merge_request_comments(5, 1) + # Gitlab.merge_request_comments(5, 1) def pull_request_comments begin @comments = @g.merge_request_comments(@project.gpid, params[:id]).reverse diff --git a/app/views/layouts/_base_project_top.html.erb b/app/views/layouts/_base_project_top.html.erb index afd78117a..d6c704aa0 100644 --- a/app/views/layouts/_base_project_top.html.erb +++ b/app/views/layouts/_base_project_top.html.erb @@ -19,8 +19,8 @@
<% unless @project.forked_from_project_id.nil? %>
- forked from <%=link_to "#{get_fork_from_project(@project.forked_from_project_id).owner.try(:show_name)}/".html_safe, user_path(get_fork_from_project(@project.forked_from_project_id).owner), :class => "pro_new_username_fork fl" %> - <%=link_to get_fork_from_project(@project.forked_from_project_id).name, project_path(get_fork_from_project(@project.forked_from_project_id)), :class => "pro_new_username_fork fl" %> + forked from <%=link_to "#{get_fork_from_project(@project.forked_from_project_id).owner.try(:show_name)}/".html_safe, user_path(get_fork_from_project(@project.forked_from_project_id).owner), :class => "pro_new_username_fork fl", :target => "_blank" %> + <%=link_to get_fork_from_project(@project.forked_from_project_id).name, project_path(get_fork_from_project(@project.forked_from_project_id)), :class => "pro_new_username_fork fl", :target => "_blank" %>
<% end %> diff --git a/app/views/pull_requests/_show.html.erb b/app/views/pull_requests/_show.html.erb index a7dbc91f1..adf0ded0c 100644 --- a/app/views/pull_requests/_show.html.erb +++ b/app/views/pull_requests/_show.html.erb @@ -31,15 +31,7 @@ 改动已合并至 <%= @request.target_branch %> 分支 <% else %> - <% if is_project_manager?(User.current.id, @project.id) %> - <% if @request.state == "closed" %> - 该请求已被关闭 - <% else %> -
- 在管理员接受后，将由系统自动合并。<%= link_to "接受", accept_pull_request_project_pull_request_path(@request.id, :project_id => @project.id), :class => "linkBlue2", :remote => true %> -
- <% end %> - <% end %> + <%= render "show_container" %> <% end %> diff --git a/app/views/pull_requests/_show_container.html.erb b/app/views/pull_requests/_show_container.html.erb new file mode 100644 index 000000000..0e5356566 --- /dev/null +++ b/app/views/pull_requests/_show_container.html.erb @@ -0,0 +1,11 @@ +<% if @request.state == "closed" %> + 该请求已被关闭 +<% elsif @commits_count == 0 %> + 项目分支 <%= @request.source_branch %> 和 <%= @request.target_branch %> 似乎没有差异，请将新改动提交至源分支或者切换到其它目标分支 +<% else %> + <% if is_project_manager?(User.current.id, @project.id) %> +
+ 在管理员接受后，将由系统自动合并。<%= link_to "接受", accept_pull_request_project_pull_request_path(@request.id, :project_id => @project.id), :class => "linkBlue2", :remote => true %> +
+ <% end %> +<% end %> diff --git a/public/stylesheets/css/project.css b/public/stylesheets/css/project.css index 33d6d1dbf..5af60925c 100644 --- a/public/stylesheets/css/project.css +++ b/public/stylesheets/css/project.css @@ -860,8 +860,8 @@ input.pro_newissue_con_check{ width: 15px; height: 15px;} .pro_new_top {padding-top:15px; border:1px solid #ddd; background-color:#fff; width: 998px;} .icons_newpro_lock{width: 22px; height: 23px; display: inline-block; background: url("/images/new_project/icons_issue.png") 0 -113px no-repeat;} .pro_new_name{width: 600px; } -a.pro_new_username { font-size: 20px; color: #3b94d6; line-height: 24px; cursor: default;} -a.pro_new_username_fork { font-size: 12px; color: #3b94d6; line-height: 24px; cursor: default;} +a.pro_new_username { font-size: 20px; color: #3b94d6; line-height: 24px;} +a.pro_new_username_fork { font-size: 12px; color: #3b94d6; line-height: 24px;} a.pro_new_proname{ overflow: hidden;white-space: nowrap;text-overflow:ellipsis;display: inline-block;} a.pro_new_project_name{ width: 250px; overflow: hidden;white-space: nowrap;text-overflow:ellipsis;display: inline-block;} a.pro_new_topbtn{ padding: 3px 7px; font-size: 12px; line-height: 20px; color: #333;vertical-align: middle;background-color: #fff; border: 1px solid #ddd; border-left: 0; border-top-right-radius: 3px; border-bottom-right-radius: 3px; color: #333;} From b15fd1607ff7a3bc808b6be159103bbe9bf5a3a7 Mon Sep 17 00:00:00 2001 From: huang Date: Fri, 25 Nov 2016 14:50:23 +0800 Subject: [PATCH 2/3] =?UTF-8?q?=E9=87=8C=E7=A8=8B=E7=A2=91issue=E7=BB=9F?= =?UTF-8?q?=E8=AE=A1=EF=BC=8C=E5=8A=A0=E5=85=A5=E6=9C=AA=E6=8C=87=E6=B4=BE?= =?UTF-8?q?=EF=BC=8C=E8=B0=83=E6=95=B4total=E4=BD=8D=E7=BD=AE=EF=BC=8C?= =?UTF-8?q?=E5=B9=B6=E6=8C=89=E6=88=90=E5=91=98issue=E7=9A=84=E6=95=B0?= =?UTF-8?q?=E9=87=8F=E6=8E=92=E5=BA=8F?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/controllers/versions_controller.rb | 3 ++- app/views/versions/_issue_statistics.html.erb | 16 ++++++++-------- app/views/versions/_new_milestone.html.erb | 2 +- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/app/controllers/versions_controller.rb b/app/controllers/versions_controller.rb index ed9c4638f..7b4695d3c 100644 --- a/app/controllers/versions_controller.rb +++ b/app/controllers/versions_controller.rb @@ -125,7 +125,8 @@ class VersionsController < ApplicationController @issue_pages = Paginator.new @issue_count, @limit, params['page'] || 1 # @offset ||= @issue_pages.offset @issues = paginateHelper @version_issues, @limit - @version_issue_assigned_name = @version_issues.group_by(&:assigned_to_id) + @version_issue_assigned_name = @version_issues.sort_by{ |i| Issue.where(:project_id => @project.id , + :assigned_to_id => i.assigned_to_id, :fixed_version_id => @version.id).count }.reverse.group_by(&:assigned_to_id) format.html { # @issues = @version.fixed_issues.visible. # includes(:status, :tracker, :priority). diff --git a/app/views/versions/_issue_statistics.html.erb b/app/views/versions/_issue_statistics.html.erb index b8c0ff2e3..47d420a75 100644 --- a/app/views/versions/_issue_statistics.html.erb +++ b/app/views/versions/_issue_statistics.html.erb @@ -9,21 +9,21 @@ + + 合计 + <%= Issue.where(:fixed_version_id => @version.id).count %> + <%= Issue.where(:fixed_version_id => @version.id, :status_id => 3).count %> + <%= Issue.where(:fixed_version_id => @version.id, :status_id => 5).count %> + <%= Issue.where(fixed_version_id: @version.id, status_id: [1,2,4]).count %> + <% @version_issue_assigned_name.each do | assigned | %> - <%= User.find(assigned[0]).try(:show_name) %> + <%= User.find(assigned[0]).try(:show_name).nil? ? "未指派" : User.find(assigned[0]).try(:show_name) %> <%= Issue.where(:fixed_version_id => @version.id, :assigned_to_id => assigned[0]).count %> <%= Issue.where(:fixed_version_id => @version.id, :assigned_to_id => assigned[0], :status_id => 3).count %> <%= Issue.where(:fixed_version_id => @version.id, :assigned_to_id => assigned[0], :status_id => 5).count %> <%= Issue.where(fixed_version_id: @version.id, assigned_to_id: assigned[0], status_id: [1,2,4]).count %> <% end %> - - Total - <%= Issue.where(:fixed_version_id => @version.id).count %> - <%= Issue.where(:fixed_version_id => @version.id, :status_id => 3).count %> - <%= Issue.where(:fixed_version_id => @version.id, :status_id => 5).count %> - <%= Issue.where(fixed_version_id: @version.id, status_id: [1,2,4]).count %> - \ No newline at end of file diff --git a/app/views/versions/_new_milestone.html.erb b/app/views/versions/_new_milestone.html.erb index 40fff71f2..b89936f3e 100644 --- a/app/views/versions/_new_milestone.html.erb +++ b/app/views/versions/_new_milestone.html.erb @@ -14,7 +14,7 @@
  • <%= f.text_field :name, :maxlength => 60, :class=>"w650", :style=>"height: 28px;", :id => "popub_setting_version_name", :no_label => true %> - +
  • From 25ffa16c06d7e70f501a4dfcf63096e89bcdff0e Mon Sep 17 00:00:00 2001 From: huang Date: Fri, 25 Nov 2016 15:15:29 +0800 Subject: [PATCH 3/3] =?UTF-8?q?pull=20request=20=E6=9C=AA=E6=94=B9?= =?UTF-8?q?=E5=8A=A8=E5=8F=8A=E5=B7=B2=E5=90=88=E5=B9=B6=E6=8F=90=E9=86=92?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/views/pull_requests/_show_container.html.erb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/views/pull_requests/_show_container.html.erb b/app/views/pull_requests/_show_container.html.erb index 0e5356566..24216ac77 100644 --- a/app/views/pull_requests/_show_container.html.erb +++ b/app/views/pull_requests/_show_container.html.erb @@ -1,7 +1,11 @@ <% if @request.state == "closed" %> - 该请求已被关闭 +
    + 该请求已被关闭 +
    <% elsif @commits_count == 0 %> - 项目分支 <%= @request.source_branch %> 和 <%= @request.target_branch %> 似乎没有差异，请将新改动提交至源分支或者切换到其它目标分支 +
    + 项目分支 <%= @request.source_branch %> 和 <%= @request.target_branch %> 似乎没有差异，请将新改动提交至源分支或者切换到其它目标分支 +
    <% else %> <% if is_project_manager?(User.current.id, @project.id) %>