对于隐藏版本库的项目，版本库对报告人员不可见

app/controllers/repositories_controller.rb

@@ -397,51 +397,56 @@ update
   end
 
   def show
-    # 顶部导航
-    @project_menu_type = 5
-
-    # TODO: the below will move to filter, done.
-    # 获取版本库目录结构
-    @entries = @repository.entries(@path, @rev)
-    if request.xhr?
-      @entries ? render(:partial => 'dir_list_content') : render(:nothing => true)
+    if  @project.hidden_repo && (role_of_members_in_project(@project.id, User.current.id) == "Reporter" || !is_project_member?(User.current.id, @project.id))
+      render_403
+      return
     else
-      unless @entries.blank?
-        @changesets_latest_coimmit = @g.rep_last_changes(@project.gpid, :rev => @rev, :path => @path)
-        # @g.rep_last_changes(@project.gpid, :rev => @rev, :path => @path)
-        # 总的提交数
-        @changesets_all_count = @g.user_static(@project.gpid, :rev => @rev).count
-        # 获取默认分支
-        @g_default_branch = @g_project.default_branch.nil? ?  "master" : @g_project.default_branch
+      # 顶部导航
+      @project_menu_type = 5
+
+      # TODO: the below will move to filter, done.
+      # 获取版本库目录结构
+      @entries = @repository.entries(@path, @rev)
+      if request.xhr?
+        @entries ? render(:partial => 'dir_list_content') : render(:nothing => true)
+      else
+        unless @entries.blank?
+          @changesets_latest_coimmit = @g.rep_last_changes(@project.gpid, :rev => @rev, :path => @path)
+          # @g.rep_last_changes(@project.gpid, :rev => @rev, :path => @path)
+          # 总的提交数
+          @changesets_all_count = @g.user_static(@project.gpid, :rev => @rev).count
+          # 获取默认分支
+          @g_default_branch = @g_project.default_branch.nil? ?  "master" : @g_project.default_branch
+
+          @creator = @project.owner.to_s
+          gitlab_address = Redmine::Configuration['gitlab_address']
+          gitlab_token = Gitlab.private_token
+          # token值加密解密
+          token = aes_encrypt("priEn3UwXfJs3Pmy", gitlab_token)
+          # token值解密
+          # gitlab_token = aes_dicrypt("priEn3UwXfJs3Pmy", token)
+          @zip_path = Gitlab.endpoint.to_s + "/projects/" + @project.gpid.to_s + "/repository/archive?&private_token=" + token
+        end
 
         @creator = @project.owner.to_s
         gitlab_address = Redmine::Configuration['gitlab_address']
-        gitlab_token = Gitlab.private_token
-        # token值加密解密
-        token = aes_encrypt("priEn3UwXfJs3Pmy", gitlab_token)
-        # token值解密
-        # gitlab_token = aes_dicrypt("priEn3UwXfJs3Pmy", token)
-        @zip_path = Gitlab.endpoint.to_s + "/projects/" + @project.gpid.to_s + "/repository/archive?&private_token=" + token
-      end
+        @repos_url = gitlab_address.to_s+"/" + @creator + "/" + @repository.identifier+"."+"git"
 
-      @creator = @project.owner.to_s
-      gitlab_address = Redmine::Configuration['gitlab_address']
-      @repos_url = gitlab_address.to_s+"/" + @creator + "/" + @repository.identifier+"."+"git"
+        # 一些数据的异步同步更新
+        # 访问版本庫后更新project_score表数据；changeset_num为提交总数
+        project_score = @project.project_score
+        if project_score.nil?
+          ProjectScore.create(:project_id => @project.id, :score => false)
+        else
+          project_score.update_column(:changeset_num, @changesets_all_count)
+        end
+        # 更新提交时间，用于课程
+        unless @changesets_latest_coimmit.blank?
+          update_commits_date(@project, @changesets_latest_coimmit)
+        end
 
-      # 一些数据的异步同步更新
-      # 访问版本庫后更新project_score表数据；changeset_num为提交总数
-      project_score = @project.project_score
-      if project_score.nil?
-        ProjectScore.create(:project_id => @project.id, :score => false)
-      else
-        project_score.update_column(:changeset_num, @changesets_all_count)
+        render :layout => 'base_projects'
       end
-      # 更新提交时间，用于课程
-      unless @changesets_latest_coimmit.blank?
-        update_commits_date(@project, @changesets_latest_coimmit)
-      end
-
-      render :layout => 'base_projects'
     end
   end
 

app/helpers/application_helper.rb

@@ -1017,6 +1017,25 @@ module ApplicationHelper
     end
   end
 
+  # 判断成员在项目中的角色 member_role == Reporter/Manager/Developer 报告人员/管理人员/报告人员；
+  def role_of_members_in_project(project, user_id)
+    member = Member.where(:project_id => project, :user_id => user_id)
+    unless member.blank?
+      member_role = member.first.roles[0].to_s
+    end
+    return member_role
+  end
+
+  # 判断用户是不是项目成员
+  def is_project_member?(user_id, project_id)
+    @result = false
+    mem = Member.where("user_id = ? and project_id = ?",user_id, project_id)
+    unless mem.blank?
+      @result = true
+    end
+    return @result
+  end
+
   def show_attachment_tip container_id, container_type
     atts = Attachment.where(:container_id => container_id, :container_type => container_type, :is_public => 0)
     atts.count > 0 ? true :false

app/helpers/projects_helper.rb

@@ -321,15 +321,6 @@ module ProjectsHelper
     end
     return @result
   end
-  # 判断用户是不是项目成员
-  def is_project_member?(user_id, project_id)
-    @result = false
-    mem = Member.where("user_id = ? and project_id = ?",user_id, project_id)
-    unless mem.blank?
-      @result = true
-    end
-    return @result
-  end
 
   # 用来判断用户是否是项目的管理员
   # added by william

app/views/layouts/_base_project_top.html.erb

@@ -50,8 +50,10 @@
       <% end %>
       <!--版本库-->
       <% if visible_repository?(@project) %>
-          <li id="project_menu_05"><%= link_to @project.project_score.changeset_num.to_i > 0 ? "#{l(:project_module_repository)}<span class='issues_nav_tag ml5'>#{switch_integer_into_k project_score.changeset_num}</span>".html_safe : "#{l(:project_module_repository)}",({:controller => 'repositories', :action => 'show', :id => @project, :repository_id => gitlab_repository(@project).try(:identifier)}), :class => "pro_new_proname", :title => "#{project_score.changeset_num}"  %>
-          </li>
+          <% unless @project.hidden_repo && (role_of_members_in_project(@project.id, User.current.id) == "Reporter" || !is_project_member?(User.current.id, @project.id)) %>
+              <li id="project_menu_05"><%= link_to @project.project_score.changeset_num.to_i > 0 ? "#{l(:project_module_repository)}<span class='issues_nav_tag ml5'>#{switch_integer_into_k project_score.changeset_num}</span>".html_safe : "#{l(:project_module_repository)}",({:controller => 'repositories', :action => 'show', :id => @project, :repository_id => gitlab_repository(@project).try(:identifier)}), :class => "pro_new_proname", :title => "#{project_score.changeset_num}"  %>
+              </li>
+          <% end %>
       <% end %>
       <!--Pull Request-->
       <% unless @project.gpid.nil? %>