优化课程首页效率

app/helpers/welcome_helper.rb

@@ -231,12 +231,12 @@ module WelcomeHelper
   # modif by nwb
   def find_all_new_hot_course limit = 9 ,school_id = 0
     #sort_project_by_hot_rails 1, 'course_ac_para DESC', limit
-    time_now = Time.new.strftime("%Y");
+    time_now = Time.new.strftime("%Y")
     if school_id
-    courses = Course.visible.joins(:course_status).where("#{Course.table_name}.created_at like '%#{time_now}%' and #{Course.table_name}.school_id <>
+    courses = Course.includes(:school).visible.joins(:course_status).where("#{Course.table_name}.created_at like '%#{time_now}%' and #{Course.table_name}.school_id <>
        ?", school_id).order("course_ac_para DESC").limit(limit).all
     else
-      courses = Course.visible.joins(:course_status).where("#{Course.table_name}.created_at like '%#{time_now}%' and #{Course.table_name}.school_id is not NULL
+      courses = Course.includes(:school).visible.joins(:course_status).where("#{Course.table_name}.created_at like '%#{time_now}%' and #{Course.table_name}.school_id is not NULL
        ").order("course_ac_para DESC").limit(limit).all
      end
     courses

app/views/welcome/_course_list.html.erb

@@ -20,9 +20,9 @@
       <div class='desc_item text_nowrap'>
         [<%= get_course_term course %>]
         <%= link_to(course.name.truncate(30, omission: '...'), course_path(course.id), :class => "d-g-blue d-p-project-name", :title => "#{course.name}") %>
-        (<%= "#{memberCount(course)}人" %>)
-        <% files_count = course.attachments.count.to_s %>
-        (<%= link_to "#{files_count}份", course_files_path(course) %>资料)
+        (<%= course.members.count %>人)
+        <%# files_count = course.attachments.count.to_s %>
+        (<%= link_to "#{course.attachments.count.to_s}份", course_files_path(course) %>资料)
       </div>
     </li>
 <% end %>

app/views/welcome/_no_course_title.html.erb

@@ -1,5 +1,5 @@
 <h1></h1>
 <p id="errorExplanation">
-  该学校未开设任何课程，您可以查看其他学校课程
+  <%= course_title%>
 </p>
 <h1></h1>

app/views/welcome/course.html.erb

@@ -91,7 +91,9 @@
         <ul class="d-p-projectlist">
 
           <% if User.current.logged? %>
-              <%= render "welcome/no_course_title"%>
+              <li>
+                <%= render :partial => 'no_course_title', :locals => {:course_title => l(:lable_school_no_course)} %>
+              </li>
               <%= render :partial => 'course_list', :locals => {:course_list => find_all_new_hot_course(9, @school_id)} %>
           <% else %>
               <%= render :partial => 'course_list', :locals => {:course_list => find_all_new_hot_course(10, @school_id)} %>
@@ -113,9 +115,9 @@
           <%= render :partial => 'course_list', :locals => {:course_list => school_course} %>
           <% if school_course.count < 10 %>
               <li>
-                <%= render "welcome/no_course_title"%>
+                <%= render :partial => 'no_course_title', :locals => {:course_title => l(:lable_school_less_course)} %>
               </li>
-              <%= render :partial => 'course_list', :locals => {:course_list => find_all_new_hot_course(10 - school_course.count - 1, @school_id)} %>
+              <%= render :partial => 'course_list', :locals => {:course_list => find_all_new_hot_course(9 - school_course.count, @school_id)} %>
           <% end %>
         </ul>
       </div>

config/locales/zh.yml

@@ -2102,3 +2102,6 @@ zh:
   modal_valid_passing: 可以使用
   label_bug: 漏洞
 
+  lable_school_no_course: 该学校未开设任何课程，您可以查看其他学校课程
+  lable_school_less_course: 该学校开设课程较少，您可以查看其他学校课程
+