jasder
/
antlr
1
0
Fork 1
Code Issues Pull Requests Releases 1 Wiki Activity

Remove field which hides another field with the same name; add check for this condition to OutputModelWalker

This commit is contained in:
Sam Harwell 2012-07-18 15:39:38 -05:00
parent 45815d97f7
commit 589d6bf187
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tool/src/org/antlr/v4/codegen/OutputModelWalker.java
View File

@ -95,6 +95,7 @@ public class OutputModelWalker {
st.add(modelArgName, omo); st.add(modelArgName, omo);
// COMPUTE STs FOR EACH NESTED MODEL OBJECT MARKED WITH @ModelElement AND MAKE ST ATTRIBUTE // COMPUTE STs FOR EACH NESTED MODEL OBJECT MARKED WITH @ModelElement AND MAKE ST ATTRIBUTE
Set<String> usedFieldNames = new HashSet<String>();
Field fields[] = cl.getFields(); Field fields[] = cl.getFields();
for (Field fi : fields) { for (Field fi : fields) {
ModelElement annotation = fi.getAnnotation(ModelElement.class); ModelElement annotation = fi.getAnnotation(ModelElement.class);
@ -103,8 +104,15 @@ public class OutputModelWalker {
} }
String fieldName = fi.getName(); String fieldName = fi.getName();
if (!usedFieldNames.add(fieldName)) {
tool.errMgr.toolError(ErrorType.INTERNAL_ERROR, "Model object " + omo.getClass().getSimpleName() + " has multiple fields named '" + fieldName + "'");
continue;
}
// Just don't set @ModelElement fields w/o formal arg in target ST // Just don't set @ModelElement fields w/o formal arg in target ST
if ( formalArgs.get(fieldName)==null ) continue; if ( formalArgs.get(fieldName)==null ) continue;
try { try {
Object o = fi.get(omo); Object o = fi.get(omo);
if ( o instanceof OutputModelObject ) { // SINGLE MODEL OBJECT? if ( o instanceof OutputModelObject ) { // SINGLE MODEL OBJECT?

1
tool/src/org/antlr/v4/codegen/model/LL1PlusBlock.java
View File

@ -46,7 +46,6 @@ public class LL1PlusBlock extends LL1Loop {
public String loopCounterVar; public String loopCounterVar;
public String[] exitLook; public String[] exitLook;
@ModelElement public SrcOp loopExpr;
@ModelElement public ThrowNoViableAlt error; @ModelElement public ThrowNoViableAlt error;
public LL1PlusBlock(OutputModelFactory factory, GrammarAST plusRoot, List<CodeBlockForAlt> alts) { public LL1PlusBlock(OutputModelFactory factory, GrammarAST plusRoot, List<CodeBlockForAlt> alts) {