diff --git a/Cutting-an-ANTLR-4-release.md b/Cutting-an-ANTLR-4-release.md index 56d81dd..0c45b28 100644 --- a/Cutting-an-ANTLR-4-release.md +++ b/Cutting-an-ANTLR-4-release.md @@ -140,6 +140,6 @@ See [Deploying ANTLR mvn artifacts](https://github.com/antlr/antlr4/wiki/Deployi * Update [Doc main page](https://theantlrguy.atlassian.net/wiki/display/ANTLR4/ANTLR+4+Documentation) and the [getting started](https://theantlrguy.atlassian.net/wiki/display/ANTLR4/Getting+Started+with+ANTLR+v4) page to use the latest version. -* add note about the prerelease to download.html (note). +* Add note about the prerelease to download.html if this is not a full release. Otherwise update the download page and the navigation bars to say 4.5 release with the date. ## Update Intellij plug-in diff --git a/How-to-build-ANTLR-itself.md b/How-to-build-ANTLR-itself.md index 5612594..255453e 100644 --- a/How-to-build-ANTLR-itself.md +++ b/How-to-build-ANTLR-itself.md @@ -314,10 +314,10 @@ Adding unit test for the runtime requires the following steps: ``` grammar ; myset: ('b'|'c') ; -a: 'a' myset 'd' {} ; +a: 'a' myset 'd' {} ; ``` 1. Now, notify the generator of this test. Alter file [tool/test/org/antlr/v4/test/rt/gen/Generator.java](https://github.com/antlr/antlr4/blob/master/tool%2Ftest%2Forg%2Fantlr%2Fv4%2Ftest%2Frt%2Fgen%2FGenerator.java) to add a statement to the appropriate `buildXXX` methods. For example, see the changes to Generator.java in commit [antlr/antlr4/353235c](https://github.com/antlr/antlr4/commit/353235ccf412477b3bd4c728aef1b45203655163). If you add it to directory `ParserErrors`, make sure to add the appropriate statement with input and output pairs etc... to `buildParserErrors()`. -1. Regenerate all of the unit tests, including the new one. +1. Regenerate all of the unit tests **for ALL targets**, including the new one. ```bash cd /tmp/antlr4 # jump to root dir of antlr ./bild.py regen_tests @@ -341,10 +341,6 @@ writeln(s) ::= <);>> ``` -## Adding a target X unit test - -That works great for the Java target but it does not affect any of the other targets. - # Editing the ANTLR github wiki If you are a kind soul and would like to fix some of the documentation associated with building and managing handler, such as this page, you can fork antlr/antlr4 at github and then clone from *YOUR_ID*: