jasder
/
runc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

trailing punctuation in header 

Signed-off-by: yupeng <yu.peng36@zte.com.cn>
This commit is contained in:
yupeng 2016-11-30 16:16:58 +08:00
parent 4c013a1524
commit 602c85fdc6
2 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
MAINTAINERS_GUIDE.md
View File

@ -7,7 +7,7 @@ features to the project. But most of your time will be spent reviewing,
cleaning up, documenting, answering questions, justifying design cleaning up, documenting, answering questions, justifying design
decisions - while everyone has all the fun! But remember - the quality decisions - while everyone has all the fun! But remember - the quality
of the maintainers work is what distinguishes the good projects from the of the maintainers work is what distinguishes the good projects from the
great. So please be proud of your work, even the unglamourous parts, great. So please be proud of your work, even the unglamorous parts,
and encourage a culture of appreciation and respect for *every* aspect and encourage a culture of appreciation and respect for *every* aspect
of improving the project - not just the hot new features. of improving the project - not just the hot new features.
@ -53,7 +53,7 @@ All decisions affecting runc, big and small, follow the same 3 steps:
* Step 3: Accept (`LGTM`) or refuse a pull request. The relevant maintainers do * Step 3: Accept (`LGTM`) or refuse a pull request. The relevant maintainers do
this (see below "Who decides what?") this (see below "Who decides what?")
### I'm a maintainer, should I make pull requests too? *I'm a maintainer, should I make pull requests too?*
Yes. Nobody should ever push to master directly. All changes should be Yes. Nobody should ever push to master directly. All changes should be
made through a pull request. made through a pull request.
@ -62,26 +62,26 @@ made through a pull request.
All decisions are pull requests, and the relevant maintainers make All decisions are pull requests, and the relevant maintainers make
decisions by accepting or refusing the pull request. Review and acceptance decisions by accepting or refusing the pull request. Review and acceptance
by anyone is denoted by adding a comment in the pull request: `LGTM`. by anyone is denoted by adding a comment in the pull request: `LGTM`.
However, only currently listed `MAINTAINERS` are counted towards the required However, only currently listed `MAINTAINERS` are counted towards the required
two LGTMs. two LGTMs.
Overall the maintainer system works because of mutual respect across the Overall the maintainer system works because of mutual respect across the
maintainers of the project. The maintainers trust one another to make decisions maintainers of the project. The maintainers trust one another to make decisions
in the best interests of the project. Sometimes maintainers can disagree and in the best interests of the project. Sometimes maintainers can disagree and
this is part of a healthy project to represent the point of views of various people. this is part of a healthy project to represent the point of views of various people.
In the case where maintainers cannot find agreement on a specific change the In the case where maintainers cannot find agreement on a specific change the
role of a Chief Maintainer comes into play. role of a Chief Maintainer comes into play.
The Chief Maintainer for the project is responsible for overall architecture The Chief Maintainer for the project is responsible for overall architecture
of the project to maintain conceptual integrity. Large decisions and of the project to maintain conceptual integrity. Large decisions and
architecture changes should be reviewed by the chief maintainer. architecture changes should be reviewed by the chief maintainer.
The current chief maintainer for the project is Michael Crosby (@crosbymichael). The current chief maintainer for the project is Michael Crosby (@crosbymichael).
Even though the maintainer system is built on trust, if there is a conflict Even though the maintainer system is built on trust, if there is a conflict
with the chief maintainer on a decision, their decision can be challenged with the chief maintainer on a decision, their decision can be challenged
and brought to the technical oversight board if two-thirds of the and brought to the technical oversight board if two-thirds of the
maintainers vote for an appeal. It is expected that this would be a maintainers vote for an appeal. It is expected that this would be a
very exceptional event. very exceptional event.
@ -89,15 +89,15 @@ very exceptional event.
The best maintainers have a vested interest in the project. Maintainers The best maintainers have a vested interest in the project. Maintainers
are first and foremost contributors that have shown they are committed to are first and foremost contributors that have shown they are committed to
the long term success of the project. Contributors wanting to become the long term success of the project. Contributors wanting to become
maintainers are expected to be deeply involved in contributing code, maintainers are expected to be deeply involved in contributing code,
pull request review, and triage of issues in the project for more than two months. pull request review, and triage of issues in the project for more than two months.
Just contributing does not make you a maintainer, it is about building trust Just contributing does not make you a maintainer, it is about building trust
with the current maintainers of the project and being a person that they can with the current maintainers of the project and being a person that they can
depend on and trust to make decisions in the best interest of the project. The depend on and trust to make decisions in the best interest of the project. The
final vote to add a new maintainer should be approved by over 66% of the current final vote to add a new maintainer should be approved by over 66% of the current
maintainers with the chief maintainer having veto power. In case of a veto, maintainers with the chief maintainer having veto power. In case of a veto,
conflict resolution rules expressed above apply. The voting period is conflict resolution rules expressed above apply. The voting period is
five business days on the Pull Request to add the new maintainer. five business days on the Pull Request to add the new maintainer.

2
libcontainer/SPEC.md
View File

@ -306,7 +306,7 @@ a container.
| Exec | Execute a new process inside of the container ( requires setns ) | | Exec | Execute a new process inside of the container ( requires setns ) |
| Set | Setup configs of the container after it's created | | Set | Setup configs of the container after it's created |
### Execute a new process inside of a running container. ### Execute a new process inside of a running container
User can execute a new process inside of a running container. Any binaries to be User can execute a new process inside of a running container. Any binaries to be
executed must be accessible within the container's rootfs. executed must be accessible within the container's rootfs.