cleancode: clean code for utils_linux.go

Signed-off-by: Jeff Zvier <zvier20@gmail.com>
This commit is contained in:
zvier 2020-07-20 22:37:36 +08:00 committed by Jeff Zvier
parent f8749ba098
commit 92e2175de1
1 changed files with 7 additions and 10 deletions

View File

@ -47,14 +47,13 @@ func loadFactory(context *cli.Context) (libcontainer.Factory, error) {
cgroupManager = libcontainer.RootlessCgroupfs cgroupManager = libcontainer.RootlessCgroupfs
} }
if context.GlobalBool("systemd-cgroup") { if context.GlobalBool("systemd-cgroup") {
if systemd.IsRunningSystemd() { if !systemd.IsRunningSystemd() {
return nil, errors.New("systemd cgroup flag passed, but systemd support for managing cgroups is not available")
}
cgroupManager = libcontainer.SystemdCgroups cgroupManager = libcontainer.SystemdCgroups
if rootlessCg { if rootlessCg {
cgroupManager = libcontainer.RootlessSystemdCgroups cgroupManager = libcontainer.RootlessSystemdCgroups
} }
} else {
return nil, errors.New("systemd cgroup flag passed, but systemd support for managing cgroups is not available")
}
} }
intelRdtManager := libcontainer.IntelRdtFs intelRdtManager := libcontainer.IntelRdtFs
@ -423,13 +422,11 @@ func startContainer(context *cli.Context, spec *specs.Spec, action CtAct, criuOp
} }
if notifySocket != nil { if notifySocket != nil {
err := notifySocket.setupSocketDirectory() if err := notifySocket.setupSocketDirectory(); err != nil {
if err != nil {
return -1, err return -1, err
} }
if action == CT_ACT_RUN { if action == CT_ACT_RUN {
err := notifySocket.bindSocket() if err := notifySocket.bindSocket(); err != nil {
if err != nil {
return -1, err return -1, err
} }
} }