Add test for ipc private and shared path

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

integration/exec_test.go

@@ -38,6 +38,38 @@ func TestExecPS(t *testing.T) {
 	}
 }
 
+func TestIPCPrivate(t *testing.T) {
+	if testing.Short() {
+		return
+	}
+
+	rootfs, err := newRootFs()
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer remove(rootfs)
+
+	l, err := os.Readlink("/proc/1/ns/ipc")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	config := newTemplateConfig(rootfs)
+	config.Namespaces["NEWIPC"] = true
+	buffers, exitCode, err := runContainer(config, "", "readlink", "/proc/self/ns/ipc")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if exitCode != 0 {
+		t.Fatalf("exit code not 0. code %d stderr %q", exitCode, buffers.Stderr)
+	}
+
+	if actual := strings.Trim(buffers.Stdout.String(), "\n"); actual == l {
+		t.Fatalf("ipc link should be private to the conatiner but equals host %q %q", actual, l)
+	}
+}
+
 func TestIPCHost(t *testing.T) {
 	if testing.Short() {
 		return
@@ -69,3 +101,58 @@ func TestIPCHost(t *testing.T) {
 		t.Fatalf("ipc link not equal to host link %q %q", actual, l)
 	}
 }
+
+func TestIPCJoinPath(t *testing.T) {
+	if testing.Short() {
+		return
+	}
+
+	rootfs, err := newRootFs()
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer remove(rootfs)
+
+	l, err := os.Readlink("/proc/1/ns/ipc")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	config := newTemplateConfig(rootfs)
+	config.Namespaces["NEWIPC"] = false
+	config.IpcNsPath = "/proc/1/ns/ipc"
+
+	buffers, exitCode, err := runContainer(config, "", "readlink", "/proc/self/ns/ipc")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if exitCode != 0 {
+		t.Fatalf("exit code not 0. code %d stderr %q", exitCode, buffers.Stderr)
+	}
+
+	if actual := strings.Trim(buffers.Stdout.String(), "\n"); actual != l {
+		t.Fatalf("ipc link not equal to host link %q %q", actual, l)
+	}
+}
+
+func TestIPCBadPath(t *testing.T) {
+	if testing.Short() {
+		return
+	}
+
+	rootfs, err := newRootFs()
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer remove(rootfs)
+
+	config := newTemplateConfig(rootfs)
+	config.Namespaces["NEWIPC"] = false
+	config.IpcNsPath = "/proc/1/ns/ipcc"
+
+	_, _, err = runContainer(config, "", "true")
+	if err == nil {
+		t.Fatal("container succeded with bad ipc path")
+	}
+}

ipc/ipc.go

@@ -11,7 +11,6 @@ import (
 // Join the IPC Namespace of specified ipc path if it exists.
 // If the path does not exist then you are not joining a container.
 func Initialize(nsPath string) error {
-
 	if nsPath == "" {
 		return nil
 	}
@@ -26,6 +25,5 @@ func Initialize(nsPath string) error {
 	if err != nil {
 		return fmt.Errorf("failed to setns current IPC namespace: %v", err)
 	}
-
 	return nil
 }