Initial hacker documentation
This was such a good resource in Docker that it would be a shame to lose it. Unfortunately, we can't just link to the corresponding information in the Docker project as a number of aspects are bound to be different here. Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
This commit is contained in:
Glyn Normington
parent
588a4d31ab
commit
b49464f6c6
|
|
@ -0,0 +1,203 @@
|
||||||
|
# Contributing to libcontainer
|
||||||
|
|
||||||
|
Want to hack on libcontainer? Awesome! Here are instructions to get you
|
||||||
|
started. They are probably not perfect, please let us know if anything
|
||||||
|
feels wrong or incomplete.
|
||||||
|
|
||||||
|
## Reporting Issues
|
||||||
|
|
||||||
|
When reporting [issues](https://github.com/dotcloud/libcontainer/issues)
|
||||||
|
on GitHub please include your host OS (Ubuntu 12.04, Fedora 19, etc),
|
||||||
|
the output of `uname -a`. Please include the steps required to reproduce
|
||||||
|
the problem if possible and applicable.
|
||||||
|
This information will help us review and fix your issue faster.
|
||||||
|
|
||||||
|
## Build Environment
|
||||||
|
|
||||||
|
For instructions on setting up your development environment, please
|
||||||
|
see our dedicated [dev environment setup
|
||||||
|
docs](to be written).
|
||||||
|
|
||||||
|
## Contribution guidelines
|
||||||
|
|
||||||
|
### Pull requests are always welcome
|
||||||
|
|
||||||
|
We are always thrilled to receive pull requests, and do our best to
|
||||||
|
process them as fast as possible. Not sure if that typo is worth a pull
|
||||||
|
request? Do it! We will appreciate it.
|
||||||
|
|
||||||
|
If your pull request is not accepted on the first try, don't be
|
||||||
|
discouraged! If there's a problem with the implementation, hopefully you
|
||||||
|
received feedback on what to improve.
|
||||||
|
|
||||||
|
We're trying very hard to keep libcontainer lean and focused. We don't want it
|
||||||
|
to do everything for everybody. This means that we might decide against
|
||||||
|
incorporating a new feature. However, there might be a way to implement
|
||||||
|
that feature *on top of* libcontainer.
|
||||||
|
|
||||||
|
### Discuss your design on the mailing list
|
||||||
|
|
||||||
|
We recommend discussing your plans [on the mailing
|
||||||
|
list](https://groups.google.com/forum/?fromgroups#!forum/docker-dev)
|
||||||
|
before starting to code - especially for more ambitious contributions.
|
||||||
|
This gives other contributors a chance to point you in the right
|
||||||
|
direction, give feedback on your design, and maybe point out if someone
|
||||||
|
else is working on the same thing.
|
||||||
|
|
||||||
|
### Create issues...
|
||||||
|
|
||||||
|
Any significant improvement should be documented as [a GitHub
|
||||||
|
issue](https://github.com/dotcloud/libcontainer/issues) before anybody
|
||||||
|
starts working on it.
|
||||||
|
|
||||||
|
### ...but check for existing issues first!
|
||||||
|
|
||||||
|
Please take a moment to check that an issue doesn't already exist
|
||||||
|
documenting your bug report or improvement proposal. If it does, it
|
||||||
|
never hurts to add a quick "+1" or "I have this problem too". This will
|
||||||
|
help prioritize the most common problems and requests.
|
||||||
|
|
||||||
|
### Conventions
|
||||||
|
|
||||||
|
Fork the repo and make changes on your fork in a feature branch:
|
||||||
|
|
||||||
|
- If it's a bugfix branch, name it XXX-something where XXX is the number of the
|
||||||
|
issue
|
||||||
|
- If it's a feature branch, create an enhancement issue to announce your
|
||||||
|
intentions, and name it XXX-something where XXX is the number of the issue.
|
||||||
|
|
||||||
|
Submit unit tests for your changes. Go has a great test framework built in; use
|
||||||
|
it! Take a look at existing tests for inspiration. Run the full test suite on
|
||||||
|
your branch before submitting a pull request.
|
||||||
|
|
||||||
|
Update the documentation when creating or modifying features. Test
|
||||||
|
your documentation changes for clarity, concision, and correctness, as
|
||||||
|
well as a clean documentation build. See ``docs/README.md`` for more
|
||||||
|
information on building the docs and how docs get released.
|
||||||
|
|
||||||
|
Write clean code. Universally formatted code promotes ease of writing, reading,
|
||||||
|
and maintenance. Always run `gofmt -s -w file.go` on each changed file before
|
||||||
|
committing your changes. Most editors have plugins that do this automatically.
|
||||||
|
|
||||||
|
Pull requests descriptions should be as clear as possible and include a
|
||||||
|
reference to all the issues that they address.
|
||||||
|
|
||||||
|
Pull requests must not contain commits from other users or branches.
|
||||||
|
|
||||||
|
Commit messages must start with a capitalized and short summary (max. 50
|
||||||
|
chars) written in the imperative, followed by an optional, more detailed
|
||||||
|
explanatory text which is separated from the summary by an empty line.
|
||||||
|
|
||||||
|
Code review comments may be added to your pull request. Discuss, then make the
|
||||||
|
suggested modifications and push additional commits to your feature branch. Be
|
||||||
|
sure to post a comment after pushing. The new commits will show up in the pull
|
||||||
|
request automatically, but the reviewers will not be notified unless you
|
||||||
|
comment.
|
||||||
|
|
||||||
|
Before the pull request is merged, make sure that you squash your commits into
|
||||||
|
logical units of work using `git rebase -i` and `git push -f`. After every
|
||||||
|
commit the test suite should be passing. Include documentation changes in the
|
||||||
|
same commit so that a revert would remove all traces of the feature or fix.
|
||||||
|
|
||||||
|
Commits that fix or close an issue should include a reference like `Closes #XXX`
|
||||||
|
or `Fixes #XXX`, which will automatically close the issue when merged.
|
||||||
|
|
||||||
|
Please do not add yourself to the AUTHORS file, as it is regenerated
|
||||||
|
regularly from the Git history.
|
||||||
|
|
||||||
|
### Merge approval
|
||||||
|
|
||||||
|
libcontainer maintainers use LGTM (looks good to me) in comments on the code review
|
||||||
|
to indicate acceptance.
|
||||||
|
|
||||||
|
A change requires LGTMs from an absolute majority of the maintainers of each
|
||||||
|
component affected. For example, if a change affects docs/ and registry/, it
|
||||||
|
needs an absolute majority from the maintainers of docs/ AND, separately, an
|
||||||
|
absolute majority of the maintainers of registry.
|
||||||
|
|
||||||
|
For more details see [MAINTAINERS.md](hack/MAINTAINERS.md)
|
||||||
|
|
||||||
|
### Sign your work
|
||||||
|
|
||||||
|
The sign-off is a simple line at the end of the explanation for the
|
||||||
|
patch, which certifies that you wrote it or otherwise have the right to
|
||||||
|
pass it on as an open-source patch. The rules are pretty simple: if you
|
||||||
|
can certify the below (from
|
||||||
|
[developercertificate.org](http://developercertificate.org/)):
|
||||||
|
|
||||||
|
```
|
||||||
|
Developer Certificate of Origin
|
||||||
|
Version 1.1
|
||||||
|
|
||||||
|
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
|
||||||
|
660 York Street, Suite 102,
|
||||||
|
San Francisco, CA 94110 USA
|
||||||
|
|
||||||
|
Everyone is permitted to copy and distribute verbatim copies of this
|
||||||
|
license document, but changing it is not allowed.
|
||||||
|
|
||||||
|
|
||||||
|
Developer's Certificate of Origin 1.1
|
||||||
|
|
||||||
|
By making a contribution to this project, I certify that:
|
||||||
|
|
||||||
|
(a) The contribution was created in whole or in part by me and I
|
||||||
|
have the right to submit it under the open source license
|
||||||
|
indicated in the file; or
|
||||||
|
|
||||||
|
(b) The contribution is based upon previous work that, to the best
|
||||||
|
of my knowledge, is covered under an appropriate open source
|
||||||
|
license and I have the right under that license to submit that
|
||||||
|
work with modifications, whether created in whole or in part
|
||||||
|
by me, under the same open source license (unless I am
|
||||||
|
permitted to submit under a different license), as indicated
|
||||||
|
in the file; or
|
||||||
|
|
||||||
|
(c) The contribution was provided directly to me by some other
|
||||||
|
person who certified (a), (b) or (c) and I have not modified
|
||||||
|
it.
|
||||||
|
|
||||||
|
(d) I understand and agree that this project and the contribution
|
||||||
|
are public and that a record of the contribution (including all
|
||||||
|
personal information I submit with it, including my sign-off) is
|
||||||
|
maintained indefinitely and may be redistributed consistent with
|
||||||
|
this project or the open source license(s) involved.
|
||||||
|
```
|
||||||
|
|
||||||
|
then you just add a line to every git commit message:
|
||||||
|
|
||||||
|
Docker-DCO-1.1-Signed-off-by: Joe Smith <joe.smith@email.com> (github: github_handle)
|
||||||
|
|
||||||
|
using your real name (sorry, no pseudonyms or anonymous contributions.)
|
||||||
|
|
||||||
|
One way to automate this, is customise your get ``commit.template`` by adding
|
||||||
|
a ``prepare-commit-msg`` hook to your libcontainer checkout:
|
||||||
|
|
||||||
|
```
|
||||||
|
curl -o .git/hooks/prepare-commit-msg https://raw.githubusercontent.com/dotcloud/docker/master/contrib/prepare-commit-msg.hook && chmod +x .git/hooks/prepare-commit-msg
|
||||||
|
```
|
||||||
|
|
||||||
|
* Note: the above script expects to find your GitHub user name in ``git config --get github.user``
|
||||||
|
|
||||||
|
#### Small patch exception
|
||||||
|
|
||||||
|
There are several exceptions to the signing requirement. Currently these are:
|
||||||
|
|
||||||
|
* Your patch fixes spelling or grammar errors.
|
||||||
|
* Your patch is a single line change to documentation contained in the
|
||||||
|
`docs` directory.
|
||||||
|
* Your patch fixes Markdown formatting or syntax errors in the
|
||||||
|
documentation contained in the `docs` directory.
|
||||||
|
|
||||||
|
If you have any questions, please refer to the FAQ in the [docs](to be written)
|
||||||
|
|
||||||
|
### How can I become a maintainer?
|
||||||
|
|
||||||
|
* Step 1: learn the component inside out
|
||||||
|
* Step 2: make yourself useful by contributing code, bugfixes, support etc.
|
||||||
|
* Step 3: volunteer on the irc channel (#docker@freenode)
|
||||||
|
* Step 4: propose yourself at a scheduled docker meeting in #docker-dev
|
||||||
|
|
||||||
|
Don't forget: being a maintainer is a time investment. Make sure you will have time to make yourself available.
|
||||||
|
You don't have to be a maintainer to make a difference on the project!
|
||||||
|
|
||||||
|
|
@ -0,0 +1,104 @@
|
||||||
|
# The libcontainer Maintainer manual
|
||||||
|
|
||||||
|
## Introduction
|
||||||
|
|
||||||
|
Dear maintainer. Thank you for investing the time and energy to help
|
||||||
|
make libcontainer as useful as possible. Maintaining a project is difficult,
|
||||||
|
sometimes unrewarding work. Sure, you will get to contribute cool
|
||||||
|
features to the project. But most of your time will be spent reviewing,
|
||||||
|
cleaning up, documenting, answering questions, justifying design
|
||||||
|
decisions - while everyone has all the fun! But remember - the quality
|
||||||
|
of the maintainers work is what distinguishes the good projects from the
|
||||||
|
great. So please be proud of your work, even the unglamourous parts,
|
||||||
|
and encourage a culture of appreciation and respect for *every* aspect
|
||||||
|
of improving the project - not just the hot new features.
|
||||||
|
|
||||||
|
This document is a manual for maintainers old and new. It explains what
|
||||||
|
is expected of maintainers, how they should work, and what tools are
|
||||||
|
available to them.
|
||||||
|
|
||||||
|
This is a living document - if you see something out of date or missing,
|
||||||
|
speak up!
|
||||||
|
|
||||||
|
## What are a maintainer's responsibility?
|
||||||
|
|
||||||
|
It is every maintainer's responsibility to:
|
||||||
|
|
||||||
|
* 1) Expose a clear roadmap for improving their component.
|
||||||
|
* 2) Deliver prompt feedback and decisions on pull requests.
|
||||||
|
* 3) Be available to anyone with questions, bug reports, criticism etc.
|
||||||
|
on their component. This includes IRC, GitHub requests and the mailing
|
||||||
|
list.
|
||||||
|
* 4) Make sure their component respects the philosophy, design and
|
||||||
|
roadmap of the project.
|
||||||
|
|
||||||
|
## How are decisions made?
|
||||||
|
|
||||||
|
Short answer: with pull requests to the libcontainer repository.
|
||||||
|
|
||||||
|
libcontainer is an open-source project with an open design philosophy. This
|
||||||
|
means that the repository is the source of truth for EVERY aspect of the
|
||||||
|
project, including its philosophy, design, roadmap and APIs. *If it's
|
||||||
|
part of the project, it's in the repo. It's in the repo, it's part of
|
||||||
|
the project.*
|
||||||
|
|
||||||
|
As a result, all decisions can be expressed as changes to the
|
||||||
|
repository. An implementation change is a change to the source code. An
|
||||||
|
API change is a change to the API specification. A philosophy change is
|
||||||
|
a change to the philosophy manifesto. And so on.
|
||||||
|
|
||||||
|
All decisions affecting libcontainer, big and small, follow the same 3 steps:
|
||||||
|
|
||||||
|
* Step 1: Open a pull request. Anyone can do this.
|
||||||
|
|
||||||
|
* Step 2: Discuss the pull request. Anyone can do this.
|
||||||
|
|
||||||
|
* Step 3: Accept (`LGTM`) or refuse a pull request. The relevant maintainers do
|
||||||
|
this (see below "Who decides what?")
|
||||||
|
|
||||||
|
|
||||||
|
## Who decides what?
|
||||||
|
|
||||||
|
All decisions are pull requests, and the relevant maintainers make
|
||||||
|
decisions by accepting or refusing the pull request. Review and acceptance
|
||||||
|
by anyone is denoted by adding a comment in the pull request: `LGTM`.
|
||||||
|
However, only currently listed `MAINTAINERS` are counted towards the required
|
||||||
|
majority.
|
||||||
|
|
||||||
|
libcontainer follows the timeless, highly efficient and totally unfair system
|
||||||
|
known as [Benevolent dictator for
|
||||||
|
life](http://en.wikipedia.org/wiki/Benevolent_Dictator_for_Life), with
|
||||||
|
yours truly, Michael Crosby, in the role of BDFL. This means that all
|
||||||
|
decisions are made by default by Michael. Since making every decision
|
||||||
|
myself would be highly un-scalable, in practice decisions are spread
|
||||||
|
across multiple maintainers.
|
||||||
|
|
||||||
|
The relevant maintainers for a pull request can be worked out in 2 steps:
|
||||||
|
|
||||||
|
* Step 1: Determine the subdirectories affected by the pull request. This
|
||||||
|
might be `src/registry`, `docs/source/api`, or any other part of the repo.
|
||||||
|
|
||||||
|
* Step 2: Find the `MAINTAINERS` file which affects this directory. If the
|
||||||
|
directory itself does not have a `MAINTAINERS` file, work your way up
|
||||||
|
the repo hierarchy until you find one.
|
||||||
|
|
||||||
|
There is also a `hacks/getmaintainers.sh` script that will print out the
|
||||||
|
maintainers for a specified directory.
|
||||||
|
|
||||||
|
### I'm a maintainer, and I'm going on holiday
|
||||||
|
|
||||||
|
Please let your co-maintainers and other contributors know by raising a pull
|
||||||
|
request that comments out your `MAINTAINERS` file entry using a `#`.
|
||||||
|
|
||||||
|
### I'm a maintainer, should I make pull requests too?
|
||||||
|
|
||||||
|
Yes. Nobody should ever push to master directly. All changes should be
|
||||||
|
made through a pull request.
|
||||||
|
|
||||||
|
### Who assigns maintainers?
|
||||||
|
|
||||||
|
Michael has final `LGTM` approval for all pull requests to `MAINTAINERS` files.
|
||||||
|
|
||||||
|
### How is this process changed?
|
||||||
|
|
||||||
|
Just like everything else: by making a pull request :)
|
||||||
|
|
@ -0,0 +1,19 @@
|
||||||
|
# libcontainer principles
|
||||||
|
|
||||||
|
In the design and development of libcontainer we try to follow these principles:
|
||||||
|
|
||||||
|
(Work in progress)
|
||||||
|
|
||||||
|
* Don't try to replace every tool. Instead, be an ingredient to improve them.
|
||||||
|
* Less code is better.
|
||||||
|
* Less components is better. Do you really need to add one more class?
|
||||||
|
* 50 lines of straightforward, readable code is better than 10 lines of magic that nobody can understand.
|
||||||
|
* Don't do later what you can do now. "//FIXME: refactor" is not acceptable in new code.
|
||||||
|
* When hesitating between 2 options, choose the one that is easier to reverse.
|
||||||
|
* No is temporary, Yes is forever. If you're not sure about a new feature, say no. You can change your mind later.
|
||||||
|
* Containers must be portable to the greatest possible number of machines. Be suspicious of any change which makes machines less interchangeable.
|
||||||
|
* The less moving parts in a container, the better.
|
||||||
|
* Don't merge it unless you document it.
|
||||||
|
* Don't document it unless you can keep it up-to-date.
|
||||||
|
* Don't merge it unless you test it!
|
||||||
|
* Everyone's problem is slightly different. Focus on the part that is the same for everyone, and solve that.
|
||||||
|
|
@ -0,0 +1,22 @@
|
||||||
|
# Hacking on libcontainer
|
||||||
|
|
||||||
|
The hack/ directory holds information and tools for everyone involved in the process of creating and
|
||||||
|
distributing libcontainer, specifically:
|
||||||
|
|
||||||
|
## Guides
|
||||||
|
|
||||||
|
If you're a *contributor* or aspiring contributor, you should read CONTRIBUTORS.md.
|
||||||
|
|
||||||
|
If you're a *maintainer* or aspiring maintainer, you should read MAINTAINERS.md.
|
||||||
|
|
||||||
|
## Roadmap
|
||||||
|
|
||||||
|
A high-level roadmap is available at ROADMAP.md.
|
||||||
|
|
||||||
|
## Build tools
|
||||||
|
|
||||||
|
TBD
|
||||||
|
|
||||||
|
## Credits
|
||||||
|
|
||||||
|
The initial documentation in the hack/ directory came from the Docker repository, where libcontainer grew up.
|
||||||
|
|
@ -0,0 +1,18 @@
|
||||||
|
# libcontainer: what's next?
|
||||||
|
|
||||||
|
This document is a high-level overview of where we want to take libcontainer next.
|
||||||
|
It is a curated selection of planned improvements which are either important, difficult, or both.
|
||||||
|
|
||||||
|
For a more complete view of planned and requested improvements, see [the Github issues](https://github.com/dotcloud/docker/issues).
|
||||||
|
|
||||||
|
To suggest changes to the roadmap, including additions, please write the change as if it were already in effect, and make a pull request.
|
||||||
|
|
||||||
|
## Broader kernel support
|
||||||
|
|
||||||
|
Our goal is to make libcontainer run everywhere, but currently libcontainer requires Linux version 3.8 or higher with lxc and aufs support. If you’re deploying new machines for the purpose of running libcontainer, this is a fairly easy requirement to meet. However, if you’re adding libcontainer to an existing deployment, you may not have the flexibility to update and patch the kernel.
|
||||||
|
|
||||||
|
Expanding libcontainer’s kernel support is a priority. This includes running on older kernel versions, but also on kernels with no AUFS support, or with incomplete lxc capabilities.
|
||||||
|
|
||||||
|
## Cross-architecture support
|
||||||
|
|
||||||
|
Our goal is to make libcontainer run everywhere. However currently libcontainer only runs on x86_64 systems. We plan on expanding architecture support, so that libcontainer containers can be created and used on more architectures.
|
||||||
Loading…
Reference in New Issue