From d4ede0d364554eb8939415237f82cb2c6c6f4f3f Mon Sep 17 00:00:00 2001 From: Vincent Batts Date: Mon, 29 Aug 2016 09:40:20 -0400 Subject: [PATCH] ci-tools: versions of golang Add and update golang versions. Also fix install.tools target for installing govet Signed-off-by: Vincent Batts --- .travis.yml | 5 +++-- Makefile | 14 +++----------- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/.travis.yml b/.travis.yml index 707efcfd..9780433d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,8 @@ language: go go: - - 1.6 - - 1.5.3 + - 1.7 + - 1.6.3 + - 1.5.4 sudo: required diff --git a/Makefile b/Makefile index 7dd069df..966a6c2b 100644 --- a/Makefile +++ b/Makefile @@ -68,9 +68,7 @@ ALLOWED_GO_VERSION = $(shell test '$(shell /bin/echo -e "$(1)\n$(2)" | sort -V | test: .govet .golint .gitvalidation -# `go get golang.org/x/tools/cmd/vet` .govet: - @go tool | grep -qw vet || (echo "ERROR: 'go vet' not found. Consider 'make install.tools' target" && false) go vet -x ./... # `go get github.com/golang/lint/golint` @@ -92,22 +90,16 @@ endif .PHONY: install.tools -install.tools: .install.golint .install.govet .install.gitvalidation +install.tools: .install.golint .install.gitvalidation # golint does not even build for =go1.5, so no need to get it. -.install.govet: -ifeq ($(call ALLOWED_GO_VERSION,1.5,$(HOST_GOLANG_VERSION)),true) - go get golang.org/x/tools/cmd/vet + go get -u github.com/golang/lint/golint endif .install.gitvalidation: - go get github.com/vbatts/git-validation + go get -u github.com/vbatts/git-validation .PHONY: clean