`WeightDevice`, `ThrottleReadBpsDevice`, `ThrottleWriteBpsDevice`,
`ThrottleReadIOpsDevice`, `ThrottleWriteIOpsDevice` are now slices to
well defined structs to allow setting multiple devices in their respective
blkio file. By using a string to represents those values it wasn't possible
to set correct values when multiple devices were passed in the config
(either newline separated or comma separated).
Signed-off-by: Antonio Murdaca <runcom@linux.com>
Kunal mentioned this tool in this thread [1]. There's some discussion
with David Liang of OCT in that thread where Kunal and David seem to
be trying to find common ground and avoid duplicating effort, but both
projects seem to be moving along on their own now. I think we should
link to both, and we can always remove a link later if/when the two
projects get together to provide a common validator framework.
Entries in this list (the first in implementations.md with two entries
in a category) are alphabetical by whatever the first text is in the
enter.
[1]: https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/B2qQ9itIsgI
Message-Id: <b8554ca7-bc0a-480c-9603-8c4ab3f4fdd6@opencontainers.org>
Signed-off-by: W. Trevor King <wking@tremily.us>
Mrunal mentioned this during today's meeting, and linking to it will
hopefully reduce the amount of duplicated effort in this area.
Signed-off-by: W. Trevor King <wking@tremily.us>
config_linux.go already has the "_linux" for the go build,
so the build tag in the file is redundant.
Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
If we don't specify this, some bundle-authors or runtime-implementers
might expect the runtime to intelligently order mounts to get the
"right" order [1]. But that's not possible because:
$ mkdir -p a/b/c d/e/f h
# mount --bind a/b h
# mount --bind d a/b
$ tree --charset=ascii h
h
`-- c
But in the other order:
# umount a/b
# umount h
# mount --bind d a/b
# mount --bind a/b h
$ tree --charset=ascii h
h
`-- e
`-- f
So there's no "right" order. Allowing the bundle-author to specify
their intended order is both easy to implement and unambiguous.
[1]: https://github.com/opencontainers/specs/pull/136#issuecomment-137275876
Suggested-by: Lai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: W. Trevor King <wking@tremily.us>
Accomplishing the same access to the commit entry, with more readable
code.
Reported-by: Lai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Initially only a DCO validation for travis, but is set up for further
validation on commits as well.
https://github.com/opencontainers/specs/issues/90
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
c18c283 (Change layout of mountpoints and mounts, 2015-09-02, #136)
removed the destination field from the Go type and examples, but
forgot to remove it from the documentation [1]. Fix that with this
commit.
[1]: https://github.com/opencontainers/specs/issues/109#issuecomment-138531616
Reported-by: 梁辰晔 (Liang Chenye) <liangchenye@huawei.com>
Signed-off-by: W. Trevor King <wking@tremily.us>
There are two RootfsPropagation fields, one is Linux.RootfsPropagation,
the other one is LinuxRuntime.RootfsPropagation. They are duplicated,
one of them should be removed.
The RootfsPropagation is definitely a runtime specific configuration,
so we remove the one of Linux.RootfsPropagation.
And the description of it is moved from config-linux.md to
runtime-config-linux.md.
Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
Antonio Murdaca
Mrunal Patel
Gao feng
W. Trevor King
Lai Jiangshan
Vincent Batts
Jonathan Boulle
Michael Crosby
Vishnu Kannan
梁辰晔 (Liang Chenye)
Mrunal Patel
Brandon Philips