handle access errors when writing cache files silently as pytest warning, fixes #1039
This commit is contained in:
parent
bf9b94595c
commit
29f4da93d4
|
@ -69,10 +69,22 @@ class Cache(object):
|
||||||
like e. g. lists of dictionaries.
|
like e. g. lists of dictionaries.
|
||||||
"""
|
"""
|
||||||
path = self._getvaluepath(key)
|
path = self._getvaluepath(key)
|
||||||
path.dirpath().ensure_dir()
|
try:
|
||||||
with path.open("w") as f:
|
path.dirpath().ensure_dir()
|
||||||
self.trace("cache-write %s: %r" % (key, value,))
|
except (py.error.EEXIST, py.error.EACCES):
|
||||||
json.dump(value, f, indent=2, sort_keys=True)
|
self.config.warn(
|
||||||
|
code='I9', message='cache could not create cache path %s' % (path,)
|
||||||
|
)
|
||||||
|
return
|
||||||
|
try:
|
||||||
|
f = path.open('w')
|
||||||
|
except py.error.ENOTDIR:
|
||||||
|
self.config.warn(
|
||||||
|
code='I9', message='cache could not write path %s' % (path,))
|
||||||
|
else:
|
||||||
|
with f:
|
||||||
|
self.trace("cache-write %s: %r" % (key, value,))
|
||||||
|
json.dump(value, f, indent=2, sort_keys=True)
|
||||||
|
|
||||||
|
|
||||||
class LFPlugin:
|
class LFPlugin:
|
||||||
|
|
|
@ -25,6 +25,21 @@ class TestNewAPI:
|
||||||
val = config.cache.get("key/name", -2)
|
val = config.cache.get("key/name", -2)
|
||||||
assert val == -2
|
assert val == -2
|
||||||
|
|
||||||
|
def test_cache_writefail_cachfile_silent(self, testdir):
|
||||||
|
testdir.makeini("[pytest]")
|
||||||
|
testdir.tmpdir.join('.cache').write('gone wrong')
|
||||||
|
config = testdir.parseconfigure()
|
||||||
|
cache = config.cache
|
||||||
|
cache.set('test/broken', [])
|
||||||
|
|
||||||
|
def test_cache_writefail_permissions(selfself, testdir):
|
||||||
|
testdir.makeini("[pytest]")
|
||||||
|
testdir.tmpdir.ensure_dir('.cache').chmod(0)
|
||||||
|
config = testdir.parseconfigure()
|
||||||
|
cache = config.cache
|
||||||
|
cache.set('test/broken', [])
|
||||||
|
|
||||||
|
|
||||||
def test_config_cache(self, testdir):
|
def test_config_cache(self, testdir):
|
||||||
testdir.makeconftest("""
|
testdir.makeconftest("""
|
||||||
def pytest_configure(config):
|
def pytest_configure(config):
|
||||||
|
|
Loading…
Reference in New Issue