jiuyuan
/
test_ok1
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

python: remove broken/ineffectual keywords marks initialization 

By my analysis, this deleted code block has no effect:

1. `self.keywords` is `update`d with `callspec.marks`.
2. `self.own_markers` is `update`d with `callspec.marks`.
3. `self.keywords` is `update`d with `self.own_markers`.

So together steps 2+3 completely undo step 1.
This commit is contained in:
Ran Benita 2021-10-06 22:59:34 +03:00
parent d9bcfa0c2b
commit 3c69bc919c
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/_pytest/python.py
View File

@ -1662,13 +1662,6 @@ class Function(PyobjMixin, nodes.Item):
self.own_markers.extend(get_unpacked_marks(self.obj)) self.own_markers.extend(get_unpacked_marks(self.obj))
if callspec: if callspec:
self.callspec = callspec self.callspec = callspec
# this is total hostile and a mess
# keywords are broken by design by now
# this will be redeemed later
for mark in callspec.marks:
# feel free to cry, this was broken for years before
# and keywords can't fix it per design
self.keywords[mark.name] = mark
self.own_markers.extend(callspec.marks) self.own_markers.extend(callspec.marks)
if keywords: if keywords:
self.keywords.update(keywords) self.keywords.update(keywords)