From de810152ec665e7a246bb3ceed2a8bfae5965e23 Mon Sep 17 00:00:00 2001
From: Ran Benita <ran@unusedvar.com>
Date: Wed, 28 Oct 2020 22:16:25 +0200
Subject: [PATCH] tox: remove checkqa-mypy environment

We run mypy through pre-commit, and we don't keep duplicate targets in
tox for all of the other linters. Since this adds some (small)
maintenance overhead, remove it.
---
 .pre-commit-config.yaml |  2 +-
 setup.cfg               |  2 --
 tox.ini                 | 13 -------------
 3 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 2d351182e..80774031c 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -49,7 +49,7 @@ repos:
     hooks:
     -   id: python-use-type-annotations
 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.790  # NOTE: keep this in sync with setup.cfg.
+    rev: v0.790
     hooks:
     -   id: mypy
         files: ^(src/|testing/)
diff --git a/setup.cfg b/setup.cfg
index 134a80b3e..08d5853f2 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -62,8 +62,6 @@ console_scripts =
     py.test=pytest:console_main
 
 [options.extras_require]
-checkqa-mypy =
-    mypy==0.790
 testing =
     argcomplete
     hypothesis>=3.56
diff --git a/tox.ini b/tox.ini
index 5a4a85e55..6c8b8b0ad 100644
--- a/tox.ini
+++ b/tox.ini
@@ -59,19 +59,6 @@ basepython = python3
 deps = pre-commit>=1.11.0
 commands = pre-commit run --all-files --show-diff-on-failure {posargs:}
 
-[testenv:mypy]
-extras = checkqa-mypy, testing
-commands = mypy {posargs:src testing}
-
-[testenv:mypy-diff]
-extras = checkqa-mypy, testing
-deps =
-    lxml
-    diff-cover
-commands =
-  -mypy --cobertura-xml-report {envtmpdir} {posargs:src testing}
-  diff-cover --fail-under=100 --compare-branch={env:DIFF_BRANCH:origin/{env:GITHUB_BASE_REF:master}} {envtmpdir}/cobertura.xml
-
 [testenv:docs]
 basepython = python3
 usedevelop = True