PR suggestions

This commit is contained in:
Tyler Smart 2023-08-19 22:20:40 -06:00
parent ebd571bb18
commit 7a625481da
1 changed files with 12 additions and 10 deletions

View File

@ -537,17 +537,19 @@ class DoctestModule(Module):
tests, obj, name, module, source_lines, globs, seen
)
def _from_module(self, module, object):
"""`cached_property` objects will are never considered a part
of the 'current module'. As such they are skipped by doctest.
Here we override `_from_module` to check the underlying
function instead. https://github.com/python/cpython/issues/107995
"""
if isinstance(object, functools.cached_property):
object = object.func
if sys.version_info < (3, 13):
# Type ignored because this is a private function.
return super()._from_module(module, object) # type: ignore[misc]
def _from_module(self, module, object):
"""`cached_property` objects are never considered a part
of the 'current module'. As such they are skipped by doctest.
Here we override `_from_module` to check the underlying
function instead. https://github.com/python/cpython/issues/107995
"""
if isinstance(object, functools.cached_property):
object = object.func
# Type ignored because this is a private function.
return super()._from_module(module, object) # type: ignore[misc]
if self.path.name == "conftest.py":
module = self.config.pluginmanager._importconftest(