From 401a3cd1bcdcb997cf68e9ebe070059648799be0 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Fri, 9 Nov 2018 01:27:11 +0100 Subject: [PATCH 1/7] minor: improve FixtureDef.__repr__ Ref: https://github.com/pytest-dev/pytest/pull/4105#pullrequestreview-163486766 --- src/_pytest/fixtures.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/_pytest/fixtures.py b/src/_pytest/fixtures.py index 73aed8371..124b611db 100644 --- a/src/_pytest/fixtures.py +++ b/src/_pytest/fixtures.py @@ -927,7 +927,7 @@ class FixtureDef(object): return hook.pytest_fixture_setup(fixturedef=self, request=request) def __repr__(self): - return "" % ( + return "" % ( self.argname, self.scope, self.baseid, From a0890f98d808b76e63d5fd5c9766367e051f5247 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Fri, 9 Nov 2018 01:31:53 +0100 Subject: [PATCH 2/7] tests: harden test_config_error --- testing/acceptance_test.py | 3 ++- testing/example_scripts/conftest_usageerror/conftest.py | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/testing/acceptance_test.py b/testing/acceptance_test.py index 8917de6b2..19d7946cf 100644 --- a/testing/acceptance_test.py +++ b/testing/acceptance_test.py @@ -27,8 +27,9 @@ class TestGeneralUsage(object): def test_config_error(self, testdir): testdir.copy_example("conftest_usageerror/conftest.py") result = testdir.runpytest(testdir.tmpdir) - assert result.ret != 0 + assert result.ret == EXIT_USAGEERROR result.stderr.fnmatch_lines(["*ERROR: hello"]) + result.stdout.fnmatch_lines(["*pytest_unconfigure_called"]) def test_root_conftest_syntax_error(self, testdir): testdir.makepyfile(conftest="raise SyntaxError\n") diff --git a/testing/example_scripts/conftest_usageerror/conftest.py b/testing/example_scripts/conftest_usageerror/conftest.py index 7d0d39d3a..8973e4252 100644 --- a/testing/example_scripts/conftest_usageerror/conftest.py +++ b/testing/example_scripts/conftest_usageerror/conftest.py @@ -2,3 +2,7 @@ def pytest_configure(config): import pytest raise pytest.UsageError("hello") + + +def pytest_unconfigure(config): + print("pytest_unconfigure_called") From 560c055b090c2cc951c687728ee84353126a53ab Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Fri, 9 Nov 2018 01:36:20 +0100 Subject: [PATCH 3/7] Session._collect: use reversed parts --- src/_pytest/main.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/_pytest/main.py b/src/_pytest/main.py index 1de5f656f..5b9a94998 100644 --- a/src/_pytest/main.py +++ b/src/_pytest/main.py @@ -495,9 +495,9 @@ class Session(nodes.FSCollector): # No point in finding packages when collecting doctests if not self.config.option.doctestmodules: pm = self.config.pluginmanager - for parent in argpath.parts(): + for parent in reversed(argpath.parts()): if pm._confcutdir and pm._confcutdir.relto(parent): - continue + break if parent.isdir(): pkginit = parent.join("__init__.py") From c1bde8e0a2de06bdcdf97687dfdc271ac2abd8eb Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Fri, 9 Nov 2018 01:37:51 +0100 Subject: [PATCH 4/7] minor: check bool before function call --- src/_pytest/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/_pytest/main.py b/src/_pytest/main.py index 5b9a94998..910812419 100644 --- a/src/_pytest/main.py +++ b/src/_pytest/main.py @@ -278,7 +278,7 @@ def pytest_ignore_collect(path, config): return True allow_in_venv = config.getoption("collect_in_virtualenv") - if _in_venv(path) and not allow_in_venv: + if not allow_in_venv and _in_venv(path): return True return False From 4a74d455dec43be8f73d670a2e850b0ed21c8f40 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Fri, 9 Nov 2018 01:44:53 +0100 Subject: [PATCH 5/7] minor: typos --- testing/logging/test_fixture.py | 2 +- testing/test_config.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/testing/logging/test_fixture.py b/testing/logging/test_fixture.py index 7a815cf12..ff772e7ec 100644 --- a/testing/logging/test_fixture.py +++ b/testing/logging/test_fixture.py @@ -136,5 +136,5 @@ def test_caplog_captures_for_all_stages(caplog, logging_during_setup_and_teardow assert [x.message for x in caplog.get_records("setup")] == ["a_setup_log"] - # This reachers into private API, don't use this type of thing in real tests! + # This reaches into private API, don't use this type of thing in real tests! assert set(caplog._item.catch_log_handlers.keys()) == {"setup", "call"} diff --git a/testing/test_config.py b/testing/test_config.py index 82466df1f..1be266387 100644 --- a/testing/test_config.py +++ b/testing/test_config.py @@ -874,7 +874,7 @@ class TestRootdir(object): assert inifile == inifile @pytest.mark.parametrize("name", "setup.cfg tox.ini".split()) - def test_pytestini_overides_empty_other(self, tmpdir, name): + def test_pytestini_overrides_empty_other(self, tmpdir, name): inifile = tmpdir.ensure("pytest.ini") a = tmpdir.mkdir("a") a.ensure(name) From 859b3227739d345bace43a309eb2d2a098bc9ce3 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Fri, 9 Nov 2018 01:51:04 +0100 Subject: [PATCH 6/7] doc: improve/simplify doc for breakpoint behavior --- doc/en/usage.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/en/usage.rst b/doc/en/usage.rst index cc118fad8..08682d614 100644 --- a/doc/en/usage.rst +++ b/doc/en/usage.rst @@ -255,8 +255,8 @@ Pytest supports the use of ``breakpoint()`` with the following behaviours: - When ``breakpoint()`` is called and ``PYTHONBREAKPOINT`` is set to the default value, pytest will use the custom internal PDB trace UI instead of the system default ``Pdb``. - When tests are complete, the system will default back to the system ``Pdb`` trace UI. - - If ``--pdb`` is called on execution of pytest, the custom internal Pdb trace UI is used on both ``breakpoint()`` and failed tests/unhandled exceptions. - - If ``--pdbcls`` is used, the custom class debugger will be executed when a test fails (as expected within existing behaviour), but also when ``breakpoint()`` is called from within a test, the custom class debugger will be instantiated. + - With ``--pdb`` passed to pytest, the custom internal Pdb trace UI is used with both ``breakpoint()`` and failed tests/unhandled exceptions. + - ``--pdbcls`` can be used to specify a custom debugger class. .. _durations: From feccf532d21f823243fb89364114ddd6a055e5b9 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Fri, 9 Nov 2018 01:54:14 +0100 Subject: [PATCH 7/7] doc: improve runpytest_subprocess --- src/_pytest/pytester.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/_pytest/pytester.py b/src/_pytest/pytester.py index ca24ff1b0..8d5a6b141 100644 --- a/src/_pytest/pytester.py +++ b/src/_pytest/pytester.py @@ -1160,11 +1160,11 @@ class Testdir(object): def runpytest_subprocess(self, *args, **kwargs): """Run pytest as a subprocess with given arguments. - Any plugins added to the :py:attr:`plugins` list will added using the - ``-p`` command line option. Additionally ``--basetemp`` is used put + Any plugins added to the :py:attr:`plugins` list will be added using the + ``-p`` command line option. Additionally ``--basetemp`` is used to put any temporary files and directories in a numbered directory prefixed - with "runpytest-" so they do not conflict with the normal numbered - pytest location for temporary files and directories. + with "runpytest-" to not conflict with the normal numbered pytest + location for temporary files and directories. :param args: the sequence of arguments to pass to the pytest subprocess :param timeout: the period in seconds after which to timeout and raise