Fix trailing whitespace in terminal output

This commit is contained in:
fbjorn 2017-03-05 22:44:13 +03:00
parent b28749eb92
commit cee578e327
5 changed files with 17 additions and 5 deletions

View File

@ -43,6 +43,7 @@ Dave Hunt
David Díaz-Barquero David Díaz-Barquero
David Mohr David Mohr
David Vierra David Vierra
Denis Kirisov
Diego Russo Diego Russo
Dmitry Dygalo Dmitry Dygalo
Duncan Betts Duncan Betts

View File

@ -28,7 +28,7 @@
* Skipping plugin now also works with test items generated by custom collectors (`#2231`_). * Skipping plugin now also works with test items generated by custom collectors (`#2231`_).
Thanks to `@vidartf`_. Thanks to `@vidartf`_.
* * Fix trailing whitespace in console output if no .ini file presented (`#2281`_). Thanks `@fbjorn`_ for the PR.
* Conditionless ``xfail`` markers no longer rely on the underlying test item * Conditionless ``xfail`` markers no longer rely on the underlying test item
being an instance of ``PyobjMixin``, and can therefore apply to tests not being an instance of ``PyobjMixin``, and can therefore apply to tests not
@ -44,6 +44,7 @@
.. _@vidartf: https://github.com/vidartf .. _@vidartf: https://github.com/vidartf
.. _@kkoukiou: https://github.com/KKoukiou .. _@kkoukiou: https://github.com/KKoukiou
.. _@omerhadari: https://github.com/omerhadari .. _@omerhadari: https://github.com/omerhadari
.. _@fbjorn: https://github.com/fbjorn
.. _#2248: https://github.com/pytest-dev/pytest/issues/2248 .. _#2248: https://github.com/pytest-dev/pytest/issues/2248
.. _#2137: https://github.com/pytest-dev/pytest/issues/2137 .. _#2137: https://github.com/pytest-dev/pytest/issues/2137
@ -51,6 +52,7 @@
.. _#2231: https://github.com/pytest-dev/pytest/issues/2231 .. _#2231: https://github.com/pytest-dev/pytest/issues/2231
.. _#2234: https://github.com/pytest-dev/pytest/issues/2234 .. _#2234: https://github.com/pytest-dev/pytest/issues/2234
.. _#2238: https://github.com/pytest-dev/pytest/issues/2238 .. _#2238: https://github.com/pytest-dev/pytest/issues/2238
.. _#2281: https://github.com/pytest-dev/pytest/issues/2281
.. _PEP-479: https://www.python.org/dev/peps/pep-0479/ .. _PEP-479: https://www.python.org/dev/peps/pep-0479/

View File

@ -295,8 +295,8 @@ class TerminalReporter:
def pytest_report_header(self, config): def pytest_report_header(self, config):
inifile = "" inifile = ""
if config.inifile: if config.inifile:
inifile = config.rootdir.bestrelpath(config.inifile) inifile = " " + config.rootdir.bestrelpath(config.inifile)
lines = ["rootdir: %s, inifile: %s" %(config.rootdir, inifile)] lines = ["rootdir: %s, inifile:%s" % (config.rootdir, inifile)]
plugininfo = config.pluginmanager.list_plugin_distinfo() plugininfo = config.pluginmanager.list_plugin_distinfo()
if plugininfo: if plugininfo:

View File

@ -519,7 +519,7 @@ def test_consider_args_after_options_for_rootdir_and_inifile(testdir, args):
args[i] = d2 args[i] = d2
with root.as_cwd(): with root.as_cwd():
result = testdir.runpytest(*args) result = testdir.runpytest(*args)
result.stdout.fnmatch_lines(['*rootdir: *myroot, inifile: ']) result.stdout.fnmatch_lines(['*rootdir: *myroot, inifile:'])
@pytest.mark.skipif("sys.platform == 'win32'") @pytest.mark.skipif("sys.platform == 'win32'")

View File

@ -906,3 +906,12 @@ def test_summary_stats(exp_line, exp_color, stats_arg):
print("Actually got: \"%s\"; with color \"%s\"" % (line, color)) print("Actually got: \"%s\"; with color \"%s\"" % (line, color))
assert line == exp_line assert line == exp_line
assert color == exp_color assert color == exp_color
def test_no_trailing_whitespace_after_inifile_word(testdir):
result = testdir.runpytest('')
assert 'inifile:\n' in result.stdout.str()
testdir.makeini('[pytest]')
result = testdir.runpytest('')
assert 'inifile: tox.ini\n' in result.stdout.str()