From 4c62cd451a44959f3f2ce3b55f94e4dff9ab0f94 Mon Sep 17 00:00:00 2001 From: Floris Bruynooghe Date: Thu, 17 Nov 2016 21:25:22 +0000 Subject: [PATCH 1/2] Add section about how you become a committer --- CONTRIBUTING.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 19b31c7f4..d8f806be6 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -236,3 +236,15 @@ but here is a simple overview: base: features # if it's a feature +Joining the Development Team +---------------------------- + +Anyone who has successfully seen through a pull request which did not +require any extra work from the development team to merge will +themselves gain commit access (if we forget please send a friendly +reminder). This does not mean your workflow to contribute changes, +everyone goes through the same pull-request-and-review process and +no-one merges their own pull requests. It however means you can +participate in the development process more fully since you can merge +pull requests from other contributors yourself after having reviewed +them. From 1f0d06641a3f0dbea673f1b2468c6a40da5861e1 Mon Sep 17 00:00:00 2001 From: Floris Bruynooghe Date: Sun, 19 Feb 2017 15:16:34 -0300 Subject: [PATCH 2/2] Update text to only give access when wanted Also clarify merging perms given the PR approval now available. --- CONTRIBUTING.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index d8f806be6..42c9f645b 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -241,10 +241,10 @@ Joining the Development Team Anyone who has successfully seen through a pull request which did not require any extra work from the development team to merge will -themselves gain commit access (if we forget please send a friendly +themselves gain commit access if they so wish (if we forget to ask please send a friendly reminder). This does not mean your workflow to contribute changes, everyone goes through the same pull-request-and-review process and -no-one merges their own pull requests. It however means you can +no-one merges their own pull requests unless already approved. It does however mean you can participate in the development process more fully since you can merge pull requests from other contributors yourself after having reviewed them.