aa53e37fa2
Add a test to expose leaked PseudoFixtureDef types.
2018-02-21 22:42:44 -08:00
75f11f0b65
Fix reference cycle caused by PseudoFixtureDef.
...
Python types have reference cycles to themselves when they are created. This is
partially caused by descriptors which get / set values from the __dict__
attribute for getattr / setattr on classes.
This is not normally an issue since types tend to remain referenced for the
lifetime of the Python process (and thus never become garbage).
However, in the case of PseudoFixtureDef, the class is generated in
_get_active_fixturedef and later discarded when pytest_fixture_setup returns.
As a result, the generated PseudoFixtureDef type becomes garbage.
This is not really a performance issue but it can lead to some problems when
making tests and assertions about garbage when using pytest.
This garbage creation problem can be rectified by returning a namedtuple
instance which is functionally the same. In the modified code, the namedtuple
is allocated / deallocated using reference counting rather than having to use
the garbage collector.
2018-02-21 21:40:54 -08:00
dae74b674e
Merge pull request #3242 from nicoddemus/delete-changelog-3.4.1
...
Delete changelog entries for 3.4.1 release
2018-02-21 10:38:53 -03:00
2a99e5dd2a
Delete changelog entries for 3.4.1 release
...
Unfortunately due to hawkowl/towncrier#99 those news fragments were
not deleted at the time of CHANGELOG generation.
2018-02-20 23:45:21 -03:00
9361d48b61
Merge pull request #3239 from nicoddemus/release-3.4.1
...
Release 3.4.1
2018-02-20 18:08:47 -03:00
b319375592
Preparing release version 3.4.1
2018-02-20 01:43:59 +00:00
f8fdf0ae91
Add --yes to towncrier to automatically remove files
2018-02-20 01:43:20 +00:00
053fc118b7
Merge pull request #3199 from nicoddemus/publish-tag-3060
...
Implement deploying to PyPI by pushing a tag
2018-02-19 22:34:35 -03:00
b486e1294b
Merge pull request #3222 from The-Compiler/match-msg
...
Remove "matching '...'" part from the pytest.raises message
2018-02-17 21:18:05 -02:00
9d879bee36
Merge pull request #3215 from pytest-dev/bugfix/985/disable-output-capturing-in-doctest
...
Disable output capturing in doctest
2018-02-17 18:39:32 -02:00
4131d3f300
Probably it's best to write the err stream to stderr.
2018-02-17 12:13:33 -05:00
254e357076
Correct the broken indentation.
2018-02-17 12:10:29 -05:00
0f6879bf5e
Small update to changelog/README.rst
2018-02-17 10:20:41 -02:00
bfe2cbe875
Implement publishing to PyPI by pushing a tag
...
Fix #3060
2018-02-17 10:13:25 -02:00
00d3001138
Merge pull request #3188 from s0undt3ch/issues/3184
...
Don't traceback on unkown sections.
2018-02-17 09:02:44 -02:00
6bc45d158d
Merge pull request #3186 from brianmaissy/bugfix/print_captured_stdout_before_entering_pdb
...
Added printing of captured stdout before entering pdb
2018-02-15 19:38:23 -02:00
371eb8c6af
Merge pull request #3206 from mbachry/fix-unittest-mock
...
Fix mock patchings detection when both mock and unittest.mock are present
2018-02-15 19:35:44 -02:00
435b8ddc7c
Rename method for additional clarity.
2018-02-15 09:17:33 -05:00
3cbf0c8ec0
Raise unexpected exceptions with pytest.raises() using match=
2018-02-15 12:11:56 +01:00
9849022eb2
Remove "matching '...'" part from the pytest.raises message
...
When a test with pytest.raises(ValueError, match='foo') doesn't raise, the
following error is printed:
Failed: DID NOT RAISE <class 'ValueError'> matching 'foo'
This error message is confusing as it implies a ValueError was raised, but the
message wasn't matching 'foo'.
I first considered rewording it somehow to preserve the match pattern in it, but
I don't think that's worthwhile as the pattern should usually be apparent from
the stacktrace anyways (hard-coded, as parametrization, or with --showlocals for
more sophisticated cases).
2018-02-14 19:20:00 +01:00
18c84a1904
Restrict fix to macOS only. Ref #3215 .
2018-02-13 17:51:20 -05:00
247cdb835a
Remove xfail; tests now pass on macOS. Ref #985 .
2018-02-13 12:41:19 -05:00
ce1872e7e8
Merge branch 'master' into bugfix/985/disable-output-capturing-in-doctest
2018-02-13 12:33:07 -05:00
d845af7b24
Add changelog. Ref #985 .
2018-02-13 12:32:00 -05:00
391553887b
Disable output capturing in doctest to avoid losing reference to stdout. Fixes #985 .
2018-02-13 12:08:39 -05:00
7656fc8320
Added printing of captured stdout and stderr before entering pdb
2018-02-12 23:17:51 +02:00
b6166dccb4
Fix mock patchings detection when both mock and unittest.mock are present
2018-02-12 20:29:37 +01:00
e7bcc854d9
Merge pull request #3202 from rouge8/pytest-raises-sphinx-parameters
...
Add Sphinx parameter docs for `match` and `message` args to `pytest.raises()`
2018-02-10 02:32:56 -02:00
ffee213c85
Update and rename 3202.trivial.rst to 3202.doc.rst
2018-02-09 22:51:15 -02:00
e5b527d0e3
Add Sphinx parameter docs for `match` and `message` args to `pytest.raises()`
2018-02-09 16:28:17 -08:00
c04e248de5
Rename 3161.bugfix to 3161.bugfix.rst
2018-02-09 14:06:24 -02:00
3685c1bc01
Merge pull request #3192 from nicoddemus/pr-template
...
Add changelog/README.rst and streamline our PR template text
2018-02-08 19:20:54 +01:00
eea169e515
Code review suggestions
2018-02-08 08:03:14 -02:00
16c52f05f1
Merge pull request #3177 from nicoddemus/mention-force-result
...
Mention outcome.force_result() and add link to pluggy's docs
2018-02-07 18:16:16 -02:00
f72182977d
Merge pull request #3183 from cheezman34/master
...
Fix ordering of tests to minimize fixture creating
2018-02-07 18:15:41 -02:00
40d0ade2d9
Add changelog/README.rst and streamline our PR template text
...
This streamlines the PR template text and adds a more in-depth explanation
about how the changelog entries work because this topic is a common source of
confusion:
- How to name the files.
- Which formatting to use (people in general assume it is Markdown).
- Recommend adding `.rst` extension to changelog files to help with the
above (`towncrier` doesn't care).
This was heavily inspired by the excellent python-trio/trio docs.
2018-02-06 22:20:39 -02:00
7152707280
Update changelog entry to "trivial" as it is a temporary workaround
...
I think this is a more appropriate category given that the underlying problem still exists
2018-02-06 08:54:44 -02:00
42c1f85257
Update CHANGELOG
2018-02-05 20:07:42 -02:00
0d15a46863
Don't traceback on unkown sections.
2018-02-05 19:09:38 +00:00
570edb466b
Merge pull request #3185 from nicoddemus/remove-ignore-py37
...
Support py37 officially
2018-02-05 10:04:34 +01:00
7c80c81433
Merge pull request #3152 from brianmaissy/silently_fail_to_import_during_postmortem
...
If we fail to import doctest.UnexpectedException during postmortem, fail quietly
2018-02-05 10:04:00 +01:00
9202ba91cf
Merge pull request #3187 from brianmaissy/bugfix/skip_failing_pdb_doctest_test_on_mac
...
skip failing pdb/doctest test on mac
2018-02-03 23:35:39 -02:00
ea8997a108
Update wording in CHANGELOG
2018-02-03 20:21:06 -02:00
867344d0d7
move import to top
2018-02-04 00:03:17 +02:00
e64feaba7a
xfail is better than skip
2018-02-03 23:28:37 +02:00
74633815aa
skip failing pdb/doctest test on mac
2018-02-03 23:24:11 +02:00
e289c60c3a
Support py37 officially
...
Python 3.7.0b1 has been released:
https://www.python.org/downloads/release/python-370b1/
Fix #3168
2018-02-02 17:15:16 -02:00
8c81722a0c
Merge pull request #3167 from nicoddemus/fix-py37
...
Fix test for py37
2018-02-02 17:13:00 -02:00
3425edd2a5
Reword changelog a bit
2018-02-01 19:54:51 -02:00
4458e65fe7
Fix ordering of tests to minimize fixture creating
2018-02-01 13:07:45 -08:00
Allan Feldman
Bruno Oliveira
Jason R. Coombs
Florian Bruhin
Brian Maissy
Marcin Bachry
Andy Freeland
Florian Bruhin
Pedro Algarvio
Ronny Pfannschmidt
Aaron