Commit Graph

9315 Commits

Author SHA1 Message Date
Bruno Oliveira f96e1b6f3e
Merge pull request #4532 from nicoddemus/failure-summary
Change -ra to show errors and failures last, instead of first
2018-12-13 10:30:28 -02:00
Bruno Oliveira 15b0a89fb1
Merge pull request #4539 from nicoddemus/deprecate-pytest-raises-message
Deprecate the 'message' parameter of pytest.raises
2018-12-13 06:00:59 -02:00
Bruno Oliveira 5b83417afc Deprecate the 'message' parameter of pytest.raises
Fix #3974
2018-12-12 22:26:30 -02:00
Bruno Oliveira 110fe2473f
Merge pull request #4531 from nicoddemus/remove-custom-collection-types
Remove PyCollector.makeitem
2018-12-12 18:27:50 -02:00
Bruno Oliveira e3d30f8ebf Remove deprecated PyCollector.makeitem
Fix #4535
2018-12-12 14:15:52 -02:00
Bruno Oliveira 3cd11617ea Add CHANGELOG 2018-12-11 20:40:06 -02:00
Bruno Oliveira 9839ceffe0 Change -ra to show errors and failures last, instead of first
Often in large test suites (like pytest's), the -ra summary is very useful
to obtain a list of failures so we can execute each test at once to fix them.

Problem is the default shows errors and failures first, which leads to a lot
of scrolling to get to them.
2018-12-11 20:36:57 -02:00
Daniel Hahler bb363c8ff2
Merge pull request #4528 from blueyed/parser-prog
argparsing: Parser: allow to forward prog to argparse
2018-12-11 13:33:40 +01:00
Daniel Hahler ebe0a88226
Merge pull request #4522 from blueyed/p-no-space
Handle missing space with -p
2018-12-11 13:33:18 +01:00
Daniel Hahler 3445eae737 argparsing: Parser: allow to forward prog to argparse
Ref: https://github.com/pytest-dev/pytest-xdist/pull/388.
2018-12-11 06:22:35 +01:00
Daniel Hahler 8152b6837e
Merge pull request #4419 from blueyed/set_trace-kwargs
pdb: support kwargs with `pdb.set_trace`
2018-12-11 04:28:24 +01:00
Daniel Hahler 0e4e8e00a9
Merge pull request #4504 from feuillemorte/4278_add_cachedir_tag
#4278 Added a CACHEDIR.TAG file to the cache directory
2018-12-11 04:27:35 +01:00
Daniel Hahler 7b1cb885c7 Handle missing space with -p
This still does not use an actual argument parser, which only gets
instantiated below, and it does not appear to make sense instantiating
it just for this pre-parsing it seems.

`-p` without the required value is being handled before already though,
so it could potentially be passed down from somewhere already?!

Fixes https://github.com/pytest-dev/pytest/issues/3532.
2018-12-11 04:27:03 +01:00
Daniel Hahler 038f1f94c2
Merge pull request #4524 from blueyed/merge-master
Merge master into features
2018-12-10 10:17:23 +01:00
Daniel Hahler 539d3dc34d Merge branch 'fix-test_raises_exception_looks_iterable' into merge-master 2018-12-10 06:30:36 +01:00
Daniel Hahler 5ecbb02ace tests: fix test_raises_exception_looks_iterable
Started to fail on py37-xdist between
https://travis-ci.org/pytest-dev/pytest/jobs/465498973 and
https://travis-ci.org/pytest-dev/pytest/jobs/465792343, but could not
find a diff in versions (from the tox header), and both commits failed
locally.
2018-12-10 06:26:32 +01:00
Daniel Hahler 0db5ccb0dd Merge master into features 2018-12-10 05:42:07 +01:00
Daniel Hahler abb0dfcfa3
Merge pull request #4523 from blueyed/addopts-separate
Ensure that PYTEST_ADDOPTS and addopts ini values are valid by themselves.
2018-12-10 01:43:04 +01:00
Daniel Hahler f3babf13ea Ensure that PYTEST_ADDOPTS are valid by themselves
Fixes https://github.com/pytest-dev/pytest/issues/4265.
2018-12-09 21:57:10 +01:00
Bruno Oliveira 76884c73bf
Merge pull request #4146 from Tadaboody/give_hints_when_an_assertion_value_is_None_instead_of_a_boolean_3191
[#3191] Give hints when an assertion value is None instead of a boolean
2018-12-05 20:04:52 -02:00
Daniel Hahler 5ebacc49c6 Harden tests, fix doc/msg 2018-12-05 19:22:44 +01:00
Daniel Hahler 8a0ed7e2b3
Revisit changelog entry [ci skip] 2018-12-05 19:14:41 +01:00
Daniel Hahler 62b8f2f731
Update changelog [ci skip] 2018-12-05 19:07:10 +01:00
Tomer Keren 8fd60483ef Don't insert warnings when not in a module 2018-12-05 19:49:54 +02:00
Tomer Keren 7a7ad0c120 Shorten docstring for warn_about_none_ast 2018-12-05 17:47:34 +02:00
Tomer Keren 41031fce2f Address code review 2018-12-05 17:18:57 +02:00
Ronny Pfannschmidt 818aa4d343
Merge pull request #4509 from Tadaboody/doc_doctest_fixture_pitfall_1495
Document doctest fixture pitfalls
2018-12-05 15:40:45 +01:00
Tomer Keren b7a64d6729 Create changelog file for 1495 2018-12-05 11:29:32 +02:00
Tomer Keren cb52d17d07 Document doctest fixture pitfalls 2018-12-05 11:25:52 +02:00
Tomer Keren e1e4b226c6 👌 Address code review
Edited the changelog for extra clarity, and to fire off auto-formatting

Oddly enough, keeping `filename='{filename!r}'` caused an error while
collecting tests, but getting rid of the single ticks fixed it
Hopefully closes #3191
2018-12-05 10:52:12 +02:00
Bruno Oliveira 26d27df6fc Improve changelog message 2018-12-05 10:41:30 +02:00
Tomer Keren 3e6f1fa2db Simplify warning creation by using ast.parse
in py2 it's a ast.Name where in py3 it's a ast.NamedConstant

Fixes namespace by using import from
2018-12-05 10:42:05 +02:00
Tomer Keren aaf7f7fcca Update changelog 2018-12-05 10:41:30 +02:00
Tomer Keren e0c2ab1901 Fix tests not to assert a function that already asserts
Maybe there should be a warning about that too?
2018-12-05 10:41:30 +02:00
Tomer Keren 59a11b6a5d Check for 'assert None' and warn appropriately
🐛Fix warn ast bugs

🐛Fix inner-ast imports by using importFrom

Alternetavly ast_call_helper could be retooled to use ast.attribute(...)
2018-12-05 10:41:42 +02:00
Tomer Keren 9fc9b2926f Fix tests and add aditional cases
As requested by review.

👌 Address code review for tests
2018-12-05 10:41:30 +02:00
Tomer Keren 1654b77ca0 [#3191] Set up tests to confirm warnings 2018-12-05 10:41:18 +02:00
Bruno Oliveira 60599b667e
Merge pull request #4505 from yashtodi94/patch-1
Rectified typo
2018-12-04 12:23:31 -02:00
Yash Todi db32949c50
Rectified typo 2018-12-04 19:33:13 +05:30
feuillemorte d237197de3 #4278 Added a CACHEDIR.TAG file to the cache directory 2018-12-04 13:49:08 +01:00
Ronny Pfannschmidt 86ccfaec22
Merge pull request #4503 from asottile/upgrade
Upgrade sphinx doc requirements
2018-12-04 07:49:07 +01:00
Anthony Sottile ae92b8c624 Upgrade sphinx doc requirements 2018-12-03 15:30:45 -08:00
Anthony Sottile 5db46d2087
Merge pull request #4498 from asottile/deprecate_pytest_config
Deprecate pytest.config
2018-12-03 11:10:15 -08:00
Anthony Sottile 99d3fe22dc
Merge pull request #4501 from s0undt3ch/master
Test case for #4500 and respective fix #4487
2018-12-03 09:11:00 -08:00
Anthony Sottile b88c3f8f82 Deprecate pytest.config 2018-12-03 09:01:42 -08:00
Pedro Algarvio 6da8befc74
Black suggestions 2018-12-03 12:58:22 +00:00
Pedro Algarvio c1bdb07b2f
Fix change log entry 2018-12-03 12:17:14 +00:00
Pedro Algarvio 14024c7fc1
Test case for #4500 bug and respective fix #4487 2018-12-03 12:17:14 +00:00
Pedro Algarvio 517b8bc69e
Stop using the deprecated `\.warn()` log handler method 2018-12-03 11:52:33 +00:00
Daniel Hahler ecc5c84c1e
Merge pull request #4487 from s0undt3ch/master
Logging done late enough might happen when capture already stopped.
2018-12-02 12:10:00 +01:00