I'm not that happy with the way this is implemented and that it isn't integrated into our localization workflow...
this is a quick fix and something cleaner will come later
* Clean up dead code
We had a lot of old code-behind comments.
I've removed them for better readability of the code and easier maintenance.
(when searching stiff in the code, it sometimes brings you to dead code ...)
Also, the methods on the gamePage observing the routes does only log "/"
as we don't use namedRoutes.
* Update position.dart
Co-authored-by: Calcitem <calcitem@outlook.com>
## Why?
- in the future we could enable the developer options in dev builds only. This would result in better performance and smaller downloadsize.
- Ability to disable catcher. Catcher limits the ability of debuging as it catches everything thrown. Also catcher won't even display the crash when the system is in dark mode (white text on white background. Probably a bug on theier side)
## How to use this?
just add a `--dart-define` followed by your config after the flutter command. Further info can be found in [Readme.md](/Readme.md)
- migrate the `open source license page`to `showLicensePage()`
- deactivate unused buildrunner
## Why?
this method is flutter internal. This means less code to maintain and less issues to make (see the one this fixes).
## What changes?
- a bit of UI (the new page will have a master detail view on large screens helping accessibility)
- we don't need to pre generate the licenses manually
info: Conditions should not unconditionally evaluate to `true` or
to `false`. verify: pieceToRemoveCount <= 0.
(invariant_booleans at [sanmill] lib/mill/position.dart:675)
- removed `shared/common/`
- implemented new data models for the settings
- implemented a new `LocalDatabaseService`
Why:
The new code will allow use to better utilize flutter's ractivenes. `HiveDB` (our new database backend) will give us `ValueListenable`, `Streams` and real time storage access. The sriliazation for the models is generated by `build_runner` and even the old seriliazation for the storage migration is generated (json_serializable).
TODO:
- implement reactivenes. We currently don't utilize this functionality to it's full potential (`Consumer`) :)
- implement migration. The migration service for the old database service isn't there yet.
Leptopoda-GitHub
Calcitem