## Why?
- in the future we could enable the developer options in dev builds only. This would result in better performance and smaller downloadsize.
- Ability to disable catcher. Catcher limits the ability of debuging as it catches everything thrown. Also catcher won't even display the crash when the system is in dark mode (white text on white background. Probably a bug on theier side)
## How to use this?
just add a `--dart-define` followed by your config after the flutter command. Further info can be found in [Readme.md](/Readme.md)
- migrate the `open source license page`to `showLicensePage()`
- deactivate unused buildrunner
## Why?
this method is flutter internal. This means less code to maintain and less issues to make (see the one this fixes).
## What changes?
- a bit of UI (the new page will have a master detail view on large screens helping accessibility)
- we don't need to pre generate the licenses manually
- removed `shared/common/`
- implemented new data models for the settings
- implemented a new `LocalDatabaseService`
Why:
The new code will allow use to better utilize flutter's ractivenes. `HiveDB` (our new database backend) will give us `ValueListenable`, `Streams` and real time storage access. The sriliazation for the models is generated by `build_runner` and even the old seriliazation for the storage migration is generated (json_serializable).
TODO:
- implement reactivenes. We currently don't utilize this functionality to it's full potential (`Consumer`) :)
- implement migration. The migration service for the old database service isn't there yet.
Effectively rewriting the entire audio stack
- propperly await futures
- only play sound once on take play back
Further testing is needed but as we await the autio play we should be able to remove the stopPlay now.
fix late init problem
* Enabled strict linting.
* Fix all the linting errors and disabled the rules that needed to much
restructure.
* Restructured the files.
Known Issues:
* Tap drawer menu item will get an exception when AI is thinking
Change difficulty level to 30, thinking time to 60, select AI Vs. AI and
tap Start Game, and tap on the settings in the drawer menu get the
exception:
This widget has been unmounted, so the State no longer has a context
(and should be considered defunct).
* Sound problem
when this option is enabled, it does not take effect:
Preferences -> Sound effects -> Keep mute when taking back
The sound issue is related to some async not being
appropriately handled. This leads to the game_page setting Audios.
isTemporaryMute to false before Audios evaluated the value.
This leads to the sound being played. Some out-of-order execution.
It seems to be a thing with the code in general that Futures aren't
really awaited. This will be quite some stuff to do and check later.
* Performance
Performance testing has not yet been conducted.
- move list_item_divider into lib/shared
- move lib/engine into lib/services/engine
unify Import style
- I've unified the way files are imported. We now use absolute imports everywhere.
This is not a must but I find it more usefull.
cleanup imports
- prefer using part files where needed
cleanup the drawer code.
- fixes the drawer design
Home drawer performance improvements
As the child doesn't depend on the transformation we shouldn't repaint it => better performance
Most notably:
- require_trailing_commas
- prefer_const_constructors
- type_annotate_public_apis
- always_declare_return_types
- prefer_foreach
- use_string_buffers
- join_return_with_assignment
For now disabled rules:
- avoid_positional_boolean_parameters
- constant_identifier_names
- avoid_escaping_inner_quotes
- use_build_context_synchronously
Those lint rules are going to be disabled for now as they require massive restructure and logic change of the current codebase
Already fixed:
- avoid_print (previous commit)
this enables vscode to auto format files in the flutter project.
Also fixes a formatting error
enable formatting only for dart files
format settings.json
Leptopoda
Calcitem