p15670423
/
monkey
1
0
Fork 5
Code Issues Pull Requests 3 Projects Releases Wiki Activity

Island: remove code duplication in credentials_parser.py

This commit is contained in:
vakarisz 2022-02-23 14:14:43 +02:00
parent 9396ac7512
commit 04b217cde5
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
monkey/monkey_island/cc/services/telemetry/processing/credentials/credentials_parser.py
View File

@ -1,4 +1,5 @@
import logging import logging
from itertools import chain
from typing import Mapping from typing import Mapping
from common.common_consts.credential_component_type import CredentialComponentType from common.common_consts.credential_component_type import CredentialComponentType
@ -12,14 +13,11 @@ from .secrets.ssh_key_processor import process_ssh_key
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
SECRET_PROCESSORS = { CREDENTIAL_COMPONENT_PROCESSORS = {
CredentialComponentType.PASSWORD: process_password,
CredentialComponentType.NT_HASH: process_nt_hash,
CredentialComponentType.LM_HASH: process_lm_hash, CredentialComponentType.LM_HASH: process_lm_hash,
CredentialComponentType.NT_HASH: process_nt_hash,
CredentialComponentType.PASSWORD: process_password,
CredentialComponentType.SSH_KEYPAIR: process_ssh_key, CredentialComponentType.SSH_KEYPAIR: process_ssh_key,
}
IDENTITY_PROCESSORS = {
CredentialComponentType.USERNAME: process_username, CredentialComponentType.USERNAME: process_username,
} }
@ -31,9 +29,6 @@ def parse_credentials(telemetry_dict: Mapping):
] ]
for credential in credentials: for credential in credentials:
for identity in credential.identities: for cred_comp in chain(credential.identities, credential.secrets):
credential_type = CredentialComponentType[identity["credential_type"]] credential_type = CredentialComponentType[cred_comp["credential_type"]]
IDENTITY_PROCESSORS[credential_type](identity, credential) CREDENTIAL_COMPONENT_PROCESSORS[credential_type](cred_comp, credential)
for secret in credential.secrets:
credential_type = CredentialComponentType[secret["credential_type"]]
SECRET_PROCESSORS[credential_type](secret, credential)