p15670423
/
monkey
1
0
Fork 5
Code Issues Pull Requests 3 Projects Releases Wiki Activity

island: Don't use `shell=True` when running local monkey

This commit is contained in:
Mike Salvatore 2021-05-12 08:42:12 -04:00
parent f86bc7f943
commit 2485c85d59
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
monkey/monkey_island/cc/services/run_local_monkey.py
View File

@ -3,7 +3,6 @@ import os
import platform import platform
import stat import stat
import subprocess import subprocess
import sys
from shutil import copyfile from shutil import copyfile
import monkey_island.cc.environment.environment_singleton as env_singleton import monkey_island.cc.environment.environment_singleton as env_singleton
@ -45,13 +44,11 @@ class RunLocalMonkeyService:
# run the monkey # run the monkey
try: try:
args = [ ip = local_ip_addresses()[0]
'"%s" m0nk3y -s %s:%s' port = env_singleton.env.get_island_port()
% (dest_path, local_ip_addresses()[0], env_singleton.env.get_island_port())
] args = [dest_path, "m0nk3y", "-s", f"{ip}:{port}"]
if sys.platform == "win32": subprocess.Popen(args, cwd=RunLocalMonkeyService.DATA_DIR)
args = "".join(args)
subprocess.Popen(args, cwd=RunLocalMonkeyService.DATA_DIR, shell=True).pid
except Exception as exc: except Exception as exc:
logger.error("popen failed", exc_info=True) logger.error("popen failed", exc_info=True)
return False, "popen failed: %s" % exc return False, "popen failed: %s" % exc