From 5f66a99f30fd7a05048764cbfd9482ebd21ed349 Mon Sep 17 00:00:00 2001
From: Shreya <shreya.malviya@gmail.com>
Date: Tue, 2 Mar 2021 14:41:16 +0530
Subject: [PATCH] Consider non-threat issues when calculating threat count

---
 .../report-components/SecurityReport.js       | 24 ++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js b/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js
index 82ac51735..63ff12444 100644
--- a/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js
+++ b/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js
@@ -46,6 +46,8 @@ class ReportPageComponent extends AuthComponent {
       ZEROLOGON_PASSWORD_RESTORE_FAILED: 16
     };
 
+  NotThreats = [this.Issue.ZEROLOGON_PASSWORD_RESTORE_FAILED];
+
   Warning =
     {
       CROSS_SEGMENT: 0,
@@ -253,9 +255,8 @@ class ReportPageComponent extends AuthComponent {
               <div>
                 During this simulated attack the Monkey uncovered <span
                 className='badge badge-warning'>
-                    {this.state.report.overview.issues.filter(function (x) {
-                      return x === true;
-                    }).length} threats</span>:
+                  {this.getThreatCount()}
+                </span>:
                 <ul>
                   {this.state.report.overview.issues[this.Issue.STOLEN_SSH_KEYS] &&
                   <li>Stolen SSH keys are used to exploit other machines.</li>}
@@ -415,6 +416,23 @@ class ReportPageComponent extends AuthComponent {
     );
   }
 
+  getThreatCount() {
+    let threatCount = this.state.report.overview.issues.filter(function (x) {
+      return x === true;
+    }).length
+
+    this.NotThreats.forEach(x => {
+      if (this.state.report.overview.issues[x] === true) {
+        threatCount -= 1;
+      }
+    });
+
+    if (threatCount === 1)
+      return "1 threat"
+    else
+      return threatCount + " threats"
+  }
+
   generateZerologonOverview() {
     let zerologonOverview = [];
     if (this.state.report.overview.issues[this.Issue.ZEROLOGON]) {