From 6377ff4c666e5ec3ae6fa7c3c69901e39230ed92 Mon Sep 17 00:00:00 2001 From: Mike Salvatore Date: Wed, 27 Jul 2022 10:37:21 -0400 Subject: [PATCH] Agent: Add TODO about using Python's ipaddress library --- .../infection_monkey/network_scanning/scan_target_generator.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/monkey/infection_monkey/network_scanning/scan_target_generator.py b/monkey/infection_monkey/network_scanning/scan_target_generator.py index 4c8f9815d..7fbdbe61a 100644 --- a/monkey/infection_monkey/network_scanning/scan_target_generator.py +++ b/monkey/infection_monkey/network_scanning/scan_target_generator.py @@ -8,6 +8,9 @@ from infection_monkey.network import NetworkAddress, NetworkInterface logger = logging.getLogger(__name__) +# TODO: We can probably reduce code and save ourselves some trouble if we use IPv4Address and +# IPv4Network. See https://docs.python.org/3/library/ipaddress.html + def compile_scan_target_list( local_network_interfaces: List[NetworkInterface],