From 67fd1712b5dd71ea47af8c2f6129a9c9fc6623bf Mon Sep 17 00:00:00 2001 From: Mike Salvatore Date: Thu, 25 Feb 2021 09:04:47 -0500 Subject: [PATCH] report: rename ZEROLOGON_CRED_RESTORE_FAILED -> ZEROLOGON_PASSWORD_RESTORED --- monkey/monkey_island/cc/services/reporting/report.py | 4 ++-- .../cc/ui/src/components/report-components/SecurityReport.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/monkey/monkey_island/cc/services/reporting/report.py b/monkey/monkey_island/cc/services/reporting/report.py index 3405ca8b3..c6cc9b9cf 100644 --- a/monkey/monkey_island/cc/services/reporting/report.py +++ b/monkey/monkey_island/cc/services/reporting/report.py @@ -65,7 +65,7 @@ class ReportService: VSFTPD = 13 DRUPAL = 14 ZEROLOGON = 15 - ZEROLOGON_CRED_RESTORE_FAILED = 16 + ZEROLOGON_PASSWORD_RESTORED = 16 class WARNINGS_DICT(Enum): CROSS_SEGMENT = 0 @@ -716,7 +716,7 @@ class ReportService: issues_byte_array[ReportService.ISSUES_DICT.DRUPAL.value] = True elif issue['type'] == 'zerologon': if issue['password_restored']: - issues_byte_array[ReportService.ISSUES_DICT.ZEROLOGON_CRED_RESTORE_FAILED.value] = True + issues_byte_array[ReportService.ISSUES_DICT.ZEROLOGON_PASSWORD_RESTORED.value] = True issues_byte_array[ReportService.ISSUES_DICT.ZEROLOGON.value] = True elif issue['type'].endswith('_password') and issue['password'] in config_passwords and \ issue['username'] in config_users or issue['type'] == 'ssh': diff --git a/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js b/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js index 512ac6a82..40f92b8a6 100644 --- a/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js +++ b/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js @@ -44,7 +44,7 @@ class ReportPageComponent extends AuthComponent { VSFTPD: 13, DRUPAL: 14, ZEROLOGON: 15, - ZEROLOGON_CRED_RESTORE_FAILED: 16 + ZEROLOGON_PASSWORD_RESTORED: 16 }; Warning = @@ -368,7 +368,7 @@ class ReportPageComponent extends AuthComponent { let zeroLogonOverview = []; // TODO finish this by linking to the documentation - if(this.state.report.overview.issues[this.Issue.ZEROLOGON_CRED_RESTORE_FAILED]) { + if(!this.state.report.overview.issues[this.Issue.ZEROLOGON_PASSWORD_RESTORED]) { zeroLogonOverview.push( Automatic password restoration on a domain controller failed!