p15670423
/
monkey
1
0
Fork 5
Code Issues Pull Requests 3 Projects Releases Wiki Activity

Island: Remove extract_ssh_keys from stolen_credentials reporting

This commit is contained in:
Ilija Lazoroski 2022-07-14 17:23:12 +02:00
parent 4dbdbcc75e
commit 89f5ff89d2
2 changed files with 1 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
monkey/monkey_island/cc/services/reporting/stolen_credentials.py
View File

@ -15,10 +15,6 @@ def get_stolen_creds() -> Sequence[Mapping]:
return stolen_creds return stolen_creds
def extract_ssh_keys(credentials: Sequence[Mapping]) -> Sequence[Mapping]:
return [c for c in credentials if c["_type"] == CredentialComponentType.SSH_KEYPAIR.name]
def _fetch_from_db() -> Sequence[StolenCredentials]: def _fetch_from_db() -> Sequence[StolenCredentials]:
return list(StolenCredentials.objects()) return list(StolenCredentials.objects())

27
monkey/tests/unit_tests/monkey_island/cc/services/reporting/test_stolen_credentials.py
View File

@ -2,10 +2,7 @@ import pytest
from common.credentials import CredentialComponentType from common.credentials import CredentialComponentType
from monkey_island.cc.models import Monkey, StolenCredentials from monkey_island.cc.models import Monkey, StolenCredentials
from monkey_island.cc.services.reporting.stolen_credentials import ( from monkey_island.cc.services.reporting.stolen_credentials import get_stolen_creds
extract_ssh_keys,
get_stolen_creds,
)
monkey_hostname = "fake_hostname" monkey_hostname = "fake_hostname"
fake_monkey_guid = "abc" fake_monkey_guid = "abc"
@ -73,25 +70,3 @@ def test_get_credentials(fake_monkey):
assert result2 in credentials assert result2 in credentials
assert result3 in credentials assert result3 in credentials
assert result4 in credentials assert result4 in credentials
@pytest.mark.usefixtures("uses_database")
def test_extract_ssh_keys(fake_monkey):
StolenCredentials(
identities=fake_credentials["identities"],
secrets=fake_credentials["secrets"],
monkey=fake_monkey,
).save()
credentials = get_stolen_creds()
keys = extract_ssh_keys(credentials)
assert len(keys) == 1
result = {
"origin": monkey_hostname,
"_type": CredentialComponentType.SSH_KEYPAIR.name,
"type": "Clear SSH private key",
"username": fake_username,
}
assert result in keys