Merge pull request #1833 from guardicore/fix-ut-windows-bugs

Fix ut windows bugs

monkey/infection_monkey/utils/monkey_log_path.py

@@ -1,3 +1,4 @@
+import os
 import tempfile
 import time
 from functools import lru_cache, partial
@@ -11,7 +12,8 @@ def _get_log_path(monkey_arg: str) -> Path:
     prefix = f"infection-monkey-{monkey_arg}-{timestamp}-"
     suffix = ".log"
 
-    _, monkey_log_path = tempfile.mkstemp(suffix=suffix, prefix=prefix)
+    handle, monkey_log_path = tempfile.mkstemp(suffix=suffix, prefix=prefix)
+    os.close(handle)
 
     return Path(monkey_log_path)
 

monkey/tests/unit_tests/infection_monkey/telemetry/attack/test_t1107_telem.py

@@ -6,7 +6,8 @@ import pytest
 from common.utils.attack_utils import ScanStatus
 from infection_monkey.telemetry.attack.t1107_telem import T1107Telem
 
-PATH = "path/to/file.txt"
+# Convert to path to fix path separators for current os
+PATH = str(Path("path/to/file.txt"))
 STATUS = ScanStatus.USED
 
 

monkey/tests/unit_tests/infection_monkey/utils/test_monkey_log_path.py

@@ -2,6 +2,7 @@ import pytest
 
 from infection_monkey.utils.monkey_log_path import get_agent_log_path, get_dropper_log_path
 
+
 def delete_log_file(log_path):
     if log_path.is_file():
         log_path.unlink()